Re: [Xen-devel] virtio_net: Fix napi poll list corruption

2014-12-24 Thread Marcelo Ricardo Leitner
On 19-12-2014 22:23, Herbert Xu wrote: David Vrabel david.vra...@citrix.com wrote: After d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) the napi instance is removed from the per-cpu list prior to calling the n-poll(), and is only requeued if all of the budget was

Re: [Xen-devel] virtio_net: Fix napi poll list corruption

2014-12-22 Thread Jason Wang
On 12/20/2014 08:23 AM, Herbert Xu wrote: David Vrabel david.vra...@citrix.com wrote: After d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) the napi instance is removed from the per-cpu list prior to calling the n-poll(), and is only requeued if all of the

Re: [Xen-devel] virtio_net: Fix napi poll list corruption

2014-12-22 Thread David Miller
From: Herbert Xu herb...@gondor.apana.org.au Date: Sat, 20 Dec 2014 11:23:27 +1100 The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) breaks virtio_net in an insidious way. It is now required that if the entire budget is consumed when poll returns, the

[Xen-devel] virtio_net: Fix napi poll list corruption

2014-12-19 Thread Herbert Xu
David Vrabel david.vra...@citrix.com wrote: After d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt masking in NAPI) the napi instance is removed from the per-cpu list prior to calling the n-poll(), and is only requeued if all of the budget was used. This inadvertently broke