Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-03 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"): > On Mon, Feb 02, 2015 at 06:06:15PM +, Ian Jackson wrote: > > Something like this perhaps, yes. Although it seems to have rather > > too much

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Wei Liu
On Mon, Feb 02, 2015 at 06:06:15PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in > remove/destroy functions"): > > On Mon, Feb 02, 2015 at 04:38:00PM +, Ian Jackson wrote: > > > libxl_device_disk_remove sh

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"): > On Mon, Feb 02, 2015 at 04:38:00PM +, Ian Jackson wrote: > > libxl_device_disk_remove should definitely not require the caller to > > do what xl currently does. >

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Wei Liu
On Mon, Feb 02, 2015 at 04:38:00PM +, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in > remove/destroy functions"): > > FWIW xl block-detach calls libxl_vdev_to_device_disk to convert a vdev > > to disk. That functi

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"): > FWIW xl block-detach calls libxl_vdev_to_device_disk to convert a vdev > to disk. That function reads xenstore to get the actual backend of that > specific vdev. Don't

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Wei Liu
On Mon, Feb 02, 2015 at 01:27:13PM +, Ian Campbell wrote: > On Mon, 2015-01-26 at 16:14 -0700, Jim Fehlig wrote: > > Cc-ing the other toolstack maintainers, both of whom have more > familiarity with this part of libxl than I. > > > The attached patch is a hack I cooked up to fix one of the li

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions"): > Perhaps better would be to add a new parameter to0 DEFINE_DEVICE_REMOVE > like extra_setdefault_args which is pasted in the appropriate place? I don't think this is

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Ian Campbell
On Mon, 2015-02-02 at 13:27 +, Ian Campbell wrote: > On Mon, 2015-01-26 at 16:14 -0700, Jim Fehlig wrote: > > Cc-ing the other toolstack maintainers, both of whom have more > familiarity with this part of libxl than I. > > > The attached patch is a hack I cooked up to fix one of the libvirt-T

Re: [Xen-devel] [PATCH RFC] libxl: set disk defaults in remove/destroy functions

2015-02-02 Thread Ian Campbell
On Mon, 2015-01-26 at 16:14 -0700, Jim Fehlig wrote: Cc-ing the other toolstack maintainers, both of whom have more familiarity with this part of libxl than I. > The attached patch is a hack I cooked up to fix one of the libvirt-TCK > Xen failures. The test (200-disk-hotplug.t) attempts to hot a