Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-11 Thread Jan Beulich
>>> On 11.08.16 at 12:56, <ian.jack...@eu.citrix.com> wrote: > Jan Beulich writes ("Re: [Xen-devel] [PATCH v2 1/3] livepach: Add > .livepatch.hooks functions and test-case"): >> On 10.08.16 at 11:46, <jbeul...@suse.com> wrote: >> > Odd. I've tr

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-11 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case"): > On 10.08.16 at 11:46, <jbeul...@suse.com> wrote: > > Odd. I've tried this simple example: > > > > typedef int fn_t(void); ... > > const f

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-11 Thread Jan Beulich
>>> On 10.08.16 at 11:46, wrote: > Odd. I've tried this simple example: > > typedef int fn_t(void); > > struct s { > unsigned n; > fn_t**fn; > fn_t*const*fnc; > const fn_t**cfn; > }; > > int test1(const struct s*ps) { > unsigned i; > int

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-10 Thread Konrad Rzeszutek Wilk
On Wed, Aug 10, 2016 at 03:46:49AM -0600, Jan Beulich wrote: > >>> On 09.08.16 at 20:01, wrote: > >> >> > @@ -70,7 +71,11 @@ struct payload { > >> >> > unsigned int nsyms; /* Nr of entries in .strtab > >> >> > and > >> >> > symbols. */ > >> >> >

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-10 Thread Jan Beulich
>>> On 09.08.16 at 20:01, wrote: >> >> > @@ -70,7 +71,11 @@ struct payload { >> >> > unsigned int nsyms; /* Nr of entries in .strtab >> >> > and >> >> > symbols. */ >> >> > struct livepatch_build_id id;/* >> >> >

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-09 Thread Konrad Rzeszutek Wilk
> >> > @@ -70,7 +71,11 @@ struct payload { > >> > unsigned int nsyms; /* Nr of entries in .strtab > >> > and > >> > symbols. */ > >> > struct livepatch_build_id id;/* > >> > ELFNOTE_DESC(.note.gnu.build-id) of the payload. */ > >> > struct

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread Andrew Cooper
On 08/08/16 16:15, Jan Beulich wrote: On 08.08.16 at 16:10, wrote: >> On 08/08/16 15:01, Jan Beulich wrote: >> On 08.08.16 at 15:42, wrote: On 05/08/16 16:35, Jan Beulich wrote: On 04.08.16 at 17:49,

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread Jan Beulich
>>> On 08.08.16 at 16:10, wrote: > On 08/08/16 15:01, Jan Beulich wrote: > On 08.08.16 at 15:42, wrote: >>> On 05/08/16 16:35, Jan Beulich wrote: >>> On 04.08.16 at 17:49, wrote: > In general, the hooks

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread George Dunlap
On 08/08/16 15:01, Jan Beulich wrote: On 08.08.16 at 15:42, wrote: >> On 05/08/16 16:35, Jan Beulich wrote: >> On 04.08.16 at 17:49, wrote: In general, the hooks provide flexibility when having to deal with unforeseen cases,

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread Jan Beulich
>>> On 08.08.16 at 15:42, wrote: > On 05/08/16 16:35, Jan Beulich wrote: > On 04.08.16 at 17:49, wrote: >>> In general, the hooks provide flexibility when having to deal with >>> unforeseen cases, but their application should be rarely

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread George Dunlap
On 05/08/16 16:35, Jan Beulich wrote: On 04.08.16 at 17:49, wrote: >> In general, the hooks provide flexibility when having to deal with >> unforeseen cases, but their application should be rarely required (< >> 10%)." > > But the greater flexibility of course comes

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-08 Thread Jan Beulich
>>> On 05.08.16 at 23:08, wrote: > On Fri, Aug 05, 2016 at 09:35:49AM -0600, Jan Beulich wrote: >> >>> On 04.08.16 at 17:49, wrote: >> > In general, the hooks provide flexibility when having to deal with >> > unforeseen cases, but their application

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-05 Thread Konrad Rzeszutek Wilk
On Fri, Aug 05, 2016 at 09:35:49AM -0600, Jan Beulich wrote: > >>> On 04.08.16 at 17:49, wrote: > > In general, the hooks provide flexibility when having to deal with > > unforeseen cases, but their application should be rarely required (< > > 10%)." > > But the greater

Re: [Xen-devel] [PATCH v2 1/3] livepach: Add .livepatch.hooks functions and test-case

2016-08-05 Thread Jan Beulich
>>> On 04.08.16 at 17:49, wrote: > In general, the hooks provide flexibility when having to deal with > unforeseen cases, but their application should be rarely required (< > 10%)." But the greater flexibility of course comes with increased chances of screwing things up.