Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-02-27 Thread Julien Grall
Hi Ian, On 20/02/15 15:52, Ian Campbell wrote: As DOM0 will get most the devices, the vIRQ is equal to the IRQ in that case. Am I correct that after this patch all callers still pass irq==virq to the new function? Sorry, I forgot to answer to this question. Yes, all the callers will pass

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-02-27 Thread Ian Campbell
On Fri, 2015-02-27 at 14:33 +, Julien Grall wrote: Hi Ian, On 20/02/15 17:09, Julien Grall wrote: On 20/02/15 15:52, Ian Campbell wrote: action = xmalloc(struct irqaction); -if (!action) +if ( !action ) +return -ENOMEM; + +info = xmalloc(struct

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-02-20 Thread Ian Campbell
On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: Actually Xen is assuming that the virtual IRQ will always be the same as IRQ. s/Actually/Currently/? Modify route_guest_irq to take the virtual IRQ in parameter and let Xen assign a different IRQ number. I think I must be

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-02-20 Thread Julien Grall
On 20/02/15 15:52, Ian Campbell wrote: On Tue, 2015-01-13 at 14:25 +, Julien Grall wrote: Actually Xen is assuming that the virtual IRQ will always be the same as IRQ. s/Actually/Currently/? Yes, I always mix both because the former is close to the french word. Modify route_guest_irq

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-01-28 Thread Julien Grall
On 28/01/15 16:56, Julien Grall wrote: On 28/01/15 16:47, Stefano Stabellini wrote: diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 25ecf1d..830832c 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -31,6 +31,13 @@ static unsigned int local_irqs_type[NR_LOCAL_IRQS];

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-01-28 Thread Stefano Stabellini
On Tue, 13 Jan 2015, Julien Grall wrote: Actually Xen is assuming that the virtual IRQ will always be the same as IRQ. Modify route_guest_irq to take the virtual IRQ in parameter and let Xen assign a different IRQ number. Also store the vIRQ in the desc action to easily retrieve easily the

Re: [Xen-devel] [PATCH v3 08/24] xen/arm: Allow virq != irq

2015-01-28 Thread Julien Grall
On 28/01/15 16:47, Stefano Stabellini wrote: diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index 25ecf1d..830832c 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -31,6 +31,13 @@ static unsigned int local_irqs_type[NR_LOCAL_IRQS]; static