Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-25 Thread Juergen Gross
On 25/07/16 13:05, Wei Liu wrote: > On Mon, Jul 25, 2016 at 06:33:35AM +0200, Juergen Gross wrote: >> On 22/07/16 20:51, Wei Liu wrote: >>> On Fri, Jul 22, 2016 at 08:49:17PM +0200, Juergen Gross wrote: On 22/07/16 18:31, Wei Liu wrote: > Only skim-read this patch, will do proper review la

Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-25 Thread Wei Liu
On Mon, Jul 25, 2016 at 06:33:35AM +0200, Juergen Gross wrote: > On 22/07/16 20:51, Wei Liu wrote: > > On Fri, Jul 22, 2016 at 08:49:17PM +0200, Juergen Gross wrote: > >> On 22/07/16 18:31, Wei Liu wrote: > >>> Only skim-read this patch, will do proper review later. > >>> > >>> On Fri, Jul 22, 2016

Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-24 Thread Juergen Gross
On 22/07/16 20:51, Wei Liu wrote: > On Fri, Jul 22, 2016 at 08:49:17PM +0200, Juergen Gross wrote: >> On 22/07/16 18:31, Wei Liu wrote: >>> Only skim-read this patch, will do proper review later. >>> >>> On Fri, Jul 22, 2016 at 05:09:28PM +0200, Juergen Gross wrote: >>> [...] CAMLprim value o

Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-22 Thread Wei Liu
On Fri, Jul 22, 2016 at 08:49:17PM +0200, Juergen Gross wrote: > On 22/07/16 18:31, Wei Liu wrote: > > Only skim-read this patch, will do proper review later. > > > > On Fri, Jul 22, 2016 at 05:09:28PM +0200, Juergen Gross wrote: > > [...] > >> CAMLprim value ocaml_launched_by_systemd(value ignor

Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-22 Thread Juergen Gross
On 22/07/16 18:31, Wei Liu wrote: > Only skim-read this patch, will do proper review later. > > On Fri, Jul 22, 2016 at 05:09:28PM +0200, Juergen Gross wrote: > [...] >> CAMLprim value ocaml_launched_by_systemd(value ignore) >> { >> -CAMLparam1(ignore); >> -CAMLlocal1(ret); >> + CA

Re: [Xen-devel] [PATCH v3 1/4] tools: remove systemd xenstore socket definitions

2016-07-22 Thread Wei Liu
Only skim-read this patch, will do proper review later. On Fri, Jul 22, 2016 at 05:09:28PM +0200, Juergen Gross wrote: [...] > CAMLprim value ocaml_launched_by_systemd(value ignore) > { > - CAMLparam1(ignore); > - CAMLlocal1(ret); > + CAMLparam1(ignore); > + CAMLlocal1(ret);