Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

2016-12-01 Thread Jan Beulich
>>> On 01.12.16 at 12:23, wrote: > On 01/12/16 11:16, Jan Beulich wrote: > On 30.11.16 at 14:50, wrote: >>> @@ -3422,6 +3422,16 @@ static int sh_page_fault(struct vcpu *v, >>> v->arch.paging.last_write_emul_ok = 0; >>> #endif

Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

2016-12-01 Thread Tim Deegan
At 11:23 + on 01 Dec (1480591394), Andrew Cooper wrote: > Hmm. It is only the PAE case we want to skip. Perhaps changing the PAE > entry condition to > > diff --git a/xen/arch/x86/mm/shadow/multi.c b/xen/arch/x86/mm/shadow/multi.c > index c45d260..28ff945 100644 > ---

Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

2016-12-01 Thread Andrew Cooper
On 01/12/16 11:16, Jan Beulich wrote: On 30.11.16 at 14:50, wrote: >> The behaviour of singlestep is to raise #DB after the instruction has been >> completed, but implementing it with inject_hw_exception() causes >> x86_emulate() >> to return X86EMUL_EXCEPTION,

Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

2016-12-01 Thread Jan Beulich
>>> On 30.11.16 at 14:50, wrote: > The behaviour of singlestep is to raise #DB after the instruction has been > completed, but implementing it with inject_hw_exception() causes x86_emulate() > to return X86EMUL_EXCEPTION, despite succesfully completing execution of the

Re: [Xen-devel] [PATCH v3 11/24] x86/emul: Implement singlestep as a retire flag

2016-11-30 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 30 November 2016 13:50 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Tim (Xen.org) ; Paul Durrant >