Re: [Xen-devel] [PATCH v4 2/5] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

2015-10-23 Thread Ian Campbell
On Thu, 2015-10-22 at 17:51 +0100, Julien Grall wrote: > On 22/10/15 17:07, Ian Campbell wrote: > > > diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c > > > index 665afeb..6b7eab3 100644 > > > --- a/xen/arch/arm/vgic-v2.c > > > +++ b/xen/arch/arm/vgic-v2.c > > > @@ -50,6 +50,94 @@ void

Re: [Xen-devel] [PATCH v4 2/5] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

2015-10-23 Thread Julien Grall
Hi Ian, On 23/10/15 10:30, Ian Campbell wrote: > On Thu, 2015-10-22 at 17:51 +0100, Julien Grall wrote: >> On 22/10/15 17:07, Ian Campbell wrote: diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 665afeb..6b7eab3 100644 --- a/xen/arch/arm/vgic-v2.c +++

Re: [Xen-devel] [PATCH v4 2/5] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

2015-10-23 Thread Ian Campbell
On Fri, 2015-10-23 at 10:37 +0100, Julien Grall wrote: > Hi Ian, > > On 23/10/15 10:30, Ian Campbell wrote: > > On Thu, 2015-10-22 at 17:51 +0100, Julien Grall wrote: > > > On 22/10/15 17:07, Ian Campbell wrote: > > > > > diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c > > > > >

Re: [Xen-devel] [PATCH v4 2/5] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

2015-10-22 Thread Ian Campbell
On Mon, 2015-10-12 at 15:22 +0100, Julien Grall wrote: > The current implementation ignores the whole write if one of the field is > 0. Although, based on the spec (4.3.12 IHI 0048B.b), 0 is a valid value > when: > - The interrupt is not wired in the distributor. From the Xen > point of

Re: [Xen-devel] [PATCH v4 2/5] xen/arm: vgic-v2: Don't ignore a write in ITARGETSR if one field is 0

2015-10-22 Thread Julien Grall
On 22/10/15 17:07, Ian Campbell wrote: >> diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c >> index 665afeb..6b7eab3 100644 >> --- a/xen/arch/arm/vgic-v2.c >> +++ b/xen/arch/arm/vgic-v2.c >> @@ -50,6 +50,94 @@ void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase, >> paddr_t vbase) >>