On Thu, 2015-07-02 at 16:16 +0100, Ian Jackson wrote:
Ian Campbell writes (Re: [Xen-devel] [CALL-FOR-AGENDA] Monthly Xen.org
Technical Call (2015-07-08)):
On Thu, 2015-07-02 at 09:45 +0100, Ian Campbell wrote:
Shall I put up a poll of some sort to gather preferred timeslot options
out
On Fri, 2015-07-03 at 12:25 +0200, Dario Faggioli wrote:
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
Reviewed-by: George Dunlap george.dun...@eu.citrix.com
---
Cc: Ian Jackson ian.jack...@eu.citrix.com
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Acked-by: Ian Campbell
On Fri, 2015-07-03 at 12:25 +0200, Dario Faggioli wrote:
-=item Bperiod=NANOSECONDS
-=item Bslice=NANOSECONDS
-=item Blatency=N
-=item Bextratime=BOOLEAN
Do these removals imply there are some redundant fields in
libxl_domain_sched_params now? If so
shall we tag them with a comment or
Jennifer Herbert writes ([Xen-devel] [PATCH 4/7] libxc: Prevent dereferencing
NULL pointers returned from xc_dom_allocate()):
The return from xc_dom_allocate is not checked for a NULL value.
This patch fixes this, causing it to return from the function with an error.
Acked-by: Ian Jackson
flight 59036 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59036/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-rumpuserxen-i386 15
rumpuserxen-demo-xenstorels/xenstorels.repeat fail REGR. vs.
Using report_find_push_age_info allows us to provide counts of
attempts since the last baseline on current tip as well as the first
attempt of each of those.
Since everything serialises on the repo lock I didn't bother trying to
parallelise anything.
It's a little terse to keep it in 80 chars.
On Fri, 2015-07-03 at 15:26 +0100, Ian Campbell wrote:
On Fri, 2015-07-03 at 12:25 +0200, Dario Faggioli wrote:
-=item Bperiod=NANOSECONDS
-=item Bslice=NANOSECONDS
-=item Blatency=N
-=item Bextratime=BOOLEAN
Do these removals imply there are some redundant fields in
On Tue, 2015-06-30 at 16:00 +0100, Stefano Stabellini wrote:
When I made this change, I gave a careful look both at the libxl side
and the QEMU side. Indeed I would appreciate a second pair of eyes on
this. These are my observations:
I think the request for secondary close review and more
Jennifer Herbert writes ([Xen-devel] [PATCH 6/7] libxc: Fix misleading use of
strncpy code in build_hvm_info()):
hvm_info-signature is not a string, but an 64 bit int, and is not
NULL terminated. The use of strncpy to populate it is inappropriate and
potentially misleading. A cursory glance
Jennifer Herbert writes ([Xen-devel] [PATCH 5/7] libxc: Removing dead code
from xc_dom_allocate()):
The only place that jumps to 'err:' does so because !dom, which is
rechecked in 'err:'. This patch simplifies, giving the same result.
I'm not particularly convinced by this change, but maybe
On Wed, 2015-07-01 at 17:37 +, Jennifer Herbert wrote:
Fix a number of coverity issues in libxc.
Do you have CID numbers which should be associated with each of these?
See e.g. d17547414199f4434289f75ab2b1364cc961982e for the style.
Ian.
___
flight 59038 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59038/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-libvirt-xsm 11 guest-start fail REGR. vs. 58842
Regressions which are
On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote:
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
@@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx,
uint32_t domid,
switch (sched) {
case LIBXL_SCHEDULER_SEDF:
-
On Fri, 2015-07-03 at 15:25 +0100, Andrew Cooper wrote:
On 01/07/15 12:00, Ian Campbell wrote:
On Wed, 2015-07-01 at 11:39 +0100, Andrew Cooper wrote:
On 01/07/15 11:27, Ian Campbell wrote:
On Wed, 2015-07-01 at 11:16 +0100, Andrew Cooper wrote:
On 01/07/15 04:07, Yang Hongyang wrote:
On Fri, 2015-07-03 at 15:22 +0100, Andrew Cooper wrote:
On 03/07/15 15:20, Ian Campbell wrote:
On Wed, 2015-07-01 at 17:37 +, Jennifer Herbert wrote:
Fix a number of coverity issues in libxc.
Do you have CID numbers which should be associated with each of these?
See e.g.
On 30/06/15 14:05, Paul Durrant wrote:
By removing the HVMIO_dispatched state and making all pending emulations
(i.e. all those not handled by the hypervisor) use HVMIO_awating_completion,
various code-paths can be simplified.
The completion case for HVMIO_dispatched can also be trivally
flight 59045 linux-next real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59045/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-xsm4 capture-logs !broken [st=!broken!]
build-i386
flight 59035 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/59035/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-xsm6 xen-boot fail REGR. vs. 59010
Regressions which
On Tue, 2015-06-02 at 16:47 +0100, Ian Campbell wrote:
Anyone fancy (n)acking this followup to XSA-131? I think we probably
want this for 4.6.
From c395657b03a1e2b7616d987e7078694874981979 Mon Sep 17 00:00:00 2001
From: Ian Campbell ian.campb...@citrix.com
Date: Mon, 1 Jun 2015 11:32:23 +0100
On 03/07/15 15:42, Ian Campbell wrote:
On Fri, 2015-07-03 at 15:22 +0100, Andrew Cooper wrote:
On 03/07/15 15:20, Ian Campbell wrote:
On Wed, 2015-07-01 at 17:37 +, Jennifer Herbert wrote:
Fix a number of coverity issues in libxc.
Do you have CID numbers which should be associated with
Ian Campbell writes (Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler):
On Fri, 2015-07-03 at 16:33 +0200, Dario Faggioli wrote:
I think I'd go for _REMOVED, as deprecated suggests (to me at least)
that it's still there but nshould not be used.
REMOVED DEPRECATED GONE IMHO too.
Ian Campbell writes (Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler):
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
@@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx,
uint32_t domid,
...
case LIBXL_SCHEDULER_SEDF:
-
On Fri, 2015-07-03 at 11:30 +0100, Andrew Cooper wrote:
On 03/07/15 11:25, Dario Faggioli wrote:
more specifically, of all the symbols and references
to it.
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
Reviewed-by: George Dunlap george.dun...@eu.citrix.com
---
Cc: Andrew
The code in the callbacks for dt_for_each_irq_map and
dt_for_each_range is very similar to the code in handle_device for
each non-pci device.
In fact the only major difference is that the irq callback needs to
call irq_set_spi_type in the PCI case. Refactor into a
map_dt_irq_to_domain callback
This uses the dt_for_each_{irq_map,range} helpers to map the interrupt
and child MMIO regions to dom0. Since PCI busses are enumerable these
resources may not be otherwise described in the DT (although they can
be).
Although PCI is the only bus we handle this way the code should be
generic enough
This provides specific handlers for the PCI bus relating to matching
and translating. It's mostly similar to the defaults but includes some
additional error checks and other PCI specific bits.
There are some subtle differences in how the generic code vs. the pci
specific code here will handle
This series adds parsing of the DT ranges and interrupt-map properties
for PCI devices, these contain the MMIOs and IRQs used by children on
the bus. This replaces the specific mapping stuff on xgene.
Since last time I've added the needed call to iomem_permit_access and
added a patch to
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
@@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx,
uint32_t domid,
switch (sched) {
case LIBXL_SCHEDULER_SEDF:
-ret=sched_sedf_domain_set(gc, domid, scinfo);
+LOG(ERROR, SEDF
On 03/07/15 15:20, Ian Campbell wrote:
On Wed, 2015-07-01 at 17:37 +, Jennifer Herbert wrote:
Fix a number of coverity issues in libxc.
Do you have CID numbers which should be associated with each of these?
See e.g. d17547414199f4434289f75ab2b1364cc961982e for the style.
These were from
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
as it is going away from libxc, so these won't build any
longer.
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
Reviewed-by: George Dunlap george.dun...@eu.citrix.com
---
Cc: Ian Jackson ian.jack...@eu.citrix.com
Cc:
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
Reviewed-by: George Dunlap george.dun...@eu.citrix.com
---
Cc: Ian Jackson ian.jack...@eu.citrix.com
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Acked-by: Ian Campbell
Ian Campbell writes (Re: [PATCH OSSTEST v4] mg-all-branch-statuses: Show how
up to date each branch is):
On Fri, 2015-07-03 at 14:40 +0100, Ian Jackson wrote:
Do you want to provide a cron job to run this weekly, or something ?
Given the NN days I was thinking more like daily, otherwise NN
On Fri, 2015-07-03 at 16:36 +0200, Dario Faggioli wrote:
On Fri, 2015-07-03 at 15:26 +0100, Ian Campbell wrote:
On Fri, 2015-07-03 at 12:25 +0200, Dario Faggioli wrote:
-=item Bperiod=NANOSECONDS
-=item Bslice=NANOSECONDS
-=item Blatency=N
-=item Bextratime=BOOLEAN
Do these
On Fri, 2015-07-03 at 12:09 +0100, Ian Jackson wrote:
Ian Campbell writes (Re: [PATCH 1/2] libxl: turn NUMA placement misconfigs
into warnings):
On Wed, 2015-07-01 at 15:38 +0100, Ian Jackson wrote:
But, be aware that you are making a semantic change to the API which
cannot be reverted
On 30/06/15 14:05, Paul Durrant wrote:
Emulation request status is already covered by STATE_IOREQ_XXX values so
just use those. The mapping is:
HVMIO_none- STATE_IOREQ_NONE
HVMIO_awaiting_completion - STATE_IOREQ_READY
HVMIO_completed - STATE_IORESP_READY
Jennifer Herbert writes ([PATCH 0/7] libxc: Fix a number of coverity issues.):
Fix a number of coverity issues in libxc.
Thanks. Error handling is a pet topic of mine so I will review this
series.
Ian.
___
Xen-devel mailing list
On 30/06/15 14:05, Paul Durrant wrote:
If memory mapped I/O is 'chunked' then the I/O must be re-emulated,
otherwise only the first chunk will be processed. This patch makes
sure all I/O from a buffer is re-emulated regardless of whether it
is a read or a write.
Signed-off-by: Paul Durrant
On 30/06/15 14:05, Paul Durrant wrote:
The code in hvmemul_do_io() that tracks large reads or writes, to avoid
re-issue of component I/O, is defeated by accesses across a page boundary
because it uses physical address. The code is also only relevant to memory
mapped I/O to or from a buffer.
Ian Campbell writes (Re: [OSSTEST PATCH 6/6] ts-logs-capture: Explicitly set
xenctx capture filename):
On Fri, 2015-07-03 at 12:49 +0100, Ian Jackson wrote:
Now that the command contains PATH, the autogenerated filename is very
ugly.
Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com
Ian Campbell writes (Re: [Xen-devel] [PATCH 1/3] xl: Break out flush_stream):
All three patched: Acked-by: Ian Campbell ian.campb...@citrix.com
Thanks, pushed.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Ian Campbell writes ([PATCH OSSTEST v4] mg-all-branch-statuses: Show how up to
date each branch is):
Using report_find_push_age_info allows us to provide counts of
attempts since the last baseline on current tip as well as the first
attempt of each of those.
Since everything serialises on
On Thu, 2015-07-02 at 14:23 +0100, Andrew Cooper wrote:
On 01/07/15 18:37, Jennifer Herbert wrote:
Fix a number of coverity issues in libxc.
Patches 2 through 7:
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
Likewise: Acked-by: Ian Campbell ian.campb...@citrix.com, just
awaiting
On Thu, 2015-07-02 at 19:55 +0200, Roger Pau Monné wrote:
El 02/07/15 a les 19.42, George Dunlap ha escrit:
There are a lot of paths through
libxl__device_disk_local_initiate_attach(), but they all really boil
down to one thing: Can we just access the file directly, or do we need
to
On 30/06/15 14:05, Paul Durrant wrote:
diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c
index 11b6028..f84f7c5 100644
--- a/xen/arch/x86/hvm/intercept.c
+++ b/xen/arch/x86/hvm/intercept.c
@@ -119,8 +119,8 @@ static const struct hvm_io_ops portio_ops = {
.write =
On 03/07/15 15:16, Ian Campbell wrote:
On Fri, 2015-06-26 at 19:47 +0200, Julien Grall wrote:
+/* First get the #interrupt-cells property of the current cursor
+ * that tells us how to interpret the passed-in intspec. If there
+ * is none, we are nice and just walk up the tree
+
On Fri, 2015-07-03 at 14:40 +0100, Ian Jackson wrote:
Ian Campbell writes ([PATCH OSSTEST v4] mg-all-branch-statuses: Show how up
to date each branch is):
Using report_find_push_age_info allows us to provide counts of
attempts since the last baseline on current tip as well as the first
In fact, when a pCPU goes down, we want to clear its
bit in the correct cpupool's valid mask, rather than
always in cpupool0's one.
Before this commit, all the pCPUs in the non-default
pool(s) will be considered immediately valid, during
system resume, even the one that have not been brought
up
When dumping scheduling information (debug key 'r'), what
we print as 'Idle cpupool' is pretty much the same of what
we print immediately after as 'Cpupool0'. In fact, if there
are no pCPUs outside of any cpupools, it is exactly the
same.
If there are free pCPUs, there is some valuable
Hello,
Take 2 of this series:
http://lists.xenproject.org/archives/html/xen-devel/2015-06/msg04137.html
There has not been much to do wrt v1, and the series has all the acks it
requires, IMO, with (maybe, see below) the exception of patch 4.
Basically, I improved the changelog of patch 2, as
and of (almost every) direct use of cpupool_online_cpumask().
In fact, what we really want for the most of the times,
is the set of valid pCPUs of the cpupool a certain domain
is part of. Furthermore, in case it's called with a NULL
pool as argument, cpupool_scheduler_cpumask() does more
harm
Ideally, the pCPUs that are 'free', i.e., not assigned
to any cpupool, should not be considred by the scheduler
for load balancing or anything. In Credit1, we fail at
this, because of how we use cpupool_scheduler_cpumask().
In fact, for a free pCPU, cpupool_scheduler_cpumask()
returns a pointer to
This function iterates over a node's ranges property and calls a
callback for each region. For now it only supplies the MMIO range (in
terms of CPU addresses, i.e. already translated).
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Reviewed-by: Julien Grall julien.gr...@citrix.com
---
This function iterates over a nodes interrupt-map property and calls a
callback for each interrupt. For now it only supplies the translated
IRQ since my use case has no need of e.g. child unit address. These
can be added as needed by any future users.
This follows much the same logic as
This is only needed if we are giving the IRQ to dom0 (as opposed to
setting it up for passthrough due to xen,passthrough property). There
is already a call to vgic_reserve_virq inside the if ( need_mapping ),
so drop this one.
Signed-off-by: Ian Campbell ian.campb...@citrix.com
Reviewed-by:
On 01/07/15 12:00, Ian Campbell wrote:
On Wed, 2015-07-01 at 11:39 +0100, Andrew Cooper wrote:
On 01/07/15 11:27, Ian Campbell wrote:
On Wed, 2015-07-01 at 11:16 +0100, Andrew Cooper wrote:
On 01/07/15 04:07, Yang Hongyang wrote:
On 06/30/2015 06:24 PM, Ian Campbell wrote:
On Thu, 2015-06-25
On Fri, 2015-07-03 at 16:33 +0200, Dario Faggioli wrote:
On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote:
On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
@@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx,
uint32_t domid,
switch (sched)
On 01/07/15 18:37, Jennifer Herbert wrote:
If xc_domain_get_guest_width were to fail, guest_width is not set, and
hence guest_64bit becomes undefined.
Fix is to initialise to 0, and report error if call fails.
Signed-off-by: Jennifer Herbert jennifer.herb...@citrix.com
Coverity-ID: 1090350
On 30/06/15 14:05, Paul Durrant wrote:
diff --git a/xen/include/asm-x86/hvm/vcpu.h b/xen/include/asm-x86/hvm/vcpu.h
index 2ed0606..efb373f 100644
--- a/xen/include/asm-x86/hvm/vcpu.h
+++ b/xen/include/asm-x86/hvm/vcpu.h
@@ -34,11 +34,16 @@ enum hvm_io_state {
HVMIO_none = 0,
The functions ring_read and ring_write() have logic to try and deal with
partial reads and writes.
However, in all cases where the while (len) loop executed twice, data
corruption would occur as the second memcpy() starts from the beginning of
data again, rather than from where it got to.
This
Consume and ignore all XS_DEBUG packets, and pass the response type back to
the caller of xenbus_recv() so the caller can take appropriate action if an
unexpected reply was received.
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com
CC: Jan Beulich jbeul...@suse.com
---
On Fri, 2015-07-03 at 14:59 +0100, Ian Campbell wrote:
This function iterates over a nodes interrupt-map property and calls a
callback for each interrupt. For now it only supplies the translated
IRQ since my use case has no need of e.g. child unit address. These
can be added as needed by any
On Fri, 2015-06-26 at 19:47 +0200, Julien Grall wrote:
+/* First get the #interrupt-cells property of the current cursor
+ * that tells us how to interpret the passed-in intspec. If there
+ * is none, we are nice and just walk up the tree
+ */
+do {
+tmp =
On 01/07/15 18:37, Jennifer Herbert wrote:
hvm_info-signature is not a string, but an 64 bit int, and is not
NULL terminated. The use of strncpy to populate it is inappropriate and
potentially misleading. A cursory glance might have you thinking someone
had miscounted the length of the
On 01/07/15 18:37, Jennifer Herbert wrote:
The only place that jumps to 'err:' does so because !dom, which is
rechecked in 'err:'. This patch simplifies, giving the same result.
Signed-off-by: Jennifer Herbert jennifer.herb...@citrix.com
Coverity-ID: 1055188
~Andrew
---
On 30/06/15 14:05, Paul Durrant wrote:
Use an ioreq_t rather than open coded state, size, dir and data fields
in struct hvm_vcpu_io. This also allows PIO completion to be handled
similarly to MMIO completion by re-issuing the handle_pio() call.
Signed-off-by: Paul Durrant
Jennifer Herbert writes ([Xen-devel] [PATCH 1/7] libxc: fix uninitialized
variable in xc_cpuid_pv_policy()):
If xc_domain_get_guest_width were to fail, guest_width is not set, and
hence guest_64bit becomes undefined.
Fix is to initialise to 0, and report error if call fails.
...
diff --git
Jennifer Herbert writes ([Xen-devel] [PATCH 7/7] libxc: Prevent NULL pointer
dereference in stdiostream_vmessage()):
Unlikely that it may seem localtime_r could fail, which would result in a
null pointer dereference. In this case, one can simply just skip logging the
date/time, and logging
Ian Campbell writes (Re: [Xen-devel] [PATCH 1/7] libxc: fix uninitialized
variable in xc_cpuid_pv_policy()):
On Fri, 2015-07-03 at 16:15 +0100, Ian Jackson wrote:
Unfortunately xc_cpuid_pv_policy doesn't return an error code. I
think it needs to. So that's rather a yak.
I was about to
On Fri, 2015-07-03 at 16:25 +0100, Ian Jackson wrote:
Jennifer Herbert writes ([Xen-devel] [PATCH 6/7] libxc: Fix misleading use
of strncpy code in build_hvm_info()):
hvm_info-signature is not a string, but an 64 bit int, and is not
NULL terminated. The use of strncpy to populate it is
If memory mapped I/O is 'chunked' then the I/O must be re-emulated,
otherwise only the first chunk will be processed. This patch makes
sure all I/O from a buffer is re-emulated regardless of whether it
is a read or a write.
Signed-off-by: Paul Durrant paul.durr...@citrix.com
Cc: Keir Fraser
The state of in-flight I/O and how its completion will be handled are
logically separate and conflating the two makes the code unnecessarily
confusing.
Signed-off-by: Paul Durrant paul.durr...@citrix.com
Cc: Keir Fraser k...@xen.org
Cc: Jan Beulich jbeul...@suse.com
Reviewed-by: Andrew Cooper
Emulation request status is already covered by STATE_IOREQ_XXX values so
just use those. The mapping is:
HVMIO_none- STATE_IOREQ_NONE
HVMIO_awaiting_completion - STATE_IOREQ_READY
HVMIO_completed - STATE_IORESP_READY
Signed-off-by: Paul Durrant paul.durr...@citrix.com
By removing the HVMIO_dispatched state and making all pending emulations
(i.e. all those not handled by the hypervisor) use HVMIO_awating_completion,
various code-paths can be simplified.
The completion case for HVMIO_dispatched can also be trivally removed
from hvmemul_do_io() as it was already
By removing the calls in hvmemul_do_io() (which is replaced by a single
assignment) and hvm_complete_assist_request() (which is replaced by a
call to hvm_process_portio_intercept() with a suitable set of ops) then
hvm_io_assist() can be moved into hvm.c and made static (and hence be a
candidate
The code in hvmemul_do_io() that tracks large reads or writes, to avoid
re-issue of component I/O, is defeated by accesses across a page boundary
because it uses physical address. The code is also only relevant to memory
mapped I/O to or from a buffer.
This patch re-factors the code and moves it
Use an ioreq_t rather than open coded state, size, dir and data fields
in struct hvm_vcpu_io. This also allows PIO completion to be handled
similarly to MMIO completion by re-issuing the handle_pio() call.
Signed-off-by: Paul Durrant paul.durr...@citrix.com
Cc: Keir Fraser k...@xen.org
Cc: Jan
Building on the previous patch, this patch restricts portio port numbers
to uint16_t in registration/relocate calls and portio_action_t. It also
changes portio sizes to unsigned int which then allows the io_handler
size field to reduce to an unsigned int.
Signed-off-by: Paul Durrant
Jennifer Herbert writes ([Xen-devel] [PATCH 2/7] libxc: Use const pointer in
local_file_dump()):
By adding the const keyword, it is clearer to people and static analysis
tools that no changes to the data are to be made.
Would it be wrong for a future patch to add a field to dump_args which
On Fri, 2015-07-03 at 16:24 +0100, Ian Jackson wrote:
Jennifer Herbert writes ([Xen-devel] [PATCH 5/7] libxc: Removing dead code
from xc_dom_allocate()):
The only place that jumps to 'err:' does so because !dom, which is
rechecked in 'err:'. This patch simplifies, giving the same result.
On Fri, 2015-07-03 at 16:33 +0100, Ian Jackson wrote:
Ian Campbell writes (Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code
from xc_dom_allocate()):
On Fri, 2015-07-03 at 16:24 +0100, Ian Jackson wrote:
Jennifer Herbert writes ([Xen-devel] [PATCH 5/7] libxc: Removing dead
code
Ian Campbell writes (Re: [Xen-devel] [PATCH 7/7] libxc: Prevent NULL pointer
dereference in stdiostream_vmessage()):
On Fri, 2015-07-03 at 16:29 +0100, Ian Jackson wrote:
I think it would be best, in this error case, to explicitly note that
date/time conversion failed, by printing (say)
This uses the dt_for_each_{irq_map,range} helpers to map the interrupt
and child MMIO regions to dom0. Since PCI busses are enumerable these
resources may not be otherwise described in the DT (although they can
be).
Although PCI is the only bus we handle this way the code should be
generic enough
This provides specific handlers for the PCI bus relating to matching
and translating. It's mostly similar to the defaults but includes some
additional error checks and other PCI specific bits.
There are some subtle differences in how the generic code vs. the pci
specific code here will handle
The code in the callbacks for dt_for_each_irq_map and
dt_for_each_range is very similar to the code in handle_device for
each non-pci device.
In fact the only major difference is that the irq callback needs to
call irq_set_spi_type in the PCI case. Refactor into a
map_dt_irq_to_domain callback
Ian Campbell writes (Re: [PATCH OSSTEST v4] mg-all-branch-statuses: Show how
up to date each branch is):
Should it not be:
BRANCHES=all-branch-statuses ./cr-for-branches . -w ./cr-maintjobs ''
which ends up calling
./cr-maintjobs all-branch-status
which in turn calls (from a case $1) the
On 03/07/15 12:34, Roger Pau Monne wrote:
And for the FreeBSD part:
Have you thought at all about what the Linux support for this mode would
look like?
I started briefly looking today but don't really have time to look into
it properly. I do think we want to use as much of the native/HVM
On 01/07/15 19:09, Ed White wrote:
Implement and hook up the code to enable VMX support of VMFUNC and #VE.
VMFUNC leaf 0 (EPTP switching) emulation is added in a later patch.
Signed-off-by: Ed White edmund.h.wh...@intel.com
Reviewed-by: Andrew Cooper andrew.coop...@citrix.com
(You are also
El 03/07/15 a les 18.19, David Vrabel ha escrit:
On 03/07/15 12:34, Roger Pau Monne wrote:
And for the FreeBSD part:
Have you thought at all about what the Linux support for this mode would
look like?
I started briefly looking today but don't really have time to look into
it properly.
On 01/07/15 19:09, Ed White wrote:
The existing ept_set_entry() and ept_get_entry() routines are extended
to optionally set/get suppress_ve and renamed. New ept_set_entry() and
ept_get_entry() routines are provided as wrappers, where set preserves
suppress_ve for an existing entry and sets it
The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge:
forward IPv6 fragmented packets introduced a new function
br_validate_ipv6 which take a reference on the inet6 device. Although,
the reference is not released at the end.
This will result to the impossibility to destroy any
On Fri, 2015-07-03 at 16:15 +0100, Julien Grall wrote:
The other caller of dt_irq_translate returns an error when ret is not 0.
I would do the same here.
dt_device_get_irq just returns the value of dt_irq_translate directly.
But the caller of dt_device_get_irq is treating everything
Jennifer Herbert writes ([Xen-devel] [PATCH 3/7] libxc: Fix uninitialized
valiables in xc_cpuid_hvm_policy()):
If xc_hvm_param_get fails, is_pae and/or is_nestedhvm are left undefined.
This patch Indicates error and defaults to false.
I think my comments on xc_cpuid_pv_policy apply to this
On Thu, Jul 2, 2015 at 1:48 PM, Dario Faggioli dario.faggi...@citrix.com
wrote:
On Thu, 2015-07-02 at 12:48 +0300, Vitaly Chernooky wrote:
Hi all!
Hi,
I have theoretical question.
Great, I love theoretical stuff! :-P
What do you think about porting futexes or binder to XEN?
On Fri, 2015-07-03 at 16:15 +0100, Ian Jackson wrote:
Jennifer Herbert writes ([Xen-devel] [PATCH 1/7] libxc: fix uninitialized
variable in xc_cpuid_pv_policy()):
If xc_domain_get_guest_width were to fail, guest_width is not set, and
hence guest_64bit becomes undefined.
Fix is to
Ian Campbell writes (Re: [Xen-devel] [PATCH 5/7] libxc: Removing dead code
from xc_dom_allocate()):
I'd be ok with either leaving this as is (and tagging CID 1055188 as
intentioanl) or adding the null initialiser as you suggested in your
However:
I would be happy with either of those.
(I
More specifically, this time, of cases when we try to shut the system down or
suspend it in the following situations:
- when the boot cpu (i.e., most of the times, cpu 0) is not assigned to any
cpupool,
- when a (non default) cpupool only has one cpu (and that is not the boot
cpu).
In
The function is called both when we want to remove a cpu
from a cpupool, and during cpu teardown, for suspend or
shutdown. If, however, the boot cpu (cpu 0, most of the
times) is not present in the default cpupool, during
suspend or shutdown, Xen crashes like this:
root@Zhaman:~# xl
And this time, do it right. In fact, a similar change was
attempted in 93be8285a79c6 (cpupools: update domU's node-affinity
on the cpupool_unassign_cpu() path). But that was buggy, and got
reverted with 8395b67ab0b8a86.
However, even though reverting was the right thing to do, it
remains true
No functional change intended.
Signed-off-by: Dario Faggioli dario.faggi...@citrix.com
---
Cc: George Dunlap george.dun...@eu.citrix.com
---
xen/common/schedule.c | 48 +---
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git
On Fri, 2015-07-03 at 15:43 +0100, Ian Jackson wrote:
Ian Campbell writes (Re: [PATCH OSSTEST v4] mg-all-branch-statuses: Show how
up to date each branch is):
On Fri, 2015-07-03 at 14:40 +0100, Ian Jackson wrote:
Do you want to provide a cron job to run this weekly, or something ?
1 - 100 of 236 matches
Mail list logo
