Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Jan Beulich
>>> On 11.12.15 at 17:56, wrote: > On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: >> >> It is not possible to do this at runtime. I think we should do this at >> compile time because in any case it is not supported to run a QEMU built >> for a given Xen version on a different Xen v

Re: [Xen-devel] [PATCH v2 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.

2015-12-14 Thread Jan Beulich
>>> On 12.12.15 at 10:03, wrote: >> On 11.12.2015 at 6:01pm, wrpte: >> >>> On 10.12.15 at 10:33, wrote: >> > @@ -167,10 +172,12 @@ static int queue_invalidate_wait(struct iommu >> *iommu, >> > start_time = NOW(); >> > while ( poll_slot != QINVAL_STAT_DONE ) >> > { >> >

Re: [Xen-devel] [PATCH v2 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.

2015-12-14 Thread Xu, Quan
> On 14.12.2015 at 4:19pm, wrote: > >>> On 12.12.15 at 10:03, wrote: > >> On 11.12.2015 at 6:01pm, wrpte: > >> >>> On 10.12.15 at 10:33, wrote: > >> > @@ -167,10 +172,12 @@ static int queue_invalidate_wait(struct iommu > >> *iommu, > >> > start_time = NOW(); > >> > while ( pol

Re: [Xen-devel] [PATCH v2 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 09:31, wrote: >> On 14.12.2015 at 4:19pm, wrote: >> >>> On 12.12.15 at 10:03, wrote: >> >> On 11.12.2015 at 6:01pm, wrpte: >> >> >>> On 10.12.15 at 10:33, wrote: >> >> > @@ -167,10 +172,12 @@ static int queue_invalidate_wait(struct iommu >> >> *iommu, >> >> > start

Re: [Xen-devel] sh_page_fault

2015-12-14 Thread Jan Beulich
>>> On 12.12.15 at 12:17, wrote: > In case of HVM guests, where is the sh_page_fault function called? Since the pattern repeats, may I please ask you to - avoid sending each of your mails twice (once to @lists.xen.org, and a 2nd time to @lists.xenproject.org), and - consult source code before y

Re: [Xen-devel] [PATCH] tools: always enable HAS_MEM_ACCESS

2015-12-14 Thread Jan Beulich
>>> On 11.12.15 at 17:00, wrote: > For all supported targets HAS_MEM_ACCESS is enabled so this drops the > conditional and always makes it enabled. The goal here is to remove the > setting in the top level config directory when kconfig changes land. Suggested-by: Jan Beulich > Signed-off-by: Do

Re: [Xen-devel] [PATCH] squash into 'build: convert HAS_MEM_ACCESS to use Kconfig'

2015-12-14 Thread Jan Beulich
>>> On 11.12.15 at 17:15, wrote: > I've submitted 'tools: always enable HAS_MEM_ACCESS' and once that lands > this can be squashed into 'build: convert HAS_MEM_ACCESS to use Kconfig'. Well, for some particular definition of "squash" only. I can't see how it would apply incrementally on top of tha

Re: [Xen-devel] [PATCH] xen/tools/get-fields.sh: Use printf for POSIX compat

2015-12-14 Thread Jan Beulich
>>> On 12.12.15 at 19:18, wrote: > xen/tools/get-fields.sh used echo -n which is not POSIX compatible and > breaks with dash. Change it to use printf "%s" which is usable > everywhere. Looks okay, but a couple of remarks: - For the unaware as well as to know why to take care going forward, it w

Re: [Xen-devel] [PATCH v3 1/2] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed.

2015-12-14 Thread Jan Beulich
>>> On 12.12.15 at 14:21, wrote: > @@ -167,10 +172,12 @@ static int queue_invalidate_wait(struct iommu *iommu, > start_time = NOW(); > while ( poll_slot != QINVAL_STAT_DONE ) > { > -if ( NOW() > (start_time + DMAR_OPERATION_TIMEOUT) ) > +if ( NOW(

Re: [Xen-devel] [PATCH v3 2/2] VT-d: Fix vt-d flush timeout issue.

2015-12-14 Thread Jan Beulich
>>> On 12.12.15 at 14:21, wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1890,6 +1890,9 @@ static int intel_iommu_add_device(u8 devfn, struct > pci_dev *pdev) > if ( !pdev->domain ) > return -EINVAL; > > +if ( is_pdev_unass

Re: [Xen-devel] [xen-unstable test] 65791: regressions - FAIL

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 08:50, wrote: > flight 65791 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/65791/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-armhf 5 xen-build

Re: [Xen-devel] [linux-3.14 test] 65633: regressions - FAIL

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 10:30 +0800, Robert Hu wrote: > On Fri, 2015-12-11 at 12:01 +, Ian Campbell wrote: > > On Fri, 2015-12-11 at 11:48 +0800, Robert Hu wrote: > > > On Fri, 2015-12-11 at 01:16 +, osstest service owner wrote: > > > > flight 65633 linux-3.14 real [real] > > > > http://logs.

Re: [Xen-devel] sh_page_fault

2015-12-14 Thread Ian Campbell
On Sat, 2015-12-12 at 11:17 +, Gohar Irfan wrote: > In case of HVM guests, where is the sh_page_fault function called? Please read http://wiki.xen.org/wiki/Asking_Xen_Devel_Questions and pay particular attention to the section "Use your tools". Ian. __

Re: [Xen-devel] [linux-4.1 test] 65781: regressions - FAIL

2015-12-14 Thread Ian Campbell
On Sun, 2015-12-13 at 22:34 +, osstest service owner wrote: > flight 65781 linux-4.1 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/65781/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >  test-amd64-i386-rumpuse

Re: [Xen-devel] [xen-unstable test] 65791: regressions - FAIL

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 02:39 -0700, Jan Beulich wrote: > > > > On 14.12.15 at 08:50, wrote: > > flight 65791 xen-unstable real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/65791/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests whic

[Xen-devel] Question about arm passthrough and power related

2015-12-14 Thread Peng Fan
Hi, I am trying to passthrough a platform device to domU, but as we know clk dts property and related code are handled in dom0. If passthrough the platform device to domU, then how the clock for the device. I came across this documentation "How to passthrough your integrated device to a VM on ARM

Re: [Xen-devel] stubdom migration failure on merlot* XSM related (Was: [adhoc test] 65682: tolerable FAIL])

2015-12-14 Thread Ian Campbell
On Fri, 2015-12-11 at 15:16 +, Ian Campbell wrote: > > I have a new flight going on (65755) with flask=permissive instead of > flask=enforcing (assuming I didn't botch the osstest modifications to > support that setting via a runvar). I did botch the mods, but luckily permissive is the defaul

Re: [Xen-devel] [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

2015-12-14 Thread Ian Campbell
Hello, On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: > Like we are doing for TUN/TAP devices, we should do the same for > macvtaps. Although, it's not as critical as in that case, we > should do it for the consistency. > > Signed-off-by: Michal Privoznik This has triggered a build

Re: [Xen-devel] [linux-3.14 test] 65709: regressions - FAIL

2015-12-14 Thread Ian Campbell
On Sat, 2015-12-12 at 17:37 +, osstest service owner wrote: > flight 65709 linux-3.14 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/65709/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >  test-amd64-i386-rumpus

Re: [Xen-devel] [linux-3.10 test] 65697: regressions - FAIL

2015-12-14 Thread Ian Campbell
On Sat, 2015-12-12 at 11:50 +, osstest service owner wrote: > flight 65697 linux-3.10 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/65697/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >  test-amd64-i386-rumpus

Re: [Xen-devel] [libvirt test] 65654: regressions - FAIL

2015-12-14 Thread Stefano Stabellini
On Fri, 11 Dec 2015, Ian Jackson wrote: > Ian Campbell writes ("Re: [libvirt test] 65654: regressions - FAIL"): > > On Fri, 2015-12-11 at 15:18 +, osstest service owner wrote: > > > flight 65654 libvirt real [real] > > > http://logs.test-lab.xenproject.org/osstest/logs/65654/ > > > > > > Regres

Re: [Xen-devel] [linux-3.14 test] 65633: regressions - FAIL

2015-12-14 Thread Robert Hu
On Mon, 2015-12-14 at 09:38 +, Ian Campbell wrote: > On Mon, 2015-12-14 at 10:30 +0800, Robert Hu wrote: > > On Fri, 2015-12-11 at 12:01 +, Ian Campbell wrote: > > > On Fri, 2015-12-11 at 11:48 +0800, Robert Hu wrote: > > > > On Fri, 2015-12-11 at 01:16 +, osstest service owner wrote: >

Re: [Xen-devel] Taking on a Xen development project

2015-12-14 Thread Ian Campbell
On Sat, 2015-12-12 at 17:07 -0500, Joshua Otto wrote: > On Fri, Dec 11, 2015 at 01:52:41PM +, Ian Campbell wrote: > > Cool! Just to be clear, you are looking for one project for the 3 of > > you to > > work on as a group (vs 3 individual projects), is that right? > > Yes, that's right. > > >

Re: [Xen-devel] stubdom migration failure on merlot* XSM related (Was: [adhoc test] 65682: tolerable FAIL])

2015-12-14 Thread George Dunlap
On Mon, Dec 14, 2015 at 10:14 AM, Ian Campbell wrote: > On Fri, 2015-12-11 at 15:16 +, Ian Campbell wrote: >> >> I have a new flight going on (65755) with flask=permissive instead of >> flask=enforcing (assuming I didn't botch the osstest modifications to >> support that setting via a runvar).

Re: [Xen-devel] [libvirt] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

2015-12-14 Thread Daniel P. Berrange
On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote: > Upstream Xen is in the process of splitting the (stable API) xtl_* > interfaces out from the (unstable API) libxenctrl library and into a > new (stable API) libxentoollog. > > In order to be compatible with Xen both before and after t

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Stefano Stabellini
On Fri, 11 Dec 2015, Ian Campbell wrote: > On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: > >   > > It is not possible to do this at runtime. I think we should do this at > > compile time because in any case it is not supported to run a QEMU built > > for a given Xen version on a diff

Re: [Xen-devel] [linux-3.14 test] 65633: regressions - FAIL

2015-12-14 Thread Ian Jackson
Robert Hu writes ("Re: [Xen-devel] [linux-3.14 test] 65633: regressions - FAIL"): > On Mon, 2015-12-14 at 09:38 +, Ian Campbell wrote: > > We test all kernel.org long term kernels in independent branches (from the > > "linux stable tree" as you call it). This report is for the branch which is

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2015, Jan Beulich wrote: > >>> On 11.12.15 at 17:56, wrote: > > On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: > >> > >> It is not possible to do this at runtime. I think we should do this at > >> compile time because in any case it is not supported to run a QEMU bui

Re: [Xen-devel] [PATCH XEN v6 25/32] tools/libs/gnttab: Extensive updates to API documentation.

2015-12-14 Thread Ian Campbell
On Fri, 2015-12-11 at 17:35 +, Ian Campbell wrote: > On Fri, 2015-12-11 at 17:19 +, Ian Jackson wrote: > > Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v6 25/32] > > tools/libs/gnttab: Extensive updates to API documentation."): > > > I'm currently intending to write something very simil

Re: [Xen-devel] stubdom migration failure on merlot* XSM related (Was: [adhoc test] 65682: tolerable FAIL])

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 11:11 +, George Dunlap wrote: > On Mon, Dec 14, 2015 at 10:14 AM, Ian Campbell > wrote: > > On Fri, 2015-12-11 at 15:16 +, Ian Campbell wrote: > > > > > > I have a new flight going on (65755) with flask=permissive instead of > > > flask=enforcing (assuming I didn't b

Re: [Xen-devel] [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

2015-12-14 Thread Michal Privoznik
On 14.12.2015 11:23, Ian Campbell wrote: > Hello, > > On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: >> Like we are doing for TUN/TAP devices, we should do the same for >> macvtaps. Although, it's not as critical as in that case, we >> should do it for the consistency. >> >> Signed-off

Re: [Xen-devel] [PATCH v10 3/5] libxl: add pvusb API

2015-12-14 Thread George Dunlap
On Mon, Dec 14, 2015 at 7:25 AM, Chun Yan Liu wrote: > > On 12/10/2015 at 08:08 PM, in message <56696b4b.7060...@citrix.com>, George > Dunlap wrote: >> On 10/12/15 12:05, George Dunlap wrote: >> > From: Chunyan Liu >> > >> > Add pvusb APIs, including: >> > - attach/detach (create/destroy)

Re: [Xen-devel] [libvirt] [PATCH LIBVIRT] libxl: Use libxentoollog in preference to libxenctrl if available.

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 11:15 +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2015 at 11:38:36AM +, Ian Campbell wrote: > > Upstream Xen is in the process of splitting the (stable API) xtl_* > > interfaces out from the (unstable API) libxenctrl library and into a > > new (stable API) libxentoo

[Xen-devel] [PATCH] ehci: make idt processing more robust

2015-12-14 Thread Gerd Hoffmann
Make ehci_process_itd return an error in case we didn't do any actual iso transfer because we've found no active transaction. That'll avoid ehci happily run in circles forever if the guest builds a loop out of idts. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 5 +++-- 1 file changed, 3

[Xen-devel] [PATCH v2 00/10] igd passthrough chipset tweaks

2015-12-14 Thread Gerd Hoffmann
Hi, We have some code in our tree to support pci passthrough of intel graphics devices (igd) on xen, which requires some chipset tweaks for (a) the host bridge and (b) the lpc/isa-bridge to meat the expectations of the guest driver. For kvm we need pretty much the same, also the requirements fo

[Xen-devel] [PATCH v2 01/10] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

2015-12-14 Thread Gerd Hoffmann
rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, use it for both xen and non-xen init. That changes behavior of all pc-i440fx-$version machine types where specifying -machine igd-passthru=on used to have no effect and now it has. It is unlikely to cause any trouble though as there used to be no

[Xen-devel] [PATCH v2 03/10] pc: move igd support code to igd.c

2015-12-14 Thread Gerd Hoffmann
Pure code motion, except for dropping instance_size for TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, we can inherit it from TYPE_I440FX_PCI_DEVICE). Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini --- hw/pci-host/Makefile.objs | 3 ++ hw/pci-host/igd.c | 96 +++

[Xen-devel] [PATCH v2 06/10] igd: use defines for standard pci config space offsets

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index 6f52ab1..0784128 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -10,9 +10,9 @@ typedef struct { /* Here we just ex

[Xen-devel] [PATCH v2 04/10] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ef0273b..d1eeafb 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,7 +53,7 @@ out: return ret; } -static

[Xen-devel] [PATCH v2 08/10] igd: add q35 support

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 41 - hw/pci-host/q35.c | 6 +- 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index ec48875..f6e3f7a 100644 --- a/hw/pci-host/igd.c +++ b/hw/pc

[Xen-devel] [PATCH v2 10/10] igd: handle igd-passthrough-isa-bridge setup in realize()

2015-12-14 Thread Gerd Hoffmann
That way a simple '-device igd-passthrough-isa-bridge,addr=1f' will do the setup. Also instead of looking up reasonable PCI IDs based on the graphic device id simply copy over the ids from the host, thereby reusing the infrastructure we have in place for the igd host bridges. Less code, and shoul

[Xen-devel] [PATCH v2 07/10] igd: revamp host config read

2015-12-14 Thread Gerd Hoffmann
Move all work to the host_pci_config_copy helper function, which we can easily reuse when adding q35 support. Open sysfs file only once for all values. Use pread. Proper error handling. Fix bugs: * Don't throw away results (like old host_pci_config_read did because val was passed by value no

[Xen-devel] [PATCH v2 09/10] igd: move igd-passthrough-isa-bridge to igd.c too

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/i386/pc_piix.c | 113 -- hw/pci-host/igd.c | 108 +++ 2 files changed, 108 insertions(+), 113 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c in

[Xen-devel] [PATCH v2 02/10] pc: remove has_igd_gfx_passthru global

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/xen/xen_pt.h | 3 +-- vl.c| 10 -- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index c545280..6d8702b 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -320,10 +320,9 @@ extern void *

[Xen-devel] [PATCH v2 05/10] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

2015-12-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/igd.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c index d1eeafb..6f52ab1 100644 --- a/hw/pci-host/igd.c +++ b/hw/pci-host/igd.c @@ -53,12 +53,20 @@ out: return ret; } +static void (*i440fx_

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 11:19 +, Stefano Stabellini wrote: > On Fri, 11 Dec 2015, Ian Campbell wrote: > > On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: > > >   > > > It is not possible to do this at runtime. I think we should do this > > > at > > > compile time because in any case

Re: [Xen-devel] [PATCH] tools: always enable HAS_MEM_ACCESS

2015-12-14 Thread Razvan Cojocaru
On 12/11/2015 06:00 PM, Doug Goldstein wrote: > For all supported targets HAS_MEM_ACCESS is enabled so this drops the > conditional and always makes it enabled. The goal here is to remove the > setting in the top level config directory when kconfig changes land. > > Signed-off-by: Doug Goldstein

Re: [Xen-devel] [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 12:35 +0100, Michal Privoznik wrote: > On 14.12.2015 11:23, Ian Campbell wrote: > > Hello, > > > > On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: > > > Like we are doing for TUN/TAP devices, we should do the same for > > > macvtaps. Although, it's not as critical

Re: [Xen-devel] [PATCH XEN v6 25/32] tools/libs/gnttab: Extensive updates to API documentation.

2015-12-14 Thread Ian Jackson
Ian Campbell writes ("Re: [Xen-devel] [PATCH XEN v6 25/32] tools/libs/gnttab: Extensive updates to API documentation."): > So I think at least call, foreignmemory and gnttab need a > restriction/caveat like the above, which is that on fork but not exec you > can call close() and hope it does somet

[Xen-devel] [PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)

2015-12-14 Thread Ian Campbell
Allows: (XEN) avc: denied { pcilevel } for domid=2 target=1 scontext=system_u:system_r:dm_dom_t tcontext=system_u:system_r:domU_t_target tclass=hvm Which otherwise leads to the following on resume after migrate (comparing non-XSM to XSM): ata2.00: configured for MWDMA2 usb 1-2: reset full-

Re: [Xen-devel] stubdom migration failure on merlot* XSM related (Was: [adhoc test] 65682: tolerable FAIL])

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 10:14 +, Ian Campbell wrote: >  > I've running a test with the following patch. I'm reasonably hopeful. and it did indeed pass: http://logs.test-lab.xenproject.org/osstest/logs/66273/ I'll resubmit as a proper patch. Ian. > > Ian. > > From 3f14c5afedc0df360952364b93c

Re: [Xen-devel] [PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)

2015-12-14 Thread Ian Jackson
Ian Campbell writes ("[PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)"): ... > - allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl > irqlevel pciroute cacheattr send_irq }; > + allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl

Re: [Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-12-14 Thread Don Slutz
On 12/07/15 08:36, Paul Durrant wrote: >> -Original Message- > [snip] >> >> if ( rc ) >> -hvm_unmap_ioreq_page(s, 0); >> +{ >> +hvm_unmap_ioreq_page(s, IOREQ_PAGE_TYPE_IOREQ); >> +return rc; >> +} >> + >> +rc = hvm

[Xen-devel] [linux-mingo-tip-master test] 65794: regressions - FAIL

2015-12-14 Thread osstest service owner
flight 65794 linux-mingo-tip-master real [real] http://logs.test-lab.xenproject.org/osstest/logs/65794/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-rumpuserxen-i386 10 guest-start fail REGR. vs. 60684 test-amd64

Re: [Xen-devel] [PATCH v7 12/28] build: convert HAS_VGA use to Kconfig

2015-12-14 Thread Jan Beulich
>>> On 10.12.15 at 17:48, wrote: > --- a/xen/drivers/video/Kconfig > +++ b/xen/drivers/video/Kconfig > @@ -2,3 +2,7 @@ > # Select HAS_VIDEO if video is supported > config HAS_VIDEO > bool > + > +# Select HAS_VGA if VGA is supported > +config HAS_VGA > + bool I think HAS_VGA should s

Re: [Xen-devel] [PATCH v7 00/28] Kconfig conversion

2015-12-14 Thread Jan Beulich
>>> On 10.12.15 at 17:48, wrote: > The following series is a follow on to the Kconfig conversion patch series. > There are still more components to convert however this is the bare minimal > to get everything working and get the options out of the existing makefiles. > > The CONFIG_HAS_ variables

Re: [Xen-devel] [PATCH v7 23/28] build: convert HAS_EHCI use to Kconfig

2015-12-14 Thread Jan Beulich
>>> On 10.12.15 at 17:48, wrote: > +# USB EHCI debug port support > +config HAS_EHCI > + bool > + depends on X86 As said before, dependencies on prompt-less options are bogus and potentially confusing (and really wrong here - there's nothing precluding ARM to also use that code as soon as

Re: [Xen-devel] [PATCH] scripts: Add a script to build and submit to coverity.

2015-12-14 Thread Ian Campbell
On Thu, 2015-12-10 at 18:06 +, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] scripts: Add a script to build and > submit to coverity."): > > If curl can do that then fine.  Given > > > > > > > > +declare -a curl_args > > > > > > +curl_args+=("--form" "token=$COV_TOKEN") > > > >

Re: [Xen-devel] [PATCH] xen/x86/pvh: Use HVM's flush_tlb_others op

2015-12-14 Thread David Vrabel
On 13/12/15 00:25, Boris Ostrovsky wrote: > Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor > will likely perform same IPIs as would have the guest. > > More importantly, using MMUEXT_INVLPG_MULTI may not to invalidate the > guest's address on remote CPU (when, for example, V

Re: [Xen-devel] [PATCH RFC 0/3] Xen on Virtio

2015-12-14 Thread David Vrabel
On 07/12/15 16:19, Stefano Stabellini wrote: > Hi all, > > this patch series introduces support for running Linux on top of Xen > inside a virtual machine with virtio devices (nested virt scenario). > The problem is that Linux virtio drivers use virt_to_phys to get the > guest pseudo-physical addr

Re: [Xen-devel] [PATCH] xen/x86/pvh: Use HVM's flush_tlb_others op

2015-12-14 Thread Boris Ostrovsky
On 12/14/2015 08:58 AM, David Vrabel wrote: On 13/12/15 00:25, Boris Ostrovsky wrote: Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor will likely perform same IPIs as would have the guest. More importantly, using MMUEXT_INVLPG_MULTI may not to invalidate the guest's addres

Re: [Xen-devel] [PATCH XEN v6 10/32] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-12-14 Thread Ian Campbell
On Thu, 2015-12-03 at 11:22 +, Ian Campbell wrote: > [...] > +void *xengnttab_map_grant_ref(xengnttab_handle *xgt, > +  uint32_t domid, > +  uint32_t ref, > +  int prot); > [...] > +int xengnttab_munmap(xengntta

Re: [Xen-devel] [PATCH RFC 1/3] xen: export xen_phys_to_bus, xen_bus_to_phys and xen_virt_to_bus

2015-12-14 Thread David Vrabel
On 07/12/15 16:19, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini Can you add a brief description about why these are being moved? Then, assuming this is needed in the end: Acked-by: David Vrabel David ___ Xen-devel mailing list Xen-

Re: [Xen-devel] [PATCH RFC 0/3] Xen on Virtio

2015-12-14 Thread Michael S. Tsirkin
On Mon, Dec 14, 2015 at 02:00:05PM +, David Vrabel wrote: > On 07/12/15 16:19, Stefano Stabellini wrote: > > Hi all, > > > > this patch series introduces support for running Linux on top of Xen > > inside a virtual machine with virtio devices (nested virt scenario). > > The problem is that Lin

Re: [Xen-devel] [PATCH] squash into 'build: convert HAS_MEM_ACCESS to use Kconfig'

2015-12-14 Thread Doug Goldstein
On 12/14/15 3:01 AM, Jan Beulich wrote: On 11.12.15 at 17:15, wrote: >> I've submitted 'tools: always enable HAS_MEM_ACCESS' and once that lands >> this can be squashed into 'build: convert HAS_MEM_ACCESS to use Kconfig'. > > Well, for some particular definition of "squash" only. I can't see

Re: [Xen-devel] [PATCHv4] xen/gntdev: add ioctl for grant copy

2015-12-14 Thread David Vrabel
On 01/12/15 16:43, David Vrabel wrote: > Add IOCTL_GNTDEV_GRANT_COPY to allow applications to copy between user > space buffers and grant references. > > This interface is similar to the GNTTABOP_copy hypercall ABI except > the local buffers are provided using a virtual address (instead of a > GFN

[Xen-devel] [PATCHv4 0/2] x86/ept: reduce translation invalidation impact

2015-12-14 Thread David Vrabel
This series improves the performance of EPT by further reducing the impact of the translation invalidations (ept_sync_domain()). By: a) Deferring invalidations until the p2m write lock is released. Prior to this change a 16 VCPU guest could not be successfully migrated on an (admittedly slow) 160

[Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread David Vrabel
If a guest allocates a page and the tlbflush_timestamp on the page indicates that a TLB flush of the previous owner is required, only the linear and combined mappings are invalidated. The guest-physical mappings are not invalidated. This is currently safe because the EPT code ensures that the gue

[Xen-devel] [PATCHv4 2/2] x86/ept: defer the invalidation until the p2m lock is released

2015-12-14 Thread David Vrabel
Holding the p2m lock while calling ept_sync_domain() is very expensive since it does a on_selected_cpus() call. IPIs on many socket machines can be very slows and on_selected_cpus() is serialized. Defer the invalidate until the p2m lock is released. Since the processor may cache partial translat

Re: [Xen-devel] [PATCHv3 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread David Vrabel
On 07/12/15 10:25, George Dunlap wrote: > > I took the past tense ("synced") to mean, "These CPUs have been > brought into sync (or are no longer out of sync)". So they start out > not-synced, so you initialize the bit to be clear; when an INVEPT is > executed, they become synced, so you set the

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread Andrew Cooper
On 14/12/15 14:39, David Vrabel wrote: > diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c > index eef0372..6e0cf89 100644 > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -1089,9 +1089,10 @@ static void ept_memory_type_changed(struct p2m_domain > *p2m) >

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread David Vrabel
On 14/12/15 14:52, Andrew Cooper wrote: > On 14/12/15 14:39, David Vrabel wrote: >> diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c >> index eef0372..6e0cf89 100644 >> --- a/xen/arch/x86/mm/p2m-ept.c >> +++ b/xen/arch/x86/mm/p2m-ept.c [...] >> +on_selected_cpus(d->domain_dirt

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread Andrew Cooper
On 14/12/15 15:00, David Vrabel wrote: > On 14/12/15 14:52, Andrew Cooper wrote: >> On 14/12/15 14:39, David Vrabel wrote: >>> diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c >>> index eef0372..6e0cf89 100644 >>> --- a/xen/arch/x86/mm/p2m-ept.c >>> +++ b/xen/arch/x86/mm/p2m-ept.c

Re: [Xen-devel] [PATCH] xen/x86/pvh: Use HVM's flush_tlb_others op

2015-12-14 Thread Konrad Rzeszutek Wilk
On Sat, Dec 12, 2015 at 07:25:55PM -0500, Boris Ostrovsky wrote: > Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor > will likely perform same IPIs as would have the guest. > But if the VCPU is asleep, doing it via the hypervisor will save us waking up the guest VCPU, sending

Re: [Xen-devel] [PATCHv4] xen/gntdev: add ioctl for grant copy

2015-12-14 Thread Boris Ostrovsky
On 12/14/2015 09:21 AM, David Vrabel wrote: On 01/12/15 16:43, David Vrabel wrote: Add IOCTL_GNTDEV_GRANT_COPY to allow applications to copy between user space buffers and grant references. This interface is similar to the GNTTABOP_copy hypercall ABI except the local buffers are provided using

Re: [Xen-devel] [PATCH] xen/x86/pvh: Use HVM's flush_tlb_others op

2015-12-14 Thread Roger Pau Monné
El 14/12/15 a les 16.27, Konrad Rzeszutek Wilk ha escrit: > On Sat, Dec 12, 2015 at 07:25:55PM -0500, Boris Ostrovsky wrote: >> Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor >> will likely perform same IPIs as would have the guest. >> > > But if the VCPU is asleep, doing it

Re: [Xen-devel] [PATCHv4 1/2] x86/ept: invalidate guest physical mappings on VMENTER

2015-12-14 Thread George Dunlap
On 14/12/15 15:09, Andrew Cooper wrote: > On 14/12/15 15:00, David Vrabel wrote: >> On 14/12/15 14:52, Andrew Cooper wrote: >>> On 14/12/15 14:39, David Vrabel wrote: diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index eef0372..6e0cf89 100644 --- a/xen/arch/x86/m

[Xen-devel] [PATCH] squash into 'build: convert HAS_PCI use to Kconfig'

2015-12-14 Thread Doug Goldstein
Signed-off-by: Doug Goldstein --- xen/include/xen/iommu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 47f3180..8217cb7 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -107,7 +107,7 @@ int iom

Re: [Xen-devel] [PATCH] xen/tools/get-fields.sh: Use printf for POSIX compat

2015-12-14 Thread Alex Xu
On Mon, 14 Dec 2015 02:12:16 -0700 "Jan Beulich" wrote: > >>> On 12.12.15 at 19:18, wrote: > > xen/tools/get-fields.sh used echo -n which is not POSIX compatible > > and breaks with dash. Change it to use printf "%s" which is usable > > everywhere. > > Looks okay, but a couple of remarks: >

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Jan Beulich
>>> On 11.12.15 at 17:56, wrote: > For the original issue here, could the flag be exposed as a > XEN_SYSCTL_PHYSCAP_ Yes, I think it could, albeit calling this a "capability" or "feature" seems odd (since really the original behavior was bogus/buggy). But - with sysctl not being a stable inte

Re: [Xen-devel] [PATCH] xen/x86/pvh: Use HVM's flush_tlb_others op

2015-12-14 Thread Boris Ostrovsky
On 12/14/2015 10:35 AM, Roger Pau Monné wrote: El 14/12/15 a les 16.27, Konrad Rzeszutek Wilk ha escrit: On Sat, Dec 12, 2015 at 07:25:55PM -0500, Boris Ostrovsky wrote: Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor will likely perform same IPIs as would have the guest.

Re: [Xen-devel] [PATCH] xen-pciback: fix up cleanup path when alloc fails

2015-12-14 Thread David Vrabel
On 02/12/15 14:56, Doug Goldstein wrote: > On 12/2/15 4:35 AM, David Vrabel wrote: >> On 26/11/15 20:32, Doug Goldstein wrote: >>> When allocating a pciback device fails, avoid the possibility of a >>> use after free. >> >> We should not require clearing drvdata for correctness. We should >> ensur

[Xen-devel] [PATCH] squash into 'build: convert HAS_VGA use to Kconfig'

2015-12-14 Thread Doug Goldstein
Signed-off-by: Doug Goldstein --- xen/arch/x86/Kconfig | 1 - xen/drivers/video/Kconfig | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index b03d228..a42c149 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -

[Xen-devel] [PATCH] squash into 'build: convert HAS_EHCI use to Kconfig'

2015-12-14 Thread Doug Goldstein
Signed-off-by: Doug Goldstein --- xen/drivers/char/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index 36a742b..08973cf 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -53,7 +53,6 @@ config HAS_SCIF # USB EH

[Xen-devel] [PATCH] hvmloader: Load proper ACPI tables with OVMF

2015-12-14 Thread Anthony PERARD
This patch loads the ACPI tables associated with QEMU instead of the one for qemu-traditional. Signed-off-by: Anthony PERARD --- tools/firmware/hvmloader/ovmf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/

Re: [Xen-devel] [PATCH] xen/tools/get-fields.sh: Use printf for POSIX compat

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 16:56, wrote: > On Mon, 14 Dec 2015 02:12:16 -0700 > "Jan Beulich" wrote: > >> >>> On 12.12.15 at 19:18, wrote: >> > xen/tools/get-fields.sh used echo -n which is not POSIX compatible >> > and breaks with dash. Change it to use printf "%s" which is usable >> > everywhere.

Re: [Xen-devel] [PATCH] hvmloader: Load proper ACPI tables with OVMF

2015-12-14 Thread Ian Campbell
On Mon, 2015-12-14 at 16:08 +, Anthony PERARD wrote: > This patch loads the ACPI tables associated with QEMU instead of the one > for qemu-traditional. I'd add "... we only support OVMF with qemu-xen" or something, just to make it clear why this is correct. > Signed-off-by: Anthony PERARD A

[Xen-devel] [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE

2015-12-14 Thread Ian Campbell
This is always present at the point of use, which with -pedantic provokes: error: ISO C does not allow extra ';' outside of a function [-Werror=edantic] Signed-off-by: Ian Campbell --- xen/include/public/arch-arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/

[Xen-devel] Pre-domain released event?

2015-12-14 Thread Razvan Cojocaru
Hello, Currently, all the in-tree examples that figure out that a domain has been shut down subscribe to xenstore's @releaseDomain combined with an xs_is_domain_introduced() check. That works fine if you're only interested that the domain no longer exists. However, I'd like to be able to do some c

Re: [Xen-devel] [PATCH] hvmloader: Load proper ACPI tables with OVMF

2015-12-14 Thread Andrew Cooper
On 14/12/15 16:17, Ian Campbell wrote: > On Mon, 2015-12-14 at 16:08 +, Anthony PERARD wrote: >> This patch loads the ACPI tables associated with QEMU instead of the one >> for qemu-traditional. > I'd add "... we only support OVMF with qemu-xen" or something, just to make > it clear why this is

Re: [Xen-devel] [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE

2015-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2015, Ian Campbell wrote: > This is always present at the point of use, which with -pedantic > provokes: > > error: ISO C does not allow extra ';' outside of a function [-Werror=edantic] > > Signed-off-by: Ian Campbell Acked-by: Stefano Stabellini > xen/include/public/arch-ar

Re: [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-14 Thread Stefano Stabellini
On Mon, 14 Dec 2015, Jan Beulich wrote: > >>> On 11.12.15 at 17:56, wrote: > > For the original issue here, could the flag be exposed as a > > XEN_SYSCTL_PHYSCAP_ > > Yes, I think it could, albeit calling this a "capability" or "feature" > seems odd (since really the original behavior was bog

Re: [Xen-devel] [PATCH v7 03/28] build: build Kconfig and config rules

2015-12-14 Thread Jan Beulich
>>> On 10.12.15 at 17:48, wrote: > --- /dev/null > +++ b/xen/Kconfig > @@ -0,0 +1,24 @@ > +# > +# For a description of the syntax of this configuration file, > +# see docs/misc/kconfig-language.txt > +# > +mainmenu "Xen/$SRCARCH $XEN_FULLVERSION Configuration" > + > +config SRCARCH > + string

Re: [Xen-devel] [PATCH v7 04/28] build: use generated Kconfig options for Xen

2015-12-14 Thread Jan Beulich
>>> On 10.12.15 at 17:48, wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -34,6 +34,8 @@ default: build > .PHONY: dist > dist: install > > +build:: include/config/auto.conf > + > .PHONY: build install uninstall clean distclean cscope TAGS tags MAP gtags > build install uninstall debug

Re: [Xen-devel] [PATCH] hvmloader: Load proper ACPI tables with OVMF

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 17:23, wrote: > On 14/12/15 16:17, Ian Campbell wrote: >> On Mon, 2015-12-14 at 16:08 +, Anthony PERARD wrote: >>> This patch loads the ACPI tables associated with QEMU instead of the one >>> for qemu-traditional. >> I'd add "... we only support OVMF with qemu-xen" or someth

Re: [Xen-devel] [PATCH] xen: arm: Drop trailing ; from DEFINE_XEN_GUEST_HANDLE

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 17:21, wrote: > This is always present at the point of use, which with -pedantic > provokes: > > error: ISO C does not allow extra ';' outside of a function [-Werror=edantic] > > Signed-off-by: Ian Campbell FWIW Acked-by: Jan Beulich __

[Xen-devel] blkback name greater than 16 characters issue

2015-12-14 Thread Konrad Rzeszutek Wilk
Hey, Way back in the past Jan pointed out this issue http://lists.xenproject.org/archives/html/xen-devel/2015-05/msg03505.html which is that the device name is "blkback.." for exmaple: blkback.8.xvda, blkback.11.hda With the multiqueue block backend we add "-%d" for the queue. But sadly this i

Re: [Xen-devel] [PATCH] x86/time: Don't use EFI's GetTime call by default

2015-12-14 Thread Konrad Rzeszutek Wilk
On Tue, Dec 08, 2015 at 11:02:16AM +, Ian Campbell wrote: > On Wed, 2015-12-02 at 02:33 -0700, Jan Beulich wrote: > > > > > On 01.12.15 at 20:26, wrote: > > > On 01/12/15 17:26, Jan Beulich wrote: > > > > > > > On 01.12.15 at 17:57, wrote: > > > > > When EFI is used, don't use EFI's GetTime()

Re: [Xen-devel] [PATCH] x86/time: Don't use EFI's GetTime call by default

2015-12-14 Thread Jan Beulich
>>> On 14.12.15 at 17:53, wrote: > On Tue, Dec 08, 2015 at 11:02:16AM +, Ian Campbell wrote: >> In reality only Microsoft (and perhaps to a lesser extent Apple) have any >> sort of ability to force things in this way (even so it is alleged in this >> thread that even Windows avoids the GetTime

[Xen-devel] [PATCH OSSTEST] Debian: Support runvar to set flask mode

2015-12-14 Thread Ian Campbell
Currently it is hardcoding to enforcing but it might be useful to run with e.g. permissive or even disabled (aka dummy mode) Signed-off-by: Ian Campbell --- Osstest/Debian.pm | 10 -- overlay/etc/grub.d/20_linux_xen | 4 +++- 2 files changed, 11 insertions(+), 3 deletions(

  1   2   >