Re: [Xen-devel] [PATCH] libxl: fix printing hotplug arguments/environment

2016-08-02 Thread Roger Pau Monne
On Tue, Aug 02, 2016 at 10:13:42AM +0100, Wei Liu wrote: > On Mon, Aug 01, 2016 at 06:20:56PM +0200, Roger Pau Monne wrote: > > A OS could decide to not pass arguments or any environment variables to > > "An" > > > hotplug scripts, and this will trigger a bug in device_hotplug logic, since > >

Re: [Xen-devel] [PATCH v4 3/4] tools: use pidfile for test if xenstored is running

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:39:27PM +0200, Juergen Gross wrote: > Instead of trying to read xenstore via xenstore-read use the pidfile > of xenstored for the test whether xenstored is running. This prepares > support of xenstore domain, as trying to read xenstore will block > for ever in case

Re: [Xen-devel] [PATCH v4 4/4] tools: make xenstore domain easy configurable

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:39:28PM +0200, Juergen Gross wrote: > Add configuration entries to sysconfig.xencommons for selection of the > xenstore type (domain or daemon) and start the selected xenstore > service via a script called from sysvinit or systemd. > > Signed-off-by: Juergen Gross

[Xen-devel] [xen-unstable-smoke test] 99900: tolerable all pass - PUSHED

2016-08-02 Thread osstest service owner
flight 99900 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/99900/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread George Dunlap
On 02/08/16 12:37, Wei Liu wrote: > On Mon, Aug 01, 2016 at 12:32:54PM +0100, Ian Jackson wrote: >> Introducing HVMCTL, Jan wrote: >>> A long while back separating out all control kind operations (intended >>> for use by only the control domain or device model) from the currect >>> hvmop hypercall

[Xen-devel] [distros-debian-snapshot test] 66884: trouble: blocked/broken/fail/pass

2016-08-02 Thread Platform Team regression test user
flight 66884 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66884/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Juergen Gross
On 02/08/16 13:59, Olaf Hering wrote: > On Tue, Aug 02, Juergen Gross wrote: > >> -rm -f "$XENSTORED_ROOTDIR"/tdb* &>/dev/null >> +rm -f "$XENSTORED_ROOTDIR"/tdb* 2>/dev/null >> >> Please note the "&" in the removed line. And the description just tells >> you that: the file

Re: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:30:30PM +0200, Ingo Jürgensmann wrote: > On 02.08.2016 11:20, Wei Liu wrote: > >On Fri, Jul 29, 2016 at 10:17:22PM +0200, Ingo Jürgensmann wrote: > >What is also interesting is that you seem to be running some sort of > >ip accounting software (pmacctd) which also

[Xen-devel] [PATCH 1034/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1033/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1031/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1035/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1030/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1029/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1028/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 1032/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread David Vrabel
On 02/08/16 12:58, Jan Beulich wrote: On 02.08.16 at 13:38, wrote: >> On Mon, Aug 01, 2016 at 06:41:20AM -0600, Jan Beulich wrote: >> On 01.08.16 at 13:32, wrote: 4. We could invent a new hypercall `DMOP' for hypercalls which device

Re: [Xen-devel] [PATCH] libxl: fix printing hotplug arguments/environment

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 11:27:13AM +0200, Roger Pau Monne wrote: > On Tue, Aug 02, 2016 at 10:13:42AM +0100, Wei Liu wrote: > > On Mon, Aug 01, 2016 at 06:20:56PM +0200, Roger Pau Monne wrote: > > > A OS could decide to not pass arguments or any environment variables to > > > > "An" > > > > >

Re: [Xen-devel] [PATCH v3 3/4] tools: use pidfile for test if xenstored is running

2016-08-02 Thread Wei Liu
On Fri, Jul 22, 2016 at 05:09:30PM +0200, Juergen Gross wrote: > Instead of trying to read xenstore via xenstore-read use the pidfile > of xenstored for the test whether xenstored is running. This prepares > support of xenstore domain, as trying to read xenstore will block > for ever in case

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-08-02 Thread Wei Liu
On Thu, Jul 28, 2016 at 12:06:11PM +0100, Julien Grall wrote: > Hi, > > On 26/07/16 02:17, Boris Ostrovsky wrote: > >On 07/25/2016 07:40 PM, Stefano Stabellini wrote: > >>On Mon, 25 Jul 2016, Boris Ostrovsky wrote: > >>>On 07/25/2016 06:06 PM, Stefano Stabellini wrote: > On Mon, 25 Jul 2016,

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-08-02 Thread Wei Liu
On Thu, Jul 28, 2016 at 08:42:05PM +0800, Shannon Zhao wrote: > On 2016年07月28日 19:06, Julien Grall wrote: > > On 26/07/16 02:17, Boris Ostrovsky wrote: > >> On 07/25/2016 07:40 PM, Stefano Stabellini wrote: > >>> On Mon, 25 Jul 2016, Boris Ostrovsky wrote: > On 07/25/2016 06:06 PM, Stefano

[Xen-devel] [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [Xen-devel] [PATCH] xen: use a common function for pv and hvm guest backend register calls

2016-08-02 Thread Gerd Hoffmann
On Di, 2016-08-02 at 08:32 +0200, Juergen Gross wrote: > Instead of calling xen_be_register() for each supported backend type > for hvm and pv guests in their machine init functions use a common > function in order not to have to add new backends twice. > > This at once fixes the error that hvm

Re: [Xen-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Juergen Gross
On 02/08/16 13:37, Gerd Hoffmann wrote: > On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote: >> When unplugging a device in the Xen pvusb backend drain the submit >> queue before deallocation of the control structures. Otherwise there >> will be bogus memory accesses when I/O contracts are

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 13:38, wrote: > On Mon, Aug 01, 2016 at 06:41:20AM -0600, Jan Beulich wrote: >> >>> On 01.08.16 at 13:32, wrote: >> > 4. We could invent a new hypercall `DMOP' for hypercalls which device >> >models should be able to use,

Re: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-08-02 Thread Wei Liu
On Fri, Jul 29, 2016 at 10:17:22PM +0200, Ingo Jürgensmann wrote: > Am 29.07.2016 um 13:45 schrieb Andreas Ziegler : > > > we tried with kernel 4.6 now, the crashed happened again, though. > > Please find attached the netconsole log of 3 from 4 crashes so far today…

[Xen-devel] [libvirt test] 99895: tolerable FAIL - PUSHED

2016-08-02 Thread osstest service owner
flight 99895 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/99895/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 14 guest-saverestorefail never pass test-armhf-armhf-libvirt 12

[Xen-devel] [PATCH v4 1/4] tools: remove systemd xenstore socket definitions

2016-08-02 Thread Juergen Gross
On a system with systemd the xenstore sockets are created via systemd. Remove the related configuration files in order to be able to decide at runtime whether the sockets should be created or not. This will enable Xen to start xenstore either via a daemon or via a stub domain. As the xenstore

[Xen-devel] [PATCH v4 4/4] tools: make xenstore domain easy configurable

2016-08-02 Thread Juergen Gross
Add configuration entries to sysconfig.xencommons for selection of the xenstore type (domain or daemon) and start the selected xenstore service via a script called from sysvinit or systemd. Signed-off-by: Juergen Gross --- V3: - remove check for running xenstore domain, as this

Re: [Xen-devel] [PATCH] x86: use gcc6'es flags asm() output support

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 11:15, wrote: > On 02/08/16 07:09, Jan Beulich wrote: > On 01.08.16 at 19:11, wrote: >>> On 01/08/16 17:06, Jan Beulich wrote: >>> On 01.07.16 at 18:51, wrote: > How about a different

[Xen-devel] [PATCH v4 3/4] tools: use pidfile for test if xenstored is running

2016-08-02 Thread Juergen Gross
Instead of trying to read xenstore via xenstore-read use the pidfile of xenstored for the test whether xenstored is running. This prepares support of xenstore domain, as trying to read xenstore will block for ever in case xenstore domain is started after trying to read. Signed-off-by: Juergen

[Xen-devel] [PATCH v4 0/4] tools: make xenstore domain/daemon configurable

2016-08-02 Thread Juergen Gross
Add a configuration option to /etc/sysconfig/xencommons to let the user configure whether he wants to start xenstore service as a daemon or as a stubdom. Changes in V4: - patch 1: remove sd_booted() test, undo unintended white space changes - patch 3: use @XEN_RUN_DIR@ as requested by Wei Liu

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Juergen Gross
On 02/08/16 13:13, Wei Liu wrote: > On Tue, Aug 02, 2016 at 12:39:26PM +0200, Juergen Gross wrote: >> In order to prepare starting a xenstore domain split out the starting >> of the xenstore daemon from the xencommons script into a dedicated >> launch-xenstore script. >> >> Correct one error:

Re: [Xen-devel] [PATCH] libxl: fix printing hotplug arguments/environment

2016-08-02 Thread Wei Liu
On Mon, Aug 01, 2016 at 06:20:56PM +0200, Roger Pau Monne wrote: > A OS could decide to not pass arguments or any environment variables to "An" > hotplug scripts, and this will trigger a bug in device_hotplug logic, since > it expects both the argument and the environment arrays to exist. Allow

Re: [Xen-devel] [PATCH v3 3/4] tools: use pidfile for test if xenstored is running

2016-08-02 Thread Juergen Gross
On 02/08/16 12:23, Wei Liu wrote: > On Fri, Jul 22, 2016 at 05:09:30PM +0200, Juergen Gross wrote: >> Instead of trying to read xenstore via xenstore-read use the pidfile >> of xenstored for the test whether xenstored is running. This prepares >> support of xenstore domain, as trying to read

Re: [Xen-devel] [RFC 21/22] xen/arm: p2m: Re-implement p2m_set_mem_access using p2m_{set, get}_entry

2016-08-02 Thread Mark Rutland
On Tue, Aug 02, 2016 at 10:58:00AM +0100, Julien Grall wrote: > On 01/08/2016 19:22, Mark Rutland wrote: > >On Mon, Aug 01, 2016 at 06:26:54PM +0100, Mark Rutland wrote: > >>On Mon, Aug 01, 2016 at 05:57:50PM +0100, Julien Grall wrote: > >>>however we only need one TLBI instruction (assuming there

Re: [Xen-devel] [PATCH v2] libxl: fix printing hotplug arguments/environment

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:49:51PM +0200, Roger Pau Monne wrote: > An OS could decide to not pass any environment variables to hotplug scripts, > and this will trigger a bug in device_hotplug logic, since it expects the > environment array to exist. Allow env to be NULL. > > Signed-off-by: Roger

Re: [Xen-devel] [PATCH 0805/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 07:48:12PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro,

Re: [Xen-devel] [PATCH 2/9] x86/pv: Support do_set_segment_base() for compat guests

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 11:51, wrote: > set_segment_base is the only hypercall exists in only one of the two modes > guests might run in; all other hypercalls are either implemented, or > unimplemented in both modes. > > Remove this split, by allowing do_set_segment_base()

Re: [Xen-devel] [PATCH 3/9] x86/hypercall: Move the hypercall arg tables into C

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 11:51, wrote: > Editing (and indeed, finding) the hypercall args tables can be tricky, > especially towards the end where .rept's are used to maintain the correct > layout. > > Move this all into C, and let the compiler do the hard work. As 0 is the

Re: [Xen-devel] [PATCH RFC 06/12] xen/x86: populate PVHv2 Dom0 physical memory map

2016-08-02 Thread Roger Pau Monne
On Fri, Jul 29, 2016 at 08:04:12PM +0100, Andrew Cooper wrote: > On 29/07/16 17:29, Roger Pau Monne wrote: > > Craft the Dom0 e820 memory map and populate it. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Jan Beulich > > Cc: Andrew Cooper

Re: [Xen-devel] [PATCH RFC 01/12] x86/paging: introduce paging_set_allocation

2016-08-02 Thread Roger Pau Monne
On Fri, Jul 29, 2016 at 05:47:24PM +0100, Andrew Cooper wrote: > On 29/07/16 17:28, Roger Pau Monne wrote: > > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > > index 107fc8c..1b270df 100644 > > --- a/xen/arch/x86/mm/paging.c > > +++ b/xen/arch/x86/mm/paging.c > > @@ -953,6

Re: [Xen-devel] Default controller type for USB devices

2016-08-02 Thread Wei Liu
On Fri, Jul 29, 2016 at 02:15:24PM +0100, George Dunlap wrote: > On 29/07/16 14:00, Juergen Gross wrote: > > When specifying no USB controller type for a usb device the default is > > chosen in libxl__device_usbctrl_setdefault(). For a HVM guest this is > > currently the not yet supported

[Xen-devel] [ovmf test] 99896: all pass - PUSHED

2016-08-02 Thread osstest service owner
flight 99896 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/99896/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 28ade7b802e0732cf9839017ee6e9cf78b842582 baseline version: ovmf

Re: [Xen-devel] [PATCH v2 00/25] arm/altp2m: Introducing altp2m to ARM.

2016-08-02 Thread George Dunlap
On 02/08/16 08:38, Julien Grall wrote: > Hello Tamas, > > On 01/08/2016 21:41, Tamas K Lengyel wrote: >> On Mon, Aug 1, 2016 at 1:55 PM, Julien Grall >> wrote: we did discuss whether altp2m on ARM should be exposed to guests or not but we did not agree whether

Re: [Xen-devel] [PATCH 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Gerd Hoffmann
On Fr, 2016-07-29 at 13:17 +0200, Juergen Gross wrote: > When unplugging a device in the Xen pvusb backend drain the submit > queue before deallocation of the control structures. Otherwise there > will be bogus memory accesses when I/O contracts are finished. > > Correlated to this issue is the

[Xen-devel] live migration to qemu.git fails

2016-08-02 Thread Olaf Hering
Doing a live migration of a HVM domU from staging-4.5 with its included qemu-xen to staging-4.7 with qemu-xen from qemu.org (either master or 2.6.0) fails: # cat /var/log/xen/qemu-dm-fv-x64-sles12sp1-clean--incoming.log char device redirected to /dev/pts/4 (label serial0) xen_ram_alloc: do not

Re: [Xen-devel] [RFC 21/22] xen/arm: p2m: Re-implement p2m_set_mem_access using p2m_{set, get}_entry

2016-08-02 Thread Julien Grall
On 01/08/2016 19:22, Mark Rutland wrote: Hi, Hi Mark, I realised I made a confusing mistake in my last reply; clarification below. On Mon, Aug 01, 2016 at 06:26:54PM +0100, Mark Rutland wrote: On Mon, Aug 01, 2016 at 05:57:50PM +0100, Julien Grall wrote: however we only need one TLBI

[Xen-devel] [PATCH v2] libxl: fix printing hotplug arguments/environment

2016-08-02 Thread Roger Pau Monne
An OS could decide to not pass any environment variables to hotplug scripts, and this will trigger a bug in device_hotplug logic, since it expects the environment array to exist. Allow env to be NULL. Signed-off-by: Roger Pau Monné --- Cc: Wei Liu Cc:

Re: [Xen-devel] Xen 4.6.1 crash with altp2m enabled by default

2016-08-02 Thread Kevin.Mayer
Thanks for your reply. I installed the debug hypervisor and got a new crash dump now. I must confess that I have little to no experience debugging crash dumps, but this seems to be a different kind of error, or at least the way the error is reached is different. The pattern with “page number X

Re: [Xen-devel] [PATCH v2 23/25] arm/altp2m: Extend libxl to activate altp2m on ARM.

2016-08-02 Thread Wei Liu
On Mon, Aug 01, 2016 at 07:10:26PM +0200, Sergej Proskurin wrote: > The current implementation allows to set the parameter HVM_PARAM_ALTP2M. > This parameter allows further usage of altp2m on ARM. For this, we > define an additional, common altp2m field as part of the > libxl_domain_type struct.

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Olaf Hering
On Tue, Aug 02, Juergen Gross wrote: > - rm -f "$XENSTORED_ROOTDIR"/tdb* &>/dev/null > + rm -f "$XENSTORED_ROOTDIR"/tdb* 2>/dev/null > > Please note the "&" in the removed line. And the description just tells > you that: the file shouldn't be removed in the background. How else >

Re: [Xen-devel] [PATCH v3] libxl: memory size in kb requires 64 bit variable

2016-08-02 Thread Wei Liu
On Thu, Jul 28, 2016 at 03:35:19PM +0200, Juergen Gross wrote: > libxl_set_memory_target() and several other interface functions of > libxl use a 32 bit sized parameter for a memory size value in kBytes. > This limits the maximum size to be passed in such a parameter > depending on signedness of

Re: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-08-02 Thread Ingo Jürgensmann
On 02.08.2016 11:20, Wei Liu wrote: On Fri, Jul 29, 2016 at 10:17:22PM +0200, Ingo Jürgensmann wrote: What is also interesting is that you seem to be running some sort of ip accounting software (pmacctd) which also segfault'ed. Yeah, it is segfaulting, because the database (in a domU VM) where

[Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Juergen Gross
In order to prepare starting a xenstore domain split out the starting of the xenstore daemon from the xencommons script into a dedicated launch-xenstore script. Correct one error: don't remove old tdb files in background, as this could lead to very subtle races. A rerun of autogen.sh is

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread Wei Liu
On Mon, Aug 01, 2016 at 12:32:54PM +0100, Ian Jackson wrote: > Introducing HVMCTL, Jan wrote: > > A long while back separating out all control kind operations (intended > > for use by only the control domain or device model) from the currect > > hvmop hypercall has been discussed. This series aims

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread Wei Liu
On Mon, Aug 01, 2016 at 06:41:20AM -0600, Jan Beulich wrote: > >>> On 01.08.16 at 13:32, wrote: > > 4. We could invent a new hypercall `DMOP' for hypercalls which device > >models should be able to use, which always has the target domain in > >a fixed location

Re: [Xen-devel] [PATCH v9] x86/mem-sharing: mem-sharing a range of memory

2016-08-02 Thread Wei Liu
On Mon, Aug 01, 2016 at 11:14:27AM -0600, Tamas K Lengyel wrote: > Currently mem-sharing can be performed on a page-by-page basis from the > control > domain. However, this process is quite wasteful when a range of pages have to > be deduplicated. > > This patch introduces a new mem_sharing

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:42:36PM +0100, George Dunlap wrote: > On 02/08/16 12:37, Wei Liu wrote: > > On Mon, Aug 01, 2016 at 12:32:54PM +0100, Ian Jackson wrote: > >> Introducing HVMCTL, Jan wrote: > >>> A long while back separating out all control kind operations (intended > >>> for use by only

Re: [Xen-devel] [PATCH v2] mem_access: sanitize code around sending vm_event request

2016-08-02 Thread Jan Beulich
>>> On 01.08.16 at 18:52, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -1707,7 +1707,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned > long gla, > int rc, fall_through = 0, paged = 0; > int sharing_enomem = 0; >

Re: [Xen-devel] [PATCH v2 25/25] arm/altp2m: Add test of xc_altp2m_change_gfn.

2016-08-02 Thread Razvan Cojocaru
On 08/01/2016 08:10 PM, Sergej Proskurin wrote: > This commit extends xen-access by a simple test of the functionality > provided by "xc_altp2m_change_gfn". The idea is to dynamically remap a > trapping gfn to another mfn, which holds the same content as the > original mfn. > > Signed-off-by:

Re: [Xen-devel] [PATCH] x86: use gcc6'es flags asm() output support

2016-08-02 Thread Andrew Cooper
On 02/08/16 07:09, Jan Beulich wrote: On 01.08.16 at 19:11, wrote: >> On 01/08/16 17:06, Jan Beulich wrote: >> On 01.07.16 at 18:51, wrote: How about a different example, from the second hunk ---

Re: [Xen-devel] [PATCH v2 25/25] arm/altp2m: Add test of xc_altp2m_change_gfn.

2016-08-02 Thread Sergej Proskurin
Hi Razvan, On 08/02/2016 11:14 AM, Razvan Cojocaru wrote: > On 08/01/2016 08:10 PM, Sergej Proskurin wrote: >> This commit extends xen-access by a simple test of the functionality >> provided by "xc_altp2m_change_gfn". The idea is to dynamically remap a >> trapping gfn to another mfn, which

[Xen-devel] [qemu-mainline baseline-only test] 66883: regressions - trouble: blocked/broken/fail/pass

2016-08-02 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 66883 qemu-mainline real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66883/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 3

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:39:26PM +0200, Juergen Gross wrote: > In order to prepare starting a xenstore domain split out the starting > of the xenstore daemon from the xencommons script into a dedicated > launch-xenstore script. > > Correct one error: don't remove old tdb files in background, as

[Xen-devel] [PATCH v2 2/2] xen: drain submit queue in xen-usb before removing device

2016-08-02 Thread Juergen Gross
When unplugging a device in the Xen pvusb backend drain the submit queue before deallocation of the control structures. Otherwise there will be bogus memory accesses when I/O contracts are finished. Correlated to this issue is the handling of cancel requests: a packet cancelled will still lead to

[Xen-devel] [PATCH 0806/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

[Xen-devel] [PATCH 0805/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [Xen-devel] Xen 4.6.1 crash with altp2m enabled by default

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 13:45, wrote: > (XEN) [ Xen-4.6.1 x86_64 debug=y Not tainted ] > (XEN) CPU:6 > (XEN) RIP:e008:[] vmx_vmenter_helper+0x27e/0x30a > (XEN) RFLAGS: 00010003 CONTEXT: hypervisor > (XEN) rax: 8005003b rbx: 8300e72fc000

[Xen-devel] [xen-4.6-testing test] 99894: regressions - FAIL

2016-08-02 Thread osstest service owner
flight 99894 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/99894/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 15 guest-start/debian.repeat fail REGR. vs. 99776 Regressions

Re: [Xen-devel] live migration to qemu.git fails

2016-08-02 Thread Olaf Hering
On Tue, Aug 02, Olaf Hering wrote: > Doing a live migration of a HVM domU from staging-4.5 with its included > qemu-xen to staging-4.7 with qemu-xen from qemu.org (either master or > 2.6.0) fails: It fails also with staging-4.6 and staging-4.7 and their included qemu-xen binaries, and

Re: [Xen-devel] [PATCH v4 1/4] tools: remove systemd xenstore socket definitions

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 12:39:25PM +0200, Juergen Gross wrote: > On a system with systemd the xenstore sockets are created via systemd. > Remove the related configuration files in order to be able to decide > at runtime whether the sockets should be created or not. This will > enable Xen to start

Re: [Xen-devel] [PATCH] x86/hap: use the right cache attributes when MTRR is disabled

2016-08-02 Thread Roger Pau Monne
On Mon, Aug 01, 2016 at 09:33:56AM -0600, Jan Beulich wrote: > >>> On 26.07.16 at 18:15, wrote: > > --- a/xen/arch/x86/hvm/mtrr.c > > +++ b/xen/arch/x86/hvm/mtrr.c > > @@ -814,10 +814,17 @@ int epte_get_entry_emt(struct domain *d, unsigned > > long gfn, mfn_t mfn, > >

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Wei Liu
On Tue, Aug 02, 2016 at 01:20:40PM +0200, Juergen Gross wrote: > On 02/08/16 13:13, Wei Liu wrote: > > On Tue, Aug 02, 2016 at 12:39:26PM +0200, Juergen Gross wrote: > >> In order to prepare starting a xenstore domain split out the starting > >> of the xenstore daemon from the xencommons script

Re: [Xen-devel] [PATCH] x86/hap: use the right cache attributes when MTRR is disabled

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 13:25, wrote: > On Mon, Aug 01, 2016 at 09:33:56AM -0600, Jan Beulich wrote: >> >>> On 26.07.16 at 18:15, wrote: >> > --- a/xen/arch/x86/hvm/mtrr.c >> > +++ b/xen/arch/x86/hvm/mtrr.c >> > @@ -814,10 +814,17 @@ int

[Xen-devel] [PATCH v2 1/2] xen: when removing a backend don't remove many of them

2016-08-02 Thread Juergen Gross
When a Xenstore watch fires indicating a backend has to be removed don't remove all backends for that domain with the specified device index, but just the one which has the correct type. The easiest way to achieve this is to use the already determined xendev as parameter for xen_be_del_xendev()

[Xen-devel] [PATCH v2 0/2] xen: bug fixes in Xen backend handling

2016-08-02 Thread Juergen Gross
When testing qemu based pvusb backend two bugs have been discovered: - detaching of a usb controller leads to memory clobbering in qemu - detaching of a usb device with active I/O requests could result in crash of qemu V2: remove checkpatch warnings for patch 2 as requested by Gerd Hoffmann

[Xen-devel] [PATCH 0828/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Baole Ni
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 11:51, wrote: > --- a/xen/include/asm-x86/hypercall.h > +++ b/xen/include/asm-x86/hypercall.h > @@ -5,9 +5,21 @@ > #ifndef __ASM_X86_HYPERCALL_H__ > #define __ASM_X86_HYPERCALL_H__ > > +#include > #include > +#include Why? > #include /*

Re: [Xen-devel] [PATCH 4/9] x86/pv: Implement pv_hypercall() in C

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 11:51, wrote: > +long pv_hypercall(struct cpu_user_regs *regs) > +{ > +struct vcpu *curr = current; > +#ifndef NDEBUG > +unsigned long old_rip = regs->rip; > +#endif > +long ret; > +uint32_t eax = regs->eax; > + > +

Re: [Xen-devel] Xen 4.7.0 boot PANIC on kernel 4.7.0-4 + UEFI ?

2016-08-02 Thread lists
On Mon, Aug 1, 2016, at 11:36 PM, Jan Beulich wrote: > yet without a full log thereof I can't judge I've asked what that 'full log' should be >>> Hmmm Could you provide full console dump from Xen and Linux kernel? > >Will serial console output with these options > > kernel:

Re: [Xen-devel] Xen 4.7.0 boot PANIC on kernel 4.7.0-4 + UEFI ?

2016-08-02 Thread lists
On Mon, Aug 1, 2016, at 11:57 PM, Jan Beulich wrote: > Obviously it's not mentioned, as it's in the base tarball. Not obvious at all. What seemed obvious is that the changelog would show all the changes. It doesn't and it wasn't mentioned. Now I know. > Can you try > >

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 15:02, wrote: > On 02/08/16 12:58, Jan Beulich wrote: > On 02.08.16 at 13:38, wrote: >>> On Mon, Aug 01, 2016 at 06:41:20AM -0600, Jan Beulich wrote: >>> On 01.08.16 at 13:32, wrote: > 4. We

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH v4 2/4] tools: split out xenstored starting form xencommons"): > On Tue, Aug 02, 2016 at 01:20:40PM +0200, Juergen Gross wrote: > > Still confused? > > Ah, the 2> vs &> thing is really subtle. I missed that, sorry. `&>' is a (bash-specific, I think) syntax for

Re: [Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 15:58, wrote: > On Mon, Aug 01, 2016 at 09:21:28AM -0600, Jan Beulich wrote: >> >>> On 26.07.16 at 17:45, wrote: >> > Change the message so that it mentions running from the top level directory >> > and using '-C xen' in order to

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-02 Thread Andrew Cooper
On 02/08/16 15:54, Jan Beulich wrote: On 02.08.16 at 16:26, wrote: >> On 02/08/16 15:17, Jan Beulich wrote: >> On 02.08.16 at 16:04, wrote: On 02/08/16 14:28, Jan Beulich wrote: On 02.08.16 at 15:14,

Re: [Xen-devel] Discussion about virtual iommu support for Xen guest

2016-08-02 Thread Lan, Tianyu
On 5/27/2016 4:19 PM, Lan Tianyu wrote: > As for the individual issue of 288vcpu support, there are already issues > with 64vcpu guests at the moment. While it is certainly fine to remove > the hard limit at 255 vcpus, there is a lot of other work required to > even get 128vcpu guests stable.

Re: [Xen-devel] [PATCH 0096/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Roger Pau Monné
On Tue, Aug 02, 2016 at 06:40:21PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro,

Re: [Xen-devel] [PATCH 2/9] x86/pv: Support do_set_segment_base() for compat guests

2016-08-02 Thread Andrew Cooper
On 02/08/16 13:52, Jan Beulich wrote: On 18.07.16 at 11:51, wrote: >> set_segment_base is the only hypercall exists in only one of the two modes >> guests might run in; all other hypercalls are either implemented, or >> unimplemented in both modes. >> >> Remove

Re: [Xen-devel] [PATCH 2/9] x86/pv: Support do_set_segment_base() for compat guests

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 15:25, wrote: > On 02/08/16 13:52, Jan Beulich wrote: > On 18.07.16 at 11:51, wrote: >>> set_segment_base is the only hypercall exists in only one of the two modes >>> guests might run in; all other hypercalls are

Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons

2016-08-02 Thread Ian Jackson
Olaf Hering writes ("Re: [Xen-devel] [PATCH v4 2/4] tools: split out xenstored starting form xencommons"): > "&>" redirects stdout and stderr at the same time. See bash(1) > "Redirecting Standard Output and Standard Error". > Are you saying it does fork into background instead? Snap. That'll

Re: [Xen-devel] [PATCH v2 23/25] arm/altp2m: Extend libxl to activate altp2m on ARM.

2016-08-02 Thread Sergej Proskurin
Hi Wei, On 08/02/2016 01:59 PM, Wei Liu wrote: > On Mon, Aug 01, 2016 at 07:10:26PM +0200, Sergej Proskurin wrote: >> The current implementation allows to set the parameter HVM_PARAM_ALTP2M. >> This parameter allows further usage of altp2m on ARM. For this, we >> define an additional, common

Re: [Xen-devel] [PATCH 4/9] x86/pv: Implement pv_hypercall() in C

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 16:06, wrote: > On 02/08/16 14:12, Jan Beulich wrote: > On 18.07.16 at 11:51, wrote: >>> +long pv_hypercall(struct cpu_user_regs *regs) >>> +{ >>> +struct vcpu *curr = current; >>> +#ifndef NDEBUG >>> +unsigned

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-02 Thread Julien Grall
On 02/08/16 15:17, Jan Beulich wrote: On 02.08.16 at 16:04, wrote: On 02/08/16 14:28, Jan Beulich wrote: On 02.08.16 at 15:14, wrote: On 02/08/16 13:50, Jan Beulich wrote: On 18.07.16 at 11:51, wrote: ---

Re: [Xen-devel] [RFC Design Doc v2] Add vNVDIMM support for Xen

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 02:29, wrote: > 4.2.2 Detection of Host pmem Devices > > The detection and initialize host pmem devices require a non-trivial > driver to interact with the corresponding ACPI namespace devices, > parse namespace labels and make necessary recovery

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-02 Thread Jan Beulich
>>> On 02.08.16 at 16:26, wrote: > > On 02/08/16 15:17, Jan Beulich wrote: > On 02.08.16 at 16:04, wrote: >>> On 02/08/16 14:28, Jan Beulich wrote: >>> On 02.08.16 at 15:14, wrote: > On 02/08/16 13:50, Jan

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: Annotate gfn_get_* helpers as requiring non-NULL parameters

2016-08-02 Thread George Dunlap
On Mon, Aug 1, 2016 at 5:59 PM, Andrew Cooper wrote: > Introduce and use the nonnull attribute to help the compiler catch NULL > parameters being passed to function which require their parameters not to be > NULL. Experimentally, GCC 4.9 on Debian Jessie only warns of

Re: [Xen-devel] [PATCH 1/9] x86/hypercall: Move some of the hvm hypercall infrastructure into hypercall.h

2016-08-02 Thread Andrew Cooper
On 02/08/16 13:50, Jan Beulich wrote: On 18.07.16 at 11:51, wrote: >> --- a/xen/include/asm-x86/hypercall.h >> +++ b/xen/include/asm-x86/hypercall.h >> @@ -5,9 +5,21 @@ >> #ifndef __ASM_X86_HYPERCALL_H__ >> #define __ASM_X86_HYPERCALL_H__ >> >> +#include >>

Re: [Xen-devel] [PATCH 5/9] x86/hypercall: Move the hypercall tables into C

2016-08-02 Thread Jan Beulich
>>> On 18.07.16 at 11:51, wrote: > +hypercall_fn_t *const hypercall_table[NR_hypercalls] = { > +HYPERCALL(set_trap_table), > +HYPERCALL(mmu_update), > +HYPERCALL(set_gdt), > +HYPERCALL(stack_switch), > +HYPERCALL(set_callbacks), > +

Re: [Xen-devel] [PATCH] xen/kconfig: unify messages of options moved from command line to kconfig

2016-08-02 Thread Roger Pau Monne
On Mon, Aug 01, 2016 at 09:21:28AM -0600, Jan Beulich wrote: > >>> On 26.07.16 at 17:45, wrote: > > Change the message so that it mentions running from the top level directory > > and using '-C xen' in order to call the 'menuconfig' target inside of the > > xen directory

  1   2   3   >