Re: [Xen-devel] [PATCH v10 09/11] xen: make grant resource limits per domain

2017-09-28 Thread Juergen Gross
On 28/09/17 02:26, Julien Grall wrote: > Hi Juergen, > > On 09/25/2017 11:00 AM, Juergen Gross wrote: >> diff --git a/xen/include/asm-arm/grant_table.h >> b/xen/include/asm-arm/grant_table.h >> index 30db2d1616..bcdeada9ca 100644 >> --- a/xen/include/asm-arm/grant_table.h >> +++ b/xen/include/asm-

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Hongjiang Zhang
See the attachment. >-Original Message- >From: Juergen Gross [mailto:jgr...@suse.com] >Sent: Thursday, September 28, 2017 2:13 PM >To: Hongjiang Zhang ; xen- >de...@lists.xenproject.org >Subject: Re: [Xen-devel] Only 1 CPU was detected > >On 28/09/17 07:12, Hongjiang Zhang wrote: >> Hi all

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Juergen Gross
On 28/09/17 09:22, Hongjiang Zhang wrote: > See the attachment. > >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: Thursday, September 28, 2017 2:13 PM >> To: Hongjiang Zhang ; xen- >> de...@lists.xenproject.org >> Subject: Re: [Xen-devel] Only 1 CPU was detec

[Xen-devel] [qemu-mainline test] 113864: regressions - FAIL

2017-09-28 Thread osstest service owner
flight 113864 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/113864/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 113817 test-amd64-

Re: [Xen-devel] [PATCH] x86/pvh: fix PVHv2 Dom0 memory calculation

2017-09-28 Thread Jan Beulich
>>> On 27.09.17 at 19:02, wrote: > On 09/27/2017 11:10 AM, Roger Pau Monné wrote: >> On Wed, Sep 27, 2017 at 02:26:37PM +, Jan Beulich wrote: >> On 27.09.17 at 16:16, wrote: --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -263,8 +263,7 @@ unsigned long __

[Xen-devel] [distros-debian-wheezy test] 72167: tolerable trouble: broken/pass

2017-09-28 Thread Platform Team regression test user
flight 72167 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72167/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-arm64 2 hosts-allocate broken like 72135 build-arm64-pvops

Re: [Xen-devel] [PATCH v4 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

2017-09-28 Thread Wei Liu
On Thu, Sep 28, 2017 at 10:12:08AM +0800, Yi Sun wrote: > On 17-09-26 15:19:19, Wei Liu wrote: > > On Sat, Sep 23, 2017 at 05:48:11PM +0800, Yi Sun wrote: > > > This patch renames PSR sysctl/domctl interfaces and related xsm policy to > > > make them be general for all resource allocation features

Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Jan Beulich
>>> On 27.09.17 at 21:56, wrote: > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > .instance_size = sizeof(XenPCIPassthroughState), > .instance_finalize = xen_pci_passthrough_finalize, > .class_init = xen_pci_

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 09:22, wrote: > See the attachment. With (XEN) ACPI Error (tbxfroot-0218): A valid RSDP was not found [20070126] I wonder if you're trying to use xen.gz on an EFI system. Is so, you want to use xen.efi there instead if firmware doesn't set up enough compatibility things in EF

[Xen-devel] [PATCH v2] x86/PV: fix/generalize guest nul selector handling

2017-09-28 Thread Jan Beulich
Segment bases (and limits) aren't being cleared by the loading of a nul selector into a segment register on AMD CPUs. Therefore, if an outgoing vCPU has a non-zero base in FS or GS and the subsequent incoming vCPU has a non-zero but nul selector in the respective register(s), the selector value(s)

[Xen-devel] Linux kernel tmem regression v4.1 -> v4.4

2017-09-28 Thread James Dingwall
Hi, I am trying to migrate my domU instances from v4.1.44 to v4.4.88 and it seems that whether or not e820_host = 1 in the domU configuration is the cause of the following stack trace. Please note I have #define MC_DEBUG 1 in arch/x86/xen/multicall.c so the failed hypervisor call is logged.

Re: [Xen-devel] Building xtf on older distros

2017-09-28 Thread Wei Liu
On Thu, Sep 28, 2017 at 02:43:57PM +1300, Glenn Enright wrote: > Hi there > > When building the xen testing framework on CentOS6, I see the below issue. I > see similar issues with CentOS7 and other distros with older tool chains. > The only one that built cleanly for me was Ubuntu 1604. > > Some

Re: [Xen-devel] Building xtf on older distros

2017-09-28 Thread Andrew Cooper
On 28/09/2017 09:45, Wei Liu wrote: > On Thu, Sep 28, 2017 at 02:43:57PM +1300, Glenn Enright wrote: >> Hi there >> >> When building the xen testing framework on CentOS6, I see the below issue. I >> see similar issues with CentOS7 and other distros with older tool chains. >> The only one that built

[Xen-devel] [PATCH v7] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-28 Thread Alexandru Isaila
From: Andrew Cooper An access which crosses a page boundary is performed atomically by x86 hardware, albeit with a severe performance penalty. An important corner case is when a straddled access hits two pages which differ in whether a translation exists, or in net access rights. The use of hvm

Re: [Xen-devel] Building xtf on older distros

2017-09-28 Thread Wei Liu
On Thu, Sep 28, 2017 at 09:51:20AM +0100, Andrew Cooper wrote: > On 28/09/2017 09:45, Wei Liu wrote: > > On Thu, Sep 28, 2017 at 02:43:57PM +1300, Glenn Enright wrote: > >> Hi there > >> > >> When building the xen testing framework on CentOS6, I see the below issue. > >> I > >> see similar issues

Re: [Xen-devel] [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Jan Beulich
>>> On 25.09.17 at 12:00, wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -930,6 +930,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, > uint32_t leaf, > res->b = v->vcpu_id; > break; > > +case 5: /* PV-specific parameters */ > +if ( i

Re: [Xen-devel] [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Juergen Gross
On 28/09/17 10:59, Jan Beulich wrote: On 25.09.17 at 12:00, wrote: >> --- a/xen/arch/x86/traps.c >> +++ b/xen/arch/x86/traps.c >> @@ -930,6 +930,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, >> uint32_t leaf, >> res->b = v->vcpu_id; >> break; >> >> +case 5:

Re: [Xen-devel] [PATCH v7] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Alexandru Isaila [mailto:aisa...@bitdefender.com] > Sent: 28 September 2017 09:52 > To: xen-devel@lists.xen.org > Cc: jbeul...@suse.com; Andrew Cooper ; > Paul Durrant ; Alexandru Isaila > > Subject: [PATCH v7] x86/hvm: Implement hvmemul_write() using real > ma

Re: [Xen-devel] RT-Xen on ARM

2017-09-28 Thread Andrii Anisov
Hello, On 27.09.17 22:57, Meng Xu wrote: Note that: When you use gEDF scheduler in VM or VMM (i.e., Xen), you should use MPR2 model I guess you mean DMPR in CARTS terms. to compute the resource interface (i.e., VCPU parameters). When you use pEDF scheduler, you should use PRM model to comp

[Xen-devel] [ovmf test] 113867: all pass - PUSHED

2017-09-28 Thread osstest service owner
flight 113867 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/113867/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf ce9aaba64e07d7e12eb160ae32cde7b3357ce388 baseline version: ovmf 36d083ef0018b78ea12db

Re: [Xen-devel] [PATCH v7] x86/hvm: Implement hvmemul_write() using real mappings

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 11:07, wrote: >> From: Alexandru Isaila [mailto:aisa...@bitdefender.com] >> Sent: 28 September 2017 09:52 >> +static void *hvmemul_map_linear_addr( >> +unsigned long linear, unsigned int bytes, uint32_t pfec, >> +struct hvm_emulate_ctxt *hvmemul_ctxt) >> +{ >> +struc

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Hongjiang Zhang
>-Original Message- >From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, September 28, 2017 4:38 PM >To: Hongjiang Zhang >Cc: xen-de...@lists.xenproject.org; Juergen Gross >Subject: Re: [Xen-devel] Only 1 CPU was detected > On 28.09.17 at 09:22, wrote: >> See the attachmen

Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Marcel Apfelbaum
On 27/09/2017 22:56, Eduardo Habkost wrote: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to all direct subtypes of TYPE_PCI_DEVICE, except: 1) The ones that already have INTERFACE_PCIE_DEVICE set: * base-xhci * e1000e * nvme * pvscsi * vfio-pci * virtio-pci * vmxnet3 2) base-pci-bridge Not all PCI b

Re: [Xen-devel] Guest start issue on ARM (maybe related to Credit2) [Was: Re: [xen-unstable test] 113807: regressions - FAIL]

2017-09-28 Thread Dario Faggioli
On Thu, 2017-09-28 at 00:52 +0100, Julien Grall wrote: > On 09/28/2017 12:51 AM, Julien Grall wrote: > > > Things *should really not* explode (like as in Xen crashes) if > > > that > > > happens; actually, from a scheduler perspective, it should really > > > not > > > be too big of a deal (especial

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 11:32, wrote: >> -Original Message- >>From: Jan Beulich [mailto:jbeul...@suse.com] >>Sent: Thursday, September 28, 2017 4:38 PM >>To: Hongjiang Zhang >>Cc: xen-de...@lists.xenproject.org; Juergen Gross >>Subject: Re: [Xen-devel] Only 1 CPU was detected >> > On 28.0

Re: [Xen-devel] [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 11:04, wrote: > On 28/09/17 10:59, Jan Beulich wrote: > On 25.09.17 at 12:00, wrote: >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -930,6 +930,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, >>> uint32_t leaf, >>> res->b = v->vcpu_i

Re: [Xen-devel] [PATCH 1/3] xen: timers: don't miss a timer event because of stop_timer()

2017-09-28 Thread Dario Faggioli
On Wed, 2017-09-27 at 15:39 +0200, Dario Faggioli wrote: > On Wed, 2017-09-27 at 04:30 -0600, Jan Beulich wrote: > >  Or wait - > > wouldn't all you need be to avoid calling stop_timer() in the > > call tree above, if the timer's expiry has passed (suitably > > explained in a comment)? > > > Yes.

Re: [Xen-devel] [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Juergen Gross
On 28/09/17 11:40, Jan Beulich wrote: On 28.09.17 at 11:04, wrote: >> On 28/09/17 10:59, Jan Beulich wrote: >> On 25.09.17 at 12:00, wrote: --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -930,6 +930,13 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, u

[Xen-devel] [PATCH v11 3/3] xen: add some comments in include/public/arch-x86/cpuid.h

2017-09-28 Thread Juergen Gross
Leaf 4 of the Xen-specific CPUID leaves isn't mentioned at all in include/public/arch-x86/cpuid.h, the comments for leaf 5 don't tell anything about the sub-leaf semantics. Add comments to clarify the interface. Signed-off-by: Juergen Gross Acked-by: Jan Beulich --- xen/include/public/arch-x86

[Xen-devel] [PATCH v11 1/3] xen: make grant resource limits per domain

2017-09-28 Thread Juergen Gross
Instead of using the same global resource limits of grant tables (max. number of grant frames, max. number of maptrack frames) for all domains make these limits per domain. Set those per-domain limits in grant_table_set_limits(). The global settings are serving as an upper boundary now which must n

[Xen-devel] [PATCH v11 0/3] xen: better grant v2 support

2017-09-28 Thread Juergen Gross
Currently Linux has no support for grant v2 as this would reduce the maximum number of active grants by a factor of 2 compared to v1, because the number of possible grants are limited by the allowed number of grant frames and grant entries of v2 need twice as much bytes as those of v1. Unfortunate

[Xen-devel] [PATCH v11 2/3] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Juergen Gross
On very large hosts a pv-guest needs to know whether it will have to handle frame numbers larger than 32 bits in order to select the appropriate grant interface version. Add a new Xen specific CPUID node to contain the maximum machine address width similar to the x86 CPUID node 0x8008 containi

Re: [Xen-devel] [PATCH v10 10/11] xen: add new Xen cpuid node for max address width info

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 11:52, wrote: > On 28/09/17 11:40, Jan Beulich wrote: > On 28.09.17 at 11:04, wrote: >>> On 28/09/17 10:59, Jan Beulich wrote: >>> On 25.09.17 at 12:00, wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -930,6 +930,13 @@ void cpuid_hyper

[Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Dario Faggioli
If stop_timer() is called between when the RCU idle timer's interrupt arrives (and TIMER_SOFTIRQ is raised) and when softirqs are checked and handled, the timer is deactivated, and the handler never runs. This happens to the RCU idle timer because stop_timer() is called on it during the wakeup fro

[Xen-devel] [PATCH v2 3/3] xen: RCU: make the period of the idle timer adaptive.

2017-09-28 Thread Dario Faggioli
Basically, if the RCU idle timer, when (if!) it fires, finds that the grace period isn't over, we increase the timer's period (i.e., it will fire later, next time). If, OTOH, it finds the grace period is already finished, we decrease the timer's period (i.e., it will fire a bit earlier next time).

[Xen-devel] [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable.

2017-09-28 Thread Dario Faggioli
Make it possible for the user to specify, with the boot time parameter rcu-idle-timer-period-ms, how frequently a CPU that went idle with pending RCU callbacks should be woken up to check if the grace period ended. Typical values (i.e., some of the values used by Linux as the tick frequency) are 1

[Xen-devel] [PATCH] x86/pvh: fix memory accounting for Dom0

2017-09-28 Thread Roger Pau Monne
Make sure that the memory for the paging structures in case of a HVM Dom0 is subtracted from the total amount of memory available for Dom0 to use. Also take into account whether the IOMMU is sharing the page tables with HAP, or else also reserve some memory for the IOMMU page tables. While there r

[Xen-devel] [PATCH v2 0/3] xen: RCU: Improve the idle timer handling

2017-09-28 Thread Dario Faggioli
Hello, take 2 of this series. v1 is here: https://lists.xen.org/archives/html/xen-devel/2017-09/msg01855.html In patch 2 and patch 3, I took care of Jan's review comments. That meant, in patch 2, changing how the boot parameter is parsed and handled, from using a custom_param() to integer_param

Re: [Xen-devel] [PATCH v4 2/3] x86/xen/time: setup vcpu 0 time info page

2017-09-28 Thread Joao Martins
On 09/28/2017 12:46 AM, Joao Martins wrote: > On 09/27/2017 11:44 PM, Boris Ostrovsky wrote: >> On 09/27/2017 04:57 PM, Joao Martins wrote: >>> On 09/27/2017 09:22 PM, Boris Ostrovsky wrote: On 09/27/2017 11:26 AM, Joao Martins wrote: > On 09/27/2017 03:40 PM, Boris Ostrovsky wrote: >>

Re: [Xen-devel] [PATCH v4 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

2017-09-28 Thread Jan Beulich
>>> On 23.09.17 at 11:48, wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -37,7 +37,7 @@ > #include "hvm/save.h" > #include "memory.h" > > -#define XEN_DOMCTL_INTERFACE_VERSION 0x000e > +#define XEN_DOMCTL_INTERFACE_VERSION 0x000f This is needed onl

[Xen-devel] [PATCH 1/2] x86/hvm/dmop: fix EFAULT condition

2017-09-28 Thread Wei Liu
The copy macro returns false when the copy fails. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant Backport to 4.9 --- xen/arch/x86/hvm/dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index 87

[Xen-devel] [PATCH 0/2] Fix bugs in dmop code

2017-09-28 Thread Wei Liu
I discovered two issues while trying to figure out what went wrong with Windows. Wei Liu (2): x86/hvm/dmop: fix EFAULT condition libxendevicemodel: initialise extent to zero tools/libs/devicemodel/core.c | 2 ++ xen/arch/x86/hvm/dm.c | 2 +- 2 files changed, 3 insertions(+), 1 deleti

[Xen-devel] [PATCH 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Wei Liu
The pad field needs to be zero as required by the hypervisor. Instead of setting the pad separately, memset extent to zero. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Paul Durrant Backport to 4.9 --- tools/libs/devicemodel/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tool

Re: [Xen-devel] [PATCH v4 03/15] x86: rename 'cbm_type' to 'psr_type' to make it general

2017-09-28 Thread Jan Beulich
>>> On 23.09.17 at 11:48, wrote: > This patch renames 'cbm_type' to 'psr_type' to generalize it. > Then, we can reuse this for all psr allocation features. > > Signed-off-by: Yi Sun > Reviewed-by: Wei Liu > Reviewed-by: Roger Pau Monn? Please could you try to get the name right here (so the c

Re: [Xen-devel] [PATCH v4 04/15] x86: implement data structure and CPU init flow for MBA

2017-09-28 Thread Jan Beulich
>>> On 26.09.17 at 10:38, wrote: > On Sat, Sep 23, 2017 at 09:48:13AM +, Yi Sun wrote: >> @@ -332,20 +355,58 @@ static int cat_init_feature(const struct cpuid_leaf >> *regs, >> } >> >> default: >> -return -ENOENT; >> +return false; >> } >> >> /* Add thi

Re: [Xen-devel] [PATCH 1/2] x86/hvm/dmop: fix EFAULT condition

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 September 2017 11:24 > To: Xen-devel > Cc: Wei Liu ; Jan Beulich ; > Andrew Cooper ; Paul Durrant > > Subject: [PATCH 1/2] x86/hvm/dmop: fix EFAULT condition > > The copy macro returns false when the copy fails.

Re: [Xen-devel] [PATCH 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 September 2017 11:24 > To: Xen-devel > Cc: Wei Liu ; Ian Jackson ; > Paul Durrant > Subject: [PATCH 2/2] libxendevicemodel: initialise extent to zero > > The pad field needs to be zero as required by the hypervi

[Xen-devel] [PATCH v2 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Wei Liu
The pad field needs to be zero as required by the hypervisor. Instead of setting the pad separately, use C99 initialiser to clear extent. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Paul Durrant Backport to 4.9 --- tools/libs/devicemodel/core.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[Xen-devel] [PATCH v2 1/2] x86/hvm/dmop: fix EFAULT condition

2017-09-28 Thread Wei Liu
The copy macro returns false when the copy fails. Signed-off-by: Wei Liu --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul Durrant Backport to 4.9 --- xen/arch/x86/hvm/dm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c in

[Xen-devel] [PATCH v2 0/2] Fix bugs in dmop code

2017-09-28 Thread Wei Liu
Wei Liu (2): x86/hvm/dmop: fix EFAULT condition libxendevicemodel: initialise extent to zero tools/libs/devicemodel/core.c | 2 +- xen/arch/x86/hvm/dm.c | 6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) -- 2.11.0 ___ Xen-devel

Re: [Xen-devel] [PATCH v2 1/2] x86/hvm/dmop: fix EFAULT condition

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 September 2017 11:36 > To: Xen-devel > Cc: Anthony Perard ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH v2 1/2] x86/hvm/dmop: fix EFAULT condition > > The copy macro returns false

Re: [Xen-devel] [PATCH v2 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 September 2017 11:36 > To: Xen-devel > Cc: Anthony Perard ; Wei Liu > ; Ian Jackson ; Paul Durrant > > Subject: [PATCH v2 2/2] libxendevicemodel: initialise extent to zero > > The pad field needs to be zero as r

Re: [Xen-devel] [PATCH v2 0/2] Fix bugs in dmop code

2017-09-28 Thread Andrew Cooper
On 28/09/17 11:36, Wei Liu wrote: > Wei Liu (2): > x86/hvm/dmop: fix EFAULT condition > libxendevicemodel: initialise extent to zero Both Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] task btrfs-transacti:651 blocked for more than 120 seconds

2017-09-28 Thread Olivier Bonvalet
Hi ! I have a virtual server (Xen) which very frequently hangs with only this error in logs : [ 1330.144124] INFO: task btrfs-transacti:651 blocked for more than 120 seconds. [ 1330.144141] Not tainted 4.9-dae-xen #2 [ 1330.144146] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables

Re: [Xen-devel] [PATCH v2 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Wei Liu
On Thu, Sep 28, 2017 at 11:40:45AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Wei Liu [mailto:wei.l...@citrix.com] > > Sent: 28 September 2017 11:36 > > To: Xen-devel > > Cc: Anthony Perard ; Wei Liu > > ; Ian Jackson ; Paul Durrant > > > > Subject: [PATCH v2 2/2] libxend

Re: [Xen-devel] [PATCH v2 2/2] libxendevicemodel: initialise extent to zero

2017-09-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 28 September 2017 11:46 > To: Paul Durrant > Cc: Wei Liu ; Xen-devel de...@lists.xenproject.org>; Anthony Perard ; > Ian Jackson > Subject: Re: [PATCH v2 2/2] libxendevicemodel: initialise extent to zero > > On Th

Re: [Xen-devel] [PATCH v4 3/3] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

2017-09-28 Thread Paolo Bonzini
On 27/09/2017 18:06, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 27, 2017 at 02:46:23PM +0100, Joao Martins wrote: >> This file defines an ABI shared between guest and hypervisor(s) >> (KVM, Xen) and as such there should be an correspondent entry in >> MAINTAINERS file. Notice that there's already a

[Xen-devel] [PATCH XTF 3/4] build: Opencode vmfunc as bytes

2017-09-28 Thread Andrew Cooper
Binutils 2.20 of CentOS 6 vintage doesn't understand the mnemonic. The instruction doesn't encode any operands, so we don't lose any flexibility. Reported-by: Glenn Enright Signed-off-by: Andrew Cooper --- tests/xsa-203/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

Re: [Xen-devel] [PATCH v4 04/15] x86: implement data structure and CPU init flow for MBA

2017-09-28 Thread Jan Beulich
>>> On 23.09.17 at 11:48, wrote: > This patch implements main data structures of MBA. > > Like CAT features, MBA HW info has cos_max which means the max thrtl > register number, and thrtl_max which means the max throttle value > (delay value). It also has a flag to represent if the throttle > val

[Xen-devel] [PATCH XTF 2/4] build: Drop unnecessary register clobbers

2017-09-28 Thread Andrew Cooper
The code in question is executing __HYPERVISOR_multicall which is 2-parameter hypercall, which means that args 3-6 are preserved (as opposed to the arguments in the multicall_entry_t list, which are clobbered). GCC 4.4 in CentOS 6 can't cope with the ebp clobber. Reported-by: Glenn Enright Signe

[Xen-devel] [PATCH XTF 4/4] build: Avoid using initialisers for anonymous unions

2017-09-28 Thread Andrew Cooper
GCC 4.4 of CentOS 6 vintage can't cope. Reported-by: Glenn Enright Signed-off-by: Andrew Cooper --- tests/livepatch-priv-check/main.c | 75 ++- 1 file changed, 26 insertions(+), 49 deletions(-) diff --git a/tests/livepatch-priv-check/main.c b/tests/livepatc

[Xen-devel] [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert()

2017-09-28 Thread Andrew Cooper
Implement enough compatibility so the code can use Clang's __has_extension() logic when compiled with GCC. Reported-by: Glenn Enright Signed-off-by: Andrew Cooper --- include/xtf/compiler-gcc.h | 31 +++ include/xtf/compiler.h | 4 include/xtf/lib.h

Re: [Xen-devel] [PATCH v4 06/15] x86: implement get value interface for MBA

2017-09-28 Thread Jan Beulich
>>> On 23.09.17 at 11:48, wrote: > This patch implements get value domctl interface for MBA. > > Signed-off-by: Yi Sun > Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xe

Re: [Xen-devel] [PATCH v4 07/15] x86: implement set value flow for MBA

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 04:39, wrote: > On 17-09-26 10:39:31, Roger Pau Monn wrote: >> On Sat, Sep 23, 2017 at 09:48:16AM +, Yi Sun wrote: >> > @@ -274,29 +277,6 @@ static enum psr_feat_type psr_type_to_feat_type(enum >> > psr_type type) >> > return feat_type; >> > } >> > >> > -static bool

Re: [Xen-devel] task btrfs-transacti:651 blocked for more than 120 seconds

2017-09-28 Thread Nikolay Borisov
On 28.09.2017 13:16, Olivier Bonvalet wrote: > Hi ! > > I have a virtual server (Xen) which very frequently hangs with only > this error in logs : > > [ 1330.144124] INFO: task btrfs-transacti:651 blocked for more than 120 > seconds. > [ 1330.144141] Not tainted 4.9-dae-xen #2 > [ 1330.1

Re: [Xen-devel] [PATCH v4 07/15] x86: implement set value flow for MBA

2017-09-28 Thread Jan Beulich
>>> On 23.09.17 at 11:48, wrote: > This patch implements set value flow for MBA including its callback > function and domctl interface. > > It also changes the memebers in 'cos_write_info' to transfer the > feature array, feature properties array and value array. Then, we > can write all features

Re: [Xen-devel] [PATCH v10 11/11] xen: add some comments in include/public/arch-x86/cpuid.h

2017-09-28 Thread George Dunlap
On 09/25/2017 01:01 PM, Jan Beulich wrote: On 25.09.17 at 12:00, wrote: >> Leaf 4 of the Xen-specific CPUID leaves isn't mentioned at all in >> include/public/arch-x86/cpuid.h, the comments for leaf 5 don't tell >> anything about the sub-leaf semantics. >> >> Add comments to clarify the inter

Re: [Xen-devel] [PATCH v10 11/11] xen: add some comments in include/public/arch-x86/cpuid.h

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 13:50, wrote: > On 09/25/2017 01:01 PM, Jan Beulich wrote: > On 25.09.17 at 12:00, wrote: >>> Leaf 4 of the Xen-specific CPUID leaves isn't mentioned at all in >>> include/public/arch-x86/cpuid.h, the comments for leaf 5 don't tell >>> anything about the sub-leaf semantics.

[Xen-devel] [xen-unstable-smoke test] 113879: tolerable all pass - PUSHED

2017-09-28 Thread osstest service owner
flight 113879 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/113879/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [linux-linus test] 113866: tolerable FAIL - PUSHED

2017-09-28 Thread osstest service owner
flight 113866 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/113866/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemut-win7-amd64 17 guest-stopfail REGR. vs. 113855 test-armhf-armhf-xl-rtds

[Xen-devel] ARM Hikey 960 - Missing Image Files for Xen

2017-09-28 Thread John P. McDermott (USN Civilian)
Xen Developers, The guidance for running Xen on a HiKey 960 identifies files that should be flashed onto the board, as part of the process for installing Xen. https://wiki.xen.org/wiki/HiKey960 All but 2 of the files are available from 96 Boards or can be created by following the guida

Re: [Xen-devel] [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert()

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:59, wrote: > --- /dev/null > +++ b/include/xtf/compiler-gcc.h > @@ -0,0 +1,31 @@ > +#ifndef XTF_COMPILER_GCC_H > +#define XTF_COMPILER_GCC_H > + > +#define GCC_VER (__GNUC__ * 1 + \ > + __GNUC_MINOR__ * 100 + \ > + __GNUC_PATCHLE

Re: [Xen-devel] [PATCH XTF 2/4] build: Drop unnecessary register clobbers

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:59, wrote: > The code in question is executing __HYPERVISOR_multicall which is 2-parameter > hypercall, which means that args 3-6 are preserved (as opposed to the > arguments in the multicall_entry_t list, which are clobbered). > > GCC 4.4 in CentOS 6 can't cope with the ebp

Re: [Xen-devel] [PATCH XTF 3/4] build: Opencode vmfunc as bytes

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:59, wrote: > Binutils 2.20 of CentOS 6 vintage doesn't understand the mnemonic. The > instruction doesn't encode any operands, so we don't lose any flexibility. > > Reported-by: Glenn Enright > Signed-off-by: Andrew Cooper FWIW Reviewed-by: Jan Beulich __

Re: [Xen-devel] [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert()

2017-09-28 Thread Andrew Cooper
On 28/09/17 13:32, Jan Beulich wrote: On 28.09.17 at 12:59, wrote: >> --- /dev/null >> +++ b/include/xtf/compiler-gcc.h >> @@ -0,0 +1,31 @@ >> +#ifndef XTF_COMPILER_GCC_H >> +#define XTF_COMPILER_GCC_H >> + >> +#define GCC_VER (__GNUC__ * 1 + \ >> + __GNUC_MINOR__ * 10

Re: [Xen-devel] [PATCH XTF 4/4] build: Avoid using initialisers for anonymous unions

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:59, wrote: > --- a/tests/livepatch-priv-check/main.c > +++ b/tests/livepatch-priv-check/main.c > @@ -38,23 +38,17 @@ static void check_ret(const char *test, int rc) > static void test_upload(void) > { > static uint8_t payload[PAGE_SIZE]; > -xen_sysctl_t op = > -

Re: [Xen-devel] [PATCH XTF 1/4] build: Support BUILD_BUG_ON() with compilers lacking _Static_assert()

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 14:34, wrote: > On 28/09/17 13:32, Jan Beulich wrote: > On 28.09.17 at 12:59, wrote: >>> --- /dev/null >>> +++ b/include/xtf/compiler-gcc.h >>> @@ -0,0 +1,31 @@ >>> +#ifndef XTF_COMPILER_GCC_H >>> +#define XTF_COMPILER_GCC_H >>> + >>> +#define GCC_VER (__GNUC__ * 1 +

[Xen-devel] [PATCH v4 00/22] libxl/xl: add PVH guest type

2017-09-28 Thread Roger Pau Monne
Hello, This series adds a new PVH guest type to libxl/xl. This supersedes the current PVHv2 implementation that relies on using the "none" device model version. As part of this series a new xl option is also implemented, called "type" that supersedes the current "builder" option. A "firmware" opt

[Xen-devel] [PATCH v4 05/22] xl: introduce a domain type option

2017-09-28 Thread Roger Pau Monne
Introduce a new type option to xl configuration files in order to specify the domain type. This supersedes the current builder option. The new option is documented in the xl.cfg man page, and the previous builder option is marked as deprecated. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson

Re: [Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:15, wrote: > --- a/xen/common/rcupdate.c > +++ b/xen/common/rcupdate.c > @@ -465,7 +465,21 @@ void rcu_idle_timer_stop() > return; > > rdp->idle_timer_active = false; > -stop_timer(&rdp->idle_timer); > + > +/* > + * In general, as the CPU is becomi

Re: [Xen-devel] ARM Hikey 960 - Missing Image Files for Xen

2017-09-28 Thread Konrad Rzeszutek Wilk
On Thu, Sep 28, 2017 at 08:29:27AM -0400, John P. McDermott (USN Civilian) wrote: > Xen Developers, > > The guidance for running Xen on a HiKey 960 identifies files that should be > flashed onto the board, as part of the process for installing Xen. > > https://wiki.xen.org/wiki/HiKey960 >

Re: [Xen-devel] [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable.

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:16, wrote: > @@ -569,6 +579,16 @@ void __init rcu_init(void) > { > void *cpu = (void *)(long)smp_processor_id(); > > +/* We don't allow 0, or anything higher than IDLE_TIMER_PERIOD_MAX */ > +if ( idle_timer_period_ms < 1 || The literal 1 here looks suspicious

Re: [Xen-devel] [PATCH v2 3/3] xen: RCU: make the period of the idle timer adaptive.

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:16, wrote: > Basically, if the RCU idle timer, when (if!) it fires, > finds that the grace period isn't over, we increase the > timer's period (i.e., it will fire later, next time). > If, OTOH, it finds the grace period is already finished, > we decrease the timer's period (i

Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

2017-09-28 Thread Eduardo Habkost
On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > >>> On 27.09.17 at 21:56, wrote: > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > > .instance_size = sizeof(XenPCIPassthroughState), > > .instan

Re: [Xen-devel] [PATCH v4 05/22] xl: introduce a domain type option

2017-09-28 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v4 05/22] xl: introduce a domain type option"): > Introduce a new type option to xl configuration files in order to > specify the domain type. This supersedes the current builder option. > > The new option is documented in the xl.cfg man page, and the previous > bui

Re: [Xen-devel] [PATCH] x86/pvh: fix memory accounting for Dom0

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 12:16, wrote: > Make sure that the memory for the paging structures in case of a HVM > Dom0 is subtracted from the total amount of memory available for Dom0 > to use. Also take into account whether the IOMMU is sharing the > page tables with HAP, or else also reserve some memory

Re: [Xen-devel] [PATCH v1 02/14] x86/np2m: add np2m_flush_base()

2017-09-28 Thread George Dunlap
On 09/04/2017 09:14 AM, Sergey Dyasli wrote: > The new function finds all np2m objects with the specified np2m_base > and flushes them. > > Convert p2m_flush_table() into p2m_flush_table_locked() in order not to > release the p2m_lock after np2m_base check. > > Signed-off-by: Sergey Dyasli Revi

Re: [Xen-devel] [PATCH v1 01/14] x86/np2m: refactor p2m_get_nestedp2m()

2017-09-28 Thread George Dunlap
On 09/04/2017 09:14 AM, Sergey Dyasli wrote: > 1. Add a helper function assign_np2m() > 2. Remove useless volatile > 3. Update function's comment in the header > 4. Minor style fixes ('\n' and d) > > Signed-off-by: Sergey Dyasli Reviewed-by: George Dunlap > --- > xen/arch/x86/mm/p2m.c | 3

[Xen-devel] [linux-3.18 test] 113869: tolerable FAIL - PUSHED

2017-09-28 Thread osstest service owner
flight 113869 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/113869/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-rumprun-i386 17 rumprun-demo-xenstorels/xenstorels.repeat fail in 113856 pass in 113869 test-amd

Re: [Xen-devel] [PATCH v2 1/3] xen: RCU: let the RCU idle timer handler run

2017-09-28 Thread Dario Faggioli
On Thu, 2017-09-28 at 06:59 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 12:15, wrote: > > --- a/xen/common/rcupdate.c > > +++ b/xen/common/rcupdate.c > > @@ -465,7 +465,21 @@ void rcu_idle_timer_stop() > >  return; > >   > >  rdp->idle_timer_active = false; > > -stop_timer(&rd

Re: [Xen-devel] [PATCH v4 05/22] xl: introduce a domain type option

2017-09-28 Thread Roger Pau Monné
On Thu, Sep 28, 2017 at 01:04:19PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v4 05/22] xl: introduce a domain type > option"): > > Introduce a new type option to xl configuration files in order to > > specify the domain type. This supersedes the current builder option. > > > > T

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Hongjiang Zhang
>-Original Message- >From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, September 28, 2017 5:39 PM >To: Hongjiang Zhang >Cc: xen-de...@lists.xenproject.org; Juergen Gross >Subject: RE: [Xen-devel] Only 1 CPU was detected > On 28.09.17 at 11:32, wrote: >>> -Original Me

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Hongjiang Zhang
>> (XEN) ACPI Error (tbxfroot-0218): A valid RSDP was not found >> [20070126] > >Uuh, that is rather bad, I guess. > >Just to be sure: can you please add "loglvl=all" to the xen boot parameters? >This would need to be added in your grub config file just where "no-real- >mode edd=off" is specified t

[Xen-devel] [seabios test] 113870: tolerable FAIL - PUSHED

2017-09-28 Thread osstest service owner
flight 113870 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/113870/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail blocked in 113733 test-amd64-amd64-xl-qemuu-ws16-amd64 10 w

[Xen-devel] Re : task btrfs-transacti:651 blocked for more than 120 seconds

2017-09-28 Thread Olivier Bonvalet
Le jeudi 28 septembre 2017 à 14:18 +0300, Nikolay Borisov a écrit : > So what this stack trace means is that transaction commit has hung. > And > judging by the called functions (assuming they are correct, though > the ? > aren't very encouraging). Concretely, it means that an io has been > started

Re: [Xen-devel] [PATCH v2 2/3] xen: RCU: make the period of the idle timer configurable.

2017-09-28 Thread Dario Faggioli
On Thu, 2017-09-28 at 07:06 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 12:16, wrote: > > > > @@ -569,6 +579,16 @@ void __init rcu_init(void) > >  { > >  void *cpu = (void *)(long)smp_processor_id(); > >   > > +/* We don't allow 0, or anything higher than > > IDLE_TIMER_PERIOD_MAX */

[Xen-devel] [xen-unstable-smoke test] 113883: tolerable all pass - PUSHED

2017-09-28 Thread osstest service owner
flight 113883 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/113883/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] Re : task btrfs-transacti:651 blocked for more than 120 seconds

2017-09-28 Thread Olivier Bonvalet
Le jeudi 28 septembre 2017 à 12:16 +0200, Olivier Bonvalet a écrit : > It's a Debian Stretch system, running a 4.9.52 Linux kernel (on a Xen > 4.8.2 hypervisor). > With an old 4.1.x Linux kernel, I haven't any problem. Just a precision, this VM have 26 block devices attached. Don't know if that ca

Re: [Xen-devel] Only 1 CPU was detected

2017-09-28 Thread Jan Beulich
>>> On 28.09.17 at 16:36, wrote: >> -Original Message- >>From: Jan Beulich [mailto:jbeul...@suse.com] >>Sent: Thursday, September 28, 2017 5:39 PM >>To: Hongjiang Zhang >>Cc: xen-de...@lists.xenproject.org; Juergen Gross >>Subject: RE: [Xen-devel] Only 1 CPU was detected >> > On 28.0

[Xen-devel] [PATCH] x86: mmio_ro_do_page_fault() must be unreachable for DomU

2017-09-28 Thread Jan Beulich
When combining PTWR and MMIO-R/O PV page fault handlers, the need for a second hwdom check was overlooked. Signed-off-by: Jan Beulich --- a/xen/arch/x86/pv/ro-page-fault.c +++ b/xen/arch/x86/pv/ro-page-fault.c @@ -346,7 +346,8 @@ int pv_ro_page_fault(unsigned long addr, struct if ( ((l1e_ge

  1   2   >