[Xen-devel] [qemu-mainline test] 114148: regressions - FAIL

2017-10-09 Thread osstest service owner
flight 114148 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/114148/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 12 guest-start fail REGR. vs. 114042

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Wei Liu
On Mon, Oct 09, 2017 at 03:23:37PM +0100, Andrew Cooper wrote: > On 09/10/17 15:11, Wei Liu wrote: > > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > > index 30c2769684..64955dc017 100644 > > --- a/xen/arch/x86/Kconfig > > +++ b/xen/arch/x86/Kconfig > > Based on Julien's testing,

Re: [Xen-devel] [PATCH] Remove redundant code in branch MAP_PIRQ_TYPE_MSI

2017-10-09 Thread Roger Pau Monné
On Mon, Oct 09, 2017 at 06:00:15AM +, Zhenzhong Duan wrote: > Same code is already in allocate_and_map_msi_pirq() > > Signed-off-by: Zhenzhong Duan Reviewed-by: Roger Pau Monné Whit one nit below. > --- > xen/arch/x86/physdev.c |2 --

Re: [Xen-devel] [PATCH v9 04/11] x86/hvm/ioreq: defer mapping gfns until they are actually requsted

2017-10-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 09 October 2017 13:46 > To: Paul Durrant > Cc: Andrew Cooper ; George Dunlap > ; Ian Jackson ; > Stefano

Re: [Xen-devel] [PATCH v2 01/13] x86emul/fuzz: add rudimentary limit checking

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 14:54, wrote: > On 25/09/17 15:26, George Dunlap wrote: >> From: Jan Beulich >> >> fuzz_insn_fetch() is the only data access helper where it is possible >> to see offsets larger than 4Gb in 16- or 32-bit modes, as we leave the >>

Re: [Xen-devel] [PATCH v2 9/9] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

2017-10-09 Thread Julien Grall
Hi Jan, On 09/10/17 14:40, Jan Beulich wrote: On 09.10.17 at 14:20, wrote: Hi Jan, On 09/10/17 12:42, Jan Beulich wrote: On 05.10.17 at 19:42, wrote: --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -50,8 +50,6 @@ struct

Re: [Xen-devel] [PATCH v2 9/9] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 15:48, wrote: > On 09/10/17 14:40, Jan Beulich wrote: > On 09.10.17 at 14:20, wrote: >>> On 09/10/17 12:42, Jan Beulich wrote: >>> On 05.10.17 at 19:42, wrote: > --- a/xen/arch/arm/domain_build.c

Re: [Xen-devel] [OSSTEST PATCH] examine: save xl info output

2017-10-09 Thread Roger Pau Monné
On Mon, Oct 09, 2017 at 11:34:02AM +, Ian Jackson wrote: > One reason we want this is that it contains a reasonably easy-to-parse > record of the host memory. > > When we have collected this information for all hosts, as xl info > output, we can write a program to copy the information into a

[Xen-devel] [xen-unstable-smoke test] 114193: regressions - FAIL

2017-10-09 Thread osstest service owner
flight 114193 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/114193/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 113972 Tests which

Re: [Xen-devel] [PATCH] tools/libxc: Fix domid parameter types

2017-10-09 Thread Wei Liu
On Mon, Oct 09, 2017 at 03:51:49PM +0100, Andrew Cooper wrote: > On 09/10/17 15:47, Wei Liu wrote: > > On Fri, Oct 06, 2017 at 08:00:00PM +0100, Andrew Cooper wrote: > >> Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters. > >> With a signed type, and an explicitly 16-bit

[Xen-devel] [PATCH v2 1/3] xen/ubsan: Import ubsan implementation from Linux 4.13

2017-10-09 Thread Wei Liu
From: Andrew Cooper A future change will adjust it to compile in Xen. Signed-off-by: Andrew Cooper Signed-off-by: Wei Liu Reviewed-by: Wei Liu Acked-by: Jan Beulich ---

[Xen-devel] [PATCH v2 2/3] xen/ubsan: Implement __ubsan_handle_nonnull_arg()

2017-10-09 Thread Wei Liu
From: Andrew Cooper This hook appears to be missing from the Linux ubsan implemention. This patch is a forward port of https://lkml.org/lkml/2014/10/20/182 Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu Acked-by:

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-09 Thread Ian Jackson
(resending to right address for xen-devel) Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > The last thing the QEMU command line needs is more exotic options. Are > you sure we need a new one here? Can we make existing -runas serve? >

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-09 Thread Daniel P. Berrange
On Mon, Oct 09, 2017 at 04:05:10PM +0100, Ian Jackson wrote: > Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new > -runasid option"): > > The last thing the QEMU command line needs is more exotic options. Are > > you sure we need a new one here? Can we make existing

Re: [Xen-devel] [PATCH v9 01/11] x86/hvm/ioreq: maintain an array of ioreq servers rather than a list

2017-10-09 Thread Jan Beulich
>>> On 06.10.17 at 14:25, wrote: > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -33,6 +33,44 @@ > > #include > > +static void set_ioreq_server(struct domain *d, unsigned int id, > + struct hvm_ioreq_server *s) > +{

Re: [Xen-devel] [PATCH v2 9/9] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 14:20, wrote: > Hi Jan, > > On 09/10/17 12:42, Jan Beulich wrote: > On 05.10.17 at 19:42, wrote: >>> --- a/xen/arch/arm/domain_build.c >>> +++ b/xen/arch/arm/domain_build.c >>> @@ -50,8 +50,6 @@ struct map_range_data >>> /*

Re: [Xen-devel] [PATCH v2] x86: psr: support co-exist features' values setting

2017-10-09 Thread Roger Pau Monné
On Sun, Oct 08, 2017 at 04:22:00AM +, Yi Sun wrote: > It changes the memebers in 'cos_write_info' to transfer the feature array, > feature properties array and value array. Then, we can write all features > values on the cos id into MSRs. > > Because multiple features may co-exist, we need

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 16:11, wrote: > --- a/xen/common/ubsan/ubsan.c > +++ b/xen/common/ubsan/ubsan.c > @@ -10,13 +10,18 @@ > * > */ > > -#include > -#include > -#include > -#include > -#include > -#include > -#include > +#include > +#include > + > +#define

Re: [Xen-devel] [PATCH v9 06/11] x86/hvm/ioreq: add a new mappable resource type...

2017-10-09 Thread Jan Beulich
>>> On 06.10.17 at 14:25, wrote: > @@ -288,6 +301,61 @@ static int hvm_map_ioreq_gfn(struct hvm_ioreq_server *s, > bool buf) > return rc; > } > > +static int hvm_alloc_ioreq_mfn(struct hvm_ioreq_server *s, bool buf) > +{ > +struct domain *currd =

Re: [Xen-devel] [PATCH v9 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-09 Thread Jan Beulich
>>> On 06.10.17 at 14:25, wrote: > @@ -395,6 +397,39 @@ int compat_memory_op(unsigned int cmd, > XEN_GUEST_HANDLE_PARAM(void) compat) > } > #endif > > +case XENMEM_acquire_resource: > +{ > +xen_ulong_t *gmfn_list = (xen_ulong_t

[Xen-devel] Results of Formal vote on Unicore Proposal : Passed & Next Steps

2017-10-09 Thread Lars Kurth
Hi everyone. this is a quick note that the proposal for the Unicore Proposal (see http://markmail.org/message/ly3f6e53nv3jaxd7) has passed. The calculation is as follows: 1) XAPI subproject: quorum not met; subproject’s vote discounted 2) Hypervisor subproject: quorum met 7 votes in favour (min

Re: [Xen-devel] [PATCH v2 01/13] x86emul/fuzz: add rudimentary limit checking

2017-10-09 Thread Andrew Cooper
On 09/10/17 14:26, Jan Beulich wrote: > >>> (NB: put_rep_prefix() is what allows >>> complete_insn to be reached with rc set to other than X86EMUL_OKAY or >>> X86EMUL_DONE. See also commit 53f87c03b4 ["x86emul: generalize >>> exception handling for rep_* hooks"].) >>> >>> Add assert()-s for all

Re: [Xen-devel] [PATCH 1/2] libxl: set the default grant/maptrack frames at structure init

2017-10-09 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH 1/2] libxl: set the default grant/maptrack frames at structure init"): > libxl_domain_build_info had both the maptrack and grant frames set to > 0 by default, forcing the client of libxl to set a sane default. > > This is not backwards compatible, so instead

[Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Wei Liu
Make the following changes: 1. Introduce CONFIG_UBSAN and other auxiliary options. 2. Introduce Build system rune to filter objects. 3. Make ubsan.c build. Currently only x86 is supported. All init.o's are filtered out because of limitation in the build system. There is no user of noubsan-y yet

[Xen-devel] [PATCH v2 0/3] Add support for using the Undefined Behaviour Sanitizer

2017-10-09 Thread Wei Liu
Andrew Cooper (2): xen/ubsan: Import ubsan implementation from Linux 4.13 xen/ubsan: Implement __ubsan_handle_nonnull_arg() Wei Liu (1): xen: hook up UBSAN with CONFIG_UBSAN Cc: Jan Beulich Cc: Andrew Cooper Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Julien Grall
On 09/10/17 15:23, Andrew Cooper wrote: On 09/10/17 15:11, Wei Liu wrote: diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 30c2769684..64955dc017 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig Based on Julien's testing, shouldn't ARM64 also select HAS_UBSAN? I

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Wei Liu
On Mon, Oct 09, 2017 at 03:38:55PM +0100, Andrew Cooper wrote: > On 09/10/17 15:36, Jan Beulich wrote: > On 09.10.17 at 16:11, wrote: > >> --- a/xen/common/ubsan/ubsan.c > >> +++ b/xen/common/ubsan/ubsan.c > >> @@ -10,13 +10,18 @@ > >> * > >> */ > >> > >> -#include

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Andrew Cooper
On 09/10/17 15:36, Jan Beulich wrote: On 09.10.17 at 16:11, wrote: >> --- a/xen/common/ubsan/ubsan.c >> +++ b/xen/common/ubsan/ubsan.c >> @@ -10,13 +10,18 @@ >> * >> */ >> >> -#include >> -#include >> -#include >> -#include >> -#include >> -#include >>

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 16:38, wrote: > On 09/10/17 15:36, Jan Beulich wrote: > On 09.10.17 at 16:11, wrote: >>> --- a/xen/common/ubsan/ubsan.c >>> +++ b/xen/common/ubsan/ubsan.c >>> @@ -10,13 +10,18 @@ >>> * >>> */ >>> >>> -#include >>>

Re: [Xen-devel] [PATCH for-4.10 5/5] tools/dombuilder: Prevent failures of xc_dom_gnttab_init()

2017-10-09 Thread Wei Liu
On Fri, Oct 06, 2017 at 07:04:49PM +0100, Andrew Cooper wrote: > On 06/10/17 11:30, Roger Pau Monné wrote: > > On Thu, Oct 05, 2017 at 06:23:44PM +, Andrew Cooper wrote: > >> Recent changes in grant table configuration have caused calls to > >> xc_dom_gnttab_init() to fail if not proceeded

Re: [Xen-devel] [PATCH] tools/libxc: Fix domid parameter types

2017-10-09 Thread Andrew Cooper
On 09/10/17 16:19, Wei Liu wrote: > On Mon, Oct 09, 2017 at 03:51:49PM +0100, Andrew Cooper wrote: >> On 09/10/17 15:47, Wei Liu wrote: >>> On Fri, Oct 06, 2017 at 08:00:00PM +0100, Andrew Cooper wrote: Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters. With a

Re: [Xen-devel] RT-Xen on ARM

2017-10-09 Thread Meng Xu
Hi Andrii, I'm sorry for replying to this thread late. I was busy with a paper deadline until last Saturday morning. I saw Dario's thorough answer which explains the high-level idea of the real-time analysis that is the theoretical foundation of the analysis tool, e.g., CARTs. Hopefully, he

Re: [Xen-devel] [PATCH v9 01/11] x86/hvm/ioreq: maintain an array of ioreq servers rather than a list

2017-10-09 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 09 October 2017 13:40 > To: Paul Durrant > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v9 01/11] x86/hvm/ioreq: maintain an array

Re: [Xen-devel] [PATCH v9 04/11] x86/hvm/ioreq: defer mapping gfns until they are actually requsted

2017-10-09 Thread Jan Beulich
>>> On 06.10.17 at 14:25, wrote: > --- a/xen/arch/x86/hvm/ioreq.c > +++ b/xen/arch/x86/hvm/ioreq.c > @@ -357,6 +357,9 @@ static void hvm_update_ioreq_evtchn(struct > hvm_ioreq_server *s, > } > } > > +#define HANDLE_BUFIOREQ(s) \ > +(s->bufioreq_handling !=

[Xen-devel] [PATCH v4 08/10] xen/arm: mm: Embed permission in the flags

2017-10-09 Thread Julien Grall
Currently, it is not possible to specify the permission of a new mapping. It would be necessary to use the function modify_xen_mappings with a different set of flags. Introduce a couple of new flags for the permissions (Non-eXecutable, Read-Only) and also provides definition that combine the

[Xen-devel] [PATCH v4 09/10] xen/arm: mm: Handle permission flags when adding a new mapping

2017-10-09 Thread Julien Grall
Currently, all the new mappings will be read-write non-executable. Allow the caller to use other permissions. Signed-off-by: Julien Grall --- Changes in v2: - Switch the runtime check to a BUG_ON() --- xen/arch/arm/mm.c | 3 +++ 1 file changed, 3 insertions(+)

[Xen-devel] [PATCH v4 03/10] xen/arm: mm: Rename and clarify AP[1] in the stage-1 page table

2017-10-09 Thread Julien Grall
The description of AP[1] in Xen is based on testing rather than the ARM ARM. Per the ARM ARM, on EL2 stage-1 page table, AP[1] is RES1 as the translation regime applies to only one exception level (see D4.4.4 and G4.6.1 in ARM DDI 0487B.a). Update the comment and also rename the field to match

[Xen-devel] [PATCH v4 05/10] xen/arm: mm: Rename 'ai' into 'flags' in create_xen_entries

2017-10-09 Thread Julien Grall
The parameter 'ai' is used either for attribute index or for permissions. Follow-up patch will rework that parameters to carry more information. So rename the parameter to 'flags'. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara Reviewed-by:

[Xen-devel] [PATCH v4 06/10] xen/arm: mm: Use PAGE_HYPERVISOR_* instead of MT_* when calling set_fixmap

2017-10-09 Thread Julien Grall
At the moment, PAGE_HYPERVISOR_* and MT_* have exactly the same value. In a follow-up patch the former will be extended to carry more information. It looks like the caller of set_fixmap are mixing the both. Stay consistent and only use PAGE_HYPERVISOR_*. This is also match the behavior of

[Xen-devel] [PATCH v4 02/10] xen/arm: page: Clean-up the definition of MAIRVAL

2017-10-09 Thread Julien Grall
Currently MAIRVAL is defined in term of MAIR0VAL and MAIR1VAL which are both hardcoded value. This makes quite difficult to understand the value written in both registers. Rework the definition by using value of each attribute shifted by their associated index. Signed-off-by: Julien Grall

[Xen-devel] [PATCH v4 01/10] xen/arm: page: Use ARMv8 naming to improve readability

2017-10-09 Thread Julien Grall
This is based on the Linux ARMv8 naming scheme (see arch/arm64/mm/proc.S). Each type will contain "NORMAL" or "DEVICE" to make clear whether each attribute targets device or normal memory. Signed-off-by: Julien Grall --- Changes in v3: - The ai '000' is named

[Xen-devel] [PATCH v4 10/10] xen/arm: mm: Use memory flags for modify_xen_mappings rather than custom one

2017-10-09 Thread Julien Grall
This will help to consolidate the page-table code and avoid different path depending on the action to perform. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara Reviewed-by: Stefano Stabellini Reviewed-by: Konrad

[Xen-devel] [PATCH v4 00/10] xen/arm: Memory subsystem clean-up

2017-10-09 Thread Julien Grall
Hi all, This patch series contains clean-up for the ARM memory subsystem in preparation of reworking the page tables handling. For all changes, see in each patch. Cheers, Julien Grall (10): xen/arm: page: Use ARMv8 naming to improve readability xen/arm: page: Clean-up the definition of

[Xen-devel] [PATCH v4 07/10] xen/arm: page: Describe the layout of flags used to update page tables

2017-10-09 Thread Julien Grall
Currently, the flags used to update page tables (i.e PAGE_HYPERVISOR_*) only contains the memory attribute index. Follow-up patches will add more information in it. So document the current layout. At the same time introduce PAGE_AI_MASK to get the memory attribute index easily. Signed-off-by:

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-10-09 Thread Lars Kurth
> On 27 Sep 2017, at 13:57, Robert VanVossen > wrote: > > > > On 9/26/2017 3:12 AM, Dario Faggioli wrote: >> [Cc-list modified by removing someone and adding someone else] >> >> On Mon, 2017-09-25 at 16:10 -0700, Stefano Stabellini wrote: >>> On Mon, 11 Sep

[Xen-devel] [PATCH 1/2] libxl: set the default grant/maptrack frames at structure init

2017-10-09 Thread Roger Pau Monne
libxl_domain_build_info had both the maptrack and grant frames set to 0 by default, forcing the client of libxl to set a sane default. This is not backwards compatible, so instead initialize both max_grant_frames and max_maptrack_frames to a sane default (ie: like previous behavior). This fixes

Re: [Xen-devel] preparations for 4.9.1 and 4.7.4

2017-10-09 Thread Lars Kurth
I will try and run the XSA scripts this week and get back to you Lars On 06/10/2017, 14:33, "Jan Beulich" wrote: All, with the goal of releasing around the end of the month, please point out backport candidates you find missing from the respective staging

Re: [Xen-devel] [PATCH v9 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-09 Thread Jan Beulich
>>> On 06.10.17 at 14:25, wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -965,6 +965,67 @@ static long xatp_permission_check(struct domain *d, > unsigned int space) > return xsm_add_to_physmap(XSM_TARGET, current->domain, d); > } > > +#ifdef

Re: [Xen-devel] [PATCH v2 3/3] xen: hook up UBSAN with CONFIG_UBSAN

2017-10-09 Thread Andrew Cooper
On 09/10/17 15:11, Wei Liu wrote: > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 30c2769684..64955dc017 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig Based on Julien's testing, shouldn't ARM64 also select HAS_UBSAN?  Otherwise, LGTM. ~Andrew

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-09 Thread Ian Jackson
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > The last thing the QEMU command line needs is more exotic options. Are > you sure we need a new one here? Can we make existing -runas serve? > Precedence: Coreutils[*]. Pseudo-code: > > if

Re: [Xen-devel] [PATCH v2 01/17] x86emul: support remaining AVX insns

2017-10-09 Thread George Dunlap
On 09/14/2017 04:12 PM, Jan Beulich wrote: > I.e. those not being equivalents of SSEn ones. > > There's one necessary change to generic code: Faulting behavior of > VMASKMOVP{S,D} requires us to do partial reads/writes. > > Signed-off-by: Jan Beulich > --- > v2: Move

Re: [Xen-devel] [PATCH v3 7/9] xen/arm: mm: Embed permission in the flags

2017-10-09 Thread Julien Grall
Hi, On 02/10/17 18:31, Julien Grall wrote: Currently, it is not possible to specify the permission of a new mapping. It would be necessary to use the function modify_xen_mappings with a different set of flags. Introduce a couple of new flags for the permissions (Non-eXecutable, Read-Only) and

[Xen-devel] [PATCH v4 04/10] xen/arm: Switch to SYS_STATE_boot just after end_boot_allocator()

2017-10-09 Thread Julien Grall
We should consider the early boot period to end when we stop using the boot allocator. This is inline with x86 and will be helpful to know whether we should allocate memory from the boot allocator or xenheap. Signed-off-by: Julien Grall Reviewed-by: Andre Przywara

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

2017-10-09 Thread Lars Kurth
> On 12 Sep 2017, at 16:35, Rich Persaud wrote: > >> On Sep 11, 2017, at 13:01, George Dunlap wrote: >> >> +### XSM & FLASK >> + >> +Status: Experimental >> + >> +Compile time disabled >> + >> +### XSM & FLASK support for IS_PRIV >> + >> +

[Xen-devel] [xen-unstable-smoke test] 114188: regressions - FAIL

2017-10-09 Thread osstest service owner
flight 114188 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/114188/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 12 guest-start fail REGR. vs. 113972 Tests which

Re: [Xen-devel] [PATCH v2 01/13] x86emul/fuzz: add rudimentary limit checking

2017-10-09 Thread Andrew Cooper
On 25/09/17 15:26, George Dunlap wrote: > From: Jan Beulich > > fuzz_insn_fetch() is the only data access helper where it is possible > to see offsets larger than 4Gb in 16- or 32-bit modes, as we leave the > incoming rIP untouched in the emulator itself. Is it reasonable to

[Xen-devel] [PATCH 0/2] xl/libxl: fixes for the grant-table changes

2017-10-09 Thread Roger Pau Monne
The recent grant-table commits have changed the behavior of xl/libxl, and are currently causing regressions in the osstest tests. The following two commits attempt to restore previous behavior by setting a sane default number of grant/maptrack frames. Note that only the first patch should be

[Xen-devel] [PATCH 2/2] xl: set default maptrack frames to 1024

2017-10-09 Thread Roger Pau Monne
This is in line with the previous behavior, setting the number of maptrack frames to 0 will prevent driver domains from working correctly. Signed-off-by: Roger Pau Monné --- Cc: Ian Jackson Cc: Wei Liu Cc: Juergen Gross

[Xen-devel] [ovmf test] 114172: all pass - PUSHED

2017-10-09 Thread osstest service owner
flight 114172 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/114172/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 728d74973c9262b6c7b7ef4be213223d55affec3 baseline version: ovmf

Re: [Xen-devel] [PATCH] tools/libxc: Fix domid parameter types

2017-10-09 Thread Wei Liu
On Fri, Oct 06, 2017 at 08:00:00PM +0100, Andrew Cooper wrote: > Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters. > With a signed type, and an explicitly 16-bit type, it is exceedingly difficult > to construct an INVALID_DOMID constant which works with all of them. (The

Re: [Xen-devel] [PATCH] tools/libxc: Fix domid parameter types

2017-10-09 Thread Andrew Cooper
On 09/10/17 15:47, Wei Liu wrote: > On Fri, Oct 06, 2017 at 08:00:00PM +0100, Andrew Cooper wrote: >> Mixed throughout libxc are uint32_t, int, and domid_t for domid parameters. >> With a signed type, and an explicitly 16-bit type, it is exceedingly >> difficult >> to construct an INVALID_DOMID

Re: [Xen-devel] [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post

2017-10-09 Thread Anthony PERARD
On Wed, Oct 04, 2017 at 05:18:06PM +0100, Ian Jackson wrote: > We need to restrict *all* the control fds that qemu opens. Looking in > /proc/PID/fd shows there are many; their allocation seems scattered > throughout Xen support code in qemu. > > We must postpone the restrict call until roughly

[Xen-devel] [PATCH v2 00/24] Provide some actual restriction of qemu

2017-10-09 Thread Ian Jackson
With this series, it is possible to run qemu in a way that I think really does not have global privilege any more. I have verified that it runs as a non-root user. I have checked all of its fds and they are either privcmd (which I have arranged to neuter), or /dev/null, or harmless sockets and

[Xen-devel] [PATCH 01/26] xen: Provide XEN_DMOP_remote_shutdown

2017-10-09 Thread Ian Jackson
SCHEDOP_remote_shutdown should be a DMOP so that a deprivileged qemu can do the propery tidying up. We need to keep SCHEDOP_remote_shutdown for ABI stability reasons and because it is needed for PV guests. CC: Jan Beulich CC: Andrew Cooper CC:

[Xen-devel] [PATCH 08/26] libxl: #include "xentoolcore_internal.h"

2017-10-09 Thread Ian Jackson
We are going to want to move something here. Signed-off-by: Ian Jackson Acked-by: Wei Liu --- tools/libxl/Makefile | 11 ++- tools/libxl/libxl_internal.h | 2 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git

[Xen-devel] [PATCH 10/26] xentoolcore_restrict_all: Implement for libxendevicemodel

2017-10-09 Thread Ian Jackson
Signed-off-by: Ian Jackson Acked-by: Wei Liu --- tools/Rules.mk | 2 +- tools/libs/devicemodel/Makefile | 3 ++- tools/libs/devicemodel/core.c | 16

[Xen-devel] [PATCH 16/26] tools/xenstore: get_handle: use "goto err" error handling style

2017-10-09 Thread Ian Jackson
Replace the ad-hoc exit clauses with the error handling style where - local variables contain either things to be freed, or sentinels - all error exits go via an "err" label which frees everything Signed-off-by: Ian Jackson Acked-by: Wei Liu

[Xen-devel] [PATCH 21/26] libxl: Rationalise calculation of user to run qemu as

2017-10-09 Thread Ian Jackson
If the config specifies a user we use that. Otherwise: When we are not restricting qemu, there is very little point running it as a different user than root. Indeed, previously, creating the "magic" users would cause qemu to become slightly dysfunctional (for example, you can't insert a cd that

[Xen-devel] [PATCH 14/26] xentoolcore_restrict_all: Declare problems due to no evtchn support

2017-10-09 Thread Ian Jackson
Signed-off-by: Ian Jackson Acked-by: Wei Liu --- tools/libs/toolcore/include/xentoolcore.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libs/toolcore/include/xentoolcore.h b/tools/libs/toolcore/include/xentoolcore.h index

[Xen-devel] [xen-unstable-smoke test] 114199: regressions - trouble: blocked/broken/fail

2017-10-09 Thread osstest service owner
flight 114199 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/114199/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-amd64 6

[Xen-devel] [refpolicy SELinux PATCH] Updates to SELinux refpolicies to make xenconsoled work. (v1)]

2017-10-09 Thread Konrad Rzeszutek Wilk
Re-sending as the first didn't hit the refpolicy mailing list. Date: Mon, 9 Oct 2017 11:53:45 -0400 From: Konrad Rzeszutek Wilk To: refpol...@oss.tresys.com Cc: xen-de...@lists.xenproject.org Subject: [refpolicy SELinux PATCH] Updates to SELinux refpolicies to make

Re: [Xen-devel] [PATCH v2 3/5] xl: enable per-VCPU extratime flag for RTDS

2017-10-09 Thread Dario Faggioli
On Mon, 2017-10-09 at 12:13 -0400, Meng Xu wrote: > On Wed, Sep 13, 2017 at 8:51 PM, Dario Faggioli > wrote: > > > > On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote: > > > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c > > > index ba0159d..1b03d44 100644

Re: [Xen-devel] Windows "heinsenbug" (WAS: Re: Notes Design Session: Making Releases Lessons Learned: Improving Our Release Process and Tooling)

2017-10-09 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Paul Durrant > Sent: 26 September 2017 08:41 > To: 'Julien Grall' ; Ian Jackson > ; Jan Beuli ch > Cc: Juergen Gross

[Xen-devel] [refpolicy SELinux PATCH 2/2] kernel/xen: Add map permission to the dev_rw_xen

2017-10-09 Thread Konrad Rzeszutek Wilk
From: Konrad Rzeszutek Wilk type=AVC msg=audit(1504637347.487:280): avc: denied { map } for pid=857 comm="xenconsoled" path="/dev/xen/privcmd" dev="devtmpfs" ino=16289 scontext=system_u:system_r:xenconsoled_t:s0 Without this we can't use xenconsole (client) to talk to

[Xen-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-09 Thread Ian Jackson
We need to restrict *all* the control fds that qemu opens. Looking in /proc/PID/fd shows there are many; their allocation seems scattered throughout Xen support code in qemu. We must postpone the restrict call until roughly the same time as qemu changes its uid, chroots (if applicable), and so

[Xen-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-09 Thread Ian Jackson
xc_interface_open etc. is not going to work if we have dropped privilege, but xendevicemodel_shutdown will if everything is new enough. xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so provide a stub for earlier versions. Signed-off-by: Ian Jackson

[Xen-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-09 Thread Ian Jackson
From: Anthony PERARD Xen libraries 4.10 will include a new xentoolcore library, without which xendevicemodel et al will not work. Signed-off-by: Ian Jackson --- configure | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[Xen-devel] [PATCH 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-09 Thread Ian Jackson
This makes it much easier to find a particular thing in config.log. The information may be lacking in other shells, resulting in harmless empty output. (This is why we don't use the proper ${FUNCNAME[*]} array syntax - other shells will choke on that.) The extra output is only printed if

[Xen-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-09 Thread Ian Jackson
We are going to want to reuse this. No functional change. Signed-off-by: Ian Jackson Reviewed-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/i386/xen/xen-hvm.c

[Xen-devel] [PATCH 7/8] os-posix: Provide new -runas . facility

2017-10-09 Thread Ian Jackson
This allows the caller to specify a uid and gid to use, even if there is no corresponding password entry. This will be useful in certain Xen configurations. We don't support just -runas because: (i) deprivileging without calling setgroups would be ineffective (ii) given only a uid we don't know

Re: [Xen-devel] [PATCH v2 01/17] x86emul: support remaining AVX insns

2017-10-09 Thread Jan Beulich
>>> On 09.10.17 at 17:36, wrote: > On 09/14/2017 04:12 PM, Jan Beulich wrote: >> @@ -7119,6 +7142,18 @@ x86_emulate( >> fic.insn_bytes = PFX_BYTES + 3; >> break; >> >> +case X86EMUL_OPC_VEX_66(0x0f38, 0x19): /* vbroadcastsd m64,ymm */ >> +case

Re: [Xen-devel] [PATCH v2 3/5] xl: enable per-VCPU extratime flag for RTDS

2017-10-09 Thread Meng Xu
On Wed, Sep 13, 2017 at 8:51 PM, Dario Faggioli wrote: > > On Fri, 2017-09-01 at 11:58 -0400, Meng Xu wrote: > > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c > > index ba0159d..1b03d44 100644 > > --- a/tools/xl/xl_cmdtable.c > > +++

Re: [Xen-devel] [PATCH v4 01/39] arm/p2m: Introduce p2m_(switch|restore)_vttbr_and_(g|s)et_flags

2017-10-09 Thread Julien Grall
Hi Sergej, On 30/08/17 19:32, Sergej Proskurin wrote: This commit introduces macros for switching and restoring the vttbr considering the currently set irq flags. We define these macros, as the following commits will use the associated functionality multiple times throughout different files.

Re: [Xen-devel] [PATCH v4 02/39] arm/p2m: Add first altp2m HVMOP stubs

2017-10-09 Thread Julien Grall
Hi Sergej, On 30/08/17 19:32, Sergej Proskurin wrote: This commit copies and extends the altp2m-related code from x86 to ARM. Functions that are no yet supported notify the caller or print a BUG message stating their absence. I am still concerned on the locking differing between x86 and Arm

Re: [Xen-devel] [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post

2017-10-09 Thread Ian Jackson
(My resend has crossed with your review. Sorry about that.) Anthony PERARD writes ("Re: [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post"): > On Wed, Oct 04, 2017 at 05:18:06PM +0100, Ian Jackson wrote: > > +void xen_setup_post(void) > > +{ > > +int rc; > > We

[Xen-devel] [ovmf baseline-only test] 72221: regressions - FAIL

2017-10-09 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72221 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72221/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 15

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-10-09 Thread Meng Xu
On Tue, Sep 19, 2017 at 5:23 AM, Dario Faggioli wrote: > > On Fri, 2017-09-15 at 12:01 -0400, Meng Xu wrote: > > On Wed, Sep 13, 2017 at 8:16 PM, Dario Faggioli > > wrote: > > > > > > > I'm ok with what it is in this patch, although I feel

Re: [Xen-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-09 Thread Ian Jackson
Ian Jackson writes ("[PATCH 1/8] xen: link against xentoolcore"): > From: Anthony PERARD > > Xen libraries 4.10 will include a new xentoolcore library, without > which xendevicemodel et al will not work. The xentoolcore library was just committed to xen.git#staging,

Re: [Xen-devel] [PATCH v4 00/39] arm/altp2m: Introducing altp2m to ARM

2017-10-09 Thread Julien Grall
On 07/10/17 11:54, Sergej Proskurin wrote: Hi Julien, Hello, On 10/07/2017 12:29 PM, Julien Grall wrote: On 07/10/2017 11:18, Sergej Proskurin wrote: Hi all, Hello Sergej, just wanted to friendly remind you about the next altp2m on ARM patch series, since it has been submitted

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-09 Thread Ian Jackson
Daniel P. Berrange writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Just use getpwuid() to get the "struct passwd *", then change_process_uid() > doesn't need any changes at all AFAICT. See my comments in the commit message. There may be multiple passwd entries

Re: [Xen-devel] [PATCH v3 1/3] xen: RCU: let the RCU idle timer handler run

2017-10-09 Thread Dario Faggioli
On Mon, 2017-10-09 at 03:49 -0600, Jan Beulich wrote: > > > > On 28.09.17 at 19:06, wrote: > > > With at least the latter addressed > Reviewed-by: Jan Beulich > Of course both should be easy to take care of while committing, > should no other reason

Re: [Xen-devel] [PATCH v4 07/39] arm/p2m: Move hostp2m init/teardown to individual functions

2017-10-09 Thread Julien Grall
Hi Sergej, On 30/08/17 19:32, Sergej Proskurin wrote: This commit pulls out generic init/teardown functionality out of "p2m_init" and "p2m_teardown" into "p2m_init_one", "p2m_teardown_one", and "p2m_flush_table" functions. This allows our future implementation to reuse existing code for the

Re: [Xen-devel] [PATCH] Remove redundant code in branch MAP_PIRQ_TYPE_MSI

2017-10-09 Thread Konrad Rzeszutek Wilk
On Mon, Oct 09, 2017 at 02:15:48PM +0800, Joe Jin wrote: > Looks good for me. > > Reviewed-by: Joe Jin Ah, indeed. Reviewed-by: Konrad Rzeszutek Wilk Also CC-ing Jan and Andrew. P.S. Could you change the title to have 'x86/physdev:' as part of

Re: [Xen-devel] [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-09 Thread Bill Bonaparte
On Mon, Oct 9, 2017 at 12:13 AM, Tan, Jianfeng wrote: > Hi, > > On 10/8/2017 12:54 PM, Bill Bonaparte wrote: > > Thanks Jianfeng for taking time to reply. > > please allow me to briefly explain why I want to run dpdk on xen. > our system is based on dpdk, which means we

Re: [Xen-devel] [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-10-09 Thread Ian Jackson
(resending, more competently this time) Daniel P. Berrange writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Just use getpwuid() to get the "struct passwd *", then change_process_uid() > doesn't need any changes at all AFAICT. See my comments in the commit

Re: [Xen-devel] [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post

2017-10-09 Thread Ian Jackson
(My resend has crossed with your review. Sorry about that.) Anthony PERARD writes ("Re: [PATCH 3/8] xen: defer call to xen_restrict until after os_setup_post"): > On Wed, Oct 04, 2017 at 05:18:06PM +0100, Ian Jackson wrote: > > +void xen_setup_post(void) > > +{ > > +int rc; > > We

Re: [Xen-devel] [PATCH 27/27 v11] xen/arm: vpl011: Correct the logic for asserting/de-asserting SBSA UART TX interrupt

2017-10-09 Thread Andre Przywara
Hi, can you please re-break the commit message to fit into 72 characters? git show looks rather ugly as it is now. On 27/09/17 07:13, Bhupinder Thakur wrote: > This patch fixes the issue observed when pl011 patches were tested on > the junos hardware by Andre/Julien. It was observed that when

[Xen-devel] [PATCH v4] x86/altp2m: Added xc_altp2m_set_mem_access_multi()

2017-10-09 Thread Petre Pircalabu
From: Razvan Cojocaru For the default EPT view we have xc_set_mem_access_multi(), which is able to set an array of pages to an array of access rights with a single hypercall. However, this functionality was lacking for the altp2m subsystem, which could only set page

Re: [Xen-devel] [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements

2017-10-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507564902-9000-1-git-send-email-ian.jack...@eu.citrix.com Subject: [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements === TEST SCRIPT BEGIN === #!/bin/bash

[Xen-devel] [xen-4.8-testing test] 114173: tolerable FAIL - PUSHED

2017-10-09 Thread osstest service owner
flight 114173 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/114173/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-xtf-amd64-amd64-1 48 xtf/test-hvm64-lbr-tsx-vmentry fail in 114093 pass in 114173

  1   2   >