Re: [Xen-devel] [PATCH] Avoid needless flush cache when guest change MTRR

2015-02-03 Thread Tian, Kevin
> From: Zhang, Yang Z > Sent: Wednesday, February 04, 2015 1:54 PM > > Tian, Kevin wrote on 2015-02-04: > >> From: Li, Liang Z > >> Sent: Wednesday, February 04, 2015 11:28 AM > >> > >> Flushing cache is needed only when guest has IOMMU device, using > >> need_iommu(d) can minimize the impact to g

Re: [Xen-devel] [RFC PATCH V3 12/12] xen/vm_event: Check for VM_EVENT_FLAG_DUMMY only in Debug builds

2015-02-03 Thread Tian, Kevin
> From: Tamas K Lengyel [mailto:tamas.leng...@zentific.com] > Sent: Friday, January 30, 2015 5:47 AM > > The flag is only used for debugging purposes, thus it should be only checked > for in debug builds of Xen. > > Signed-off-by: Tamas K Lengyel > --- > xen/arch/x86/mm/mem_sharing.c | 2 ++ >

Re: [Xen-devel] [RFC PATCH V3 10/12] xen: Introduce monitor_op domctl

2015-02-03 Thread Tian, Kevin
> From: Tamas K Lengyel [mailto:tamas.leng...@zentific.com] > Sent: Friday, January 30, 2015 5:47 AM > > In preparation for allowing for introspecting ARM and PV domains the old > control interface via the hvm_op hypercall is retired. A new control > mechanism > is introduced via the domctl hyperc

Re: [Xen-devel] [RFC PATCH V3 09/12] x86/hvm: factor out and rename vm_event related functions into separate file

2015-02-03 Thread Tian, Kevin
> From: Tamas K Lengyel [mailto:tamas.leng...@zentific.com] > Sent: Friday, January 30, 2015 5:47 AM > > To avoid growing hvm.c these functions can be stored > separately. > > Signed-off-by: Tamas K Lengyel VMX changes are clearly renaming: Acked-by: Kevin Tian > --- > v3: Style fixes and re

Re: [Xen-devel] [PATCH] Avoid needless flush cache when guest change MTRR

2015-02-03 Thread Zhang, Yang Z
Tian, Kevin wrote on 2015-02-04: >> From: Li, Liang Z >> Sent: Wednesday, February 04, 2015 11:28 AM >> >> Flushing cache is needed only when guest has IOMMU device, using >> need_iommu(d) can minimize the impact to guest with device assigned, >> since a guest may be hot plugged with a device thus

Re: [Xen-devel] [PATCH] Avoid needless flush cache when guest change MTRR

2015-02-03 Thread Tian, Kevin
> From: Li, Liang Z > Sent: Wednesday, February 04, 2015 11:28 AM > > Flushing cache is needed only when guest has IOMMU device, using > need_iommu(d) can minimize the impact to guest with device assigned, > since a guest may be hot plugged with a device thus there may be dirty > cache lines befor

[Xen-devel] [rumpuserxen test] 34129: regressions - FAIL

2015-02-03 Thread xen . org
flight 34129 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34129/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 6 xen-build fail REGR. vs. 33866 build-i386-rumpuserxe

[Xen-devel] [ovmf test] 34106: regressions - FAIL

2015-02-03 Thread xen . org
flight 34106 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34106/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3865 xen-build fail REGR. vs. 33686 build-amd64

Re: [Xen-devel] Xen's Linux kernel config options V2

2015-02-03 Thread Juergen Gross
On 02/04/2015 01:48 AM, Luis R. Rodriguez wrote: I'm going to work on this now so my replies below. Note: If we want feature to require XEN_PV || XEN_PVH || XEN_PVHVM, since XEN_BACKEND depends on them I think we could just use XEN_BACKEND as a shorthand. Furthermore if we then wanted something

[Xen-devel] [linux-3.10 test] 34094: regressions - FAIL

2015-02-03 Thread xen . org
flight 34094 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 7 debian-hvm-install fail REGR. vs. 26303 test-amd64-amd64-xl-qe

Re: [Xen-devel] pvSCSI test

2015-02-03 Thread Juergen Gross
On 02/03/2015 07:16 PM, Kristian Hagsted Rasmussen wrote: Hi Olaf and Juergen I am interested in testing pvSCSI as I have a system were it would be ideal. I have tried to apply this patch "http://marc.info/?l=xen-devel&m=139885599019457&w=2"; called "libbxl: add support for pvscsi, iteration

[Xen-devel] [RFC 4/7] libxl: Add "stubdomain_version" to domain_build_info.

2015-02-03 Thread Eric Shelton
This enum gives the ability to select between a MiniOS-based QEMU traditional stub domain and a Linux-based QEMU upstream stub domain. To use the Linux-based stubdomain, the following two lines should be included in the appropriate xl.cfg file: device_model_version="qemu-xen" device_model_stubdom

[Xen-devel] [RFC 5/7] libxl: Handle Linux stubdomain specific QEMU options.

2015-02-03 Thread Eric Shelton
This patch creates an appropriate command line for the QEMU instance running in a Linux-based stubdomain. NOTE: a number of items are not currently implemented for Linux-based stubdomains, such as: - save/restore - QMP socket - graphics output (e.g., VNC) Signed-off-by: Eric Shelton --- tools/l

[Xen-devel] [RFC 3/7] linux-stubdomain: Build a disk image

2015-02-03 Thread Eric Shelton
This patch builds a disk image intended to be mounted as rootfs by the Linux stub domain. It is assembled using dracut and genext2fs. Signed-off-by: Eric Shelton --- stubdom-linux/.gitignore | 4 ++ stubdom-linux/Makefile| 45 +++- stubdom-linux/extra/inits

[Xen-devel] [RFC 6/7] libxl: Build the domain with a Linux based stubdomain

2015-02-03 Thread Eric Shelton
This will build a Linux-based stubdomain with QEMU upstream. Signed-off-by: Eric Shelton --- tools/libxl/libxl.c | 25 -- tools/libxl/libxl_create.c | 7 ++- tools/libxl/libxl_dm.c | 108 --- tools/libxl/libxl_internal.c | 22 +

[Xen-devel] [RFC 0/7] RFC Linux-based QEMU-upstream stub domain

2015-02-03 Thread Eric Shelton
This patch series updates Anthony Perard's original patch series to bring support for running QEMU upstream as a device model in a stubdomain by using a Linux-based stubdom, rather than MiniOS as currently used for QEMU traditional. Anthony posted the original patch series on April 17, 2013. The

[Xen-devel] [RFC 7/7] libxl: Wait for QEMU startup in stubdomain

2015-02-03 Thread Eric Shelton
To ensure the QEMU instance in a stubdomain is running before we unpause an HVM guest that relies on it for a device model, we do a xenstore wait on QEMU's indiction that it is running. Signed-off-by: Eric Shelton --- tools/libxl/libxl_dm.c | 46 +- 1

[Xen-devel] [RFC 1/7] linux-stubdomain: Compile QEMU

2015-02-03 Thread Eric Shelton
This patch adds a Makefile which downloads, patches, and compiles upstream QEMU for a stubdomain based on a linux kernel. Signed-off-by: Eric Shelton --- stubdom-linux/.gitignore| 3 ++ stubdom-linux/Makefile | 55 + stubdom-linux/qem

[Xen-devel] [RFC 2/7] linux-stubdomain: Compile Linux

2015-02-03 Thread Eric Shelton
This patch adds rules to the Makefile to retrieve Linux and build a minimal kernel for the stubdomain. Using Linux kernel 3.17.8. In order to work as a stubdomain, two patches are applied to the Linux kernel source. Signed-off-by: Eric Shelton --- stubdom-linux/.gitignore

[Xen-devel] [PATCH] Avoid needless flush cache when guest change MTRR

2015-02-03 Thread Liang Li
Flushing cache is needed only when guest has IOMMU device, using need_iommu(d) can minimize the impact to guest with device assigned, since a guest may be hot plugged with a device thus there may be dirty cache lines before need_iommu(d) becoming true, force the flush_all when the first device is a

Re: [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Chen, Tiejun
On 2015/2/3 19:07, Ian Campbell wrote: On Tue, 2015-02-03 at 09:04 +0800, Chen, Tiejun wrote: On 2015/2/2 20:54, Ian Jackson wrote: Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough"): On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote:

Re: [Xen-devel] Xen's Linux kernel config options V2

2015-02-03 Thread Luis R. Rodriguez
On Mon, Jan 19, 2015 at 5:59 AM, Jan Beulich wrote: On 19.01.15 at 14:28, wrote: >> I think it is still the case that selecting an option which is user >> visible is frowned upon? > > I don't think so; iirc there are cases where things deliberately get > set up that way (for example library

Re: [Xen-devel] Xen's Linux kernel config options V2

2015-02-03 Thread Luis R. Rodriguez
I'm going to work on this now so my replies below. Note: If we want feature to require XEN_PV || XEN_PVH || XEN_PVHVM, since XEN_BACKEND depends on them I think we could just use XEN_BACKEND as a shorthand. Furthermore if we then wanted something to be available for both backend and frontend we co

Re: [Xen-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-03 Thread Chen, Tiejun
On 2015/2/3 18:19, Wei Liu wrote: On Tue, Feb 03, 2015 at 09:01:53AM +0800, Chen, Tiejun wrote: On 2015/2/2 20:19, Wei Liu wrote: On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd

Re: [Xen-devel] [PATCH v2 2/3] hvm_complete_assist_req: We should not be able to get here on IOREQ_TYPE_PCI_CONFIG

2015-02-03 Thread Don Slutz
On 02/03/15 06:05, Jan Beulich wrote: On 02.02.15 at 16:22, wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -2573,6 +2573,7 @@ bool_t hvm_send_assist_req_to_ioreq_server(struct >> hvm_ioreq_server *s, >> >> static bool_t hvm_complete_assist_req(ioreq_t *p) >

Re: [Xen-devel] Request for help, implementing a new network scheduler

2015-02-03 Thread ronald pina
Thanks Ian for your helpful answer, you are right that is on Linux side but to clear my idea , the goal is to prioritize traffic that comes from different guest, for example if guest_1 is used for a voip server than it would be reasonable to schedule first the vif guest_1 before other guests. The

Re: [Xen-devel] Request for help, implementing a new network scheduler

2015-02-03 Thread ronald pina
Thanks Zoli for your clear and very helpfull answer, my idea is to prioritize traffic that comes from different guest, for example if guest_1 is used for a voip server than it would be reasonable to schedule first the vif guest_1 before other guests. The diagram atached below explains better my ide

[Xen-devel] [PATCH v3 23/27] Ovmf/Xen: implement dummy RealTimeClockLib for Xen

2015-02-03 Thread Ard Biesheuvel
This implements a dummy RealTimeClockLib for Xen, as there is no guest interface to access the time kept by Xen that can be shared between UEFI and the OS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- .../XenRealTimeClockLib/XenRealTimeClockLib.c

[Xen-devel] [PATCH v3 24/27] Ovfm/Xen: add a Vendor Hardware device path GUID for the XenBus root

2015-02-03 Thread Ard Biesheuvel
On non-PCI Xen guests (such as ARM), the XenBus root is not a PCI device but an abstract 'platform' device. Add a dedicated Vendor Hardware device path GUID to identify this node. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel ---

[Xen-devel] [PATCH v3 20/27] Ovmf/Xen: implement XenHypercallLib for ARM

2015-02-03 Thread Ard Biesheuvel
This patch adds an implementation of XenHypercallLib for both AArch64 and AArch32 execution modes on ARM systems. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Stefano Stabellini Signed-off-by: Ard Biesheuvel --- .../Include/IndustryStandard/Xen/arch-arm/xen.h| 436 ++

[Xen-devel] [PATCH v3 27/27] ArmVirtualizationPkg: add platform description for Xen guests

2015-02-03 Thread Ard Biesheuvel
This adds the .dsc and .fdf descriptions to build a UEFI image that is bootable by a Xen guest on 64-bit ARM (AArch64) Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- .../ArmVirtualizationPkg/ArmVirtualizationXen.dsc | 218 ++

[Xen-devel] [PATCH v3 21/27] Ovmf/Xen: add ARM and AArch64 support to XenBusDxe

2015-02-03 Thread Ard Biesheuvel
This patch adds support to XenBusDxe for executing on ARM and AArch64 machines (the former only when built with GCC). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/XenBusDxe/AtomicsGcc.c | 44 + OvmfPkg/

[Xen-devel] [PATCH v3 25/27] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-03 Thread Ard Biesheuvel
This adds a XenIoMmioLib declaration and implementation that can be invoked to install the XENIO_PROTOCOL and a corresponding grant table address on a EFI handle. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Include/Library/XenIoMmioLib.h

[Xen-devel] [PATCH v3 12/27] ArmVirtualizationPkg: Xen/PV relocatable platformlib instance

2015-02-03 Thread Ard Biesheuvel
Add a ArmPlatformLib instance that can deal with the self relocation and truly dynamic discovery of system RAM base and size. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel --- .../AARCH64/MemnodeParser.S| 232

[Xen-devel] [PATCH v3 16/27] Ovmf/Xen: move XenBusDxe hypercall code to separate library

2015-02-03 Thread Ard Biesheuvel
This moves all of the Xen hypercall code that was private to XenBusDxe to a new library class XenHypercallLib. This will allow us to reimplement it for ARM, and to export the Xen hypercall functionality to other parts of the code, such as a Xen console SerialPortLib driver. Contributed-under: Tian

[Xen-devel] [PATCH v3 17/27] Ovmf/Xen: introduce XENIO_PROTOCOL

2015-02-03 Thread Ard Biesheuvel
This introduces the abstract XENIO_PROTOCOL that will be used to communicate the Xen grant table address to drivers supporting this protocol. Primary purpose is allowing us to change the XenBusDxe implementation so that it can support non-PCI Xen implementations such as Xen on ARM. Contributed-und

[Xen-devel] [PATCH v3 26/27] ArmVirtualizationPkg/VirtFdtDxe: wire up XenBusDxe to "xen, xen" DT node

2015-02-03 Thread Ard Biesheuvel
This patchs adds support to VirtFdtDxe for the Xen DT node which contains the base address of the Grant Table. This data is communicated to XenBusDxe using a XENIO_PROTOCOL instance. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel -

[Xen-devel] [PATCH v3 18/27] Ovmf/Xen: add separate driver for Xen PCI device

2015-02-03 Thread Ard Biesheuvel
Prepare for making XenBusDxe suitable for use with non-PCI devices (such as the DT node exposed by Xen on ARM) by introducing a separate DXE driver that binds to the Xen virtual PCI device and exposes the abstract XENIO_PROTOCOL for XenBusDxe to bind against. Contributed-under: TianoCore Contribut

[Xen-devel] [PATCH v3 22/27] Ovmf/Xen: add Xen PV console SerialPortLib driver

2015-02-03 Thread Ard Biesheuvel
This implements a SerialPortLib instance that wires up to the PV console ring used by domU guests. Also imports the required upstream Xen io/console.h header. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Stefano Stabellini Signed-off-by: Ard Biesheuvel --- OvmfPkg/Includ

[Xen-devel] [PATCH v3 13/27] Ovmf/Xen: move Xen interface version to

2015-02-03 Thread Ard Biesheuvel
Tiancore has its private copy of the Xen headers, and all drivers that depend on it should use the same Xen interface version, so let's move the #define to xen.h itself. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Stefano Stabellini Acked-by: Laszlo Ersek Signed-off-by:

[Xen-devel] [PATCH v3 15/27] Ovmf/Xen: refactor XenBusDxe hypercall implementation

2015-02-03 Thread Ard Biesheuvel
This refactors the Xen hypercall implementation that is part of the XenBusDxe driver, in preparation of splitting it off entirely into a XenHypercallLib library. This involves: - removing the dependency on XENBUS_DEVICE* pointers in the XenHypercall() prototypes - moving the discovered hyperpage

[Xen-devel] [PATCH v3 14/27] Ovmf/Xen: fix pointer to int cast in XenBusDxe

2015-02-03 Thread Ard Biesheuvel
On ARM, xen_pfn_t is 64 bits but the size of a pointer is only 32 bits, so casting between them needs to go via (UINTN). Also move the xen_pfn_t cast outside the shift so that we can avoid shifting 64-bit quantities on 32-bit architectures, which may require runtime library support. Contributed-un

[Xen-devel] [PATCH v3 19/27] Ovmf/Xen: move XenBusDxe to abstract XENIO_PROTOCOL

2015-02-03 Thread Ard Biesheuvel
While Xen on Intel uses a virtual PCI device to communicate the base address of the grant table, the ARM implementation uses a DT node, which is fundamentally incompatible with the way XenBusDxe is implemented, i.e., as a UEFI Driver Model implementation for a PCI device. Contributed-under: TianoC

[Xen-devel] [PATCH v3 09/27] ArmVirtualizationPkg: add a relocatable version of PrePi

2015-02-03 Thread Ard Biesheuvel
This patch introduces a relocatable PrePi, which can execute from arbitrary offsets in RAM. This is intendend to be run from a boot loader which passes a description of the actual platform in a device tree, for instance. This module is based on the PrePi implementations residing under ArmPlatformP

[Xen-devel] [PATCH v3 10/27] ArmVirtualizationPkg: implement custom MemoryInitPeiLib

2015-02-03 Thread Ard Biesheuvel
This implements a MemoryInitPeiLib instance that differs from the stock ArmPlatformPkg version only in the fact that it does not remove the memory used by the flash device (FD). The reason is that, when using PrePi, the DXE core is started immediately and never returns so there is no reason to pres

[Xen-devel] [PATCH v3 11/27] ArmVirtualizationPkg: allow patchable PCD for FV and DT base addresses

2015-02-03 Thread Ard Biesheuvel
Allow the use of patchable PCDs for gArmTokenSpaceGuid.PcdFvBaseAddress and gArmVirtualizationTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress by moving them from the [FixedPcd] to the [Pcd] section in the INF file of PlatformPeiLib. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-b

[Xen-devel] [PATCH v3 02/27] ArmPkg: allow patchable PCDs for memory, FD and FV addresses

2015-02-03 Thread Ard Biesheuvel
In order to allow a runtime self relocating PrePi instance, change the allowable PCD types for the following PCDs: gArmTokenSpaceGuid.PcdSystemMemoryBase gArmTokenSpaceGuid.PcdSystemMemorySize gArmTokenSpaceGuid.PcdFdBaseAddress gArmTokenSpaceGuid.PcdFvBaseAddress to include PcdsPatchable

[Xen-devel] [PATCH v3 00/27] Xen/ARM guest support

2015-02-03 Thread Ard Biesheuvel
This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus supp

[Xen-devel] [PATCH v3 03/27] ArmPlatformPkg: allow patchable PCD for FD base address

2015-02-03 Thread Ard Biesheuvel
This moves the reference to gArmTokenSpaceGuid.PcdFdBaseAddress from the [FixedPcd] to the [Pcd] section in the INF file of PrePiArmPlatformGlobalVariableLib so that its users may choose to use a patchable PCD instead. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Olivier Ma

[Xen-devel] [PATCH v3 05/27] ArmVirtualizationPkg: allow patchable PCD for device tree base address

2015-02-03 Thread Ard Biesheuvel
To allow a runtime self relocating PrePi instance to discover the base address of the device tree at runtime, allow the use of a patchable PCD for gArmVirtualizationTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress. We will not be using the build time patch tool in this case, but using a patchable PCD

[Xen-devel] [PATCH v3 08/27] ArmVirtualizationPkg: add padding to FDT allocation

2015-02-03 Thread Ard Biesheuvel
Our primary user QEMU/mach-virt presents us with a FDT blob padded to 64 KB with plenty of room to set additional properties. However, in the general case, we should only add properties after making sure there is enough room available. Contributed-under: TianoCore Contribution Agreement 1.0 Review

[Xen-devel] [PATCH v3 04/27] ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe

2015-02-03 Thread Ard Biesheuvel
This adds support for detecting the presence of a GICv3 interrupt controller from the device tree, and recording its distributor and redistributor base addresses in their respective PCDs. Contributed-under: TianoCore Contribution Agreement 1.0 Acked-by: Laszlo Ersek Signed-off-by: Ard Biesheuvel

[Xen-devel] [PATCH v3 06/27] ArmVirtualizationPkg: move early UART discovery to PlatformPeim

2015-02-03 Thread Ard Biesheuvel
This is partially motivated by the desire to use PrePi in a virt environment, and in that configuration, ArmPlatformInitializeSystemMemory() is never called. But actually, this is a more suitable place anyway. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Laszlo Ersek Revie

[Xen-devel] [PATCH v3 01/27] ArmPkg: allow HYP timer interrupt to be omitted

2015-02-03 Thread Ard Biesheuvel
The DT binding for the ARM generic timer describes the secure, non-secure, virtual and hypervisor timer interrupts, respectively. However, under virtualization, only the virtual timer is usable, and the device tree may omit the hypervisor timer interrupt. (Other timer interrupts cannot be omitted s

[Xen-devel] [PATCH v3 07/27] ArmVirtualizationPkg: use a HOB to store device tree blob

2015-02-03 Thread Ard Biesheuvel
Instead of using a dynamic PCD, store the device tree address in a HOB so that we can also run under a configuration that does not support dynamic PCDs. This also adds MemoryAllocationLib to the [LibraryClasses] section of ArmVirtualizationPlatformLib/ArmVirtualizationPlatformLib.inf, as this depe

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Ian Campbell wrote: > Olof, you just removed the nul terminator used there AFAICT. At best > this means that the vgabios_copyright is printed twice. My bad. Will resend. Thanks for the review. Olaf ___ Xen-devel mailing list Xen-devel@

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Andrew Cooper wrote: > A release date is part of the SMBIOS spec, and the change below results > in a malformed smbios table (stale p->release_date_str = 3; pointer) Good point. Thanks for review. Do you have a pointer to that spec? > A better approach would be to derive the date

[Xen-devel] [xen-4.5-testing test] 34088: tolerable FAIL - PUSHED

2015-02-03 Thread xen . org
flight 34088 xen-4.5-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34088/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-pvh-intel 9 guest-start fail never pass test-armhf-armhf-xl-sedf 10 mig

Re: [Xen-devel] [PATCH v5 1/2] xen: add xen_is_preemptible_hypercall()

2015-02-03 Thread Luis R. Rodriguez
On Tue, Feb 03, 2015 at 11:05:15AM +, David Vrabel wrote: > On 27/01/15 01:51, Luis R. Rodriguez wrote: > > > > +#ifndef CONFIG_PREEMPT > > +extern struct { char _entry[32]; } preemptible_hypercall_page[]; > > + > > +static inline bool xen_is_preemptible_hypercall(struct pt_regs *regs) > > +{

Re: [Xen-devel] [PATCH 03/18] x86/boot: use %ecx instead of %eax

2015-02-03 Thread Daniel Kiper
On Tue, Feb 03, 2015 at 10:02:09AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > /* Save the Multiboot info struct (after relocation) for later > > use. */ > > mov $sym_phys(cpu0_stack)+1024,%esp > > -push%ebx > > -callreloc > > +

Re: [Xen-devel] [PATCH 00/18] x86: multiboot2 protocol support

2015-02-03 Thread Daniel Kiper
On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wrote: > >>> On 30.01.15 at 18:54, wrote: > > - xen.efi build will not so strongly depend > > on a given GCC and binutils version. > > While I can see the possibility of making the binutils version > dependency go away (by manually creati

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:23, wrote: > On 03/02/15 16:15, Jan Beulich wrote: > On 03.02.15 at 17:02, wrote: >>> On 03/02/15 15:54, Olaf Hering wrote: Including a timestamp into the binary makes it impossible to get reproducible binaries. Remove the timestamp because it carries no v

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:28, wrote: > On Tue, 2015-02-03 at 16:17 +, Jan Beulich wrote: >> >>> On 03.02.15 at 17:06, wrote: >> > On 03/02/15 15:54, Olaf Hering wrote: >> >> Including a timestamp into the binary makes it impossible to get >> >> reproducible binaries. Remove the timestamp because

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:17 +, Jan Beulich wrote: > >>> On 03.02.15 at 17:06, wrote: > > On 03/02/15 15:54, Olaf Hering wrote: > >> Including a timestamp into the binary makes it impossible to get > >> reproducible binaries. Remove the timestamp because it carries no > >> valuable info. > >> >

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:23 +, Andrew Cooper wrote: > On 03/02/15 16:18, Ian Campbell wrote: > > On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: > >> On 03/02/15 15:54, Olaf Hering wrote: > >>> Including a timestamp into the binary makes it impossible to get > >>> reproducible binaries.

Re: [Xen-devel] [RFC PATCH V3 07/12] xen: Remove mem_event

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -750,15 +750,15 @@ struct xen_domctl_gdbsx_domstatus { > }; > > /* > - * Memory event operations > + * VM event operations > */ > > -/* XEN_DOMCTL_mem_event_op */ > +/* XEN_DOMCTL_

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Andrew Cooper
On 03/02/15 16:15, Jan Beulich wrote: On 03.02.15 at 17:02, wrote: >> On 03/02/15 15:54, Olaf Hering wrote: >>> Including a timestamp into the binary makes it impossible to get >>> reproducible binaries. Remove the timestamp because it carries no >>> valuable info. >> I agree with the sentime

Re: [Xen-devel] [RFC PATCH V3 06/12] xen: migrate mem_event to vm_event

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > This is the second patch in the mem_event -> vm_event migration. > This patch migrates all previous use-cases of mem_event to use the > new vm_event system. > > Signed-off-by: Tamas K Lengyel Provided this is what it looks to be (a mechanical renaming of mem_e

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Andrew Cooper
On 03/02/15 16:18, Ian Campbell wrote: > On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: >> On 03/02/15 15:54, Olaf Hering wrote: >>> Including a timestamp into the binary makes it impossible to get >>> reproducible binaries. Remove the timestamp because it carries no >>> valuable info. >>>

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: > On 03/02/15 15:54, Olaf Hering wrote: > > Including a timestamp into the binary makes it impossible to get > > reproducible binaries. Remove the timestamp because it carries no > > valuable info. > > > > Signed-off-by: Olaf Hering > > Cc: I

Re: [Xen-devel] [PATCH v17 14/23] x86/VPMU: Initialize VPMUs with __initcall

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:02, wrote: > On 01/30/2015 09:54 AM, Jan Beulich wrote: > On 05.01.15 at 22:44, wrote: >>> +static int __init vpmu_init(void) >>> +{ >>> +int vendor = current_cpu_data.x86_vendor; >>> + >>> +if ( vpmu_mode == XENPMU_MODE_OFF ) >>> +{ >>> +printk(XENLO

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:06, wrote: > On 03/02/15 15:54, Olaf Hering wrote: >> Including a timestamp into the binary makes it impossible to get >> reproducible binaries. Remove the timestamp because it carries no >> valuable info. >> >> Signed-off-by: Olaf Hering >> Cc: Ian Jackson >> Cc: Stefano S

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:02, wrote: > On 03/02/15 15:54, Olaf Hering wrote: >> Including a timestamp into the binary makes it impossible to get >> reproducible binaries. Remove the timestamp because it carries no >> valuable info. > > I agree with the sentiment, but this is not how to do it. > > A

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Andrew Cooper
On 03/02/15 15:54, Olaf Hering wrote: > Including a timestamp into the binary makes it impossible to get > reproducible binaries. Remove the timestamp because it carries no > valuable info. > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Li

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:54 +0100, Olaf Hering wrote: > Including a timestamp into the binary makes it impossible to get > reproducible binaries. Remove the timestamp because it carries no > valuable info. AFAICT this is changing the contents of a firmware table which is exposed to the guest, so t

Re: [Xen-devel] [RFC PATCHv1] Prototype ticket locks

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 16:01, wrote: > On 03/02/15 13:55, Jan Beulich wrote: > On 03.02.15 at 12:50, wrote: >>> Note that spin_lock_irq() and spin_lock_irqsave() now spin with irqs >>> disabled (previously, they would spin with irqs enabled if possible). >>> This is required to prevent deadlocks

Re: [Xen-devel] [PATCH v17 14/23] x86/VPMU: Initialize VPMUs with __initcall

2015-02-03 Thread Boris Ostrovsky
On 01/30/2015 09:54 AM, Jan Beulich wrote: On 05.01.15 at 22:44, wrote: --- a/xen/arch/x86/hvm/vpmu.c +++ b/xen/arch/x86/hvm/vpmu.c @@ -497,3 +497,39 @@ long do_xenpmu_op(int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg) return ret; } + +static int __init vpmu_init(void) +{ +i

Re: [Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Andrew Cooper
On 03/02/15 15:54, Olaf Hering wrote: > Including a timestamp into the binary makes it impossible to get > reproducible binaries. Remove the timestamp because it carries no > valuable info. > > Signed-off-by: Olaf Hering > Cc: Keir Fraser > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Ian Jackson

[Xen-devel] [PATCH 1/2] hvmloader: remove timestamp from smbios

2015-02-03 Thread Olaf Hering
Including a timestamp into the binary makes it impossible to get reproducible binaries. Remove the timestamp because it carries no valuable info. Signed-off-by: Olaf Hering Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu

[Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Olaf Hering
Including a timestamp into the binary makes it impossible to get reproducible binaries. Remove the timestamp because it carries no valuable info. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/firmware/vgabios/Makefile | 11 -

Re: [Xen-devel] [RFC PATCH V3 05/12] xen: Introduce vm_event

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > --- a/docs/misc/xsm-flask.txt > +++ b/docs/misc/xsm-flask.txt > @@ -87,6 +87,7 @@ __HYPERVISOR_domctl (xen/include/public/domctl.h) > * XEN_DOMCTL_set_machine_address_size > * XEN_DOMCTL_debug_op > * XEN_DOMCTL_gethvmcontext_partial > + * XEN_DOMCTL_vm_even

[Xen-devel] [PATCH 0/2] remove timestamp from hvmloader for reproducible build

2015-02-03 Thread Olaf Hering
Somehow these timestamps got into the tree a long time ago. Now they prevent reproducible hvmloader binaries. Olaf Olaf Hering (2): hvmloader: remove timestamp from smbios hvmloader: remove timestamp from vgabios tools/firmware/hvmloader/Makefile | 1 - tools/firmware/hvmloader/smbios.c |

Re: [Xen-devel] [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

2015-02-03 Thread Konrad Rzeszutek Wilk
On Tue, Feb 03, 2015 at 03:11:11PM +, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("[PATCH 2/4] libxl: vcpuset: Check max_vcpus > argument against the maximum number of vCPUs the guest has set."): > > The maximum number of VCPUs the guest can have is determined during > > domain creation

Re: [Xen-devel] [RFC PATCH V3 03/12] xen/mem_paging: Convert mem_event_op to mem_paging_op

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > --- a/xen/arch/x86/mm/mem_paging.c > +++ b/xen/arch/x86/mm/mem_paging.c > @@ -25,31 +25,29 @@ > #include > > > -int mem_paging_memop(struct domain *d, xen_mem_event_op_t *mec) > +int mem_paging_memop(struct domain *d, xen_mem_paging_op_t *mpc) > { > i

Re: [Xen-devel] [RFC PATCH V3 02/12] xen/mem_event: Rename the mem_event ring from 'access' to 'monitor'

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS2 > +#define XEN_DOMCTL_MEM_EVENT_OP_MONITOR2 While this one looks okay, ... > -#define XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE 0 > -#define XEN_DOMCTL_MEM_EVEN

Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

2015-02-03 Thread Jan Beulich
>>> On 29.01.15 at 22:46, wrote: > +static int hvm_memory_event_traps(long parameters, mem_event_request_t *req) It looks like parameters isn't really a signed quantity... > void hvm_memory_event_cr0(unsigned long value, unsigned long old) > { > -hvm_memory_event_traps(current->domain->ar

Re: [Xen-devel] [PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

2015-02-03 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("[PATCH 2/4] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set."): > The maximum number of VCPUs the guest can have is determined during > domain creation and is set by 'maxvcpus' parameter (in the guest > config). Trying t

Re: [Xen-devel] [RFC PATCHv1] Prototype ticket locks

2015-02-03 Thread David Vrabel
On 03/02/15 13:55, Jan Beulich wrote: On 03.02.15 at 12:50, wrote: >> Use ticket locks for spin locks instead of the current byte locks. >> Ticket locks are fair. This is an important property for hypervisor >> locks. > > Isn't Linux moving to queue locks? Shouldn't we skip the intermediate

Re: [Xen-devel] [PATCH v2 3/3] hvm_has_dm: Do a full check for backing DM

2015-02-03 Thread Jan Beulich
>>> On 02.02.15 at 16:22, wrote: > Jan Beulich: > The change on what to do when hvm_send_assist_req() fails is bad. > That is correct. Made hvm_has_dm() do full checking so > that the extra VMEXIT and VMENTRY can be skipped. > hvm_complete_assist_req() be a separate function

Re: [Xen-devel] [PATCH OSSTEST v5 0/9] XSM test case for OSSTest

2015-02-03 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH OSSTEST v5 0/9] XSM test case for OSSTest"): > On Tue, Feb 03, 2015 at 01:40:05PM +, Ian Jackson wrote: > > Can you redo this with "| sort" after > > ./standalone-generate-dump-flight-runvars ? That sorts the output by > > job which in this case is probably easier t

[Xen-devel] [xen-4.4-testing test] 34091: tolerable FAIL - PUSHED

2015-02-03 Thread xen . org
flight 34091 xen-4.4-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/34091/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-pair17 guest-migrate/src_host/dst_host fail like 33774 Tests which did not succee

Re: [Xen-devel] [PATCH OSSTEST v5 1/9] overlay: update overlay/etc/grub.d/20_linux_xen

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 01:40:55PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH OSSTEST v5 1/9] overlay: update > overlay/etc/grub.d/20_linux_xen"): > > This file was originally created to work around Debian bug #633127 > > ("/etc/grub/20_linux does not recognise some old Xen kernels"). > >

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 01:55:01PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM > test jobs"): > > Duplicate Debian PV and HVM test jobs for XSM testing. > ... > > do_hvm_debian_tests() { > > + test_xsm=$(xenbranch_xsm_variants) > > Thi

Re: [Xen-devel] Formal Vote for changes to Xen Project Security Policy encoded in [PATCH v2 SECURITY-POLICY */9] (vote ends next Wed, Feb 11th)

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 12:09 +, Lars Kurth wrote: > the patch series for modifications to > http://www.xenproject.org/security-policy.html has gone it's second > revision and is ready for voting. In accordance with our governance, > committers are eligible to vote. Others can of course voice the

Re: [Xen-devel] [PATCH OSSTEST v5 0/9] XSM test case for OSSTest

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 14:10 +, Wei Liu wrote: > On Tue, Feb 03, 2015 at 01:41:45PM +, Ian Campbell wrote: > > On Tue, 2015-02-03 at 13:40 +, Ian Jackson wrote: > > > > Changes in v5 can be found in individual patch. > > > > > > > > See below for output of > > > > ./standalone-generat

Re: [Xen-devel] [PATCH OSSTEST v5 0/9] XSM test case for OSSTest

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 01:41:45PM +, Ian Campbell wrote: > On Tue, 2015-02-03 at 13:40 +, Ian Jackson wrote: > > > Changes in v5 can be found in individual patch. > > > > > > See below for output of > > > ./standalone-generate-dump-flight-runvars > origin # master > > > ./standalone-g

Re: [Xen-devel] Stubdom breakage in 4.5

2015-02-03 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 03 February 2015 14:00 > To: Ian Campbell > Cc: Wei Liu; xen-devel@lists.xen.org; Ian Jackson; Jan Beulich; Andrew > Cooper; Stefano Stabellini > Subject: RE: Stubdom breakage in 4.5 > > > -Original Message- > > From: Ian Campbell >

Re: [Xen-devel] Formal Vote for changes to Xen Project Security Policy encoded in [PATCH v2 SECURITY-POLICY */9] (vote ends next Wed, Feb 11th)

2015-02-03 Thread Tim Deegan
At 12:09 + on 03 Feb (1422961751), Lars Kurth wrote: > the patch series for modifications to > http://www.xenproject.org/security-policy.html has gone it's second > revision and is ready for voting. In accordance with our governance, > committers are eligible to vote. Others can of course voice

[Xen-devel] [RFC] native python Xenstore module

2015-02-03 Thread Simon Rowe
The current Python interface to Xenstore is just a thin binding to the C libxenstore library. This means that it is architecture-specific and makes it awkward to use in platform-independent code like the XenServer guest agent. The Xenstore protocol is simple and quite straightforward to implement

Re: [Xen-devel] Stubdom breakage in 4.5

2015-02-03 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 03 February 2015 13:48 > To: Paul Durrant > Cc: Wei Liu; xen-devel@lists.xen.org; Ian Jackson; Jan Beulich; Andrew > Cooper; Stefano Stabellini > Subject: Re: Stubdom breakage in 4.5 > > On Tue, 2015-02-03 at 13:42 +, Paul Durrant wrote

  1   2   3   >