Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-17 Thread Julien Grall
Hi Ian, On 16/04/2015 16:40, Ian Campbell wrote: On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: Concerning XSM, even if ARM is using one hypercall rather than 2, the resulting check is nearly the same. XSM PHYSDEVOP_map_pirq: 1) Check if the current domain can add resource to

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

2015-04-17 Thread Jan Beulich
On 17.04.15 at 04:40, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:54 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: This patch firstly enables EPT A/D bits if PML is used, as PML depends on EPT A/D bits to work. A bit is set for all present leaf p2m

Re: [Xen-devel] [PATCH 11/19] xen: arm: Annotate handlers for PCTR_EL2.Tx

2015-04-17 Thread Julien Grall
Hi Ian, On 16/04/2015 17:53, Ian Campbell wrote: On Mon, 2015-04-06 at 13:18 +0200, Julien Grall wrote: Hi Ian, Subject: s/PCTR/CPTR/ On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell ian.campb...@citrix.com --- xen/arch/arm/traps.c | 14 ++ 1 file

Re: [Xen-devel] [PATCH] VTd/dmar: Tweak how the DMAR table is clobbered

2015-04-17 Thread Jan Beulich
On 16.04.15 at 18:44, kevin.t...@intel.com wrote: From: Andrew Cooper [mailto:andrew.coop...@citrix.com] Sent: Tuesday, April 14, 2015 5:09 PM On 14/04/15 08:50, Jan Beulich wrote: Unless Kevin or Yang object, I'd therefore suggest reverting the change. Once we determined why VT-d needs

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Kai Huang
On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: +void vmx_vcpu_flush_pml_buffer(struct vcpu *v) +{ +uint64_t *pml_buf; +unsigned long

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

2015-04-17 Thread Kai Huang
On 04/17/2015 02:28 PM, Jan Beulich wrote: On 17.04.15 at 04:46, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:51 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global)

Re: [Xen-devel] [PATCH v2 2/4] x86/MSI-X: access MSI-X table only after having enabled MSI-X

2015-04-17 Thread Jan Beulich
On 16.04.15 at 20:21, konrad.w...@oracle.com wrote: What kernel are you using? Or better yet - what branch/tree could one find it at? As always, I'm personally using my own kernel, not in any branch/tree. But for all purposes here, our Kernel-of-the-Day should be good enough, i.e. the stuff

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Kai Huang
On 04/17/2015 02:58 PM, Jan Beulich wrote: On 17.04.15 at 08:51, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com

Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

2015-04-17 Thread Julien Grall
Hi Ian, On 16/04/2015 17:08, Ian Campbell wrote: On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: Hi Ian, On 31/03/2015 11:07, Ian Campbell wrote: Signed-off-by: Ian Campbell ian.campb...@citrix.com xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 Having injected an undefined

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

2015-04-17 Thread Jan Beulich
On 17.04.15 at 04:46, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:51 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global) d-arch.paging.mode |= PG_log_dirty;

Re: [Xen-devel] [PATCH 07/19] xen: arm: Annotate trap handler for HCR_EL2.{TWI, TWE, TSC}

2015-04-17 Thread Julien Grall
Hi Ian, On 16/04/2015 17:34, Ian Campbell wrote: On Fri, 2015-04-03 at 15:05 +0200, Julien Grall wrote: Hi Ian, On 31/03/2015 12:07, Ian Campbell wrote: Reference the bit which enables the trap and the section/page which describes what that bit enables. These ones are pretty trivial,

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

2015-04-17 Thread Kai Huang
On 04/17/2015 02:28 PM, Jan Beulich wrote: On 17.04.15 at 04:40, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:54 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: This patch firstly enables EPT A/D bits if PML is used, as PML depends on EPT A/D bits to

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Jan Beulich
On 17.04.15 at 08:51, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: +void vmx_vcpu_flush_pml_buffer(struct

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Jan Beulich
On 17.04.15 at 05:10, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: +void vmx_vcpu_flush_pml_buffer(struct vcpu *v) +{ +uint64_t *pml_buf; +unsigned long pml_idx; + +

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Jan Beulich
On 17.04.15 at 09:23, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:58 PM, Jan Beulich wrote: On 17.04.15 at 08:51, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:42 PM, Jan Beulich

Re: [Xen-devel] [v1] x86/cpuidle: get accurate C0 value with xenpm tool

2015-04-17 Thread Han, Huaitong
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, April 16, 2015 4:49 PM To: Han, Huaitong Cc: xen-devel@lists.xen.org Subject: Re: [v1] x86/cpuidle: get accurate C0 value with xenpm tool On 16.04.15 at 08:03, huaitong@intel.com wrote: When checking

Re: [Xen-devel] Archiving Xen on ARM and PVOPS subprojects

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 14:25 -0400, Konrad Rzeszutek Wilk wrote: On Thu, Apr 16, 2015 at 12:37:15PM +0100, Ian Campbell wrote: On Wed, 2015-04-15 at 17:23 +0100, Lars Kurth wrote: According to http://xenproject.org/governance.html we would need to perform an archivation review. In this

Re: [Xen-devel] [PATCH 3/8] raisin: Use fakeroot for mkdeb so we can build the package as non-root

2015-04-17 Thread Stefano Stabellini
On Fri, 17 Apr 2015, Ian Campbell wrote: On Thu, 2015-04-16 at 17:19 +0100, George Dunlap wrote: Signed-off-by: George Dunlap george.dun...@eu.citrix.com AIUI raisin does build dependency handling/tracking. If so then fakeroot ought to be added to it I think? Good point! Please add

[Xen-devel] [PATCH OSSTEST] cri-args-hostlists: No longer export $OSSTEST_CONFIG

2015-04-17 Thread Ian Campbell
All sites now have a suitable $HOME/.xen-osstest/cri-args-hostslists.settings in place which does this. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- To be applied once the following commit passes Cambridge push gate, is merged into the master instance and passes the push gate there.

Re: [Xen-devel] Is it ok to routing periperal irq to any Domain0's vCPU on Xen ARM 4.5.x?

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 11:36 +0900, 신정섭 wrote: I'm studying periperal irq routing to Domain0's vCPU What do you mean by peripheral irq routing? Do you mean supporting the guest writing to GICD_ITARGER to cause an interrupt to be injected to a specific vcpu? I thought that was supposed to

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

2015-04-17 Thread Jan Beulich
On 17.04.15 at 09:10, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:28 PM, Jan Beulich wrote: On 17.04.15 at 04:40, kai.hu...@linux.intel.com wrote: On 04/16/2015 11:54 PM, Jan Beulich wrote: On 15.04.15 at 09:03, kai.hu...@linux.intel.com wrote: This patch firstly enables EPT A/D bits

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Kai Huang
On 04/17/2015 03:37 PM, Jan Beulich wrote: On 17.04.15 at 09:23, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:58 PM, Jan Beulich wrote: On 17.04.15 at 08:51, kai.hu...@linux.intel.com wrote: On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, kai.hu...@linux.intel.com

Re: [Xen-devel] [PATCH 2/3] libxl: fd events: Break out fd_occurs

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 19:23 +0100, Ian Jackson wrote: No functional change, only code motion. Currently, contrary to this function's name, there are two sites where efd-func() is called so one of them doesn't go through here just yet. That will be dealt with in the next commit.

Re: [Xen-devel] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh domid save /tmp/blah' with guest corrupting memory (on purpose).

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 18:18 +0100, Ian Jackson wrote: Jim Fehlig writes (Re: [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh domid save /tmp/blah' with guest corrupting memory (on purpose).): On 04/14/2015 11:31 AM, Ian Jackson wrote: I have produced what I think are

Re: [Xen-devel] memaccess: skipping mem_access_send_req

2015-04-17 Thread Gareth Stockwell
On Wed, Apr 15, 2015 at 10:26:52, Ian Campbell wrote: We would like to use memaccess to perform (1) - but rather than pausing the VCPU in (2), instead simply directly inject the exception into the VCPU. That is, into the VCPUs whose permissions have been modified behind its back and not

Re: [Xen-devel] memaccess: skipping mem_access_send_req

2015-04-17 Thread Gareth Stockwell
On Fri, Apr 10, 2015 at 17:03:26, Andrew Cooper wrote: Are you perhaps looking for something similar to Intel #VE support? Yes, in that we want a way to notify a guest that it has made an access that violated a stage-2 / EPT permission. However, for our purposes a trap into the hypervisor

Re: [Xen-devel] [PATCH OSSTEST v2 0/5] Tweaks to allow running non-master production instances

2015-04-17 Thread Ian Campbell
On Wed, 2015-04-15 at 14:47 +0100, Ian Jackson wrote: Ian Campbell writes (Re: [PATCH OSSTEST v2 0/5] Tweaks to allow running non-master production instances): Since you have now acked everything may I push to the Cambridge branch (once the VM is working again)? Yes. (modulo if you

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 07:02 +0100, Julien Grall wrote: Hi Ian, On 16/04/2015 16:40, Ian Campbell wrote: On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: Concerning XSM, even if ARM is using one hypercall rather than 2, the resulting check is nearly the same. XSM

Re: [Xen-devel] [libvirt bisection] complete build-armhf-libvirt

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 21:46 +, osstest service user wrote: branch xen-unstable xen branch xen-unstable job build-armhf-libvirt test libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git Tree: qemuu

Re: [Xen-devel] [libvirt] [libvirt test] 50401: regressions - FAIL

2015-04-17 Thread Ian Campbell
On Wed, 2015-04-15 at 14:16 +0100, Daniel P. Berrange wrote: Yeah, there is nothing Xen specific about the problem - it is entirely down to the build toolchain compiler options. FYI our bisector has now tripped over another related problem,

[Xen-devel] [qemu-mainline test] 50428: regressions - FAIL

2015-04-17 Thread osstest service user
flight 50428 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/50428/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 9 windows-install fail REGR. vs. 50391 Regressions which

Re: [Xen-devel] [PATCH 4/9] raisin: add a component to build qemu_traditional

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 17:03 +0100, Stefano Stabellini wrote: On Wed, 15 Apr 2015, Andrew Cooper wrote: -./configure --prefix=$PREFIX --with-system-qemu=/usr/bin/qemu-system-i386 +./configure --prefix=$PREFIX --with-system-qemu=/usr/bin/qemu-system-i386 \ +

Re: [Xen-devel] [PATCH 3/3] libxl: fd events: Suppress spurious fd events

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 19:23 +0100, Ian Jackson wrote: Always recheck with poll() right before making the callback. All sorts of things may have happened since poll() originally signaled the fd. We would like the main functional libxl code not to have to worry about spurious wakeups. This

Re: [Xen-devel] [v1] x86/cpuidle: get accurate C0 value with xenpm tool

2015-04-17 Thread Jan Beulich
On 17.04.15 at 09:36, huaitong@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, April 16, 2015 4:49 PM On 16.04.15 at 08:03, huaitong@intel.com wrote: When checking the ACPI funciton of C-status, after 100 seconds sleep, the sampling value of C0

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

2015-04-17 Thread Jan Beulich
On 16.04.15 at 19:19, andrew.coop...@citrix.com wrote: On 16/04/15 17:44, Tim Deegan wrote: update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan

[Xen-devel] [PATCH v4 3/5] libxl: add support for vscsi

2015-04-17 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell

[Xen-devel] [PATCH v4 0/5] libbxl: add support for pvscsi, iteration 4

2015-04-17 Thread Olaf Hering
Port vscsi=[] and scsi-{attach,detach,list} commands from xend to libxl. TODO: - find better name for -feature_host (perhaps -sg_io as used in libvirt?) - maybe use events instead of polling for state changes in reconfigure (libxl__wait_for_backend vs. libxl__ev_devstate_wait) - add code to

[Xen-devel] [PATCH v4 5/5] Scripts to create and delete xen-scsiback nodes in Linux target framework

2015-04-17 Thread Olaf Hering
Just to make them public, not meant for merging: The scripts used during development to create a bunch of SCSI devices in dom0 using the Linux target framework. targetcli3 and rtslib3 is used. A patch is required for python-rtslib: http://article.gmane.org/gmane.linux.scsi.target.devel/8146

[Xen-devel] [PATCH v4 2/5] docs: add vscsi to xenstore-paths.markdown

2015-04-17 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10

Re: [Xen-devel] [PATCH 3/8] raisin: Use fakeroot for mkdeb so we can build the package as non-root

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 17:19 +0100, George Dunlap wrote: Signed-off-by: George Dunlap george.dun...@eu.citrix.com AIUI raisin does build dependency handling/tracking. If so then fakeroot ought to be added to it I think? --- CC: Stefano Stabellini stefano.stabell...@citrix.com Does CC below a

Re: [Xen-devel] [PATCH 1/3] libxl: fd events: Break out libxl__fd_poll_recheck

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 19:23 +0100, Ian Jackson wrote: Replaces two call sites where a rechecking poll() was open-coded. No functional change, other than to highly unusual error path diagnosis, and debug and error message output. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com CC: Jim

Re: [Xen-devel] [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory

2015-04-17 Thread Jan Beulich
On 16.04.15 at 18:37, t...@xen.org wrote: At 12:32 +0100 on 16 Apr (1429187564), Jan Beulich wrote: On 16.04.15 at 12:53, t...@xen.org wrote: I would be inclined to use a bigger hammer here. IMO refactoring like this makes it easier to reason about (compile tested only): This looks

[Xen-devel] [PATCH v4 4/5] vscsiif.h: add some notes about xenstore layout

2015-04-17 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser k...@xen.org Cc: Tim Deegan t...@xen.org --- xen/include/public/io/vscsiif.h | 68

[Xen-devel] [PATCH v4 1/5] vscsiif.h: fix WWN notation for p-dev property

2015-04-17 Thread Olaf Hering
The pvops kernel expects either naa.WWN:LUN or h:c:t:l in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan Beulich jbeul...@suse.com Cc: Keir Fraser

Re: [Xen-devel] [PATCH v4 2/5] docs: add vscsi to xenstore-paths.markdown

2015-04-17 Thread Olaf Hering
On Fri, Apr 17, Olaf Hering wrote: @@ -302,6 +307,10 @@ A virtual keyboard device backend. Described by A virtual network device backend. Described by [xen/include/public/io/netif.h][NETIF] + ~/backend/vscsi/$DOMID/$DEVID/* [] + +A PV SCSI backend. Described in

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Tim Deegan
At 11:32 +0800 on 17 Apr (1429270332), Kai Huang wrote: On 04/17/2015 08:10 AM, Tim Deegan wrote: At 22:57 + on 16 Apr (1429225024), Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] +if ( !p2m_change_type_one(v-domain, gfn, p2m_ram_logdirty, +

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

2015-04-17 Thread Kai Huang
On 04/17/2015 04:36 PM, Tim Deegan wrote: At 11:32 +0800 on 17 Apr (1429270332), Kai Huang wrote: On 04/17/2015 08:10 AM, Tim Deegan wrote: At 22:57 + on 16 Apr (1429225024), Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] +if (

Re: [Xen-devel] [RFC] Linux save_fl PVOP for Xen

2015-04-17 Thread David Vrabel
On 16/04/15 19:40, Andrew Cooper wrote: Having recently got some Broadwell hardware, our automatic test system discovered that 32bit PV guests would reliably blow up while attempting to boot. It turns out that the save_fl PVOP is at fault. The comment is false, as setup_smap() uses it to

Re: [Xen-devel] kernel BUG at drivers/xen/grant-table.c:923!

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 11:31 +0100, David Vrabel wrote: On 17/04/15 11:28, Ian Campbell wrote: (Was Re: [osstest test] 50423: regressions - FAIL) This cropped up in an osstest flight (the results only go to Ian and I). On Fri, 2015-04-17 at 11:10 +0100, Ian Campbell wrote: On Thu,

[Xen-devel] [xen-4.4-testing test] 50429: tolerable FAIL - PUSHED

2015-04-17 Thread osstest service user
flight 50429 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/50429/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-amd64 16 guest-localmigrate/x10 fail in 50392 pass in 50429

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

2015-04-17 Thread David Vrabel
On 17/04/15 13:32, Ian Campbell wrote: On Thu, 2015-04-16 at 16:28 +0100, Jan Beulich wrote: On 10.04.15 at 16:19, david.vra...@citrix.com wrote: +#define xadd(ptr, v) generic_xaddl((ptr), (v)) I think it is at least confusing to call the thing xadd (looking to be size generic) and then

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 13:32 +0100, Ian Campbell wrote: On Thu, 2015-04-16 at 16:28 +0100, Jan Beulich wrote: On 10.04.15 at 16:19, david.vra...@citrix.com wrote: +#define xadd(ptr, v) generic_xaddl((ptr), (v)) I think it is at least confusing to call the thing xadd (looking to be

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Jan Beulich
On 17.04.15 at 13:59, andrew.coop...@citrix.com wrote: On 17/04/15 12:17, Olaf Hering wrote: Since booting xen fails on my ProBook unless I specify maxcpus=1 I tried the EFI firmware today. To my surprise it boots and finds all cpus. But once some efi driver in dom0 is loaded xen crashes. The

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Andrew Cooper
On 17/04/15 13:39, Jan Beulich wrote: On 17.04.15 at 13:59, andrew.coop...@citrix.com wrote: On 17/04/15 12:17, Olaf Hering wrote: Since booting xen fails on my ProBook unless I specify maxcpus=1 I tried the EFI firmware today. To my surprise it boots and finds all cpus. But once some efi

[Xen-devel] [PATCH 2/2] raisin: introduce seabios component

2015-04-17 Thread Stefano Stabellini
Build SeaBIOS as a separate component. Pass --with-system-seabios to the xen configure script. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- components/seabios | 57 components/series |1 + components/xen |

[Xen-devel] [PATCH 0/2] raisin: build qemu-traditional and seabios

2015-04-17 Thread Stefano Stabellini
Hi all, This patch series builds qemu-traditional and seabios separately from the Xen tree. It also change the QEMU build to be more Xen specific, installing the QEMU binary under /usr/lib/xen/bin. Changes compared to the previous version of the qemu-traditional patch: - --enable-rombios

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 13:34 +0100, David Vrabel wrote: On 17/04/15 13:32, Ian Campbell wrote: On Thu, 2015-04-16 at 16:28 +0100, Jan Beulich wrote: On 10.04.15 at 16:19, david.vra...@citrix.com wrote: +#define xadd(ptr, v) generic_xaddl((ptr), (v)) I think it is at least confusing to

[Xen-devel] [PATCH v2 1/2] raisin: add a component to build qemu_traditional

2015-04-17 Thread Stefano Stabellini
Introduce a component to build qemu-traditional out of xen-unstable. Do not compile qemu-traditional from xen-unstable by passing the right command line option to configure. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- components/qemu_traditional | 49

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

2015-04-17 Thread Ian Campbell
On Thu, 2015-04-16 at 16:28 +0100, Jan Beulich wrote: On 10.04.15 at 16:19, david.vra...@citrix.com wrote: +#define xadd(ptr, v) generic_xaddl((ptr), (v)) I think it is at least confusing to call the thing xadd (looking to be size generic) and then expand to generic_xaddl (only supporting

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

2015-04-17 Thread David Vrabel
On 17/04/15 14:09, Ian Campbell wrote: On Fri, 2015-04-17 at 13:34 +0100, David Vrabel wrote: Can you use git://xenbits.xen.org/people/dvrabel/xen.git ticketlocks-v3 git://xenbits.xen.org/people/dvrabel/xen.git ticketlock-v3 I tried that and it built and booted just fine on both arm32

Re: [Xen-devel] [PATCH 6/8] raisin: Break build into components and allow the sub-steps to be called individually

2015-04-17 Thread Stefano Stabellini
On Thu, 16 Apr 2015, George Dunlap wrote: This makes it easier to debug just one aspect of the build. Signed-off-by: George Dunlap george.dun...@eu.citrix.com --- CC: Stefano Stabellini stefano.stabell...@citrix.com --- lib/commands.sh | 16 raise | 2 +- 2

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-17 Thread Stefano Stabellini
On Thu, 16 Apr 2015, George Dunlap wrote: Until we start hosting the blktap repo on xenbits, use the one from github. Also, we need to pass in the directories where to find the libblktapctl headers in the Xen build. Signed-off-by: George Dunlap george.dun...@eu.citrix.com --- Note: For

Re: [Xen-devel] [PATCH V2] xen/arm64: Use virtual address when setting up early_printk fixmap

2015-04-17 Thread Chen Baozi
On Wed, Apr 15, 2015 at 03:41:44PM +0100, Ian Campbell wrote: On Wed, 2015-04-08 at 12:33 +0100, Julien Grall wrote: Hi Chen, On 07/04/15 12:24, Chen Baozi wrote: We have already had the boot pagetable when reaching the point s/had/added/ ? I think switched too is what was meant

Re: [Xen-devel] [PATCH 13/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDRA

2015-04-17 Thread Ian Campbell
On Mon, 2015-04-06 at 15:24 +0200, Julien Grall wrote: Hi Ian, On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell ian.campb...@citrix.com --- xen/arch/arm/traps.c | 32 xen/include/asm-arm/cpregs.h |4

Re: [Xen-devel] [PATCH 15/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDA

2015-04-17 Thread Ian Campbell
On Mon, 2015-04-06 at 15:41 +0200, Julien Grall wrote: Hi Ian, On 31/03/2015 12:07, Ian Campbell wrote: Gather the affected handlers in a single place per trap type. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- xen/arch/arm/traps.c | 71

Re: [Xen-devel] Question about DMA on 1:1 mapping dom0 of arm64

2015-04-17 Thread Stefano Stabellini
On Fri, 17 Apr 2015, Ian Campbell wrote: On Fri, 2015-04-17 at 19:24 +0800, Chen Baozi wrote: Hi all, According to my recent experience, there might be some problems of swiotlb dma map on 1:1 mapping arm64 dom0 with large memory. The issue is like below: For those arm64 server

Re: [Xen-devel] Question about DMA on 1:1 mapping dom0 of arm64

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 15:32 +0100, Stefano Stabellini wrote: I think that given that dom0 is mapped 1:1 on ARM, the easiest and best fix would be to simply allocate memory under 4G to begin with. Not necessarily best, see my reply (hint: dom0 might not have RAM under 4GB even if the host does).

Re: [Xen-devel] [PATCH v4 12/12] docs: add xl-psr.markdown

2015-04-17 Thread Chao Peng
On Thu, Apr 16, 2015 at 12:58:16PM +0100, Ian Campbell wrote: On Thu, 2015-04-09 at 17:18 +0800, Chao Peng wrote: BTW, do you know if someone is planning to work on libvirt integration for this stuff? As I know, there are people from Intel will take care of this. (Aside: cache-occupancy

Re: [Xen-devel] Question about DMA on 1:1 mapping dom0 of arm64

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 15:34 +0100, Stefano Stabellini wrote: If I set dom0_mem to a small value (e.g. 512M), which makes all physical memory of dom0 below 4G, everything goes fine. So you are getting allocated memory below 4G? You message on IRC suggested you weren't, did you

Re: [Xen-devel] [PATCH v2 2/3] xen: arm: propagate gic's #interrupt-cells property to dom0.

2015-04-17 Thread Ian Campbell
On Mon, 2015-03-16 at 16:01 +, Julien Grall wrote: Hi Ian, On 12/03/15 17:17, Ian Campbell wrote: This is similar to 816f5bb1f074 xen: arm: propagate gic's should propagate (rather than invent our own value) since this value is used to size fields within other properties within the

[Xen-devel] [PATCH v2 19/19] xen: arm: Annotate source of ICC SGI register trapping

2015-04-17 Thread Ian Campbell
I was unable to find an ARMv8 ARM reference to this, so refer to the GIC Architecture Specification instead. ARMv8 ARM does cover other ways of trapping these accesses via ICH_HCR_EL2 but we don't use those and they trap additional registers as well. Signed-off-by: Ian Campbell

[Xen-devel] [PATCH v2 01/19] xen: arm: constify union hsr and struct hsr_* where possible.

2015-04-17 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@citrix.com --- xen/arch/arm/traps.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index

[Xen-devel] [PATCH v2 09/19] xen: arm: Annotate registers trapped by HCR_EL1.TIDCP

2015-04-17 Thread Ian Campbell
This traps variety of implementation defined registers, so add a note to the default case of the respective handler. Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@citrix.com --- v2: Typo in subject --- xen/arch/arm/traps.c | 16 1

[Xen-devel] [PATCH v2 03/19] xen: arm: call inject_undef_exception directly

2015-04-17 Thread Ian Campbell
Reducing the amount of goto maze considerably. Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@citrix.com --- xen/arch/arm/traps.c | 56 +++--- 1 file changed, 26 insertions(+), 30 deletions(-) diff --git

[Xen-devel] [PATCH v2 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

2015-04-17 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: Move last paramter of a handle_ro_raz call to next patch where it belongs. --- xen/arch/arm/traps.c | 52 -- 1 file changed, 33 insertions(+), 19 deletions(-) diff --git

[Xen-devel] [PATCH v2 08/19] xen: arm: implement handling of ACTLR_EL1 trap

2015-04-17 Thread Ian Campbell
While annotating ACTLR I noticed that we don't appear to handle the 64-bit version of this trap. Do so and annotate everything. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: s/TASC/TACR/ and s/HSR/HCR/ --- xen/arch/arm/traps.c | 20

[Xen-devel] [PATCH v2 06/19] xen: arm: add minimum exception level argument to trap handler helpers

2015-04-17 Thread Ian Campbell
Removes a load of boiler plate. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: Move last parameter of a call to handle_ro_raz here where it belongs. Added asserts for valid min_el values --- xen/arch/arm/traps.c | 73 +++--- 1

[Xen-devel] [PATCH v2 17/19] xen: arm: Remove CNTPCT_EL0 trap handling.

2015-04-17 Thread Ian Campbell
We set CNTHCTL_EL2.EL1PCTEN and therefore according to ARMv8 (DDI 0487A.d) D1-1510 Table D1-60 we are not trapping this. Signed-off-by: Ian Campbell ian.campb...@citrix.com Reviewed-by: Julien Grall julien.gr...@citrix.com --- xen/arch/arm/traps.c |1 - xen/arch/arm/vtimer.c | 30

[Xen-devel] [PATCH v2 02/19] xen: arm: Fix handling of ICC_{SGI1R, SGI0R, ASGI1R}_EL1

2015-04-17 Thread Ian Campbell
Having injected an undefined instruction we don't want to also advance pc. So return. The ICC_{SGI0R,ASGI1R}_EL1 case was previously missing a break, so would have fallen through to the default case and injected a second undef, corrupting SPSR_EL1 and ELR_EL1 for the guest. Signed-off-by: Ian

[Xen-devel] [PATCH v2 04/19] xen: arm: provide and use a handle_raz_wi helper

2015-04-17 Thread Ian Campbell
Reduces the use of goto in the trap handlers to none. Some explicitly 32-bit types become register_t here, but that's OK, on 32-bit they are 32-bit already and on 64-bit it is fine/harmless to set the larger register, a 32-bit guest won't see the top half in any case. Per section B1.2.1 (ARMv8

Re: [Xen-devel] [PATCH v2 2/4] x86/MSI-X: access MSI-X table only after having enabled MSI-X

2015-04-17 Thread Jan Beulich
On 15.04.15 at 19:41, konrad.w...@oracle.com wrote: On Mon, Apr 13, 2015 at 10:05:14AM +0100, Jan Beulich wrote: On 10.04.15 at 22:02, konrad.w...@oracle.com wrote: On Wed, Mar 25, 2015 at 04:39:49PM +, Jan Beulich wrote: As done in Linux by f598282f51 (PCI: Fix the NIU MSI-X problem

[Xen-devel] [PATCH v2 13/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDRA

2015-04-17 Thread Ian Campbell
DBGDRAR and DBGDSAR are actually two cp or sys registers each, one 32-bit and one 64-bit. The cpregs #define is suffixed 64 and annotations are added to both handlers. MDRAR_EL1 (arm64 version of DBGDRAR) wasn't handled, so add that here. Signed-off-by: Ian Campbell ian.campb...@citrix.com ---

[Xen-devel] [PATCH v2 10/19] xen: arm: implement handling of registers trapped by CPTR_EL2.TTA

2015-04-17 Thread Ian Campbell
Add explicit handler for 64-bit CP14 accesses, with more relevant debug message (as per other handlers) and to provide a place for a comment. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: Changed title from xen: arm: Annotate registers trapped by CPTR_EL2.TTA Add And all

[Xen-devel] [PATCH v2 11/19] xen: arm: Annotate handlers for CPTR_EL2.Tx

2015-04-17 Thread Ian Campbell
Also expand on the comment when writing CPTR_EL2 to mention that most of the bits we are setting are RES1 on arm64 anyway. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: s/PCTR/CPTR/ Expand the comment when writing to CPTR_EL2 --- xen/arch/arm/traps.c | 23

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Konrad Rzeszutek Wilk
On Fri, Apr 17, 2015 at 02:45:23PM +0100, Andrew Cooper wrote: On 17/04/15 14:40, Konrad Rzeszutek Wilk wrote: On Fri, Apr 17, 2015 at 01:54:28PM +0100, Andrew Cooper wrote: On 17/04/15 13:39, Jan Beulich wrote: On 17.04.15 at 13:59, andrew.coop...@citrix.com wrote: On 17/04/15 12:17,

Re: [Xen-devel] Question about DMA on 1:1 mapping dom0 of arm64

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 19:24 +0800, Chen Baozi wrote: Hi all, According to my recent experience, there might be some problems of swiotlb dma map on 1:1 mapping arm64 dom0 with large memory. The issue is like below: For those arm64 server with large memory, it is possible to set dom0_mem

Re: [Xen-devel] Archiving Xen on ARM and PVOPS subprojects

2015-04-17 Thread Stefano Stabellini
On Wed, 15 Apr 2015, Lars Kurth wrote: Hi all, I wanted to make the proposal to archive the following two subproject on the grounds that they completed their goals a) http://xenproject.org/developers/teams/pvops.html b) http://xenproject.org/developers/teams/arm-hypervisor.html In the

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Konrad Rzeszutek Wilk
On Fri, Apr 17, 2015 at 01:54:28PM +0100, Andrew Cooper wrote: On 17/04/15 13:39, Jan Beulich wrote: On 17.04.15 at 13:59, andrew.coop...@citrix.com wrote: On 17/04/15 12:17, Olaf Hering wrote: Since booting xen fails on my ProBook unless I specify maxcpus=1 I tried the EFI firmware

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Andrew Cooper
On 17/04/15 14:40, Konrad Rzeszutek Wilk wrote: On Fri, Apr 17, 2015 at 01:54:28PM +0100, Andrew Cooper wrote: On 17/04/15 13:39, Jan Beulich wrote: On 17.04.15 at 13:59, andrew.coop...@citrix.com wrote: On 17/04/15 12:17, Olaf Hering wrote: Since booting xen fails on my ProBook unless I

Re: [Xen-devel] crash in efi_runtime_call

2015-04-17 Thread Jan Beulich
On 17.04.15 at 15:40, konrad.w...@oracle.com wrote: I actually did cobble a patch like this, but it is based on Daniel's Multibootv2 so it won't apply cleany. See attached patchset with various 'work-arounds'. Jan if you are OK with them (well the 'idea' behind them) I can refresh it

[Xen-devel] [PATCH v2 14/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDOSA

2015-04-17 Thread Ian Campbell
Gather the affected handlers in a single place per trap type. Add some HSR_SYSREG and AArch32 defines for those registers (because I'd already typed them in when I realised I didn't need them). Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: Move comment block in cp14_dbg handler

[Xen-devel] [PATCH v2 07/19] xen: arm: Annotate trap handler for HSR_EL2.{TWI, TWE, TSC}

2015-04-17 Thread Ian Campbell
Reference the bit which enables the trap and the section/page which describes what that bit enables. These ones are pretty trivial, included for completeness. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: s/HSR_EL2/HCR_EL2/ --- xen/arch/arm/traps.c | 17 + 1 file

[Xen-devel] [PATCH v2 16/19] xen: arm: Annotate registers trapped by MDCR_EL2.TPM and TPMCR

2015-04-17 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com --- xen/arch/arm/traps.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 97cde45..d4505b5 100644 --- a/xen/arch/arm/traps.c +++

[Xen-devel] [PATCH v2 15/19] xen: arm: Annotate registers trapped by MDCR_EL2.TDA

2015-04-17 Thread Ian Campbell
Gather the affected handlers in a single place per trap type. Signed-off-by: Ian Campbell ian.campb...@citrix.com --- xen/arch/arm/traps.c | 60 +- 1 file changed, 49 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/traps.c

[Xen-devel] [PATCH v2 12/19] xen: arm: Annotate the handlers for HSTR_EL2.T15

2015-04-17 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com --- v2: s/Tx/T15/ --- xen/arch/arm/traps.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index a2bae51..86b5655 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@

Re: [Xen-devel] [PATCH 1/8] raisin: Fix non-verbose case

2015-04-17 Thread Stefano Stabellini
On Thu, 16 Apr 2015, George Dunlap wrote: Because we use set -e, we can't use the a b construct, as it will fail and stop the script. Signed-off-by: George Dunlap george.dun...@eu.citrix.com I am wondering whether we should ban both a b and a || b from the code and just go with the more

Re: [Xen-devel] [PATCH 5/8] raisin: Fix CentOS build

2015-04-17 Thread Stefano Stabellini
On Thu, 16 Apr 2015, George Dunlap wrote: Add package dependencies for CentOS. Also use PKGTYPE rather than DISTRO to determine if we need rpm-build. I've tested this for xen but not for libvirt or grub. Signed-off-by: George Dunlap george.dun...@eu.citrix.com --- CC: Stefano Stabellini

Re: [Xen-devel] kernel BUG at drivers/xen/grant-table.c:923!

2015-04-17 Thread Wei Liu
On Fri, Apr 17, 2015 at 11:28:39AM +0100, Ian Campbell wrote: (Was Re: [osstest test] 50423: regressions - FAIL) This cropped up in an osstest flight (the results only go to Ian and I). On Fri, 2015-04-17 at 11:10 +0100, Ian Campbell wrote: On Thu, 2015-04-16 at 21:36 +, osstest

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-17 Thread Stefano Stabellini
On Thu, 16 Apr 2015, George Dunlap wrote: Until we start hosting the blktap repo on xenbits, use the one from github. Also, we need to pass in the directories where to find the libblktapctl headers in the Xen build. Signed-off-by: George Dunlap george.dun...@eu.citrix.com --- Note: For

Re: [Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

2015-04-17 Thread Ian Campbell
On Fri, 2015-04-17 at 11:50 +0100, Stefano Stabellini wrote: +local DEP_CentOS_x86_32=$DEP_Redhat_common +local DEP_CentOS_x86_64=$DEP_Redhat_x86_32 Redhat? I don't know no Redhat. Is the use of x86_32 rather than common on the x86_64 case deliberate? Ian.

  1   2   >