Re: [Xen-devel] [PATCH v4 11/11] tools: enable xenpm to control the intel_pstate driver

2015-07-07 Thread Wang, Wei W
On 08/07/2015 14:24, Jan Beulich wrote: > >>> On 08.07.15 at 07:15, wrote: > > On 07/07/2015 20:14, Wei Liu wrote: > >> On Tue, Jul 07, 2015 at 01:05:21PM +0100, Jan Beulich wrote: > >> > >>> On 07.07.15 at 10:55, wrote: > >> > > On Thu, Jun 25, 2015 at 07:19:05PM +0800, Wei Wang wrote: > >> > >

Re: [Xen-devel] [PATCH v2 1/4] x86/compat: Test whether guest has 32b shinfo instead of being a PV 32b domain

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 19:13, wrote: > On 07/07/2015 12:15 PM, Jan Beulich wrote: > On 07.07.15 at 17:46, wrote: >>> On 07/07/2015 05:11 AM, Jan Beulich wrote: >>> On 29.06.15 at 22:21, wrote: > @@ -737,7 +737,7 @@ int arch_set_info_guest( > >/* The context is a compa

Re: [Xen-devel] [PATCH v25 10/15] x86/VPMU: Use pre-computed masks when checking validity of MSRs

2015-07-07 Thread Dietmar Hahn
Am Freitag 19 Juni 2015, 14:44:41 schrieb Boris Ostrovsky: > No need to compute those masks on every MSR access. > > Also, when checking MSR_P6_EVNTSELx registers make sure that bit 21 > (which is a reserved bit) is not set. > > Signed-off-by: Boris Ostrovsky > Acked-by: Kevin Tian Reviewed-by

Re: [Xen-devel] Performance problem about address translation

2015-07-07 Thread xinyue
Very sorry for sending wrong before. On 2015年07月08日 14:13, xinyue wrote: On 2015年07月07日 19:49, Ian Campbell wrote: On Tue, 2015-07-07 at 11:24 +0800, xinyue wrote: Please don't use HTML mail and do proper ">" quoting And after analyzing the performance of hvm domu, I found a process named "e

Re: [Xen-devel] [v5][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 23:32, wrote: >> +/* IN/OUT */ >> +unsigned intnr_entries; > > Perhaps I am missing something but I can't find any API documentation > for the return value and error returns from this new hypercall. I think this is in line with everythin

Re: [Xen-devel] [PATCH v4 11/11] tools: enable xenpm to control the intel_pstate driver

2015-07-07 Thread Jan Beulich
>>> On 08.07.15 at 07:15, wrote: > On 07/07/2015 20:14, Wei Liu wrote: >> On Tue, Jul 07, 2015 at 01:05:21PM +0100, Jan Beulich wrote: >> > >>> On 07.07.15 at 10:55, wrote: >> > > On Thu, Jun 25, 2015 at 07:19:05PM +0800, Wei Wang wrote: >> > >> --- a/tools/libxc/include/xenctrl.h >> > >> +++ b/t

Re: [Xen-devel] Performance problem about address translation

2015-07-07 Thread xinyue
On 2015年07月07日 19:49, Ian Campbell wrote: On Tue, 2015-07-07 at 11:24 +0800, xinyue wrote: Please don't use HTML mail and do proper ">" quoting And after analyzing the performance of hvm domu, I found a process named "evolution-data-" using almost 99.9% cpu. Does someone known what's this and

[Xen-devel] [PATCH] xen: Use module_pci_driver() in platform pci driver.

2015-07-07 Thread Rajat Jain
Eliminate the module_init function by using module_pci_driver() Signed-off-by: Rajat Jain Signed-off-by: Rajat Jain --- drivers/xen/platform-pci.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c index 3454973..3fb

Re: [Xen-devel] [PATCH v25 08/15] x86/VPMU: When handling MSR accesses, leave fault injection to callers

2015-07-07 Thread Dietmar Hahn
Am Freitag 19 Juni 2015, 14:44:39 schrieb Boris Ostrovsky: > Hypervisor cannot easily inject faults into PV guests from arch-specific VPMU > read/write MSR handlers (unlike it is in the case of HVM guests). > > With this patch vpmu_do_msr() will return an error code to indicate whether an > error

Re: [Xen-devel] [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

2015-07-07 Thread Meng Xu
2015-07-07 7:39 GMT-07:00 Dario Faggioli : > On Tue, 2015-07-07 at 09:59 +0100, Jan Beulich wrote: >> >>> On 29.06.15 at 04:44, wrote: >> > --- a/xen/common/Makefile >> > +++ b/xen/common/Makefile >> > @@ -31,7 +31,6 @@ obj-y += rbtree.o >> > obj-y += rcupdate.o >> > obj-y += sched_credit.o >> >

Re: [Xen-devel] [PATCH v2] Modified RTDS scheduler to use an event-driven model instead of polling.

2015-07-07 Thread Meng Xu
Hi Dario, (I understand and agree most of your comments, but have one concern about your comment. I will comment below.) Hi Dagaen, Please comment on my comment if you have any concern/idea. 2015-07-07 7:03 GMT-07:00 Dario Faggioli : > > On Mon, 2015-07-06 at 22:51 -0700, Meng Xu wrote: > > > >>

Re: [Xen-devel] [PATCH v25 07/15] x86/VPMU: Save VPMU state for PV guests during context switch

2015-07-07 Thread Dietmar Hahn
Am Freitag 19 Juni 2015, 14:44:38 schrieb Boris Ostrovsky: > Save VPMU state during context switch for both HVM and PV(H) guests. > > A subsequent patch ("x86/VPMU: NMI-based VPMU support") will make it possible > for vpmu_switch_to() to call vmx_vmcs_try_enter()->vcpu_pause() which needs > is_run

[Xen-devel] [rumpuserxen test] 59184: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59184 rumpuserxen real [real] http://logs.test-lab.xenproject.org/osstest/logs/59184/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 5 rumpuserxen-build fail REGR. vs. 33866 build-i386-rumpuserxe

Re: [Xen-devel] [PATCH v4 11/11] tools: enable xenpm to control the intel_pstate driver

2015-07-07 Thread Wang, Wei W
On 07/07/2015 20:14, Wei Liu wrote: > On Tue, Jul 07, 2015 at 01:05:21PM +0100, Jan Beulich wrote: > > >>> On 07.07.15 at 10:55, wrote: > > > On Thu, Jun 25, 2015 at 07:19:05PM +0800, Wei Wang wrote: > > >> --- a/tools/libxc/include/xenctrl.h > > >> +++ b/tools/libxc/include/xenctrl.h > > >> @@ -2

[Xen-devel] [linux-linus test] 59130: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59130 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/59130/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-xsm 6 xen-boot fail REGR. vs. 59086 Regressions which are

Re: [Xen-devel] [PATCH v10 01/13] x86: add socket_cpumask

2015-07-07 Thread Chao Peng
On Tue, Jul 07, 2015 at 06:32:55PM -0400, Boris Ostrovsky wrote: > On 06/26/2015 04:43 AM, Chao Peng wrote: > >Maintain socket_cpumask which contains all the HT and core siblings > >in the same socket. > > > >Signed-off-by: Chao Peng > >Acked-by: Jan Beulich > >--- > >Changes in v9: > >* Add comm

Re: [Xen-devel] [PATCH v10 02/13] x86: detect and initialize Intel CAT feature

2015-07-07 Thread Chao Peng
On Tue, Jul 07, 2015 at 11:25:46AM +0100, Jan Beulich wrote: > >>> On 26.06.15 at 10:43, wrote: > > Detect Intel Cache Allocation Technology(CAT) feature and store the > > cpuid information for later use. Currently only L3 cache allocation is > > supported. The L3 CAT features may vary among socke

[Xen-devel] [ovmf test] 59121: tolerable FAIL - PUSHED

2015-07-07 Thread osstest service owner
flight 59121 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/59121/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 59082 test-amd64-i386-xl-qemuu-win7-amd64 1

Re: [Xen-devel] [v5][PATCH 10/16] tools: introduce some new parameters to set rdm policy

2015-07-07 Thread Chen, Tiejun
+"none" is the default value and it means we don't check any reserved regions +and then all rdm policies would be ignored. Guest just works as before and +the conflict of RDM and guest address space wouldn't be handled, and then +this may result in the associated device not being able to work or e

[Xen-devel] [linux-3.18 test] 59117: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59117 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59117/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Tests which are failin

[Xen-devel] [libvirt test] 59132: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59132 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/59132/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm 11 guest-start fail REGR. vs. 58842 Regressions which are reg

Re: [Xen-devel] [PATCH v10 01/13] x86: add socket_cpumask

2015-07-07 Thread Boris Ostrovsky
On 06/26/2015 04:43 AM, Chao Peng wrote: Maintain socket_cpumask which contains all the HT and core siblings in the same socket. Signed-off-by: Chao Peng Acked-by: Jan Beulich --- Changes in v9: * Add comments for set_nr_sockets. * Move set_nr_sockets() invocation from __start_xen() to smp_pre

Re: [Xen-devel] [v5][PATCH 10/16] tools: introduce some new parameters to set rdm policy

2015-07-07 Thread Chen, Tiejun
On 2015/7/8 1:08, Ian Jackson wrote: Chen, Tiejun writes ("Re: [v5][PATCH 10/16] tools: introduce some new parameters to set rdm policy"): Its always fine to me but I just think, is it a good time to start to seek another *optional* approach to overturn current design and implementation ? Unles

Re: [Xen-devel] [v5][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map

2015-07-07 Thread Chen, Tiejun
+/* IN/OUT */ +unsigned intnr_entries; Perhaps I am missing something but I can't find any API documentation for the return value and error returns from this new hypercall. I think this is in line with everything else in this header - am I overlooking something? In particular, wo

Re: [Xen-devel] [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init()

2015-07-07 Thread Boris Ostrovsky
On 07/07/2015 04:26 PM, Konrad Rzeszutek Wilk wrote: diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index 8afdfcc..b1508a8 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -56,28 +56,28 @@ ENTRY(startup_xen) * @entry: true if this is a secondary vcpu coming

Re: [Xen-devel] [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init()

2015-07-07 Thread Boris Ostrovsky
On 07/07/2015 04:16 PM, Konrad Rzeszutek Wilk wrote: On Mon, Jul 06, 2015 at 11:34:20PM -0400, Boris Ostrovsky wrote: x86-64 ABI requires that functions preserve %rbx. When xen_pvh_early_cpu_init() is executed on boot cpu it is invoked as a function and 'cpuid' instruction will clobber %rbx. (Th

Re: [Xen-devel] [PATCH v8 02/11] libxl: support SHUTDOWN_soft_reset shutdown reason

2015-07-07 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:44PM +0200, Vitaly Kuznetsov wrote: > Use letter 'S' to indicate a domain in such state. > > Signed-off-by: Vitaly Kuznetsov > Acked-by: Ian Campbell Reviewed-by: Konrad Rzeszutek Wilk > --- > tools/libxl/libxl_types.idl | 1 + > tools/libxl/xl_cmdimpl.c

Re: [Xen-devel] [PATCH v8 03/11] xl: introduce enum domain_restart_type

2015-07-07 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:45PM +0200, Vitaly Kuznetsov wrote: > As a preparation before adding new restart type (soft reset) put all > restart types into an enum. > > Signed-off-by: Vitaly Kuznetsov > Acked-by: Ian Campbell Reviewed-by: Konrad Rzeszutek Wilk > --- > Changes since v7: > - s

Re: [Xen-devel] [PATCH v8 01/11] xen: introduce SHUTDOWN_soft_reset shutdown reason

2015-07-07 Thread Konrad Rzeszutek Wilk
On Tue, Jun 23, 2015 at 06:11:43PM +0200, Vitaly Kuznetsov wrote: > This special type of shutdown is supposed to be used by PVHVM guests when > they want to perform some sort of kexec/kdump. > > Signed-off-by: Vitaly Kuznetsov Reviewed-by: Konrad Rzeszutek Wilk > --- > xen/common/shutdown.c

Re: [Xen-devel] [PATCH 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-07 Thread Boris Ostrovsky
On 07/07/2015 03:54 PM, Konrad Rzeszutek Wilk wrote: On Mon, Jul 06, 2015 at 11:34:23PM -0400, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky --- arch/x86/xen/enlighten.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/a

Re: [Xen-devel] [PATCH 5/6] xen/x86/pvh: Add 32-bit PVH initialization code

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:24PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk ..thought we could just skip the whole 'entry' parameter check. > --- > arch/x86/xen/enlighten.c | 4 > arch/x86/xen/smp.c | 17 ++--- >

Re: [Xen-devel] [PATCH v3 11/13] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-07-07 Thread Andrew Cooper
On 07/07/15 21:10, Sahita, Ravi wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Tuesday, July 07, 2015 12:34 AM >> > On 06.07.15 at 12:09, wrote: >>> On 01/07/15 19:09, Ed White wrote: Signed-off-by: Ed White >>> I am still very much unconvinced by the argument against ha

Re: [Xen-devel] [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init()

2015-07-07 Thread Konrad Rzeszutek Wilk
> > diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S > > index 8afdfcc..b1508a8 100644 > > --- a/arch/x86/xen/xen-head.S > > +++ b/arch/x86/xen/xen-head.S > > @@ -56,28 +56,28 @@ ENTRY(startup_xen) > > * @entry: true if this is a secondary vcpu coming up on this entry > > *

Re: [Xen-devel] [PATCH 1/6] xen/x86/pvh: Save %rbx in xen_pvh_early_cpu_init()

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:20PM -0400, Boris Ostrovsky wrote: > x86-64 ABI requires that functions preserve %rbx. When > xen_pvh_early_cpu_init() is executed on boot cpu it is invoked as a > function and 'cpuid' instruction will clobber %rbx. (This is not a > concern on secondary processors sinc

Re: [Xen-devel] [PATCH v3 11/13] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-07-07 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Tuesday, July 07, 2015 12:34 AM > On 06.07.15 at 12:09, wrote: >> On 01/07/15 19:09, Ed White wrote: >>> Signed-off-by: Ed White >> >> I am still very much unconvinced by the argument against having a >> single HVMOP_altp2m and a set of s

Re: [Xen-devel] [PATCH 5/6] xen/x86/pvh: Add 32-bit PVH initialization code

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:24PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky A little bit more here I think - as in that the parameter passing is not an Xen specific thing but something this code cooked up? > --- > arch/x86/xen/enlighten.c | 4 > arch/x86/xen/smp.c

Re: [Xen-devel] [PATCH 6/6] xen/x86/pvh: Allow building 32-bit PVH guests

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:25PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/x86/xen/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig > index e88fda8

[Xen-devel] [seabios test] 59114: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59114 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/59114/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 9 windows-installfail REGR. vs. 59056 Regressions which are reg

[Xen-devel] 3.18.17 Xen regression

2015-07-07 Thread Boris Ostrovsky
Commit 63753fac67e1 ("x86: Store a per-cpu shadow copy of CR4") in 3.18.y branch introduced a regression on PVH Xen guests. Please apply 5054daa285be ("x86/xen: Initialize cr4 shadow for 64-bit PV(H) guests") from mainline to fix this. 3.18.y appears to be the only affected branch. Thanks.

Re: [Xen-devel] [PATCH 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:23PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > arch/x86/xen/enlighten.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index 0b95c9b..7953e

Re: [Xen-devel] [linux-3.18 test] 59041: regressions - trouble: blocked/broken/fail/pass

2015-07-07 Thread Ian Campbell
On Tue, 2015-07-07 at 15:22 -0400, Boris Ostrovsky wrote: > I didn't need to bisect this, the bad commit is 63753fac67. I am > actually surprised this went into a stable kernel since that patch was a > performance improvement (a not a huge one at that, I suspect). > > Anyway, this kernel needs 5

Re: [Xen-devel] [PATCH 3/6] xen/x86/pvh: Properly set page tables for 32-bit PVH guests

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:22PM -0400, Boris Ostrovsky wrote: > 32-bit PVH guests don't want to write-protect/pin page tables. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/x86/xen/mmu.c | 22 +- > 1 file changed, 13 insertions(+), 9

Re: [Xen-devel] [PATCH 2/6] xen/x86: Remove unnecessary memset() call

2015-07-07 Thread Konrad Rzeszutek Wilk
On Mon, Jul 06, 2015 at 11:34:21PM -0400, Boris Ostrovsky wrote: > Since ctxt is kzalloc'd there is no need to call a memset for > ctxt->fpu_ctxt. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/x86/xen/smp.c | 1 - > 1 file changed, 1 deletion(-) > > diff -

Re: [Xen-devel] [linux-3.18 test] 59041: regressions - trouble: blocked/broken/fail/pass

2015-07-07 Thread Boris Ostrovsky
On 07/07/2015 11:16 AM, Boris Ostrovsky wrote: On 07/07/2015 11:08 AM, Ian Campbell wrote: On Tue, 2015-07-07 at 10:55 -0400, Boris Ostrovsky wrote: On 07/07/2015 03:39 AM, Ian Campbell wrote: On Mon, 2015-07-06 at 12:06 -0400, Boris Ostrovsky wrote: Bisection was broken for linux-3.18 until t

[Xen-devel] [qemu-mainline test] 59109: regressions - FAIL

2015-07-07 Thread osstest service owner
flight 59109 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/59109/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-win7-amd64 9 windows-installfail REGR. vs. 59059 Regressions which a

Re: [Xen-devel] [PATCH v3 06/13] VMX/altp2m: add code to support EPTP switching and #VE.

2015-07-07 Thread Nakajima, Jun
On Wed, Jul 1, 2015 at 11:09 AM, Ed White wrote: > Implement and hook up the code to enable VMX support of VMFUNC and #VE. > > VMFUNC leaf 0 (EPTP switching) emulation is added in a later patch. > > Signed-off-by: Ed White Acked-by: Jun Nakajima -- Jun Intel Open Source Technology Center ___

Re: [Xen-devel] [PATCH v3 03/13] VMX: implement suppress #VE.

2015-07-07 Thread Nakajima, Jun
On Wed, Jul 1, 2015 at 11:09 AM, Ed White wrote: > In preparation for selectively enabling #VE in a later patch, set > suppress #VE on all EPTE's. > > Suppress #VE should always be the default condition for two reasons: > it is generally not safe to deliver #VE into a guest unless that guest > has

Re: [Xen-devel] [PATCH v3 02/13] VMX: VMFUNC and #VE definitions and detection.

2015-07-07 Thread Nakajima, Jun
On Wed, Jul 1, 2015 at 11:09 AM, Ed White wrote: > Currently, neither is enabled globally but may be enabled on a per-VCPU > basis by the altp2m code. > > Remove the check for EPTE bit 63 == zero in ept_split_super_page(), as > that bit is now hardware-defined. > > Signed-off-by: Ed White > > Rev

Re: [Xen-devel] [PATCH v2] net/bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

2015-07-07 Thread Stephen Hemminger
On Tue, 7 Jul 2015 15:55:21 +0100 Julien Grall wrote: > The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: > forward IPv6 fragmented packets" introduced a new function > br_validate_ipv6 which take a reference on the inet6 device. Although, > the reference is not released at

Re: [Xen-devel] [PATCH v2 07/12] x86/altp2m: add control of suppress_ve.

2015-07-07 Thread Sahita, Ravi
>From: George Dunlap [mailto:george.dun...@eu.citrix.com] >Sent: Tuesday, July 07, 2015 10:34 AM > >On 07/07/2015 05:24 PM, Ed White wrote: >> On 07/07/2015 03:10 AM, George Dunlap wrote: >>> On 07/06/2015 07:43 PM, Ed White wrote: > Introducing yet another layer -- particularly in a hooked i

Re: [Xen-devel] [PATCH v2 07/12] x86/altp2m: add control of suppress_ve.

2015-07-07 Thread George Dunlap
On 07/07/2015 05:24 PM, Ed White wrote: > On 07/07/2015 03:10 AM, George Dunlap wrote: >> On 07/06/2015 07:43 PM, Ed White wrote: Introducing yet another layer -- particularly in a hooked interface like this -- just seems clunky. It's not the worst thing in the world; if I thought t

Re: [Xen-devel] [PATCH v2 1/4] x86/compat: Test whether guest has 32b shinfo instead of being a PV 32b domain

2015-07-07 Thread Boris Ostrovsky
On 07/07/2015 12:15 PM, Jan Beulich wrote: On 07.07.15 at 17:46, wrote: On 07/07/2015 05:11 AM, Jan Beulich wrote: On 29.06.15 at 22:21, wrote: @@ -737,7 +737,7 @@ int arch_set_info_guest( /* The context is a compat-mode one if the target domain is compat-mode; * we expec

Re: [Xen-devel] [v5][PATCH 10/16] tools: introduce some new parameters to set rdm policy

2015-07-07 Thread Ian Jackson
Chen, Tiejun writes ("Re: [v5][PATCH 10/16] tools: introduce some new parameters to set rdm policy"): > Its always fine to me but I just think, is it a good time to start to > seek another *optional* approach to overturn current design and > implementation ? Unless you're very sure we're doing s

[Xen-devel] [PATCH v4 0/7] get rid of the SEDF

2015-07-07 Thread Dario Faggioli
This should be it. Patch 1 is still, as in v3, the only one in need of attention. Series available here too: git://xenbits.xen.org/people/dariof/xen.git rel/sched/nosedf-v4 Thanks and Regards, Dario --- Dario Faggioli (7): libxl: get rid of the SEDF scheduler tools: python: get rid

[Xen-devel] [PATCH v4 3/7] libxc: get rid of the SEDF scheduler

2015-07-07 Thread Dario Faggioli
Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Acked-by: Ian Campbell --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- tools/libxc/Makefile |1 - tools/libxc/include/xenctrl.h | 12 -- tools/libxc/xc_sedf.c | 78 ---

[Xen-devel] [PATCH v4 4/7] xen: get rid of the SEDF scheduler

2015-07-07 Thread Dario Faggioli
more specifically, of all the symbols and references to it. Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Reviewed-by: Andrew Cooper --- Changes from v1: - added markers for removed #defines, to help keep bits of the history, and reduce the likelyhood of accidental reuse, as r

[Xen-devel] [PATCH v4 5/7] xen: kill sched_sedf.c

2015-07-07 Thread Dario Faggioli
Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap --- xen/common/sched_sedf.c | 1557 --- 1 file changed, 1557 deletions(-) delete mode 100644 xen/common/sched_sedf.c diff --git a/xen/common/sched_sedf.c b/xen/common/sched_sedf.c deleted file

[Xen-devel] [PATCH v4 7/7] docs: get rid of the SEDF scheduler

2015-07-07 Thread Dario Faggioli
Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Acked-by: Ian Campbell --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- docs/INDEX |1 - docs/man/xlcpupool.cfg.pod.5|4 --- docs/misc/sedf_scheduler_mini-HOWTO.txt | 44

[Xen-devel] [PATCH v4 1/7] libxl: get rid of the SEDF scheduler

2015-07-07 Thread Dario Faggioli
only the interface is left in place, for backward compile-time compatibility, but every attempt to use it would throw an error. Signed-off-by: Dario Faggioli --- Cc: George Dunlap Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu Changes from v3: - drop George's Rev-by: w

[Xen-devel] [PATCH v4 6/7] xl: get rid of the SEDF scheduler

2015-07-07 Thread Dario Faggioli
Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Acked-by: Ian Campbell --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- docs/man/xl.cfg.pod.5 | 24 docs/man/xl.pod.1 | 42 -- tools/libxl/xl.h |1 tools/libxl/xl_cmdimpl.c

[Xen-devel] [PATCH v4 2/7] tools: python: get rid of the SEDF scheduler bindings

2015-07-07 Thread Dario Faggioli
as it is going away from libxc, so these won't build any longer. Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Acked-by: Ian Campbell --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu --- tools/python/xen/lowlevel/xc/xc.c | 70 - 1 file

Re: [Xen-devel] [PATCH V3] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()

2015-07-07 Thread Ian Jackson
Jennifer Herbert writes ("[PATCH V3] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()"): > Unlikely that it may seem localtime_r could fail, which would result in a > null pointer dereference. In this case, it shoud log the errno, (instead of > the date/time), and and continue it

[Xen-devel] [PATCH V3] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()

2015-07-07 Thread Jennifer Herbert
Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of the date/time), and and continue its logging, as this is still useful. Signed-off-by: Jennifer Herbert --- tools/libxc/xtl_logger_stdio.c | 11

Re: [Xen-devel] [PATCH OSSTEST v1] make-flight: Only test ovmf guests on ovmf flight

2015-07-07 Thread Ian Campbell
On Tue, 2015-07-07 at 17:31 +0100, Wei Liu wrote: > On Tue, Jul 07, 2015 at 05:26:45PM +0100, Ian Campbell wrote: > > Specifically drop all of the following test jobs from the ovmf flight: > > > > -test-amd64-amd64-xl-qemuu-debianhvm-amd64 > > -test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm > > -te

Re: [Xen-devel] [PATCH OSSTEST v1] make-flight: Only test ovmf guests on ovmf flight

2015-07-07 Thread Wei Liu
On Tue, Jul 07, 2015 at 05:26:45PM +0100, Ian Campbell wrote: > Specifically drop all of the following test jobs from the ovmf flight: > > -test-amd64-amd64-xl-qemuu-debianhvm-amd64 > -test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm > -test-amd64-amd64-xl-qemuu-win7-amd64 > -test-amd64-amd64-xl-qemu

Re: [Xen-devel] [PATCH 0/6] libxl: config file string handling cleanups

2015-07-07 Thread Wei Liu
On Tue, Jul 07, 2015 at 05:21:07PM +0100, Ian Jackson wrote: > Ian Jackson writes ("[PATCH 0/6] libxl: config file string handling > cleanups"): > > These 6 followup patches were developed during a review of the xl > > string handling code, prompted by XSA-137. They were embargoed until > > today

Re: [Xen-devel] [PATCH OSSTEST v1] make-flight: Only test ovmf guests on ovmf flight

2015-07-07 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST v1] make-flight: Only test ovmf guests on ovmf flight"): > Specifically drop all of the following test jobs from the ovmf flight: > > -test-amd64-amd64-xl-qemuu-debianhvm-amd64 > -test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm > -test-amd64-amd64-xl-qemuu-win7-

Re: [Xen-devel] [PATCH v5 2/3] arm: Allow the user to specify the GIC version

2015-07-07 Thread Ian Campbell
On Tue, 2015-07-07 at 17:22 +0100, Julien Grall wrote: > A platform may have a GIC compatible with previous version of the > device. > > This is allow to virtualize an unmodified OS on new hardware if the GIC > is compatible with older version. > > When a guest is created, the vGIC will emulate s

[Xen-devel] [PATCH OSSTEST v1] make-flight: Only test ovmf guests on ovmf flight

2015-07-07 Thread Ian Campbell
Specifically drop all of the following test jobs from the ovmf flight: -test-amd64-amd64-xl-qemuu-debianhvm-amd64 -test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm -test-amd64-amd64-xl-qemuu-win7-amd64 -test-amd64-amd64-xl-qemuu-winxpsp3 -test-amd64-i386-qemuu-rhel6hvm-amd -test-amd64-i386-qemuu-rhel

Re: [Xen-devel] [PATCH v3 for Xen 4.6 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

2015-07-07 Thread Dario Faggioli
On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote: > Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to > support > per-VCPU settings. > > Changes on PATCH v2: > > 1) New data structure (libxl_vcpu_sched_params and libxl_sched_params) to > help per-VCPU settings. > >

Re: [Xen-devel] [PATCH V3 1/3] xen/mem_access: Support for memory-content hiding

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 18:20, wrote: > On 07/07/2015 06:40 PM, Jan Beulich wrote: > On 07.07.15 at 17:32, wrote: >>> On 07/07/2015 04:27 PM, Jan Beulich wrote: >>> On 06.07.15 at 17:51, wrote: > @@ -1552,9 +1556,15 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned > long gla, >>>

[Xen-devel] [PATCH v5 2/3] arm: Allow the user to specify the GIC version

2015-07-07 Thread Julien Grall
A platform may have a GIC compatible with previous version of the device. This is allow to virtualize an unmodified OS on new hardware if the GIC is compatible with older version. When a guest is created, the vGIC will emulate same version as the hardware. Although, the user can specify in the co

Re: [Xen-devel] [PATCH v2 07/12] x86/altp2m: add control of suppress_ve.

2015-07-07 Thread Ed White
On 07/07/2015 03:10 AM, George Dunlap wrote: > On 07/06/2015 07:43 PM, Ed White wrote: >>> Introducing yet another layer -- particularly in a hooked interface like >>> this -- just seems clunky. It's not the worst thing in the world; if I >>> thought this would be the difference between making it

[Xen-devel] [PATCH v5 3/3] xen/arm: gic-v3: Add support of vGICv2 when available

2015-07-07 Thread Julien Grall
* Modify the GICv3 driver to recognize a such device. I wasn't able to find a register which tell if GICv2 is supported on GICv3. The only way to find it seems to check if the DT node provides GICC and GICV. * Disable access to ICC_SRE_EL1 to guest using vGICv2 * The LR is slightly different

[Xen-devel] [PATCH v5 1/3] xen/arm: Rename XEN_DOMCTL_CONFIG_GIC_DEFAULT to XEN_DOMCTL_CONFIG_GIC_NATIVE

2015-07-07 Thread Julien Grall
This will reflect that we effectively emulate the same version as the hardware GIC for the guest. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- Changes in v5: - Typo - Add Ian's ack Changes in v4: - Patch added --- tools/libxc/xc_domain.c | 2 +-

[Xen-devel] [PATCH v5 0/3] Add support for GICv2 on GICv3

2015-07-07 Thread Julien Grall
Hi all, This patch series adds support for GICv2 on GICv3. This feature is available only when the GICv3 hardware is compatible with GICv2. When it's the case, the same interface is provided in order to use a virtualize GICv2 (i.e GICC and GICV). This will allow us to re-use the same vGIC driver.

[Xen-devel] [PATCH 0/6] libxl: config file string handling cleanups

2015-07-07 Thread Ian Jackson
These 6 followup patches were developed during a review of the xl string handling code, prompted by XSA-137. They were embargoed until today. I have reviewed the whole of xl's string handling for other bugs. My search terms included: realloc sn?printf str \bstr \bstrcpy \bstrn \bstrcat \bmem

Re: [Xen-devel] [PATCH 0/6] libxl: config file string handling cleanups

2015-07-07 Thread Ian Jackson
Ian Jackson writes ("[PATCH 0/6] libxl: config file string handling cleanups"): > These 6 followup patches were developed during a review of the xl > string handling code, prompted by XSA-137. They were embargoed until > today. > > I have reviewed the whole of xl's string handling for other bugs.

Re: [Xen-devel] [PATCH V3 1/3] xen/mem_access: Support for memory-content hiding

2015-07-07 Thread Razvan Cojocaru
On 07/07/2015 06:40 PM, Jan Beulich wrote: On 07.07.15 at 17:32, wrote: >> On 07/07/2015 04:27 PM, Jan Beulich wrote: >> On 06.07.15 at 17:51, wrote: @@ -1552,9 +1556,15 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla, if ( v->arch.vm_event.emula

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-07 Thread Ed White
On 07/07/2015 08:22 AM, Tim Deegan wrote: > At 16:04 +0100 on 07 Jul (1436285059), George Dunlap wrote: >> On 07/01/2015 07:09 PM, Ed White wrote: >>> diff --git a/xen/arch/x86/mm/mm-locks.h b/xen/arch/x86/mm/mm-locks.h >>> index b4f035e..301ca59 100644 >>> --- a/xen/arch/x86/mm/mm-locks.h >>> +++

Re: [Xen-devel] [PATCH 1/6] xl: Do not ignore unparseable PCI BDFs

2015-07-07 Thread Andrew Cooper
On 07/07/15 17:13, Ian Jackson wrote: > If xlu_pci_parse_bdf fails, abandon the domain creation, rather than > blundering on. > > Signed-off-by: Ian Jackson > Acked-by: Ian Campbell > --- > tools/libxl/xl_cmdimpl.c |8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [Xen-devel] qemu tags for 4.4.3-rc1

2015-07-07 Thread Ian Jackson
Jan Beulich writes ("qemu tags for 4.4.3-rc1"): > considering how long pushes may take these days I'd rather cut RC1 > with what we have in the main tree now than push further things into > its staging branch. Could you therefore please tag the respective > qemu trees? Done. Ian. ___

Re: [Xen-devel] Mapping Dom0 page in hypervisor from domctl

2015-07-07 Thread Bread Cutter
Thank you very much, that seems to have fixed my problem. My new approach: guest_get_eff_l1e(current, domctl->va, &pte); page_info = l1e_get_page(pte); if ( ((l1e_get_flags(pte) & (_PAGE_PRESENT)) != _PAGE_PRESENT) ) { ret = -ENOMEM; break; } d->arch.hvm_domain.dom0_mapping.page_

Re: [Xen-devel] [PATCH v2 2/4] x86/pvh: Set 32b PVH guest mode in XEN_DOMCTL_set_address_size

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 17:53, wrote: > On 07/07/2015 05:15 AM, Jan Beulich wrote: > On 29.06.15 at 22:21, wrote: >>> @@ -6491,6 +6490,20 @@ enum hvm_intblk nhvm_interrupt_blocked(struct vcpu >>> *v) >>> return hvm_funcs.nhvm_intr_blocked(v); >>> } >>> >>> +int hvm_set_mode(struct vcpu

Re: [Xen-devel] [PATCH v8 0/9] pci: add pci_iomap_wc() and pci_ioremap_wc_bar()

2015-07-07 Thread Luis R. Rodriguez
On Fri, Jun 26, 2015 at 12:12:06PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2015-06-24 at 18:22 -0700, Luis R. Rodriguez wrote: > > Although I had test compiled this before just to be safe I went ahead and > > successfully test-compiled this set with allmodconfig, specially since I've > > no

Re: [Xen-devel] [PATCH v2 1/4] x86/compat: Test whether guest has 32b shinfo instead of being a PV 32b domain

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 17:46, wrote: > On 07/07/2015 05:11 AM, Jan Beulich wrote: > On 29.06.15 at 22:21, wrote: >>> @@ -737,7 +737,7 @@ int arch_set_info_guest( >>> >>> /* The context is a compat-mode one if the target domain is >>> compat-mode; >>>* we expect the tools to DTRT

[Xen-devel] [PATCH 5/6] xl: Use xasprintf for cpupoolnumsplit names

2015-07-07 Thread Ian Jackson
Otherwise we have to do complicated reasoning about the length that %d might produce. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c

[Xen-devel] [PATCH 1/6] xl: Do not ignore unparseable PCI BDFs

2015-07-07 Thread Ian Jackson
If xlu_pci_parse_bdf fails, abandon the domain creation, rather than blundering on. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c i

[Xen-devel] [PATCH 2/6] xl: Use ARRAY_EXTEND_INIT for vtpms and nics

2015-07-07 Thread Ian Jackson
This removes two open-coded reallocs. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 31d8260..6ea4e6b 100644 --- a/t

[Xen-devel] [PATCH 6/6] xl: Rewrite trim()

2015-07-07 Thread Ian Jackson
This function would produce a NULL output pointer if the input was an empty string, leading to a crash. I don't think this is likely to be a security problem, as the two call sites involve configuration options which callers are unlikely to expose to other-than-fully-trusted input. Also, the func

[Xen-devel] [PATCH 4/6] xl: Provide and use xvasprintf and xasprintf internally

2015-07-07 Thread Ian Jackson
Replace all calls to [v]asprintf with this new function. This removes a fair amount of bespoke error handling. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 96 +++--- 1 file changed, 48 insertions(+), 48 deletions(-)

[Xen-devel] [PATCH 3/6] xl: Provide and use ARRAY_EXTEND_INIT_NODEVID for disks, pcidevs and dtdevs

2015-07-07 Thread Ian Jackson
This replaces 3 sets of open-coded reallocs etc. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 6e

Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()

2015-07-07 Thread Jennifer Herbert
On 07/07/15 17:05, Ian Jackson wrote: Andrew Cooper writes ("Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()"): On 07/07/15 16:48, Jennifer Herbert wrote: +else +fprintf(lg-f, "[localtime_r failed: %d] ", errno); lg->f ? I didn

Re: [Xen-devel] [PATCH v3 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler

2015-07-07 Thread Chong Li
On Tue, Jul 7, 2015 at 10:16 AM, Dario Faggioli wrote: > On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote: > >> [Usage] >> With this patchset in use, xl sched-rtds tool can: >> >> 1) show the budget and period of each VCPU of each domain, by using "xl >> sched-rtds -v all" command. An example wo

Re: [Xen-devel] [PATCH v3 for Xen 4.6 1/4] xen: enable per-VCPU parameter settings for RTDS scheduler

2015-07-07 Thread Jan Beulich
>>> On 07.07.15 at 16:55, wrote: > So, Jan, just to be sure, do you mean (apart from the explicit padding) > something like this (attached, also)? > > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index bc45ea5..8210ecb 100644 > --- a/xen/include/public/domctl.h > +++ b

Re: [Xen-devel] [PATCH v2 1/2] Resize the MAX_NR_IO_RANGES for ioreq server

2015-07-07 Thread Yu, Zhang
On 7/7/2015 11:10 PM, Jan Beulich wrote: On 07.07.15 at 16:49, wrote: On 7/7/2015 10:43 PM, Jan Beulich wrote: On 07.07.15 at 16:30, wrote: I know that George and you have concerns about the differences between MMIO and guest page tables, but I do not quite understand why. :) But you rea

Re: [Xen-devel] Xen-unstable: pci-passthrough of device using MSI-X interrupts not working after commit x86/MSI: track host and guest masking separately

2015-07-07 Thread Jan Beulich
>>> On 26.06.15 at 17:48, wrote: > On 2015-06-26 17:22, Jan Beulich wrote: >> I have an idea: In >> >> static unsigned int startup_msi_irq(struct irq_desc *desc) >> { >> bool_t guest_masked = (desc->status & IRQ_GUEST) && >> is_hvm_domain(desc->msi_desc->dev->domain)

Re: [Xen-devel] [PATCH] blkif.h: document physical-device node

2015-07-07 Thread Ian Campbell
On Tue, 2015-07-07 at 16:48 +0100, Wei Liu wrote: > This node is used by toolstack (libxl, hotplug script) and blkback. > > Signed-off-by: Wei Liu > --- > Cc: Ian Campbell > Cc: Ian Jackson > Cc: Roger Pau Monne > Cc: David Vrabel > Cc: Konrad Rzeszutek Wilk > Cc: George Dunlap > > I notic

Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()

2015-07-07 Thread Jennifer Herbert
I guess I didn't build what I thought I built. V3 coming up On 07/07/15 16:51, Andrew Cooper wrote: On 07/07/15 16:48, Jennifer Herbert wrote: Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of t

Re: [Xen-devel] [PATCH 0/5] tools: 3 misc fixes/cleanups

2015-07-07 Thread Ian Campbell
On Tue, 2015-07-07 at 16:50 +0100, Wei Liu wrote: > On Tue, Jul 07, 2015 at 04:40:18PM +0100, Ian Campbell wrote: > > Here are five patches from my "split up libxenctrl" working branch > > (which clearly isn't going to make 4.6) which are independent fixes > > which could go into 4.6. > > > > You

  1   2   3   4   >