Re: [Xen-devel] [v7][PATCH 13/16] libxl: construct e820 map with RDM information for HVM guest

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 13:44 +0800, Chen, Tiejun wrote: On 2015/7/13 18:15, Ian Campbell wrote: On Mon, 2015-07-13 at 17:47 +0800, Chen, Tiejun wrote: This approach looks like it should work, and I think given the point in the release it would be acceptable for 4.6. However long term I

Re: [Xen-devel] [PATCH V3] libxl: Increase device model startup timeout to 1min.

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 07:17 +0100, Jan Beulich wrote: On 07.07.15 at 17:41, ian.campb...@citrix.com wrote: On Tue, 2015-07-07 at 16:14 +0100, Ian Jackson wrote: Anthony PERARD writes ([PATCH V3] libxl: Increase device model startup timeout to 1min.): On a busy host, QEMU may take more

Re: [Xen-devel] [v7][PATCH 13/16] libxl: construct e820 map with RDM information for HVM guest

2015-07-14 Thread Chen, Tiejun
However long term I think it might make sense to try and reuse one of the existing libxl__arch hooks, i.e. libxl__arch_domain_init_hw_description or libxl__arch_domain_finalise_hw_description. On ARM these are to do with setting the Device Tree Blob, which included the memory map, so it is

[Xen-devel] [xen-4.4-testing test] 59510: regressions - FAIL

2015-07-14 Thread osstest service owner
flight 59510 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59510/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-winxpsp3 15 guest-localmigrate/x10 fail REGR. vs. 59289 Regressions

[Xen-devel] how to locate the hypercall address in memory?

2015-07-14 Thread big strong
As syscalls can be located with the help of symbol files, is it possible to do it to hypercalls too? ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/9] libxl: fix libxl__abs_path

2015-07-14 Thread Ian Campbell
On Mon, 2015-07-13 at 18:12 +0100, Ian Jackson wrote: Ian Campbell writes (Re: [PATCH 1/9] libxl: fix libxl__abs_path): I rather dislike subjects of the form fix $function, since it gives very little clue to someone reading the shortlog what is going on. Yes. In this case I think

Re: [Xen-devel] [PATCH V3] libxl: Increase device model startup timeout to 1min.

2015-07-14 Thread Jan Beulich
On 07.07.15 at 17:41, ian.campb...@citrix.com wrote: On Tue, 2015-07-07 at 16:14 +0100, Ian Jackson wrote: Anthony PERARD writes ([PATCH V3] libxl: Increase device model startup timeout to 1min.): On a busy host, QEMU may take more than 10s to load and start. This is likely due to a

[Xen-devel] [xen-unstable test] 59509: regressions - FAIL

2015-07-14 Thread osstest service owner
flight 59509 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59509/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 14 guest-localmigrate.2 fail REGR. vs. 58958

Re: [Xen-devel] [PATCH v4 for Xen 4.6 0/4] Enable per-VCPU parameter settings for RTDS scheduler

2015-07-14 Thread Dario Faggioli
On Mon, 2015-07-13 at 22:45 -0700, Meng Xu wrote: Hi Dario, Hi, - not enough benchmarks/performance figures: I'd like to have the latency numbers, e.g., from cyclictest, we've spoke many times with Meng, give our official blessing at using it

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Ian Campbell
On Mon, 2015-07-13 at 18:24 +0100, Stefano Stabellini wrote: On Mon, 13 Jul 2015, Wei Liu wrote: On Fri, Jul 10, 2015 at 04:16:07PM +0530, Vijay Kilari wrote: Hi Wei, I would like to have freeze exception for ITS feature on ARM64. Design got freeze few weeks back and I have

Re: [Xen-devel] [v7][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr

2015-07-14 Thread Jan Beulich
On 14.07.15 at 03:42, tiejun.c...@intel.com wrote: +{ +printk(XENLOG_G_ERR VTDPREFIX +cannot assign %04x:%02x:%02x.%u +with shared RMRR for Dom%d.\n, + seg, bus, PCI_SLOT(devfn),

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Chen, Tiejun
Y Y [v7][PATCH 14/16] xen/vtd: enable USB device assignment Y Y [v7][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr And yet again for these two. Please avoid giving a false impression But these two patches really won Kevin's Ack,

Re: [Xen-devel] [v7][PATCH 06/16] hvmloader/pci: skip reserved ranges

2015-07-14 Thread Jan Beulich
On 14.07.15 at 08:39, tiejun.c...@intel.com wrote: -} *resource, mem_resource, high_mem_resource, io_resource; +} *resource, mem_resource, high_mem_resource, io_resource, exp_mem_resource; Despite having gone through description and the rest of the patch I can't seem to be able to

Re: [Xen-devel] Ping: [PATCH v6] dmar: device scope mem leak fix

2015-07-14 Thread Jan Beulich
On 13.07.15 at 20:10, elena.ufimts...@oracle.com wrote: On its way Jan! This wasn't a ping to you, but to the VT-d maintainers to finally ack this patch. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Vijay Kilari
On Tue, Jul 14, 2015 at 3:20 PM, Ian Campbell ian.campb...@citrix.com wrote: On Tue, 2015-07-14 at 14:54 +0530, Vijay Kilari wrote: I am trying to boot latest staging Xen branch on ThunderX with ITS patches. I face below issues with above [1] patch series 1) If pcie support only MSI, then

Re: [Xen-devel] [PATCH v10 0/5] iommu: add rmrr Xen command line option

2015-07-14 Thread Jan Beulich
On 13.07.15 at 20:17, elena.ufimts...@oracle.com wrote: From: Elena Ufimtseva elena.ufimts...@oracle.com Add Xen command line option rmrr to specify RMRR regions for devices that are not defined in ACPI thus causing IO Page

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-14 Thread Jan Beulich
On 14.07.15 at 02:01, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, July 13, 2015 1:01 AM On 10.07.15 at 23:48, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, July 09, 2015 6:30 AM On 01.07.15 at 20:09,

Re: [Xen-devel] [PATCH v2 0/3] arm64: Add multiboot support (via fdt) for Xen boot

2015-07-14 Thread Ian Campbell
On Mon, 2015-07-13 at 16:53 +0800, fu@linaro.org wrote: From: Fu Wei fu@linaro.org - This adds support for the Xen boot on ARM specification for arm64. I have used this to PXE boot Xen on a mustang board. My (handcrafted) grub.cfg was: set default=0 set timeout=5

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Wei Liu
On Tue, Jul 14, 2015 at 09:27:17AM +0800, Chen, Tiejun wrote: Please work with maintainers to get those hvmloader patches acked or reviewed. I will do. Note Jackson and Campbell also raised some comments to improve current codes. 2. explain why it needs to be in this release

Re: [Xen-devel] Requesting for freeze exception for VT-d posted-interrupts

2015-07-14 Thread Jan Beulich
On 14.07.15 at 11:21, wei.l...@citrix.com wrote: On Tue, Jul 14, 2015 at 05:51:02AM +, Wu, Feng wrote: Is it possible to get to 4.6 if making this feature default off? Note that I'm not the only one who makes the decision and I can't speak for maintainers. The first thing you ought to

Re: [Xen-devel] [PATCH v3 26/28] tools/libxl: Handle checkpoint records in a libxl migration v2 stream

2015-07-14 Thread Andrew Cooper
On 14/07/15 11:33, Yang Hongyang wrote: On 07/13/2015 08:01 PM, Andrew Cooper wrote: [...] domcreate_rebuild_done(egc, dcs, rc); @@ -966,6 +989,7 @@ static void domcreate_bootloader_done(libxl__egc *egc, } /* Restore */ +callbacks-checkpoint =

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Ian Jackson
Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Surely xfree() ought to have the same prototype as free() ? Why? If it were to be a full match, why wouldn't we call

Re: [Xen-devel] [v7][PATCH 06/16] hvmloader/pci: skip reserved ranges

2015-07-14 Thread Chen, Tiejun
Note here I don't address your comments above since I think we should achieve an agreement firstly. I think bitmap mechanism is a good idea but honestly, its not easy to cover all requirements here. And just like bootmem on Linux side, so its a little complicated to implement this entirely.

Re: [Xen-devel] [PATCH v4 11/15] x86/altp2m: define and implement alternate p2m HVMOP types.

2015-07-14 Thread Jan Beulich
On 14.07.15 at 01:39, ravi.sah...@intel.com wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, July 13, 2015 12:26 AM To: Sahita, Ravi Cc: Andrew Cooper; Wei Liu; George Dunlap; Ian Jackson; White, Edmund H; xen-devel@lists.xen.org;

Re: [Xen-devel] Requesting for freeze exception for VT-d posted-interrupts

2015-07-14 Thread Wei Liu
On Tue, Jul 14, 2015 at 05:51:02AM +, Wu, Feng wrote: -Original Message- From: Wei Liu [mailto:wei.l...@citrix.com] Sent: Monday, July 13, 2015 7:01 PM To: Wu, Feng Cc: wei.l...@citrix.com; xen-devel@lists.xen.org; Jan Beulich (jbeul...@suse.com);

Re: [Xen-devel] [v7][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-14 Thread Chen, Tiejun
On 2015/7/14 17:32, Jan Beulich wrote: On 14.07.15 at 07:22, tiejun.c...@intel.com wrote: +for ( i = 0; i memory_map.nr_map; i++ ) +{ +uint64_t end = e820[i].addr + e820[i].size; Either loop index/boundary or used array are wrong here: In the earlier loop you copied

Re: [Xen-devel] [PATCH v10 5/5] iommu: add rmrr Xen command line option for extra rmrrs

2015-07-14 Thread Jan Beulich
On 13.07.15 at 20:18, elena.ufimts...@oracle.com wrote: --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -867,6 +867,145 @@ out: return ret; } +#define MAX_EXTRA_RMRR_PAGES 16 +#define MAX_EXTRA_RMRR 10 + +/* RMRR units derived from command

Re: [Xen-devel] [PATCH V3] libxl: Increase device model startup timeout to 1min.

2015-07-14 Thread Dario Faggioli
On Tue, 2015-07-14 at 10:37 +0100, Ian Campbell wrote: On Tue, 2015-07-14 at 11:25 +0200, Dario Faggioli wrote: On Tue, 2015-07-14 at 08:55 +0100, Ian Campbell wrote: It'll be hard to say until this change gets through the Xen push gate and that version gets used for other branches

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-14 Thread Chen, Tiejun
The way this sort of thing is defined in the rest of domctl.h is like this: #define _XEN_DOMCTL_CDF_hvm_guest 0 #define XEN_DOMCTL_CDF_hvm_guest (1U_XEN_DOMCTL_CDF_hvm_guest) So the above should be #define _XEN_DOMCTL_DEV_RDM_RELAXED 0 #define XEN_DOMCTL_DEV_RDM_RELAXED

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Stefano Stabellini
On Tue, 14 Jul 2015, Ian Campbell wrote: On Mon, 2015-07-13 at 18:24 +0100, Stefano Stabellini wrote: On Mon, 13 Jul 2015, Wei Liu wrote: On Fri, Jul 10, 2015 at 04:16:07PM +0530, Vijay Kilari wrote: Hi Wei, I would like to have freeze exception for ITS feature on ARM64.

[Xen-devel] [PATCH v4 08/29] tools/libxl: Add save_helper_state pointers to libxl__xc_domain_{save, restore}()

2015-07-14 Thread Andrew Cooper
Currently, libxl__xc_domain_{save,restore}() have specific knowledge of where the libxl__save_helper_state lives inside a libxl__domain_{create,save}_state object. In later changes, the logical ownership of the libxl__save_helper_state will change and will no longer be d{c,s}s-shs. No functional

[Xen-devel] [PATCH v4 02/29] tools/libxc: Always compile the compat qemu variables into xc_sr_context

2015-07-14 Thread Andrew Cooper
This is safe (as the variables will simply be unused), and is required for correct compilation when midway through untangling the libxc/libxl interaction. The #define is left in place to highlight that the variables can be removed once the untangling is complete. Signed-off-by: Andrew Cooper

[Xen-devel] [PATCH v4 05/29] tools/libxl: Stash all restore parameters in domain_create_state

2015-07-14 Thread Andrew Cooper
Shortly more parameters will appear, and this saves unboxing each one. libxl_domain_restore_params is mandatory for restore streams, and ignored for plain creation. The old 'checkpointed_stream' was incorrectly identified as a private parameter when it was infact public. No functional change.

[Xen-devel] [PATCH v4 01/29] bsd-sys-queue-h-seddery: Massage `offsetof'

2015-07-14 Thread Andrew Cooper
From: Ian Jackson ian.jack...@eu.citrix.com For some reason BSD's queue.h uses `__offsetof'. It expects it to work just like offsetof. So use offsetof. Reported-by: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Ian Campbell

[Xen-devel] [ovmf test] 59511: all pass - PUSHED

2015-07-14 Thread osstest service owner
flight 59511 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/59511/ Perfect :-) All tests in this flight passed version targeted for testing: ovmf 2ad9cf37a492e69a4e1b7624d92d9a35fce083fc baseline version: ovmf

Re: [Xen-devel] [GIT-PULL OSSTEST] ap-fetch-version: Arrange for osstest merges from upstream to be stable

2015-07-14 Thread Ian Campbell
On Mon, 2015-07-13 at 18:03 +0100, Ian Jackson wrote: Ian Campbell writes ([GIT-PULL OSSTEST] ap-fetch-version: Arrange for osstest merges from upstream to be stable): ap-fetch-version: Arrange for osstest merges from upstream to be stable has now passed the Cambridge push gate and done a

Re: [Xen-devel] [PATCH V3 1/1] libxl: set stub domain size based on VRAM size

2015-07-14 Thread George Dunlap
On Sat, Jul 11, 2015 at 10:30 PM, Eric Shelton eshel...@pobox.com wrote: Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory condition for QEMU. Signed-off-by: Eric Shelton eshel...@pobox.com This seems

Re: [Xen-devel] [v7][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-14 Thread Jan Beulich
On 14.07.15 at 07:22, tiejun.c...@intel.com wrote: +for ( i = 0; i memory_map.nr_map; i++ ) +{ +uint64_t end = e820[i].addr + e820[i].size; Either loop index/boundary or used array are wrong here: In the earlier loop you copied memory_map[0...nr_map-1] to

[Xen-devel] [PATCH v4 27/29] tools/libxl: Handle checkpoint records in a libxl migration v2 stream

2015-07-14 Thread Andrew Cooper
This is the final bit of untangling for Remus. When libxc issues a checkpoint callback, start reading and buffering all libxl records from the stream. Once a CHECKPOINT_END record is encountered, start processing all records. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian

[Xen-devel] [PATCH v4 25/29] tools/libxl: Write checkpoint records into the stream

2015-07-14 Thread Andrew Cooper
when signalled to do so by libxl__remus_domain_checkpoint_callback() Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- v3: Corrections to comments This patch has

[Xen-devel] [PATCH v4 24/29] docs/libxl: Introduce CHECKPOINT_END to support migration v2 remus streams

2015-07-14 Thread Andrew Cooper
In a remus scenario, libxc will write a CHECKPOINT record, then hand ownership of the fd to libxl. Libxl then writes any records required and finishes with a CHECKPOINT_END record, then hands ownership of the fd back to libxc. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Vijay Kilari
Hi Ian, On Sat, Jul 11, 2015 at 12:06 PM, Julien Grall julien.gr...@citrix.com wrote: Hi, On 10/07/2015 17:52, Ian Campbell wrote: On Fri, 2015-07-10 at 12:01 +0100, Jan Beulich wrote: On 10.07.15 at 12:46, vijay.kil...@gmail.com wrote: I would like to have freeze exception for ITS

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 10:18 +0100, Jan Beulich wrote: Y Y [v7][PATCH 14/16] xen/vtd: enable USB device assignment diffstat: xen/drivers/passthrough/vtd/dmar.h | 1 - xen/drivers/passthrough/vtd/iommu.c | 11 ++- xen/drivers/passthrough/vtd/utils.c | 7 --- 3 files

[Xen-devel] [PATCH] sysctl: adjust XEN_SYSCTL_numainfo behavior

2015-07-14 Thread Jan Beulich
... to match XEN_SYSCTL_cputopoinfo, allowing the caller to get what it needs (if e.g. it's after the data for just one specific node) with just one hypercall, without caring about the total number of nodes in the system. Suggested-by: Boris Ostrovsky boris.ostrov...@oracle.com Signed-off-by: Jan

Re: [Xen-devel] [PATCH v5 15/15] tools/xen-access: altp2m testcases

2015-07-14 Thread Wei Liu
On Mon, Jul 13, 2015 at 05:15:03PM -0700, Ed White wrote: From: Tamas K Lengyel tleng...@novetta.com Working altp2m test-case. Extended the test tool to support singlestepping to better highlight the core feature of altp2m view switching. Signed-off-by: Tamas K Lengyel tleng...@novetta.com

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Jan Beulich
On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 07.07.15 at 12:07, andrew.coop...@citrix.com wrote: Just like free(), these functions are not performing a

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Vijay Kilari
On Sat, Jul 11, 2015 at 12:48 PM, Julien Grall julien.gr...@citrix.com wrote: Hi Ian, On 10/07/2015 18:07, Ian Campbell wrote: On Fri, 2015-07-10 at 16:16 +0530, Vijay Kilari wrote: I would like to have freeze exception for ITS feature on ARM64. Design got freeze few weeks back and I

Re: [Xen-devel] [PATCH V3 1/1] libxl: set stub domain size based on VRAM size

2015-07-14 Thread Eric Shelton
On Jul 14, 2015 4:51 AM, George Dunlap george.dun...@eu.citrix.com wrote: On Sat, Jul 11, 2015 at 10:30 PM, Eric Shelton eshel...@pobox.com wrote: Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory

Re: [Xen-devel] [PATCH V3 1/1] libxl: set stub domain size based on VRAM size

2015-07-14 Thread George Dunlap
On 07/14/2015 11:02 AM, Eric Shelton wrote: On Jul 14, 2015 4:51 AM, George Dunlap george.dun...@eu.citrix.com wrote: On Sat, Jul 11, 2015 at 10:30 PM, Eric Shelton eshel...@pobox.com wrote: Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to

Re: [Xen-devel] [PATCH V5 0/3] Vm_event memory introspection helpers

2015-07-14 Thread Jan Beulich
On 13.07.15 at 19:14, rcojoc...@bitdefender.com wrote: I've also moved x86 logic in patch 3/3 to x86 source files, this seems to have gone unnoticed but would likely have not compiled on ARM. Which leaves open whether this time you actually checked that ARM continues to build. Jan

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Jan Beulich
On 14.07.15 at 02:26, tiejun.c...@intel.com wrote: 1. clarify the state of patch series / feature. ReviewedAcked RMRR series v7 Y Y [v7][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map Y Y [v7][PATCH 02/16] xen/vtd: create RMRR mapping

Re: [Xen-devel] [PATCH] sysctl: adjust XEN_SYSCTL_cputopoinfo behavior

2015-07-14 Thread Jan Beulich
On 13.07.15 at 19:43, boris.ostrov...@oracle.com wrote: On 07/13/2015 11:53 AM, Jan Beulich wrote: The new function's implementation, other than the original one of XEN_SYSCTL_topologyinfo, didn't allow the caller to get what it needs (if e.g. it's after the data for just one specific CPU)

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote: +if [ x$machine != xaarch64 ]; then + multiboot_cmd=multiboot + module_cmd=module +else + multiboot_cmd=xen_hypervisor + module_cmd=xen_module +fi + Strictly speaking, this is boot-time decision. As mentioned by

Re: [Xen-devel] Requesting for freeze exception for ARM/ITS patches

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 14:54 +0530, Vijay Kilari wrote: I am trying to boot latest staging Xen branch on ThunderX with ITS patches. I face below issues with above [1] patch series 1) If pcie support only MSI, then INT mapping is not specified in DT. However the below code returns error

Re: [Xen-devel] [PATCH 1/9] libxl: fix libxl__abs_path

2015-07-14 Thread Ian Jackson
Ian Campbell writes (Re: [PATCH 1/9] libxl: fix libxl__abs_path): On Mon, 2015-07-13 at 18:12 +0100, Ian Jackson wrote: There are no call sites in libxl which can pass a NULL. I think that if we are to retain this feature, it ought to be documented, at least. Or add an assert if we

Re: [Xen-devel] Request a freeze exception for Libxl Migration v2 in 4.6

2015-07-14 Thread Ian Jackson
Andrew Cooper writes (Request a freeze exception for Libxl Migration v2 in 4.6): I would like to request a freeze exception for libxl migration v2. v3 of the series was posted this morning, and review seems to indicate that it is mostly on track. I hope to have v4 ready to post tomorrow,

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-14 Thread George Dunlap
On 07/13/2015 07:47 AM, Chen, Tiejun wrote: Thanks for this; a few more comments... Thanks for your time. @@ -1577,9 +1578,15 @@ int iommu_do_pci_domctl( seg = machine_sbdf 16; bus = PCI_BUS(machine_sbdf); devfn = PCI_DEVFN2(machine_sbdf); +flag =

[Xen-devel] [PATCH v4 03/29] tools/libxl: Introduce ROUNDUP()

2015-07-14 Thread Andrew Cooper
This is the same as is used by libxc. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxl/libxl_internal.h |3 +++ 1 file changed, 3 insertions(+) diff

[Xen-devel] [PATCH v4 09/29] tools/libxl: Fix libxl__carefd_opened() to be more useful with an invalid fd

2015-07-14 Thread Andrew Cooper
In the case that fd is -1, preserve errno and don't attempt to set CLOEXEC. Note that the implementation can still fail, as it ignores fcntl() errors and may not set CLOEXEC properly. Update the documentation accordingly until it is fixed. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com

[Xen-devel] [PATCH v4 07/29] tools/libxl: Extra management APIs for the save helper

2015-07-14 Thread Andrew Cooper
With migration v2, there are several moving parts needing to be juggled at once. This requires the error handling logic to be able to query the state of each moving part, possibly before they have been started, and be able to cancel them. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com

[Xen-devel] [PATCH v4 00/27] Libxl migration v2

2015-07-14 Thread Andrew Cooper
This series adds support for the libxl migration v2 stream, and untangles the existing layering violations of the toolstack and qemu records. It can be found on the branch libxl-migv2-v4 git://xenbits.xen.org/people/andrewcoop/xen.git http://xenbits.xen.org/git-http/people/andrewcoop/xen.git

[Xen-devel] [PATCH v4 06/29] tools/libxl: Split libxl__domain_create_state.restore_fd in two

2015-07-14 Thread Andrew Cooper
In a future patch, we shall support automatically converting a legacy stream to a v2 stream, in which case libxc needs to read from a different fd. Simply overwriting restore_fd does not work; the two fd's have different circumstances. The restore_fd needs to be returned to its original state

[Xen-devel] [PATCH v4 04/29] tools/libxl: Introduce libxl__kill()

2015-07-14 Thread Andrew Cooper
as a wrapper to kill(2), and use it in preference to sendsig in libxl_save_callout.c. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com --- v3: Fix typo, add

Re: [Xen-devel] [PATCH V3] libxl: Increase device model startup timeout to 1min.

2015-07-14 Thread Dario Faggioli
On Tue, 2015-07-14 at 08:55 +0100, Ian Campbell wrote: On Tue, 2015-07-14 at 07:17 +0100, Jan Beulich wrote: On 07.07.15 at 17:41, ian.campb...@citrix.com wrote: On Tue, 2015-07-07 at 16:14 +0100, Ian Jackson wrote: Anthony PERARD writes ([PATCH V3] libxl: Increase device model startup

Re: [Xen-devel] [PATCH V3] libxl: Increase device model startup timeout to 1min.

2015-07-14 Thread Ian Campbell
On Tue, 2015-07-14 at 11:25 +0200, Dario Faggioli wrote: On Tue, 2015-07-14 at 08:55 +0100, Ian Campbell wrote: On Tue, 2015-07-14 at 07:17 +0100, Jan Beulich wrote: On 07.07.15 at 17:41, ian.campb...@citrix.com wrote: On Tue, 2015-07-07 at 16:14 +0100, Ian Jackson wrote: Anthony

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Jan Beulich
On 14.07.15 at 11:25, ian.campb...@citrix.com wrote: On Tue, 2015-07-14 at 10:18 +0100, Jan Beulich wrote: YY [v7][PATCH 14/16] xen/vtd: enable USB device assignment diffstat: xen/drivers/passthrough/vtd/dmar.h | 1 - xen/drivers/passthrough/vtd/iommu.c | 11

Re: [Xen-devel] [PATCH v2 10/10] libxl: fix caller of libxl_cpupool functions

2015-07-14 Thread Dario Faggioli
On Mon, 2015-07-13 at 17:22 +0100, Wei Liu wrote: Coverity complains cpupool_info leaks a string in failure path. Instead of fixing that path, we rely on the callers (two public APIs at the moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in their failure path to dispose of any

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-14 Thread Jan Beulich
On 14.07.15 at 11:27, tiejun.c...@intel.com wrote: Y Y [v7][PATCH 14/16] xen/vtd: enable USB device assignment Y Y [v7][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr And yet again for these two. Please avoid giving a false impression

Re: [Xen-devel] [PATCH v3 26/28] tools/libxl: Handle checkpoint records in a libxl migration v2 stream

2015-07-14 Thread Yang Hongyang
On 07/13/2015 08:01 PM, Andrew Cooper wrote: [...] domcreate_rebuild_done(egc, dcs, rc); @@ -966,6 +989,7 @@ static void domcreate_bootloader_done(libxl__egc *egc, } /* Restore */ +callbacks-checkpoint = libxl__remus_domain_checkpoint_callback; This should be moved

Re: [Xen-devel] [v7][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-14 Thread Jan Beulich
On 14.07.15 at 12:22, tiejun.c...@intel.com wrote: On 2015/7/14 17:32, Jan Beulich wrote: On 14.07.15 at 07:22, tiejun.c...@intel.com wrote: +for ( i = 0; i memory_map.nr_map; i++ ) +{ +uint64_t end = e820[i].addr + e820[i].size; Either loop index/boundary or used array

[Xen-devel] [PATCH v4 12/29] tools/python: Libxc migration v2 infrastructure

2015-07-14 Thread Andrew Cooper
Contains: * Python implementation of the libxc migration v2 records * Verification code for spec compliance * Unit tests Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu

[Xen-devel] [PATCH v4 14/29] tools/python: Other migration infrastructure

2015-07-14 Thread Andrew Cooper
Contains: * Reverse-engineered notes of the legacy format from xg_save_restore.h * Python implementation of the legacy format * Public HVM Params used in the legacy stream * XL header format Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com

[Xen-devel] [PATCH v4 18/29] tools/libxl: Infrastructure for reading a libxl migration v2 stream

2015-07-14 Thread Andrew Cooper
From: Ross Lagerwall ross.lagerw...@citrix.com This contains the event machinery and state machines to read an act on a non-checkpointed migration v2 stream (with the exception of the xc_domain_restore() handling which is spliced later in a bisectable way). It also contains some boilerplate to

[Xen-devel] [PATCH v4 20/29] tools/libxl: Convert a legacy stream if needed

2015-07-14 Thread Andrew Cooper
For backwards compatibility, a legacy stream needs converting before it can be read by the v2 stream logic. This causes the v2 stream logic to need to juggle two parallel tasks. check_all_finished() is introduced for the purpose of joining the tasks in both success and error cases.

[Xen-devel] [PATCH v4 26/29] tools/libx{c, l}: Introduce restore_callbacks.checkpoint()

2015-07-14 Thread Andrew Cooper
And call it when a checkpoint record is found in the libxc stream. Some parts of this patch have been based on patches from the COLO series. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com Signed-off-by: Andrew Cooper andrew.coop...@citrix.com

[Xen-devel] [PATCH v4 19/29] tools/libxl: Infrastructure to convert a legacy stream

2015-07-14 Thread Andrew Cooper
Provide a thin wrapper around exec()ing the python conversion utility, and a stub implementation for cases where conversion is not wanted (i.e. not x86). One complication is that the caller of this interface needs to assume ownership of the output fd, to prevent it being closed while still in use

[Xen-devel] [PATCH v4 15/29] tools/python: Verification utility for v2 stream spec compliance

2015-07-14 Thread Andrew Cooper
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- This is exceedingly useful for development, but not of practical use being installed into a production dom0. ---

[Xen-devel] [PATCH v4 11/29] docs: Libxl migration v2 stream specification

2015-07-14 Thread Andrew Cooper
Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- v3: Spelling fixes --- docs/specs/libxl-migration-stream.pandoc | 205 ++ 1 file

[Xen-devel] [PATCH v4 29/29] tools/libxl: Drop all knowledge of toolstack callbacks

2015-07-14 Thread Andrew Cooper
Libxl has now been fully adjusted not to need them. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxl/libxl_dom.c|1 -

[Xen-devel] [PATCH v4 13/29] tools/python: Libxl migration v2 infrastructure

2015-07-14 Thread Andrew Cooper
Contains: * Python implementation of the libxl migration v2 records * Verification code for spec compliance * Unit tests Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-14 Thread George Dunlap
On 07/14/2015 11:53 AM, Chen, Tiejun wrote: The way this sort of thing is defined in the rest of domctl.h is like this: #define _XEN_DOMCTL_CDF_hvm_guest 0 #define XEN_DOMCTL_CDF_hvm_guest (1U_XEN_DOMCTL_CDF_hvm_guest) So the above should be #define _XEN_DOMCTL_DEV_RDM_RELAXED 0

Re: [Xen-devel] [PATCH V5 0/3] Vm_event memory introspection helpers

2015-07-14 Thread Jan Beulich
On 14.07.15 at 13:45, rcojoc...@bitdefender.com wrote: On 07/14/2015 01:50 PM, Jan Beulich wrote: On 13.07.15 at 19:14, rcojoc...@bitdefender.com wrote: I've also moved x86 logic in patch 3/3 to x86 source files, this seems to have gone unnoticed but would likely have not compiled on ARM.

Re: [Xen-devel] [PATCH v5 05/15] x86/altp2m: basic data structures and support routines.

2015-07-14 Thread Jan Beulich
On 14.07.15 at 02:14, edmund.h.wh...@intel.com wrote: +void +altp2m_vcpu_initialise(struct vcpu *v) +{ +if ( v != current ) +vcpu_pause(v); + +altp2m_vcpu_reset(v); +vcpu_altp2m(v).p2midx = 0; +atomic_inc(p2m_get_altp2m(v)-active_vcpus); + +

[Xen-devel] [PATCH v4 28/29] tools/libxc: Drop all XG_LIBXL_HVM_COMPAT code from libxc

2015-07-14 Thread Andrew Cooper
Libxl has now been fully adjusted not to need it. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson ian.jack...@eu.citrix.com CC: Wei Liu wei.l...@citrix.com --- tools/libxc/xc_sr_common.h |5 --

[Xen-devel] [PATCH v4 17/29] tools/libxl: Migration v2 stream format

2015-07-14 Thread Andrew Cooper
From: Ross Lagerwall ross.lagerw...@citrix.com C structures describing the Libxl migration v2 stream format Signed-off-by: Ross Lagerwall ross.lagerw...@citrix.com Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian Jackson

[Xen-devel] [PATCH v4 10/29] tools/xl: Mandatory flag indicating the format of the migration stream

2015-07-14 Thread Andrew Cooper
Introduced at this point so the python stream conversion code has a concrete ABI to use. Later when libxl itself starts supporting a v2 stream, it will be added to XL_MANDATORY_FLAG_ALL. Signed-off-by: Andrew Cooper andrew.coop...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Ian

[Xen-devel] [PATCH v4 23/29] tools/libxc+libxl+xl: Save v2 streams

2015-07-14 Thread Andrew Cooper
This is a complicated set of changes which must be done together for bisectability. * libxl-save-helper is updated to unconditionally use libxc migration v2. * libxl compatibility workarounds in libxc are disabled for save operations. * libxl__stream_write_start() is logically spliced into the

Re: [Xen-devel] [PATCH v3 03/13] VMX: implement suppress #VE.

2015-07-14 Thread George Dunlap
On 07/13/2015 08:40 AM, Jan Beulich wrote: On 10.07.15 at 21:30, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, July 09, 2015 6:01 AM On 01.07.15 at 20:09, edmund.h.wh...@intel.com wrote: @@ -232,6 +235,15 @@ static int ept_set_middle_entry(struct

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-14 Thread George Dunlap
On 07/14/2015 01:01 AM, Sahita, Ravi wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Monday, July 13, 2015 1:01 AM On 10.07.15 at 23:48, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, July 09, 2015 6:30 AM

Re: [Xen-devel] [PATCH v5 03/15] VMX: implement suppress #VE.

2015-07-14 Thread Jan Beulich
On 14.07.15 at 02:14, edmund.h.wh...@intel.com wrote: In preparation for selectively enabling #VE in a later patch, set suppress #VE on all EPTE's. Suppress #VE should always be the default condition for two reasons: it is generally not safe to deliver #VE into a guest unless that guest

Re: [Xen-devel] [PATCH] sysctl: adjust XEN_SYSCTL_numainfo behavior

2015-07-14 Thread Jan Beulich
On 14.07.15 at 14:43, andrew.coop...@citrix.com wrote: On 14/07/15 13:35, Dario Faggioli wrote: On Tue, 2015-07-14 at 10:52 +0100, Jan Beulich wrote: ... to match XEN_SYSCTL_cputopoinfo, allowing the caller to get what it needs (if e.g. it's after the data for just one specific node) with

Re: [Xen-devel] [v7][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-14 Thread George Dunlap
On 07/14/2015 12:45 PM, Jan Beulich wrote: On 14.07.15 at 13:30, george.dun...@eu.citrix.com wrote: On 07/14/2015 11:53 AM, Chen, Tiejun wrote: The way this sort of thing is defined in the rest of domctl.h is like this: #define _XEN_DOMCTL_CDF_hvm_guest 0 #define

[Xen-devel] [xen-unstable test] 59536: trouble: pass/preparing/running

2015-07-14 Thread osstest service owner
flight 59536 xen-unstable running [real] http://logs.test-lab.xenproject.org/osstest/logs/59536/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 2 hosts-allocate

Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t

2015-07-14 Thread Jan Beulich
On 14.07.15 at 12:54, ian.jack...@eu.citrix.com wrote: Jan Beulich writes (Re: [Xen-devel] [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t): On 13.07.15 at 18:56, ian.jack...@eu.citrix.com wrote: Surely xfree() ought to have the same prototype as free() ?

Re: [Xen-devel] how to locate the hypercall address in memory?

2015-07-14 Thread big strong
could you explain that in detail? As syscall tracing, we usually locate the kernel module first, then find the address of specific syscall function in that module with the help of symbol files. How could this be applied to hypercalls then? 2015-07-14 19:56 GMT+08:00 Jan Beulich jbeul...@suse.com:

Re: [Xen-devel] how to locate the hypercall address in memory?

2015-07-14 Thread Jan Beulich
On 14.07.15 at 13:59, fangtu...@gmail.com wrote: could you explain that in detail? As syscall tracing, we usually locate the kernel module first, then find the address of specific syscall function in that module with the help of symbol files. How could this be applied to hypercalls then?

Re: [Xen-devel] [PATCH v2 2/3] util/grub.d/20_linux_xen.in: Add arm64 support

2015-07-14 Thread Fu Wei
Hi Andrei, Great thanks for your review. So Are you suggesting this: (1) in util/grub.d/20_linux_xen.in, we only use xen_hypervisor/xen_module. (2) in xen_boot.c, we only register command xen_hypervisor/xen_module. (3) in grub-core/loader/i386/xen.c, we *add* ---

Re: [Xen-devel] [PATCH RFC 1 6/8] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-14 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: @@ -858,15 +863,20 @@ static void xen_pt_unregister_device(PCIDevice *d) machine_irq, errno); } } +s-machine_irq = 0; } /* delete all emulated config

Re: [Xen-devel] [xen-unstable test] 59509: regressions - FAIL

2015-07-14 Thread Jan Beulich
On 14.07.15 at 08:23, osstest-ad...@xenproject.org wrote: flight 59509 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59509/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run:

Re: [Xen-devel] [PATCH v5 15/15] tools/xen-access: altp2m testcases

2015-07-14 Thread Lengyel, Tamas
On Tue, Jul 14, 2015 at 5:56 AM, Wei Liu wei.l...@citrix.com wrote: On Mon, Jul 13, 2015 at 05:15:03PM -0700, Ed White wrote: From: Tamas K Lengyel tleng...@novetta.com Working altp2m test-case. Extended the test tool to support singlestepping to better highlight the core feature of

  1   2   3   >