Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Brandon Perez
On 07/21/2015 05:41 AM, Julien Grall wrote: On 21/07/2015 00:17, Brandon Perez wrote: Hello All, Hi Brandon, We use to send one mail by patch rather than sending them as an attachment of a single email. It's easier for reviewing the patches. You also need to add you Signed-off-by on each

Re: [Xen-devel] [PATCH OSSTEST v2 06/13] toolstack/libvirt: guest migrate, save and restore support

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:23:52PM +0100, Ian Campbell wrote: On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: Perhaps the libvirt part of the check_for_command stuff ought to be moved here? Otherwise we are claiming support before the code is actually willing to try to do so. I move this

Re: [Xen-devel] [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 12:03 +0100, Wei Liu wrote: On Mon, Jul 20, 2015 at 04:55:02PM +0200, Roger Pau Monne wrote: hotplugpath.sh by default is located in /usr/local/etc/xen/scripts on FreeBSD. Instead of hardcoding it's location use the XEN_SCRIPT_DIR variable like it's used on the

Re: [Xen-devel] [PATCH for-4.6 1/3] libxl: include sys/endian.h for FreeBSD

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:36 +0100, Wei Liu wrote: On Mon, Jul 20, 2015 at 04:55:00PM +0200, Roger Pau Monne wrote: be64toh and friends are declared in sys/endian.h on FreeBSD, so include it as part of libxl_osdeps.h. Signed-off-by: Roger Pau Monné roger@citrix.com Cc: Ian

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
Just to your example, libxl_domain_config cfg; cfg.stuff = blah; cfg.rdm.strategy = HOST; libxl_domain_create_new(cfg, domid); libxl_domain_destroy(domid); Here looks you mean d_config-rdms would be changed, right? Currently this shouldn't be allowed. But I think we need to

[Xen-devel] [PATCH v3 2/2] xen: sched/cpupool: properly update affinity when removing a cpu from a cpupool

2015-07-21 Thread Dario Faggioli
And this time, do it right. In fact, a similar change was attempted in 93be8285a79c6 (cpupools: update domU's node-affinity on the cpupool_unassign_cpu() path). But that was buggy, and got reverted with 8395b67ab0b8a86. However, even though reverting was the right thing to do, it remains true

[Xen-devel] [PATCH v3 1/2] xen: sched: reorganize cpu_disable_scheduler()

2015-07-21 Thread Dario Faggioli
The function is called both when we want to remove a cpu from a cpupool, and during cpu teardown, for suspend or shutdown. If, however, the boot cpu (cpu 0, most of the times) is not present in the default cpupool, during suspend or shutdown, Xen crashes like this: root@Zhaman:~# xl

Re: [Xen-devel] [PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 18:03 +0100, Ian Jackson wrote: Wei Liu writes ([PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init,dispose} in numa_place_domain): Call libxl_cpupoolinfo_init at the beginning. Change two returns to goto out so that libxl_cpupoolinfo_dispose is called in failure

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-21 Thread Ian Campbell
On Mon, 2015-07-20 at 13:32 +0100, Julien Grall wrote: Hi Chris, On 17/07/15 21:48, Chris (Christopher) Brand wrote: nr_mods is set in add_boot_module() to the number of module array elements used. This function also ensures that nr_mods never exceeds MAX_MODULES (the size of the array).

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:51 +0100, Ian Campbell wrote: On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: On 20/07/15 10:56, Wei Liu wrote: On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: And three

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): +static void +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) +{ +d_config-num_rdms++; +d_config-rdms =

Re: [Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 13:49 +0100, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:11:28AM +0100, Andrew Cooper wrote: On 20/07/15 10:56, Wei Liu wrote: On Fri, Jul 17, 2015 at 05:51:14PM +0100, Andrew Cooper wrote: And three improvements to debugging. Note that there is still a bug

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 23:09, Ian Jackson wrote: Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): +static void +add_rdm_entry(libxl__gc *gc, libxl_domain_config *d_config, + uint64_t rdm_start, uint64_t rdm_size, int rdm_policy) +{ +

[Xen-devel] [PATCH v3 0/2] xen: sched/cpupool: more fixing of (corner?) cases

2015-07-21 Thread Dario Faggioli
v2, which is here: http://lists.xen.org/archives/html/xen-devel/2015-07/msg03540.html suffered from a missing stg refresh issue (or, at least, that's my best guess). Thanks Juergen for noticing and pointing that out, and sorry for that. This posting should be fine. Regards, Dario --- Dario

Re: [Xen-devel] [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 17:22 +0100, Wei Liu wrote: On Mon, Jul 13, 2015 at 12:25:35PM +0100, Ian Campbell wrote: On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: We're interested in xlconfigtest. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust Fix segfaults from `xl psr-cat-cbm-set`...

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 15:36 +0100, Wei Liu wrote: On Tue, Jul 21, 2015 at 03:27:26PM +0100, Ian Jackson wrote: Ian Campbell writes (Re: [PATCH 1/5] xl: Command line: Adjust Fix segfaults from `xl psr-cat-cbm-set`...): On Fri, 2015-07-17 at 18:00 +0100, Ian Jackson wrote: Replying

[Xen-devel] [PATCH for-4.6 3/3] xen: remove non-POSIX error codes

2015-07-21 Thread Roger Pau Monne
Xen was using some non-POSIX error codes that are removed in this patch. For future reference, the list of POSIX error codes has been obtained from: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html The error codes already present and defined as optional (XSR), have been left

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Ian Jackson writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): Sorry, I just ignore the line in brackets since I always think this kind of thing is often not a big

Re: [Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Ian Campbell
On Tue, 2015-07-21 at 10:07 -0400, Brandon Perez wrote: I'm not sure that these patches are quite ready yet to be put into the Xen repo. That's ok, but even for an RFC (Request For Comments) please post them one patch per email in the manner of git send-email. You can use -

Re: [Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Jan Beulich
On 21.07.15 at 17:56, roger@citrix.com wrote: PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace them with EINVAL and EOVERFLOW respectively. Considering that we use EINVAL for almost everything (well beyond parameter checking I'm afraid), I don't think using this

Re: [Xen-devel] [PATCH OSSTEST v2 09/13] ts-debian-hvm-install: stub out libvirt + ovmf / rombios

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:27:30PM +0100, Ian Campbell wrote: On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: Libvirt's configuration converter doesn't know how to deal with BIOS selection. The end result is it always use the default one (seabios). Stub out ovmf and rombios to avoid false

Re: [Xen-devel] [PATCH OSSTEST v2 08/13] ts-libvirt-build: run libvirt test suite

2015-07-21 Thread Wei Liu
On Mon, Jul 13, 2015 at 12:25:35PM +0100, Ian Campbell wrote: On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: We're interested in xlconfigtest. Signed-off-by: Wei Liu wei.l...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com [...] +

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 23:57, Ian Jackson wrote: Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): Sorry, I just ignore the line in brackets since I always think this kind of thing is often not a big deal, and next time I should pay more attention to the ().

[Xen-devel] [xen-4.5-testing test] 59792: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59792 xen-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59792/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 6 xen-boot fail REGR. vs. 59527

Re: [Xen-devel] [PATCH v6 10/15] x86/altp2m: add remaining support routines.

2015-07-21 Thread Sahita, Ravi
From: George Dunlap [mailto:george.dun...@citrix.com] Sent: Tuesday, July 21, 2015 6:19 AM On 07/21/2015 12:58 AM, Ed White wrote: Add the remaining routines required to support enabling the alternate p2m functionality. Signed-off-by: Ed White edmund.h.wh...@intel.com Reviewed-by: Andrew

Re: [Xen-devel] [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb

2015-07-21 Thread Jan Beulich
Daniel Kiper daniel.ki...@oracle.com 07/21/15 8:23 PM On Tue, Jul 21, 2015 at 03:37:48AM -0600, Jan Beulich wrote: On 20.07.15 at 16:28, daniel.ki...@oracle.com wrote: ... because of ??? Nowadays - with X86_FEATURE_ERMS - rep stosb is expected to be faster than rep stosl. OK, I did not

Re: [Xen-devel] [PATCH] xen: arm: gic-v3: avoid \n in the middle of log messages

2015-07-21 Thread Ian Campbell
On Fri, 2015-07-17 at 15:10 +0100, Julien Grall wrote: Hi Ian, On 17/07/15 14:21, Ian Campbell wrote: These result in log messages such as: (XEN) d0v0: vGICD: RAZ on reserved register offset 0x0c (XEN) d0v0: vGICR: write r2 offset 0x000180 (XEN) not foundG3traps.c:2417:d0v0

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): [Ian Jackson:] That is, an address would be reserved if it was reserved in any of the rdm regions implied by the config. Are you saying this point? The union of two sets A and B is the set of

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): Indeed, I'm not a fan to Xen tools so I can't picture what this real scenario would happen. So if I'm misunderstanding what you mean, just please correct me. Or if you still think its hard to

[Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

2015-07-21 Thread Roger Pau Monne
PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace them with EINVAL and EOVERFLOW respectively. Signed-off-by: Roger Pau Monné roger@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Ian Campbell

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch - variables

2015-07-21 Thread Ian Jackson
Ian Campbell writes (Re: [PATCH OSSTEST v2 03/13] osstest migrate support check catch - variables): On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: @@ -300,7 +300,9 @@ proc run-job/test-pair {} { proc test-guest-migr {g} { -if {[catch { run-ts . = ts-migrate-support-check + host $g

Re: [Xen-devel] [PATCH OSSTEST v2 03/13] osstest migrate support check catch - variables

2015-07-21 Thread Ian Jackson
Wei Liu writes (Re: [PATCH OSSTEST v2 03/13] osstest migrate support check catch - variables): Do I need to change anything in this patch? I guess not? It's not very clear to me. Ian C was asking whether the patch (which I wrote) was right, in a particular respect. I answered that it is

Re: [Xen-devel] [PATCH v5 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Sahita, Ravi
From: George Dunlap [mailto:george.dun...@eu.citrix.com] Sent: Tuesday, July 14, 2015 8:57 AM On 07/14/2015 01:14 AM, Ed White wrote: Add the basic data structures needed to support alternate p2m's and the functions to initialise them and tear them down. Although Intel hardware can handle 512

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Daniel Kiper
On Tue, Jul 21, 2015 at 03:35:07AM -0600, Jan Beulich wrote: On 20.07.15 at 16:28, daniel.ki...@oracle.com wrote: Without any explanation (description) I'm inclined to say this makes things more fragile instead of improving the situation. As it looks like we indeed pointlessly copy

[Xen-devel] [v11][PATCH 02/16] xen/vtd: create RMRR mapping

2015-07-21 Thread Tiejun Chen
RMRR reserved regions must be setup in the pfn space with an identity mapping to reported mfn. However existing code has problem to setup correct mapping when VT-d shares EPT page table, so lead to problem when assigning devices (e.g GPU) with RMRR reported. So instead, this patch aims to setup

[Xen-devel] [v11][PATCH 10/16] tools: introduce some new parameters to set rdm policy

2015-07-21 Thread Tiejun Chen
This patch introduces user configurable parameters to specify RDM resource and according policies, Global RDM parameter: rdm = strategy=host,policy=strict/relaxed Per-device RDM parameter: pci = [ 'sbdf, rdm_policy=strict/relaxed' ] Global RDM parameter, strategy, allows user to specify

[Xen-devel] [v11][PATCH 04/16] xen: enable XENMEM_memory_map in hvm

2015-07-21 Thread Tiejun Chen
This patch enables XENMEM_memory_map in hvm. So hvmloader can use it to setup the e820 mappings. CC: Keir Fraser k...@xen.org CC: Jan Beulich jbeul...@suse.com CC: Andrew Cooper andrew.coop...@citrix.com Signed-off-by: Tiejun Chen tiejun.c...@intel.com Reviewed-by: Tim Deegan t...@xen.org

[Xen-devel] [v11][PATCH 00/16] Fix RMRR

2015-07-21 Thread Tiejun Chen
v11: * Rebase on staging * Patch #6: hvmloader/pci: Try to avoid placing BARs in RMRRs To find the lowest RMRR the _end_ of which is higher than base; Refine some code implementations; * Patch #7: hvmloader/e820: construct guest e820 table To check/sync memory_map.map[] before copy them

[Xen-devel] [v11][PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr

2015-07-21 Thread Tiejun Chen
Currently we're intending to cover this kind of devices with shared RMRR simply since the case of shared RMRR is a rare case according to our previous experiences. But late we can group these devices which shared rmrr, and then allow all devices within a group to be assigned to same domain. CC:

[Xen-devel] [v11][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread Tiejun Chen
Try to avoid placing PCI BARs over RMRRs: - If mmio_hole_size is not specified, and the existing MMIO range has RMRRs in it, and there is space to expand the hole in lowmem without moving more memory, then make the MMIO hole as large as possible. - When placing RMRRs, find the next RMRR

[Xen-devel] [v11][PATCH 05/16] hvmloader: get guest memory map into memory_map[]

2015-07-21 Thread Tiejun Chen
Now we get this map layout by call XENMEM_memory_map then save them into one global variable memory_map[]. It should include lowmem range, rdm range and highmem range. Note rdm range and highmem range may not exist in some cases. And here we need to check if any reserved memory conflicts with

[Xen-devel] [v11][PATCH 14/16] xen/vtd: enable USB device assignment

2015-07-21 Thread Tiejun Chen
USB RMRR may conflict with guest BIOS region. In such case, identity mapping setup is simply skipped in previous implementation. Now we can handle this scenario cleanly with new policy mechanism so previous hack code can be removed now. CC: Yang Zhang yang.z.zh...@intel.com CC: Kevin Tian

[Xen-devel] [v11][PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

2015-07-21 Thread Tiejun Chen
This patch extends the existing hypercall to support rdm reservation policy. We return error or just throw out a warning message depending on whether the policy is strict or relaxed when reserving RDM regions in pfn space. Note in some special cases, e.g. add a device to hwdomain, and remove a

[Xen-devel] [v11][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Tiejun Chen
While building a VM, HVM domain builder provides struct hvm_info_table{} to help hvmloader. Currently it includes two fields to construct guest e820 table by hvmloader, low_mem_pgend and high_mem_pgend. So we should check them to fix any conflict with RDM. RMRR can reside in address space beyond

[Xen-devel] [v11][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-21 Thread Tiejun Chen
Now use the hypervisor-supplied memory map to build our final e820 table: * Add regions for BIOS ranges and other special mappings not in the hypervisor map * Add in the hypervisor supplied regions * Adjust the lowmem and highmem regions if we've had to relocate memory (adding a highmem region

[Xen-devel] [v11][PATCH 09/16] tools: extend xc_assign_device() to support rdm reservation policy

2015-07-21 Thread Tiejun Chen
This patch passes rdm reservation policy to xc_assign_device() so the policy is checked when assigning devices to a VM. Note this also bring some fallout to python usage of xc_assign_device(). CC: Ian Jackson ian.jack...@eu.citrix.com CC: Stefano Stabellini stefano.stabell...@eu.citrix.com CC:

[Xen-devel] [v11][PATCH 01/16] xen: introduce XENMEM_reserved_device_memory_map

2015-07-21 Thread Tiejun Chen
From: Jan Beulich jbeul...@suse.com This is a prerequisite for punching holes into HVM and PVH guests' P2M to allow passing through devices that are associated with (on VT-d) RMRRs. CC: Jan Beulich jbeul...@suse.com CC: Yang Zhang yang.z.zh...@intel.com CC: Kevin Tian kevin.t...@intel.com

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 22/07/2015 01:28, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote:

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/22/2015 12:43 PM, Bob Liu wrote: On 07/21/2015 05:25 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote: On 07/21/2015 03:59 PM, Andy Lutomirski

[Xen-devel] [qemu-upstream-4.5-testing test] 59793: tolerable FAIL - PUSHED

2015-07-21 Thread osstest service owner
flight 59793 qemu-upstream-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59793/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stopfail REGR. vs. 58384

[Xen-devel] [xen-4.4-testing test] 59794: tolerable FAIL - PUSHED

2015-07-21 Thread osstest service owner
flight 59794 xen-4.4-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59794/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-winxpsp3 15 guest-localmigrate/x10 fail like 59510 test-amd64-i386-libvirt

[Xen-devel] [PATCH] x86/psr: remove invalid cpu_to_socket call

2015-07-21 Thread Chao Peng
cpu_to_socket() can't give correct socket value in CPU_PREPARE notifier as at that time phys_proc_id has not yet been initialized (the value is its default 0 in this case) which is incorrect for sockets other than socket 0. cos_to_cbm now is pre-allocated in CPU_PREPARE notifier and then consumed

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Jan Beulich
Daniel Kiper daniel.ki...@oracle.com 07/21/15 7:24 PM On Tue, Jul 21, 2015 at 03:35:07AM -0600, Jan Beulich wrote: On 20.07.15 at 16:28, daniel.ki...@oracle.com wrote: Without any explanation (description) I'm inclined to say this makes things more fragile instead of improving the

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 5:49 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:28, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Boris Ostrovsky
On 07/21/2015 08:49 PM, Andrew Cooper wrote: On 22/07/2015 01:28, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper andrew.coop...@citrix.com

Re: [Xen-devel] [PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/21/2015 05:25 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob

Re: [Xen-devel] PCI Pass-through in Xen ARM - Draft 2.

2015-07-21 Thread Manish Jaggi
On Tuesday 14 July 2015 11:31 PM, Stefano Stabellini wrote: On Tue, 14 Jul 2015, Julien Grall wrote: Hi Stefano, On 14/07/2015 18:46, Stefano Stabellini wrote: Linux provides a function (pci_for_each_dma_alias) which will return a requester ID for a given PCI device. It appears that the BDF

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 7:04 PM, Boris Ostrovsky boris.ostrov...@oracle.com wrote: On 07/21/2015 08:49 PM, Andrew Cooper wrote: On 22/07/2015 01:28, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 5:21 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 22/07/2015 01:07, Andy Lutomirski

[Xen-devel] [xen-unstable test] 59795: tolerable FAIL

2015-07-21 Thread osstest service owner
flight 59795 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59795/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail in 59772 pass in 59795

Re: [Xen-devel] [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Sahita, Ravi
From: George Dunlap [mailto:george.dun...@citrix.com] Sent: Tuesday, July 21, 2015 5:47 AM On 07/21/2015 11:13 AM, Jan Beulich wrote: On 21.07.15 at 01:58, edmund.h.wh...@intel.com wrote: Add the basic data structures needed to support alternate p2m's and the functions to initialise them and

[Xen-devel] [linux-linus test] 59789: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59789 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/59789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 5 kernel-build fail REGR. vs. 59254 build-amd64-pvops

Re: [Xen-devel] [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb

2015-07-21 Thread Daniel Kiper
On Tue, Jul 21, 2015 at 03:37:48AM -0600, Jan Beulich wrote: On 20.07.15 at 16:28, daniel.ki...@oracle.com wrote: ... because of ??? Nowadays - with X86_FEATURE_ERMS - rep stosb is expected to be faster than rep stosl. OK, I did not know about that. However, as I know this feature was

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-21 Thread Boris Ostrovsky
On 07/20/2015 10:43 AM, Boris Ostrovsky wrote: On 07/20/2015 10:09 AM, Dario Faggioli wrote: On Fri, 2015-07-17 at 14:17 -0400, Boris Ostrovsky wrote: On 07/17/2015 03:27 AM, Dario Faggioli wrote: In the meanwhile, what should we do? Document this? How? don't use vNUMA with PV guest in SMT

[Xen-devel] altp2m: patch 07/15 and 11/15

2015-07-21 Thread Sahita, Ravi
Hi maintainers, While we are sorting through the last 2 to 3 patches that have the main open comments (patch 5,6,10/15), could you please ack patch 07/15 and 11/15 if you are ok with it - all previous comments on those have been addressed (this will allow us to focus on remaining opens). Sorry

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Boris Ostrovsky
On 07/21/2015 03:59 PM, Andy Lutomirski wrote: modify_ldt has questionable locking and does not synchronize threads. Improve it: redesign the locking and synchronize all threads' LDTs using an IPI on all modifications. This will dramatically slow down modify_ldt in multithreaded programs, but

[Xen-devel] [linux-3.18 test] 59785: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59785 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581 Tests which are

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 22/07/2015 01:07, Andy Lutomirski wrote: On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote: On 07/21/2015 03:59 PM, Andy Lutomirski wrote: --- a/arch/x86/include/asm/mmu_context.h +++

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andrew Cooper
On 21/07/2015 22:53, Boris Ostrovsky wrote: On 07/21/2015 03:59 PM, Andy Lutomirski wrote: --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @@ -34,6 +34,44 @@ static inline void load_mm_cr4(struct mm_struct *mm) {} #endif /* + * ldt_structs can be

Re: [Xen-devel] [PATCH v2 1/3] x86/ldt: Make modify_ldt synchronous

2015-07-21 Thread Andy Lutomirski
On Tue, Jul 21, 2015 at 4:38 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 21/07/2015 22:53, Boris Ostrovsky wrote: On 07/21/2015 03:59 PM, Andy Lutomirski wrote: --- a/arch/x86/include/asm/mmu_context.h +++ b/arch/x86/include/asm/mmu_context.h @@ -34,6 +34,44 @@ static inline void

Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Olaf Hering
On Mon, Jun 01, Jan Beulich wrote: On 01.06.15 at 15:56, ian.campb...@citrix.com wrote: On Mon, 2015-06-01 at 14:50 +0100, Jan Beulich wrote: It's being removed in Linux 4.1. Signed-off-by: Jan Beulich jbeul...@suse.com Not sure who should, but: I guess no-one really needs to

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-21 Thread Jan Beulich
On 21.07.15 at 09:23, kevin.t...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Tuesday, July 21, 2015 3:17 PM On 21.07.15 at 09:05, kevin.t...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Tuesday, July 21, 2015 2:57 PM On 21.07.15 at

[Xen-devel] [Xen-Devel] Enabling IRQ Crossbar (Secondary Interrupt Controller) Support

2015-07-21 Thread Brandon Perez
Hello All, You can find the relevant thread that outlines the issue at [1]. In short, the issue is as follows. On the TI DRA72 chip, there is a piece of hardware called the IRQ crossbar. Due to the large number of peripheral devices, not all devices can fit onto the SPI lines on the

Re: [Xen-devel] [v10][PATCH 06/16] hvmloader/pci: Try to avoid placing BARs in RMRRs

2015-07-21 Thread Jan Beulich
On 21.07.15 at 02:53, tiejun.c...@intel.com wrote: Okay, I regenerate this patch online. And I just hope its good to be acked here: Provided it also works, Reviewed-by: Jan Beulich jbeul...@suse.com Why is this marked as Acked-by this time? The same question is raised to another

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
On Mon, Jul 20, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above array bounds [-Werror=array-bounds] [

Re: [Xen-devel] [PATCH] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Jan Beulich
On 21.07.15 at 08:32, o...@aepfle.de wrote: On Mon, Jul 20, Wei Liu wrote: On Mon, Jul 20, 2015 at 11:16:34AM +0200, Olaf Hering wrote: On Mon, Jul 20, Jan Beulich wrote: On 19.07.15 at 11:33, o...@aepfle.de wrote: [ 198s] block-log.c:549:23: error: array subscript is above

Re: [Xen-devel] [PATCH v2 05/20] block/xen-blkfront: Split blkif_queue_request in 2

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: Currently, blkif_queue_request has 2 distinct execution path: - Send a discard request - Send a read/write request The function is also allocating grants to use for generating the request. Although, this is only used for read/write

Re: [Xen-devel] [PATCH v6 01/15] common/domain: Helpers to pause a domain while in context

2015-07-21 Thread George Dunlap
On Tue, Jul 21, 2015 at 12:57 AM, Ed White edmund.h.wh...@intel.com wrote: From: Andrew Cooper andrew.coop...@citrix.com For use on codepaths which would need to use domain_pause() but might be in the target domain's context. In the case that the target domain is in context, all other vcpus

Re: [Xen-devel] [PATCH v6 05/15] x86/altp2m: basic data structures and support routines.

2015-07-21 Thread Jan Beulich
On 21.07.15 at 01:58, edmund.h.wh...@intel.com wrote: Add the basic data structures needed to support alternate p2m's and the functions to initialise them and tear them down. Although Intel hardware can handle 512 EPTP's per hardware thread concurrently, only 10 per domain are supported in

Re: [Xen-devel] [PATCH v2 06/20] block/xen-blkfront: Store a page rather a pfn in the grant structure

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: All the usage of the field pfn are done using the same idiom: pfn_to_page(grant-pfn) This will return always the same page. Store directly the page in the grant to clean up the code. Signed-off-by: Julien Grall julien.gr...@citrix.com

[Xen-devel] [linux-3.4 test] 59771: regressions - FAIL

2015-07-21 Thread osstest service owner
flight 59771 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59771/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 30511 Tests which are

Re: [Xen-devel] [PATCH v2 07/20] block/xen-blkfront: split get_grant in 2

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: Prepare the code to support 64KB page granularity. The first implementation will use a full Linux page per indirect and persistent grant. When non-persistent grant is used, each page of a bio request may be split in multiple grant.

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
I wrote: If the domain configuration has rdms and num_rdms already set, then the strategy should presumably be ignored. (Passing the same domain configuration struct to libxl_domain_create_new, after destroying the domain, ought to work, even after the first call has modified it.) But even

Re: [Xen-devel] [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-21 Thread Bob Liu
On 07/21/2015 05:13 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu bob@oracle.com ---

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
I hope the following can address all comments below: diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 2f8e590..a4bd2a1 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -407,7 +407,7 @@ int libxl__domain_build(libxl__gc *gc, switch

Re: [Xen-devel] [PATCH v5 10/15] x86/altp2m: add remaining support routines.

2015-07-21 Thread Jan Beulich
On 21.07.15 at 07:46, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Sunday, July 19, 2015 11:53 PM On 18.07.15 at 00:32, ravi.sah...@intel.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, July 16, 2015 2:34 AM On 16.07.15 at 11:16,

Re: [Xen-devel] [PATCH] unmodified-drivers: tolerate IRQF_DISABLED being undefined

2015-07-21 Thread Olaf Hering
On Tue, Jul 21, Jan Beulich wrote: Taking it to mean all maintained, that's possible, but since I can't immediately see the point I'd like to ask for some justification. Us - SUSE - apparently being the only consumer of that code, and us not using Xen 4.4 together with Linux 4.1, and our 4.5

Re: [Xen-devel] [PATCH for-4.6 3/3] hotplug/FreeBSD: fix xendriverdomain rc.d script

2015-07-21 Thread Wei Liu
On Mon, Jul 20, 2015 at 04:55:02PM +0200, Roger Pau Monne wrote: hotplugpath.sh by default is located in /usr/local/etc/xen/scripts on FreeBSD. Instead of hardcoding it's location use the XEN_SCRIPT_DIR variable like it's used on the xencommons rc.d script. Signed-off-by: Roger Pau Monné

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): I would add this check at the beginning of this function: assert(!d_config-num_rdms !d_config-rdms). As Ian Campbell and I have explained, that is not OK. The caller may choose to pass both some

Re: [Xen-devel] [PATCH v2 05/20] block/xen-blkfront: Split blkif_queue_request in 2

2015-07-21 Thread Julien Grall
Hi Roger, On 21/07/15 10:54, Roger Pau Monné wrote: El 09/07/15 a les 22.42, Julien Grall ha escrit: Currently, blkif_queue_request has 2 distinct execution path: - Send a discard request - Send a read/write request The function is also allocating grants to use for generating the

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
The domain destroy would not change cfg at all. Okay. If not, I should double check this duplication so what about a return in the case of duplicating one entry? What I am looking for is a *decision* about what the right behaviour is, backed up by a *rationale*. The most obvious answer

Re: [Xen-devel] [PATCH v2 15/20] block/xen-blkfront: Make it running on 64KB page granularity

2015-07-21 Thread Roger Pau Monné
El 09/07/15 a les 22.42, Julien Grall ha escrit: From: Julien Grall julien.gr...@linaro.org The PV block protocol is using 4KB page granularity. The goal of this patch is to allow a Linux using 64KB page granularity using block device on a non-modified Xen. The block API is using segment

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 19:11, Ian Jackson wrote: Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): I would add this check at the beginning of this function: assert(!d_config-num_rdms !d_config-rdms). As Ian Campbell and I have explained, that is not OK.

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Ian Jackson
Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): On 2015/7/21 19:11, Ian Jackson wrote: The most obvious case is something like the following code libxl_domain_config cfg; cfg.stuff = blah; cfg.rdm.strategy = HOST;

Re: [Xen-devel] [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values

2015-07-21 Thread Ian Jackson
Roger Pau Monne writes ([PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values): We cannot use the systems errno values when checking return values from Xen, because some OSes don't have the same set of errno definitions. Instead use the definitions present in

Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

2015-07-21 Thread Chen, Tiejun
On 2015/7/21 19:11, Ian Jackson wrote: Chen, Tiejun writes (Re: [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM): I would add this check at the beginning of this function: assert(!d_config-num_rdms !d_config-rdms). As Ian Campbell and I have explained, that is not OK.

[Xen-devel] [PATCH v2] blktap2: update connection handling to fix build with gcc5

2015-07-21 Thread Olaf Hering
blktap2 fails to build with gcc5 because it fails to recognize that there can be just one active connection (enforced in ctl_accept). Add a hack to use MAX_CONNECTIONS instead of ARRAY_SIZE: gives a smaller patch, and the code does not handle holes in connections[] anyway. [ 198s] block-log.c:

Re: [Xen-devel] [PATCH v2 0/6] add xsaves/xrstors support

2015-07-21 Thread Ruan, Shuai
Hi Andrew: Thanks for your review. In V2 , I have test migrate VM between two different servers, one which is xsaves capable and one which is not. There is 2 bugs related with my code in migrating between two servers( in v1 I just test migrate using localhost) and I fix it by add change the

[Xen-devel] [qemu-upstream-4.5-testing test] 59774: regressions - trouble: broken/fail/pass

2015-07-21 Thread osstest service owner
flight 59774 qemu-upstream-4.5-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/59774/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 3 host-install(3) broken REGR. vs. 58413

Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

2015-07-21 Thread Jan Beulich
On 20.07.15 at 16:28, daniel.ki...@oracle.com wrote: Without any explanation (description) I'm inclined to say this makes things more fragile instead of improving the situation. As it looks like we indeed pointlessly copy .eh_frame, but I think this would better be avoided by suppressing its

  1   2   >