Re: [Xen-devel] [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure

2017-10-16 Thread Josh Poimboeuf
On Mon, Oct 16, 2017 at 02:18:48PM -0400, Boris Ostrovsky wrote: > On 10/12/2017 03:53 PM, Boris Ostrovsky wrote: > > On 10/12/2017 03:27 PM, Andrew Cooper wrote: > >> On 12/10/17 20:11, Boris Ostrovsky wrote: > >>> There is also another problem: > >>> > >>> [1.312425] general protection

[Xen-devel] [xen-4.8-testing baseline-only test] 72248: regressions - trouble: blocked/broken/fail/pass

2017-10-16 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72248 xen-4.8-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72248/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-intel 13

Re: [Xen-devel] [PATCH v9 08/16] x86: implement set value flow for MBA

2017-10-16 Thread Yi Sun
I forgot to add 'Reviewed-by' provided by Jan. So please ignore this but refer v9.1. Thanks! On 17-10-17 09:04:18, Yi Sun wrote: > This patch implements set value flow for MBA including its callback > function and domctl interface. > > Signed-off-by: Yi Sun

[Xen-devel] [PATCH v9.1 08/16] x86: implement set value flow for MBA

2017-10-16 Thread Yi Sun
This patch implements set value flow for MBA including its callback function and domctl interface. Signed-off-by: Yi Sun Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu

[Xen-devel] [PATCH v9 08/16] x86: implement set value flow for MBA

2017-10-16 Thread Yi Sun
This patch implements set value flow for MBA including its callback function and domctl interface. Signed-off-by: Yi Sun --- CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: Roger Pau Monné

Re: [Xen-devel] [PATCH v8 08/16] x86: implement set value flow for MBA

2017-10-16 Thread Yi Sun
On 17-10-16 06:49:49, Jan Beulich wrote: > >>> On 16.10.17 at 05:04, wrote: > > This patch implements set value flow for MBA including its callback > > function and domctl interface. > > > > Signed-off-by: Yi Sun > > Reviewed-by: Jan Beulich

[Xen-devel] [PATCH 54/58] net/xen-netback: Convert timers to use timer_setup()

2017-10-16 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Wei Liu Cc: Paul Durrant Cc:

[Xen-devel] [xen-4.9-testing test] 114543: tolerable FAIL - PUSHED

2017-10-16 Thread osstest service owner
flight 114543 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/114543/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-win7-amd64 14 guest-localmigrate fail in 114533 pass in 114543

[Xen-devel] [xen-unstable test] 114540: regressions - FAIL

2017-10-16 Thread osstest service owner
flight 114540 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/114540/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumprun 8 xen-buildfail REGR. vs. 114204

Re: [Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread David Miller
From: Boris Ostrovsky Date: Mon, 16 Oct 2017 16:19:07 -0400 > On 10/16/2017 11:05 AM, Wei Liu wrote: >> On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: >>> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} >>> drivers use a minimum

Re: [Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Boris Ostrovsky
On 10/16/2017 11:05 AM, Wei Liu wrote: > On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: >> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} >> drivers use a minimum value of 0. >> >> When set MTU to 0~67 with xen_net{front|back} driver, the network >> will

Re: [Xen-devel] [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure

2017-10-16 Thread Boris Ostrovsky
On 10/12/2017 03:53 PM, Boris Ostrovsky wrote: > On 10/12/2017 03:27 PM, Andrew Cooper wrote: >> On 12/10/17 20:11, Boris Ostrovsky wrote: >>> There is also another problem: >>> >>> [1.312425] general protection fault: [#1] SMP >>> [1.312901] Modules linked in: >>> [1.313389] CPU:

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Stefano Stabellini
On Mon, 16 Oct 2017, Andrew Cooper wrote: > * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >all state is actually set up. As it currently stands, d0v0 is eligible for >scheduling before its registers have been set. This is latent as we also >hold a

[Xen-devel] [PATCH v7] x86/altp2m: Added xc_altp2m_set_mem_access_multi()

2017-10-16 Thread Petre Pircalabu
From: Razvan Cojocaru For the default EPT view we have xc_set_mem_access_multi(), which is able to set an array of pages to an array of access rights with a single hypercall. However, this functionality was lacking for the altp2m subsystem, which could only set page

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > On 16/10/17 15:56, Ian Jackson wrote: > > We are very soon going to want "NN2" and maybe "NN_1_2". > > The hypervisor uses > > #define __nonnull(...)

Re: [Xen-devel] [PATCH for-next] xen/pv: Construct d0v0's GDT properly

2017-10-16 Thread Andrew Cooper
On 16/10/17 16:58, Jan Beulich wrote: On 16.10.17 at 16:38, wrote: >> c/s cf6d39f8199 "x86/PV: properly populate descriptor tables" changed the GDT >> to reference zero_page for intermediate frames between the guest and Xen >> frames. >> >> Because

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails"): > IMO, the toolstack should not be making assumptions about the initrd, > and shouldn't be touching it. It is the users responsibility to provide > an initrd which its kernel can read.

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Andrew Cooper
On 16/10/17 15:56, Ian Jackson wrote: > Wei Liu writes ("[PATCH for-4.10] libxl: annotate s to be nonnull in > libxl__enum_from_string"): >> Hope this can placate coverity. > Acked-by: Ian Jackson > > We are very soon going to want "NN2" and maybe "NN_1_2". The

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH] libxc: don't fail domain creation when unpacking initrd fails"): > On 16.10.17 at 17:45, wrote: > > Is there no way to tell that a kernel supports gzipped initrds by > > looking at the kernel ? > > Well, Linux kernels have config

Re: [Xen-devel] [xen-4.8-testing test] 114505: regressions - FAIL

2017-10-16 Thread Andrew Cooper
On 16/10/17 16:16, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [xen-4.8-testing test] 114505: > regressions - FAIL"): >> On 15/10/17 20:45, osstest service owner wrote: >>> flight 114505 xen-4.8-testing real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/114505/ >>>

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Andrew Cooper
On 16/10/17 17:19, Jan Beulich wrote: On 16.10.17 at 17:45, wrote: >> Jan Beulich writes ("[PATCH] libxc: don't fail domain creation when >> unpacking >> initrd fails"): >>> At least Linux kernels have been able to work with gzip-ed initrd for >>> quite some

[Xen-devel] [xen-unstable-smoke test] 114547: tolerable all pass - PUSHED

2017-10-16 Thread osstest service owner
flight 114547 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/114547/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [Xen-devel] [xen-4.8-testing test] 114505: regressions - FAIL

2017-10-16 Thread Andrew Cooper
On 16/10/17 17:12, Jan Beulich wrote: On 16.10.17 at 11:14, wrote: >> On 15/10/17 20:45, osstest service owner wrote: >>> flight 114505 xen-4.8-testing real [real] >>> http://logs.test-lab.xenproject.org/osstest/logs/114505/ >>> >>> Regressions :-( >>> >>> Tests

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 04:07:32PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() > to not pass a structure by value"): > > On Mon, Oct 16, 2017 at 02:51:54PM +0100, Andrew Cooper wrote: > ... > > > With Joshua's patch in place, the

Re: [Xen-devel] [PATCH v2] x86/hvm: Add MSR old value

2017-10-16 Thread Wei Liu
On Fri, Oct 13, 2017 at 03:50:57PM +0300, Alexandru Isaila wrote: > This patch adds the old value param and the onchangeonly option > to the VM_EVENT_REASON_MOV_TO_MSR event. > > The param was added to the vm_event_mov_to_msr struct and to the > hvm_monitor_msr function. Finally I've changed the

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Andrew Cooper
On 16/10/17 16:51, Roger Pau Monné wrote: > On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: >> * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >>all state is actually set up. As it currently stands, d0v0 is eligible >> for >>scheduling before

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 18:07, wrote: > On 16/10/17 16:41, Jan Beulich wrote: >> >>> On 16.10.17 at 16:38, wrote: >>> --- a/xen/arch/x86/hvm/dom0_build.c >>> +++ b/xen/arch/x86/hvm/dom0_build.c >>> @@ -614,6 +614,7 @@ static int __init

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 17:45, wrote: > Jan Beulich writes ("[PATCH] libxc: don't fail domain creation when unpacking > initrd fails"): >> At least Linux kernels have been able to work with gzip-ed initrd for >> quite some time; initrd compressed with other methods aren't

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Andrew Cooper
On 16/10/17 16:39, Jan Beulich wrote: On 16.10.17 at 16:49, wrote: >> On 16/10/17 15:44, Wei Liu wrote: >>> On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until all

Re: [Xen-devel] [xen-4.8-testing test] 114505: regressions - FAIL

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 11:14, wrote: > On 15/10/17 20:45, osstest service owner wrote: >> flight 114505 xen-4.8-testing real [real] >> http://logs.test-lab.xenproject.org/osstest/logs/114505/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >>

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Andrew Cooper
On 16/10/17 16:41, Jan Beulich wrote: > >>> On 16.10.17 at 16:38, wrote: >> --- a/xen/arch/x86/hvm/dom0_build.c >> +++ b/xen/arch/x86/hvm/dom0_build.c >> @@ -614,6 +614,7 @@ static int __init pvh_setup_cpus(struct domain *d, >> paddr_t entry, >> >>

Re: [Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Ian Jackson
Jan Beulich writes ("[PATCH] libxc: don't fail domain creation when unpacking initrd fails"): > At least Linux kernels have been able to work with gzip-ed initrd for > quite some time; initrd compressed with other methods aren't even being > attempted to unpack. Furthermore the unzip-ing routine

Re: [Xen-devel] [PATCH for-next 1/3] x86/smp: Rework cpu_smpboot_alloc() to cope with more than just -ENOMEM

2017-10-16 Thread Wei Liu
On Mon, Oct 02, 2017 at 05:13:47PM +0100, Andrew Cooper wrote: > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-16 Thread Wei Liu
On Thu, Oct 12, 2017 at 12:10:25PM +0300, Alexandru Isaila wrote: > This patch adds the old value param and the onchangeonly option > to the VM_EVENT_REASON_MOV_TO_MSR event. > > The param was added to the vm_event_mov_to_msr struct and to the > hvm_monitor_msr function. Finally I've changed the

Re: [Xen-devel] [PATCH for-next] xen/pv: Construct d0v0's GDT properly

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 16:38, wrote: > c/s cf6d39f8199 "x86/PV: properly populate descriptor tables" changed the GDT > to reference zero_page for intermediate frames between the guest and Xen > frames. > > Because dom0_construct_pv() doesn't call arch_set_info_guest(),

Re: [Xen-devel] libxl/xenconsole: vpl011: Fix hex to dec conversion of vuart_gfn in libxl__device_vuart_add

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 17:47, wrote: > On 16 October 2017 at 15:53, Jan Beulich wrote: > On 16.10.17 at 11:02, wrote: >>> static int console_create_ring(struct console *con) >>> { >>> - int err, remote_port,

Re: [Xen-devel] [PATCH v11 06/11] x86/hvm/ioreq: add a new mappable resource type...

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 16:17, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 16 October 2017 15:07 >> >>> On 12.10.17 at 18:25, wrote: >> > ... XENMEM_resource_ioreq_server >> > >> > This patch adds support for a new resource type

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Roger Pau Monné
On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: > * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >all state is actually set up. As it currently stands, d0v0 is eligible for >scheduling before its registers have been set. This is latent as we

Re: [Xen-devel] libxl/xenconsole: vpl011: Fix hex to dec conversion of vuart_gfn in libxl__device_vuart_add

2017-10-16 Thread Bhupinder Thakur
On 16 October 2017 at 15:53, Jan Beulich wrote: On 16.10.17 at 11:02, wrote: >> static int console_create_ring(struct console *con) >> { >> - int err, remote_port, ring_ref, rc; >> + int err, remote_port, rc; >> + xen_pfn_t

Re: [Xen-devel] [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 17:05, wrote: > On 10/16/2017 01:32 PM, Jan Beulich wrote: >> Since the emulator acts on the live hardware registers, we need to >> prevent the compiler from using them e.g. for inlined memcpy() / >> memset() (as gcc7 does). > > Why doesn't this

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 16:38, wrote: > --- a/xen/arch/x86/hvm/dom0_build.c > +++ b/xen/arch/x86/hvm/dom0_build.c > @@ -614,6 +614,7 @@ static int __init pvh_setup_cpus(struct domain *d, > paddr_t entry, > > update_domain_wallclock_time(d); > > +

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 16:49, wrote: > On 16/10/17 15:44, Wei Liu wrote: >> On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: >>> * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >>>all state is actually set up. As it currently

[Xen-devel] Xen 4.10 RC1

2017-10-16 Thread Julien Grall
Hi all, Xen 4.10 RC1 is tagged. You can check that out from xen.git: git://xenbits.xen.org/xen.git 4.10.0-rc1 For your convenience there is also a tarball at: https://downloads.xenproject.org/release/xen/4.10.0-rc1/xen-4.10.0-rc1.tar.gz And the signature is at:

Re: [Xen-devel] [xen-4.8-testing test] 114505: regressions - FAIL

2017-10-16 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [xen-4.8-testing test] 114505: regressions - FAIL"): > On 15/10/17 20:45, osstest service owner wrote: > > flight 114505 xen-4.8-testing real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/114505/ > > > > Regressions :-( > > > > Tests which did

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-16 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value"): > On Mon, Oct 16, 2017 at 02:51:54PM +0100, Andrew Cooper wrote: ... > > With Joshua's patch in place, the implementer of this callback is the > > code generated by

[Xen-devel] [PATCH] libxc: don't fail domain creation when unpacking initrd fails

2017-10-16 Thread Jan Beulich
At least Linux kernels have been able to work with gzip-ed initrd for quite some time; initrd compressed with other methods aren't even being attempted to unpack. Furthermore the unzip-ing routine used here isn't capable of dealing with various forms of concatenated files, each of which was

Re: [Xen-devel] [PATCH for-4.10 2/2] tools/libxc: Fix various code smells in send_memory_live()

2017-10-16 Thread Ian Jackson
~Andrew Cooper writes ("[PATCH for-4.10 2/2] tools/libxc: Fix various code smells in send_memory_live()"): > * Don't zero ctx->save.stats; it is already zeroed > * No need for x as it duplicates ctx->save.stats.iteration > * Defer setting dirty_count until the bitmap has been filled to match

Re: [Xen-devel] [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-10-16 Thread George Dunlap
On 10/16/2017 01:32 PM, Jan Beulich wrote: > Since the emulator acts on the live hardware registers, we need to > prevent the compiler from using them e.g. for inlined memcpy() / > memset() (as gcc7 does). Why doesn't this affect the rest of the hypervisor too, since we don't save and restore

Re: [Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: > RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} > drivers use a minimum value of 0. > > When set MTU to 0~67 with xen_net{front|back} driver, the network > will become unreachable immediately, the guest can no

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 03:49:54PM +0100, Andrew Cooper wrote: > On 16/10/17 15:44, Wei Liu wrote: > > On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: > >> * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until > >>all state is actually set up. As it

Re: [Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Ian Jackson
Wei Liu writes ("[PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string"): > Hope this can placate coverity. Acked-by: Ian Jackson We are very soon going to want "NN2" and maybe "NN_1_2". Ian. ___

Re: [Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Eduardo Otubo
On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: > RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} > drivers use a minimum value of 0. > > When set MTU to 0~67 with xen_net{front|back} driver, the network > will become unreachable immediately, the guest can no

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: > * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >all state is actually set up. As it currently stands, d0v0 is eligible for >scheduling before its registers have been set. This is latent as we

[Xen-devel] [PATCH for-next] xen/pv: Construct d0v0's GDT properly

2017-10-16 Thread Andrew Cooper
c/s cf6d39f8199 "x86/PV: properly populate descriptor tables" changed the GDT to reference zero_page for intermediate frames between the guest and Xen frames. Because dom0_construct_pv() doesn't call arch_set_info_guest(), some bits of initialisation are missed, including the pv_destroy_gdt()

[Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Andrew Cooper
* x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until all state is actually set up. As it currently stands, d0v0 is eligible for scheduling before its registers have been set. This is latent as we also hold a systemcontroller pause reference at the time which

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 02:51:54PM +0100, Andrew Cooper wrote: > On 16/10/17 14:40, Wei Liu wrote: > > On Fri, Oct 13, 2017 at 06:32:18PM +0100, Andrew Cooper wrote: > >> c/s 4d69b3495 "Introduce migration precopy policy" uses bogus reasoning to > >> justify passing precopy_stats by value. > >> >

Re: [Xen-devel] [RFC 1/4] arm: add SMC wrapper that is compatible with SMCCC

2017-10-16 Thread Julien Grall
Hi Volodymyr, On 11/10/17 20:01, Volodymyr Babchuk wrote: Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need a call that is fully compatible with ARM SMCCC. This patch adds this call for

Re: [Xen-devel] [PATCH v2] x86/vpt: guarantee the return value of pt_update_irq() set in vIRR or PIR

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 15:46, wrote: > On Mon, Oct 16, 2017 at 08:26:09AM -0600, Jan Beulich wrote: > On 16.10.17 at 15:13, wrote: >>> On Mon, Oct 16, 2017 at 07:15:16AM -0600, Jan Beulich wrote: >>> On 13.10.17 at 07:10, wrote:

Re: [Xen-devel] [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-16 Thread Konrad Rzeszutek Wilk
On Sun, Oct 15, 2017 at 03:31:15AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 13, 2017 at 03:46:39PM -0700, Stefano Stabellini wrote: > > On Fri, 13 Oct 2017, Jan Beulich wrote: > > > >>> On 13.10.17 at 13:13, wrote: > > > > To Jan, Andrew, Stefano and Anthony, > > >

Re: [Xen-devel] [PATCH v3 6/6] x86/msr: handle VMX MSRs with guest_rd/wrmsr()

2017-10-16 Thread Sergey Dyasli
On Fri, 2017-10-13 at 16:38 +0100, Andrew Cooper wrote: > On 13/10/17 13:35, Sergey Dyasli wrote: > > diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c > > index a22e3dfaf2..2527fdd1d1 100644 > > --- a/xen/arch/x86/msr.c > > +++ b/xen/arch/x86/msr.c > > @@ -426,6 +426,13 @@ int

Re: [Xen-devel] [PATCH for-4.10] xen/dom0: Fix latent dom0 construction bugs on all architectures

2017-10-16 Thread Andrew Cooper
On 16/10/17 15:44, Wei Liu wrote: > On Mon, Oct 16, 2017 at 03:38:03PM +0100, Andrew Cooper wrote: >> * x86 PV and ARM dom0's must not clear _VPF_down from v->pause_flags until >>all state is actually set up. As it currently stands, d0v0 is eligible >> for >>scheduling before its

Re: [Xen-devel] [PATCH v2] x86/vpt: guarantee the return value of pt_update_irq() set in vIRR or PIR

2017-10-16 Thread Chao Gao
On Mon, Oct 16, 2017 at 08:26:09AM -0600, Jan Beulich wrote: On 16.10.17 at 15:13, wrote: >> On Mon, Oct 16, 2017 at 07:15:16AM -0600, Jan Beulich wrote: >> On 13.10.17 at 07:10, wrote: --- a/xen/arch/x86/hvm/irq.c +++

Re: [Xen-devel] [RFC 4/4] arm: tee: add basic OP-TEE mediator

2017-10-16 Thread Julien Grall
Hi Volodymyr, On 11/10/17 20:01, Volodymyr Babchuk wrote: Add basic OP-TEE mediator as an example how TEE mediator framework works. Currently it support only calls from Dom0. Calls from other guests will be declined. It maps OP-TEE static shared memory region into Dom0 address space, so Dom0

[Xen-devel] [xen-unstable-smoke test] 114544: tolerable all pass - PUSHED

2017-10-16 Thread osstest service owner
flight 114544 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/114544/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl

Re: [Xen-devel] [PATCH v2] x86/vpt: guarantee the return value of pt_update_irq() set in vIRR or PIR

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 15:13, wrote: > On Mon, Oct 16, 2017 at 07:15:16AM -0600, Jan Beulich wrote: > On 13.10.17 at 07:10, wrote: >>> --- a/xen/arch/x86/hvm/irq.c >>> +++ b/xen/arch/x86/hvm/irq.c >>> @@ -168,11 +168,13 @@ void hvm_gsi_deassert(struct

[Xen-devel] [seabios test] 114539: tolerable FAIL - PUSHED

2017-10-16 Thread osstest service owner
flight 114539 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/114539/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 114224 test-amd64-amd64-xl-qemuu-ws16-amd64 10

Re: [Xen-devel] [PATCH v11 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 16:07, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 16 October 2017 14:53 >> >>> On 12.10.17 at 18:25, wrote: >> > --- a/xen/common/memory.c >> > +++ b/xen/common/memory.c >> > @@ -965,6 +965,88 @@ static

Re: [Xen-devel] [PATCH v11 06/11] x86/hvm/ioreq: add a new mappable resource type...

2017-10-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 16 October 2017 15:07 > To: Paul Durrant > Cc: Andrew Cooper ; Ian Jackson > ; Stefano Stabellini ; xen- >

Re: [Xen-devel] [PATCH v2] x86/vpt: guarantee the return value of pt_update_irq() set in vIRR or PIR

2017-10-16 Thread Chao Gao
On Mon, Oct 16, 2017 at 07:15:16AM -0600, Jan Beulich wrote: On 13.10.17 at 07:10, wrote: >> --- a/xen/arch/x86/hvm/irq.c >> +++ b/xen/arch/x86/hvm/irq.c >> @@ -168,11 +168,13 @@ void hvm_gsi_deassert(struct domain *d, unsigned int >> gsi) >>

Re: [Xen-devel] [PATCH v11 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-16 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 16 October 2017 14:53 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; George Dunlap ; Ian > Jackson

Re: [Xen-devel] [PATCH v11 06/11] x86/hvm/ioreq: add a new mappable resource type...

2017-10-16 Thread Jan Beulich
>>> On 12.10.17 at 18:25, wrote: > ... XENMEM_resource_ioreq_server > > This patch adds support for a new resource type that can be mapped using > the XENMEM_acquire_resource memory op. > > If an emulator makes use of this resource type then, instead of mapping > gfns,

[Xen-devel] [PATCH for-4.10] libxl: annotate s to be nonnull in libxl__enum_from_string

2017-10-16 Thread Wei Liu
Hope this can placate coverity. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Julien Grall --- tools/libxl/libxl_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_internal.h

Re: [Xen-devel] [RFC 3/4] arm: tee: add OP-TEE header files

2017-10-16 Thread Julien Grall
Hi Volodymyr, On 11/10/17 20:01, Volodymyr Babchuk wrote: This header files describe protocol between OP-TEE and OP-TEE client driver in Linux. They are needed for upcomient OP-TEE mediator, which is added in the next patch. Reason to add those headers in separate patch is to ease up review.

Re: [Xen-devel] [PATCH v3 2/6] x86/msr: add VMX MSRs into struct msr_domain_policy

2017-10-16 Thread Andrew Cooper
On 16/10/17 08:42, Sergey Dyasli wrote: > On Fri, 2017-10-13 at 16:16 +0100, Andrew Cooper wrote: >> On 13/10/17 13:35, Sergey Dyasli wrote: >>> @@ -210,6 +375,255 @@ struct msr_domain_policy >>> bool available; /* This MSR is non-architectural */ >>> bool cpuid_faulting; >>>

Re: [Xen-devel] [PATCH v11 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-16 Thread Jan Beulich
>>> On 12.10.17 at 18:25, wrote: > @@ -402,14 +469,56 @@ int compat_memory_op(unsigned int cmd, > XEN_GUEST_HANDLE_PARAM(void) compat) > rc = do_memory_op(cmd, nat.hnd); > if ( rc < 0 ) > { > -if ( rc == -ENOBUFS && op ==

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-16 Thread Andrew Cooper
On 16/10/17 14:40, Wei Liu wrote: > On Fri, Oct 13, 2017 at 06:32:18PM +0100, Andrew Cooper wrote: >> c/s 4d69b3495 "Introduce migration precopy policy" uses bogus reasoning to >> justify passing precopy_stats by value. >> >> Under no circumstances can the precopy callback ever be executing in a

Re: [Xen-devel] [PATCH for-4.10 1/2] tools/libxc: Fix precopy_policy() to not pass a structure by value

2017-10-16 Thread Wei Liu
On Fri, Oct 13, 2017 at 06:32:18PM +0100, Andrew Cooper wrote: > c/s 4d69b3495 "Introduce migration precopy policy" uses bogus reasoning to > justify passing precopy_stats by value. > > Under no circumstances can the precopy callback ever be executing in a > separate address space. > The

[Xen-devel] [xen-4.8-testing test] 114538: tolerable FAIL - PUSHED

2017-10-16 Thread osstest service owner
flight 114538 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/114538/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-xtf-amd64-amd64-2 48 xtf/test-hvm64-lbr-tsx-vmentry fail in 114505 pass in 114538

[Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread Mohammed Gamal
RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} drivers use a minimum value of 0. When set MTU to 0~67 with xen_net{front|back} driver, the network will become unreachable immediately, the guest can no longer be pinged. xen_net{front|back} should not allow the user to set

Re: [Xen-devel] [PATCH v2] x86/vpt: guarantee the return value of pt_update_irq() set in vIRR or PIR

2017-10-16 Thread Jan Beulich
>>> On 13.10.17 at 07:10, wrote: > --- a/xen/arch/x86/hvm/irq.c > +++ b/xen/arch/x86/hvm/irq.c > @@ -168,11 +168,13 @@ void hvm_gsi_deassert(struct domain *d, unsigned int > gsi) > spin_unlock(>arch.hvm_domain.irq_lock); > } > > -void hvm_isa_irq_assert( > -struct

Re: [Xen-devel] [RFC 2/4] arm: add generic TEE mediator framework

2017-10-16 Thread Julien Grall
Hi Volodymyr, On 11/10/17 20:01, Volodymyr Babchuk wrote: This patch adds basic framework for TEE mediators. Guests can't talk to TEE directly, we need some entity that will intercept request and decide what to do with them. "TEE mediaor" is a such entity. s/mediaor/mediator/ This is how

Re: [Xen-devel] [PATCH v6] x86/altp2m: Added xc_altp2m_set_mem_access_multi()

2017-10-16 Thread Jan Beulich
>>> On 13.10.17 at 22:42, wrote: > @@ -4586,6 +4620,107 @@ static int do_altp2m_op( > return rc; > } > > +DEFINE_XEN_GUEST_HANDLE(compat_hvm_altp2m_op_t); > + > +#ifndef CHECK_hvm_altp2m_op > +#define CHECK_hvm_altp2m_op \ > +CHECK_SIZE_(struct,

Re: [Xen-devel] [PATCH v8 08/16] x86: implement set value flow for MBA

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 05:04, wrote: > This patch implements set value flow for MBA including its callback > function and domctl interface. > > Signed-off-by: Yi Sun Reviewed-by: Jan Beulich > v8: > - restore some

Re: [Xen-devel] [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-10-16 Thread Jan Beulich
>>> On 16.10.17 at 14:37, wrote: > On 16/10/17 13:32, Jan Beulich wrote: >> Since the emulator acts on the live hardware registers, we need to >> prevent the compiler from using them e.g. for inlined memcpy() / >> memset() (as gcc7 does). We can't, however, set this

Re: [Xen-devel] [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-10-16 Thread Andrew Cooper
On 16/10/17 13:32, Jan Beulich wrote: > Since the emulator acts on the live hardware registers, we need to > prevent the compiler from using them e.g. for inlined memcpy() / > memset() (as gcc7 does). We can't, however, set this from the command > line, as otherwise the 64-bit build would face

[Xen-devel] [PATCH] x86emul: keep compiler from using {x, y, z}mm registers itself

2017-10-16 Thread Jan Beulich
Since the emulator acts on the live hardware registers, we need to prevent the compiler from using them e.g. for inlined memcpy() / memset() (as gcc7 does). We can't, however, set this from the command line, as otherwise the 64-bit build would face issues with functions returning floating point

Re: [Xen-devel] [PATCH] x86: convert x86_platform_ops to timespec64

2017-10-16 Thread Paolo Bonzini
On 16/10/2017 14:16, Arnd Bergmann wrote: > On Mon, Oct 16, 2017 at 2:08 PM, Paolo Bonzini wrote: >> On 16/10/2017 10:11, Arnd Bergmann wrote: >>> Thanks! >>> >>> Since you've looked at it overall, do you have an opinion on the question >>> how to fix the PV interface to deal

Re: [Xen-devel] [PATCH] x86: convert x86_platform_ops to timespec64

2017-10-16 Thread Arnd Bergmann
On Mon, Oct 16, 2017 at 2:08 PM, Paolo Bonzini wrote: > On 16/10/2017 10:11, Arnd Bergmann wrote: >> Thanks! >> >> Since you've looked at it overall, do you have an opinion on the question >> how to fix the PV interface to deal with the pvclock_wall_clock overflow? > > It has

Re: [Xen-devel] [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle

2017-10-16 Thread Ross Lagerwall
On 10/16/2017 12:29 PM, Ian Jackson wrote: Ross Lagerwall writes ("Re: [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle"): No. As far as I can see, it can only be used to bind new interdomain events, not other events. OK, good, thanks. This entire file (including the

[Xen-devel] [distros-debian-sid test] 72240: tolerable trouble: blocked/broken/fail/pass

2017-10-16 Thread Platform Team regression test user
flight 72240 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72240/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-armhf-sid-netboot-pygrub 1 build-check(1)blocked n/a build-arm64-pvops

Re: [Xen-devel] [PATCH] x86: convert x86_platform_ops to timespec64

2017-10-16 Thread Paolo Bonzini
On 16/10/2017 10:11, Arnd Bergmann wrote: > Thanks! > > Since you've looked at it overall, do you have an opinion on the question > how to fix the PV interface to deal with the pvclock_wall_clock overflow? It has to be done separately for each hypervisor. In KVM, for example, it is probably

Re: [Xen-devel] [RFC 0/4] TEE mediator framework + OP-TEE mediator

2017-10-16 Thread Julien Grall
On 11/10/17 20:01, Volodymyr Babchuk wrote: Hello all, Hi Volodymyr, I want to present TEE mediator, that was discussed earlier ([1]). I selected design with built-in mediators. This is easiest way, it removes many questions, it is easy to implement and maintain (at least I hope so).

[Xen-devel] [xen-4.9-testing test] 114533: regressions - FAIL

2017-10-16 Thread osstest service owner
flight 114533 xen-4.9-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/114533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvopsbroken in 114501 build-armhf-pvops

Re: [Xen-devel] [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle

2017-10-16 Thread Ian Jackson
Ross Lagerwall writes ("Re: [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle"): > No. As far as I can see, it can only be used to bind new interdomain > events, not other events. OK, good, thanks. > This entire file (including the description) is copied directly from >

Re: [Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Julien Grall
On 16/10/17 11:30, Wei Liu wrote: On Mon, Oct 16, 2017 at 11:17:12AM +0100, Ian Jackson wrote: Otherwise, f942a9b4a12081d5f9a4679d06e88cb5d503396e xentoolcore_restrict_all: "Implement" for xenstore breaks the build of the tools inside rumprun. Signed-off-by: Ian Jackson

[Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Ian Jackson
Otherwise, f942a9b4a12081d5f9a4679d06e88cb5d503396e xentoolcore_restrict_all: "Implement" for xenstore breaks the build of the tools inside rumprun. toolcore is in libs, so we need to add the CONFIG_RUMP special case to tools/libs/Makefile and add toolcore there. Signed-off-by: Ian Jackson

Re: [Xen-devel] [PATCH] toolcore: Build in rumprun environment too

2017-10-16 Thread Wei Liu
On Mon, Oct 16, 2017 at 12:23:12PM +0100, Ian Jackson wrote: > Otherwise, > f942a9b4a12081d5f9a4679d06e88cb5d503396e > xentoolcore_restrict_all: "Implement" for xenstore > breaks the build of the tools inside rumprun. > > toolcore is in libs, so we need to add the CONFIG_RUMP special case to

Re: [Xen-devel] [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle

2017-10-16 Thread Ross Lagerwall
On 10/16/2017 11:53 AM, Ian Jackson wrote: Ross Lagerwall writes ("[PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle"): +/* + * Restrict this file descriptor so that it can only be used to bind + * new interdomain events from one domain. Can it be used to bind other

Re: [Xen-devel] [PATCH v2 2/2] xentoolcore_restrict_all: Implement for libxenevtchn

2017-10-16 Thread Ian Jackson
Ross Lagerwall writes ("[PATCH v2 2/2] xentoolcore_restrict_all: Implement for libxenevtchn"): > Signed-off-by: Ross Lagerwall ... > int osdep_evtchn_open(xenevtchn_handle *xce); > diff --git a/tools/libs/toolcore/include/xentoolcore.h >

Re: [Xen-devel] [PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle

2017-10-16 Thread Ian Jackson
Ross Lagerwall writes ("[PATCH v1 1/2] tools/libs/evtchn: Add support for restricting a handle"): > +/* > + * Restrict this file descriptor so that it can only be used to bind > + * new interdomain events from one domain. Can it be used to bind other kinds of events ? The phrasing is ambigous.

  1   2   >