Re: [Xen-devel] [PATCH 3/3] credit2: xen related changes to add support for runqueue per cpupool.

>>> On 12.09.17 at 02:45, wrote: > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -538,7 +538,34 @@ struct xen_sysctl_numainfo { > typedef struct xen_sysctl_numainfo xen_sysctl_numainfo_t; > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_numainfo_t); >

Re: [Xen-devel] [PATCH v5 04/11] x86/physdev: enable PHYSDEVOP_pci_mmcfg_reserved for PVH Dom0

>>> On 13.09.17 at 17:55, <roger@citrix.com> wrote: > On Tue, Sep 05, 2017 at 08:57:54AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, <roger@citrix.com> wrote: >> > --- a/xen/arch/x86/physdev.c >> > +++ b/xen/arch/x86/ph

[Xen-devel] [PATCH] custom parameter handling fixes

quot;dom0_nodes=" and "rmrr=", partly pre-existing, but partly also due to those recent changes not having gone far enough. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -59,7 +59,7 @@ stat

Re: [Xen-devel] Booting signed xen.efi through shim

>>> On 13.09.17 at 16:40, <ta...@tklengyel.com> wrote: > On Wed, Sep 13, 2017 at 3:21 AM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 13.09.17 at 07:27, <ta...@tklengyel.com> wrote: >>>Sections: >>>Idx Name Size VMA

Re: [Xen-devel] [PATCH] x86/oprofile: Add a missing space to initialisation failure message

>>> On 13.09.17 at 15:41, <andrew.coop...@citrix.com> wrote: > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 03/17] x86emul: build SIMD tests with -Os

>>> On 13.09.17 at 17:19, <dunl...@umich.edu> wrote: > On Wed, Jun 21, 2017 at 1:00 PM, Jan Beulich <jbeul...@suse.com> wrote: >> Namely in the context of putting together subsequent patches I've >> noticed that together with the touch() macro using

Re: [Xen-devel] [PATCH 01/17] x86emul: support remaining AVX insns

>>> On 13.09.17 at 17:02, <dunl...@umich.edu> wrote: > On Wed, Jun 21, 2017 at 12:59 PM, Jan Beulich <jbeul...@suse.com> wrote: >> I.e. those not being equivalents of SSEn ones. >> >> There's one necessary change to generic code: Faulting behavior of &

Re: [Xen-devel] Booting signed xen.efi through shim

>>> On 13.09.17 at 07:27, wrote: >Sections: >Idx Name Size VMA LMA File off Algn > 0 .text 0017a1ba 82d08020 82d08020 1000 2**12 > CONTENTS, ALLOC, LOAD, CODE > 1 .rodata

Re: [Xen-devel] [PATCH v3 14/17] livepatch/x86/arm: arch/x86/mm: generalize do_page_walk() and implement arch_livepatch_lookup_mfn

>>> On 13.09.17 at 02:23, wrote: > I will take a look at it later this week, but regardless it will require > some tweaking as well. Do you prefer the domain_page_map_to_mfn path > in instead of walk_do_page one? Yes - do_page_walk() is really only a debugging helper, not

Re: [Xen-devel] [PATCH v3 07/17] livepatch/arm/x86: Strip note_depends symbol from test-cases.

>>> On 13.09.17 at 01:46, <kon...@kernel.org> wrote: > On Tue, Sep 12, 2017 at 08:48:33AM -0600, Jan Beulich wrote: >> >>> On 12.09.17 at 02:37, <kon...@kernel.org> wrote: >> > This surfaced due to "xen/livepatch/x86/arm32: Force >>

Re: [Xen-devel] Booting signed xen.efi through shim

>>> On 13.09.17 at 01:40, wrote: > for the last couple weeks I've been poking around the options > available to get Xen booted on a Secureboot enabled box. My goal is to > extend the chain of trust to the dom0 kernel. According to > https://wiki.xenproject.org/wiki/Xen_EFI

Re: [Xen-devel] [PATCH 7/7] x86/mm: Prevent 32bit PV guests using out-of-range linear addresses

>>> On 12.09.17 at 18:04, <andrew.coop...@citrix.com> wrote: > On 12/09/17 16:50, Jan Beulich wrote: >>>>> On 12.09.17 at 14:14, <andrew.coop...@citrix.com> wrote: >>> The grant ABI uses 64 bit values, and allows a PV guest to specify linear >>

Re: [Xen-devel] [PATCH 7/7] x86/mm: Prevent 32bit PV guests using out-of-range linear addresses

>>> On 12.09.17 at 14:14, wrote: > The grant ABI uses 64 bit values, and allows a PV guest to specify linear > addresses. There is nothing interesting a 32bit PV guest can reference which > will pass an __addr_ok() check, but it should still get an error for trying.

Re: [Xen-devel] [PATCH 6/7] x86/mm: Combine {destroy, replace}_grant_{pte, va}_mapping()

top of the explicit settings done by create_grant_host_mapping() > + * On top of the explicit settings done by create_pv_host_mapping() create_grant_pv_mapping() Other than that Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 5/7] x86/mm: Carve steal_linear_address() out of replace_grant_host_mapping()

worked. >> + * >> + * Look up the L1e mapping linear, and zap it. Return the L1e via *out. >> + * Returns a boolean indicating success. If success, the caller is >> + * responsible for calling put_page_from_l1e(). >> + */ > > Can't say much about the history;

Re: [Xen-devel] [PATCH 4/7] x86/mm: Combine create_grant_{pte, va}_mapping()

gic in create_grant_pv_mapping() in a mostly common way. > > No (intended) change in behaviour from a guests point of view. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com>

Re: [Xen-devel] [PATCH 2/7] x86/mm: Factor out the grant flags to pte flags conversion logic

: Andrew Cooper <andrew.coop...@citrix.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/7] x86/mm: Misc cleanup to {create, replace}_grant_host_mapping()

e start of the functions. >> * Rename pte to nl1e. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com>

Re: [Xen-devel] [PATCH 1/7] x86/mm: Improvements to PV l1e mapping helpers

t;> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 2/2] public/sysctl: drop unnecessary typedefs and handles

By virtue of the struct xen_sysctl container structure, most of them are really just cluttering the name space. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -1212,11 +1212,11 @@ int xc_readconsolering(xc_interfac

[Xen-devel] [PATCH 1/2] public/domctl: drop unnecessary typedefs and handles

in a few places. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/tools/libxc/include/xenctrl.h +++ b/tools/libxc/include/xenctrl.h @@ -903,7 +903,7 @@ int xc_vcpu_get_extstate(xc_interface *x uint32_t vcpu, xc_vcpu_extstate_t *ex

Re: [Xen-devel] [PATCH v2 4/4] x86/hvm: Implement hvmemul_write() using real mappings

>>> On 12.09.17 at 16:37, wrote: > On 12/09/17 15:32, Paul Durrant wrote: >> >>> +{ >>> +ASSERT_UNREACHABLE(); >>> +goto unhandleable; >>> +} >>> + >>> +do { >>> +enum hvm_translation_result res; >>> +struct page_info *page;

Re: [Xen-devel] [PATCH v3 14/17] livepatch/x86/arm: arch/x86/mm: generalize do_page_walk() and implement arch_livepatch_lookup_mfn

>>> On 12.09.17 at 02:37, wrote: > With this change we can use _do_page_walk() to implement > arch_livepatch_lookup_mfn() which can be used to find out > vmap virtual addresses (as under x86 virt_to_mfn won't work > for vmap, but it does for arm!). How about using

Re: [Xen-devel] [PATCH v3 08/17] livepatch/tests: Make sure all .livepatch.funcs sections are read-only

>>> On 12.09.17 at 02:37, wrote: > --- a/xen/test/livepatch/Makefile > +++ b/xen/test/livepatch/Makefile > @@ -54,6 +54,7 @@ xen_hello_world.o: config.h livepatch_depends.h > $(LIVEPATCH): xen_hello_world_func.o xen_hello_world.o > $(LD) $(LDFLAGS) $(build_id_linker) -r

Re: [Xen-devel] [PATCH v3 07/17] livepatch/arm/x86: Strip note_depends symbol from test-cases.

>>> On 12.09.17 at 02:37, wrote: > This surfaced due to "xen/livepatch/x86/arm32: Force > .livepatch.depends section to be uint32_t aligned." which switched > to a different way of including the build-id. > > Each livepatch ends with a global: > > 30: 1

Re: [Xen-devel] [PATCH v3 05/17] alternative/x86/arm32: Align altinstructions (and altinstr_replacement) sections.

>>> On 12.09.17 at 02:37, wrote: > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -155,11 +155,9 @@ SECTIONS > __initcall_end = .; > > #ifdef CONFIG_HAS_ALTERNATIVE > - . = ALIGN(4); I think this one needs to say, while ... >

Re: [Xen-devel] [PATCH v3 02/17] livepatch: Tighten alignment checks.

is in-to account so this patch adds > a check on the ELF file as it is being parsed. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> albeit generally I'd recommend the check to be done in the opposite order. Jan

[Xen-devel] [PATCH 0/2] public/*ctl: drop unnecessary typedefs and handles

1: public/domctl: drop unnecessary typedefs and handles 2: public/sysctl: drop unnecessary typedefs and handles Signed-off-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xen_disk: avoid use of g_malloc0_n()

Prefer g_new() / g_new0() to be farther backwards compatible with older glib versions. As there's no point in zeroing the allocation here (the loop right afterwards fully initializes the memory), use the former. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/hw/block/xen_disk.c ++

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

>>> On 12.09.17 at 13:48, <roger@citrix.com> wrote: > On Tue, Sep 12, 2017 at 04:06:13AM -0600, Jan Beulich wrote: >> >>> On 12.09.17 at 11:54, <roger@citrix.com> wrote: >> > On Thu, Sep 07, 2017 at 03:53:07AM -0600, Jan Beulich wrote: >&

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

>>> On 12.09.17 at 13:27, <roger@citrix.com> wrote: > On Tue, Sep 12, 2017 at 03:04:02AM -0600, Jan Beulich wrote: >> >>> On 12.09.17 at 09:49, <roger@citrix.com> wrote: >> > On Tue, Sep 05, 2017 at 09:01:57AM -0600, Jan Beulich wrote: >&

Re: [Xen-devel] [PATCH v2 02/24] xen/mm: Use typesafe MFN for alloc_boot_pages return

..@arm.com> Non-ARM pieces Acked-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

>>> On 12.09.17 at 11:54, <roger@citrix.com> wrote: > On Thu, Sep 07, 2017 at 03:53:07AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, <roger@citrix.com> wrote: >> > + >> > +/* >> > + * The PCI

Re: [Xen-devel] [PATCH RFC v2] Add SUPPORT.md

>>> On 11.09.17 at 19:53, wrote: > As for practical limits, I don't think its reasonable to claim anything > which we can't test. What are the specs in the MA colo? I don't think the MA colo's limits ought to be the only ones applicable here, and it looks like you

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

>>> On 11.09.17 at 17:52, <ppircal...@bitdefender.com> wrote: > On Jo, 2017-09-07 at 09:08 -0600, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 07.09.17 at 16:26, <jbeul...@suse.com> wrote: >> > After dis

Re: [Xen-devel] [PATCH v5 05/11] mm: move modify_identity_mmio to global file and drop __init

>>> On 12.09.17 at 09:49, <roger@citrix.com> wrote: > On Tue, Sep 05, 2017 at 09:01:57AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, <roger@citrix.com> wrote: >> > +int modify_mmio(struct domain *d, gfn_t gfn, mfn_t mfn, unsigned

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

>>> On 12.09.17 at 02:22, <kon...@kernel.org> wrote: > On Mon, Sep 11, 2017 at 03:01:15AM -0600, Jan Beulich wrote: >> Hmm, as long as the relocation isn't required to be against aligned >> fields only (mandated by the processor ABI) I think the code doing >>

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

>>> On 11.09.17 at 17:01, <wei.l...@citrix.com> wrote: > On Mon, Sep 11, 2017 at 08:55:53AM -0600, Jan Beulich wrote: >> >>> On 11.09.17 at 16:07, <wei.l...@citrix.com> wrote: >> > e2fc5bb5cb4 ("hvmloader: dynamically determine scratch memory ra

Re: [Xen-devel] [PATCH] hvmloader: cast to avoid potential overflow in shadow_gs_test

; > Coverity-ID: 1417660 > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com> > --- > tools/firmware/hvmloader/tests.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Xen-devel] [PATCH v5 6/8] xen: add new domctl hypercall to set grant table resource limits

>>> On 11.09.17 at 12:48, <jgr...@suse.com> wrote: > On 08/09/17 17:55, Jan Beulich wrote: >>>>> On 08.09.17 at 08:56, <jgr...@suse.com> wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -3667,6

Re: [Xen-devel] [PATCH v5 4/8] xen: make grant resource limits per domain

>>> On 11.09.17 at 12:40, <jgr...@suse.com> wrote: > On 08/09/17 17:44, Jan Beulich wrote: >>>>> On 08.09.17 at 08:56, <jgr...@suse.com> wrote: >>> @@ -3755,6 +3763,12 @@ static void gnttab_usage_print(struct domain *rd) >>> >>

Re: [Xen-devel] [PATCH v5 3/8] xen: delay allocation of grant table sub structures

>>> On 11.09.17 at 11:39, <jgr...@suse.com> wrote: > On 11/09/17 11:23, Jan Beulich wrote: >>>>> On 11.09.17 at 11:03, <jgr...@suse.com> wrote: >>> On 08/09/17 17:28, Jan Beulich wrote: >>>>>>> On 08.09.17 at 08:56, <

Re: [Xen-devel] [PATCH] pci/msi: constify the pci_dev parameter of pci_msi_conf_write_intercept

>>> On 11.09.17 at 11:16, wrote: This being an x86 only change, the subject prefix would presumably better be "x86/msi". > --- a/xen/arch/x86/msi.c > +++ b/xen/arch/x86/msi.c > @@ -657,7 +657,7 @@ int msi_free_irq(struct msi_desc *entry) > return 0; > } > > -static

[Xen-devel] [PATCH 3/3] x86/cpuidle: add new CPU families

Bring code up-to-date with SDM version 063. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/acpi/cpu_idle.c +++ b/xen/arch/x86/acpi/cpu_idle.c @@ -162,7 +162,13 @@ static void do_get_hw_residencies(void * case 0x56: /* Skylake */ case 0x4E: +cas

[Xen-devel] [PATCH 2/3] VMX: add new CPU families to LBR handling

Bring code up-to-date with SDM version 063, including the LBR format enumeration. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2726,6 +2726,8 @@ static const struct lbr_info *last_branc cas

[Xen-devel] [PATCH 1/3] VMX: convert CPU family numbers to hex

This makes it easier to match them against SDM updates. Also update a few comments with names as per SDM version 063. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2723,39 +2723,39 @@ static const struct lbr_info *last

Re: [Xen-devel] [PATCH] vt-d: use two 32-bit writes to update DMAR fault address registers

>>> On 11.09.17 at 08:00, wrote: > The 64-bit DMAR fault address is composed of two 32 bits registers > DMAR_FEADDR_REG and DMAR_FEUADDR_REG. According to VT-d spec: > "Software is expected to access 32-bit registers as aligned doublewords", > a hypervisor should use two

Re: [Xen-devel] [PATCH v1 0/5] Generic MSR policy: infrastructure + cpuid_faulting

>>> On 11.09.17 at 09:29, wrote: > Ping? From a purely formal perspective, with Andrew's review there's only an ack missing for the VMX changes afaict (and I think Andrew did ask for one or two description changes, which might be best if you carried them out and

Re: [Xen-devel] Which Xen binary can I use?

>>> On 11.09.17 at 05:20, wrote: > Hi. > I'm working on a scheduling code by which I received a patch regarding > credit scheduler from my professor. > I have had some troubles during that work and I need to make the Xen binary > with 'debug=y' option. > But there was a

Re: [Xen-devel] PVH dom0 memory setup

>>> On 11.09.17 at 10:49, wrote: > AFAICT even with the change proposed I don't think > dom0_compute_nr_pages will handle the !iommu_hap_pt_share case > properly (ie: I don't see specific memory for the IOMMU pages tables > being reserved anywhere). Which (sadly) is in line

[Xen-devel] [PATCH 0/3] x86: updates for Intel SDM version 063

1: VMX: convert CPU family numbers to hex 2: VMX: add new CPU families to LBR handling 3: x86/cpuidle: add new CPU families Signed-off-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.o

Re: [Xen-devel] [PATCH] pci: constify domain parameter of pci_get_pdev_by_domain

>>> On 11.09.17 at 11:22, <roger@citrix.com> wrote: > On Mon, Sep 11, 2017 at 03:09:54AM -0600, Jan Beulich wrote: >> >>> On 08.09.17 at 20:08, <andrew.coop...@citrix.com> wrote: >> > As as bdf is also quite a common unit, how about: >>

Re: [Xen-devel] [PATCH v5 3/8] xen: delay allocation of grant table sub structures

>>> On 11.09.17 at 11:03, <jgr...@suse.com> wrote: > On 08/09/17 17:28, Jan Beulich wrote: >>>>> On 08.09.17 at 08:56, <jgr...@suse.com> wrote: >> And if you special case Dom0, >> wouldn't it be better to (also) special case the hardware doma

Re: [Xen-devel] [PATCH] pci: constify domain parameter of pci_get_pdev_by_domain

>>> On 08.09.17 at 20:08, <andrew.coop...@citrix.com> wrote: > On 08/09/17 18:33, Roger Pau Monné wrote: >> On Fri, Sep 08, 2017 at 10:00:41AM -0600, Jan Beulich wrote: >>>>>> On 08.09.17 at 16:30, <roger@citrix.com> wrote: >>>> O

Re: [Xen-devel] Xen 4.8.2 released

>>> On 10.09.17 at 01:53, <marma...@invisiblethingslab.com> wrote: > On Wed, Sep 06, 2017 at 08:42:33AM -0600, Jan Beulich wrote: >> All, >> >> I am pleased to announce the release of Xen 4.8.2. This is >> available immediately from its git repository &

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

>>> On 09.09.17 at 14:05, <kon...@kernel.org> wrote: > On Fri, Sep 08, 2017 at 03:30:07AM -0600, Jan Beulich wrote: >> >>> On 07.09.17 at 19:36, <kon...@kernel.org> wrote: >> > On Wed, Aug 02, 2017 at 03:20:05AM -0600, Jan Beulich wrote: >> &g

Re: [Xen-devel] [PATCH] pci: constify domain parameter of pci_get_pdev_by_domain

>>> On 08.09.17 at 16:30, <roger@citrix.com> wrote: > On Fri, Sep 08, 2017 at 03:15:40PM +0100, Andrew Cooper wrote: >> On 08/09/17 14:34, Roger Pau Monne wrote: >> > While there fix the indentation. >> > >> > Signed-off-by: Roger Pau Monné &

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

>>> On 08.09.17 at 16:41, <roger@citrix.com> wrote: > On Mon, Sep 04, 2017 at 09:38:11AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, <roger@citrix.com> wrote: >> > +/* >> > + * At this point we have the followin

Re: [Xen-devel] [PATCH v5 6/8] xen: add new domctl hypercall to set grant table resource limits

>>> On 08.09.17 at 08:56, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3667,6 +3667,32 @@ void grant_table_init_vcpu(struct vcpu *v) > v->maptrack_tail = MAPTRACK_TAIL; > } > > +int grant_table_set_limits(struct domain *d, unsigned int

Re: [Xen-devel] [PATCH v5 5/8] xen: double default grant frame limit for huge hosts

>>> On 08.09.17 at 08:56, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3824,8 +3824,15 @@ static int __init gnttab_usage_init(void) > { > BUILD_BUG_ON(DEFAULT_MAX_MAPTRACK_FRAMES < DEFAULT_MAX_NR_GRANT_FRAMES); > > +/* > + * In

Re: [Xen-devel] [PATCH v5 4/8] xen: make grant resource limits per domain

>>> On 08.09.17 at 08:56, wrote: > @@ -1843,6 +1838,14 @@ gnttab_setup_table( > gt = d->grant_table; > grant_write_lock(gt); > > +if ( unlikely(op.nr_frames > gt->max_grant_frames) ) > +{ > +gdprintk(XENLOG_INFO, "Domain is limited to %d grant-table >

Re: [Xen-devel] [PATCH v5 3/8] xen: delay allocation of grant table sub structures

>>> On 08.09.17 at 08:56, wrote: > Delay the allocation of the grant table sub structures in order to > allow modifying parameters needed for sizing of these structures at a > per domain basis. Either do it from gnttab_setup_table() or just > before the domain is started the

Re: [Xen-devel] [PATCH v5 2/8] xen: clean up grant_table.h

>>> On 08.09.17 at 08:56, wrote: > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -40,6 +40,44 @@ > #include > #include > > +/* Per-domain grant information. */ > +struct grant_table { > +/* > + * Lock protecting updates to grant table state

Re: [Xen-devel] [PATCH v5 1/8] xen: move XENMAPSPACE_grant_table code into grant_table.c

>>> On 08.09.17 at 08:56, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4631,40 +4631,19 @@ int xenmem_add_to_physmap_one( > { > struct page_info *page = NULL; > unsigned long gfn = 0; /* gcc ... */ > -unsigned long prev_mfn, mfn = 0, old_gpfn; >

Re: [Xen-devel] [PATCH] monitor: switch to plain bool

>>> On 08.09.17 at 15:44, wrote: > @@ -41,7 +41,7 @@ bool_t hvm_monitor_cr(unsigned int index, unsigned long > value, unsigned long old >value != old) && > (!((value ^ old) & ad->monitor.write_ctrlreg_mask[index])) ) > { > -bool_t sync =

Re: [Xen-devel] [PATCH] x86/mm: Allow map_domain_page_global() to be used during boot

>>> On 08.09.17 at 13:03, <andrew.coop...@citrix.com> wrote: > On 08/09/17 10:57, Jan Beulich wrote: >>>>> On 07.09.17 at 18:50, <andrew.coop...@citrix.com> wrote: >>> map_domain_page_global() uses vmap under the hood, which wo

Re: [Xen-devel] [PATCH] x86/mm: Allow map_domain_page_global() to be used during boot

>>> On 07.09.17 at 18:50, wrote: > map_domain_page_global() uses vmap under the hood, which works fine even > during very early boot. Relax the local_irq_is_enabled() part of the > assertion before Xen has finished booting. vm_init() being called right after having

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

>>> On 07.09.17 at 19:36, <kon...@kernel.org> wrote: > On Wed, Aug 02, 2017 at 03:20:05AM -0600, Jan Beulich wrote: >> >>> Konrad Rzeszutek Wilk <konrad.w...@oracle.com> 07/31/17 6:04 PM >>> >> >On Mon, Jul 31, 2017 at 07:55:34AM -0600

Re: [Xen-devel] [PATCH v5 11/11] vpci/msix: add MSI-X handlers

>>> On 14.08.17 at 16:28, wrote: > +void vpci_msix_arch_mask(struct vpci_arch_msix_entry *arch, > + struct pci_dev *pdev, bool mask) > +{ > +if ( arch->pirq == INVALID_PIRQ ) > +return; How come no similar guard is needed in

Re: [Xen-devel] [PATCH v5 10/11] vpci: add a priority parameter to the vPCI register initializer

; the trap handlers to work properly. > > Signed-off-by: Roger Pau Monné <roger@citrix.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 09/11] vpci/msi: add MSI handlers

>>> On 14.08.17 at 16:28, wrote: > +static unsigned int msi_flags(uint16_t data, uint64_t addr) > +{ > +unsigned int rh, dm, dest_id, deliv_mode, trig_mode; > + > +rh = MASK_EXTR(addr, MSI_ADDR_REDIRECTION_MASK); > +dm = MASK_EXTR(addr, MSI_ADDR_DESTMODE_MASK); >

Re: [Xen-devel] [PATCH v4 08/12] x86/hvm/ioreq: maintain an array of ioreq servers rather than a list

ed-off-by: Paul Durrant <paul.durr...@citrix.com> >> >> LGTM, just a couple of nitpicks, I think they can be fixed upon commit >> if desired. >> >> Reviewed-by: Roger Pau Monné <roger@citrix.com> >> >>> --- >>> Cc: Jan Beulich &

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

>>> On 07.09.17 at 16:26, wrote: > After discussing with Andrew I'm willing to agree with the changes > you do here, with one extra requirement: At least on non-debug > builds X86EMUL_UNIMPLEMENTED should always result in #UD being > raised by the final consumer of it. It

Re: [Xen-devel] [PATCH] x86/page: Implement {get, set}_pte_flags() as static inlines

t_pte_flags(intpte_t x) > +{ > +return ((x >> 40) & ~0xfff) | (x & 0xfff); > +} > +static inline intpte_t put_pte_flags(unsigned int x) > +{ > +return (((intpte_t)x & ~0xfff) << 40) | (x & 0xfff); > +} > +#endif With ideally a blank line add

Re: [Xen-devel] [PATCH v10 2/3] x86emul: New return code for unimplemented instruction

>>> On 06.09.17 at 15:48, wrote: > Enforce the distinction between an instruction not implemented by the > emulator and the failure to emulate that instruction by defining a new > return code, X86EMUL_UNIMPLEMENTED. > > This value should only be returned by the core

Re: [Xen-devel] [PATCH v4 02/12] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

>>> On 07.09.17 at 13:36, wrote: > On Thu, Sep 07, 2017 at 12:18:25PM +0100, Paul Durrant wrote: >> Ok, if you think it's necessary. (This is a tools-only hypercall and the > ranges are supplied by privcmd, allocated in kernel). > > IMHO we should allow for use case for

Re: [Xen-devel] [PATCH RFC] Add SUPPORT.md

>>> On 07.09.17 at 13:31, <george.dun...@citrix.com> wrote: > On 08/31/2017 01:46 PM, Jan Beulich wrote: >>>>> On 31.08.17 at 12:27, <george.dun...@citrix.com> wrote: >>> +### Live Patching >>> + >>> +Status: Supported,

Re: [Xen-devel] [PATCH] x86/HVM: correct repeat count update in linear->phys translation

>>> On 07.09.17 at 13:35, <andrew.coop...@citrix.com> wrote: > On 07/09/17 12:24, Jan Beulich wrote: >>>>> On 07.09.17 at 13:15, <andrew.coop...@citrix.com> wrote: >>> On 07/09/17 11:41, Jan Beulich wrote: >>>> For the insn emulator's fa

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

>>> On 07.09.17 at 13:30, <roger@citrix.com> wrote: > On Thu, Sep 07, 2017 at 03:06:50AM -0600, Jan Beulich wrote: >> >>> On 06.09.17 at 17:40, <roger@citrix.com> wrote: >> > On Mon, Sep 04, 2017 at 09:38:11AM -0600, Jan Beulich wrote: >&

Re: [Xen-devel] [PATCH] x86/HVM: correct repeat count update in linear->phys translation

>>> On 07.09.17 at 13:15, <andrew.coop...@citrix.com> wrote: > On 07/09/17 11:41, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -566,15 +566,16 @@ static int hvmemul_linear_to_phys( >> if (

Re: [Xen-devel] [PATCH] x86/HVM: correct repeat count update in linear->phys translation

>>> On 07.09.17 at 13:15, <andrew.coop...@citrix.com> wrote: > On 07/09/17 11:41, Jan Beulich wrote: >> For the insn emulator's fallback logic in REP MOVS/STOS/INS/OUTS >> handling to work correctly, *reps must not be set to zero when >> returning X86EMUL_UN

Re: [Xen-devel] [PATCH] x86/HVM: correct repeat count update in linear->phys translation

>>> On 07.09.17 at 12:50, <paul.durr...@citrix.com> wrote: >> -Original Message- >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 07 September 2017 11:42 >> To: xen-devel <xen-de...@lists.xenproject.org> >> Cc: Andrew Cooper <

[Xen-devel] [PATCH] x86/HVM: correct repeat count update in linear->phys translation

For the insn emulator's fallback logic in REP MOVS/STOS/INS/OUTS handling to work correctly, *reps must not be set to zero when returning X86EMUL_UNHANDLEABLE. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -566,15 +

Re: [Xen-devel] [PATCH] x86/HVM: drop bogus #PF raising from linear->phys translation

>>> On 07.09.17 at 12:21, <paul.durr...@citrix.com> wrote: >> -Original Message- >> From: Andrew Cooper >> Sent: 07 September 2017 11:18 >> To: Jan Beulich <jbeul...@suse.com>; xen-devel > de...@lists.xenproject.org> >> Cc: Paul

Re: [Xen-devel] [PATCH] x86/HVM: drop bogus #PF raising from linear->phys translation

>>> On 07.09.17 at 12:17, <andrew.coop...@citrix.com> wrote: > On 07/09/17 09:14, Jan Beulich wrote: >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -566,15 +566,12 @@ static int hvmemul_linear_to_phys( >> if (

Re: [Xen-devel] [PATCH v3] mm: Don't scrub pages while holding heap lock in alloc_heap_pages()

gt; bit since count_info might be updated during MCE handling in > mark_page_offline(). > > Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> Reviewed-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 2/2] hvmloader: clone REP INSW test from REP INSB one

This also covers an individual string insn access crossing a page boundary. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- v2: New patch. --- This is what has prompted the patch at lists.xenproject.org/archives/html/xen-devel/2017-09/msg00625.html (the test being added here fails w

[Xen-devel] [PATCH v2 1/2] hvmloader: dynamically determine scratch memory range for tests

This re-enables tests on configurations where commit 0d6968635c ("hvmloader: avoid tests when they would clobber used memory") forced them to be skipped. Signed-off-by: Jan Beulich <jbeul...@suse.com> --- v2: Avoid negative array index in setup_paging() to make code easier to

Re: [Xen-devel] [PATCH v5 08/11] vpci/bars: add handlers to map the BARs

>>> On 14.08.17 at 16:28, wrote: > +static int vpci_modify_bar(struct domain *d, const struct vpci_bar *bar, > + bool map) > +{ > +struct rangeset *mem; > +struct map_data data = { .d = d, .map = map }; > +int rc; > + > +

Re: [Xen-devel] [PATCH v5 02/11] vpci: introduce basic handlers to trap accesses to the PCI config space

>>> On 06.09.17 at 17:40, <roger@citrix.com> wrote: > On Mon, Sep 04, 2017 at 09:38:11AM -0600, Jan Beulich wrote: >> >>> On 14.08.17 at 16:28, <roger@citrix.com> wrote: >> > Changes since v4: >> >[...] >> > * Hypervisor

[Xen-devel] [PATCH v2 0/2] hvmloader: improve (debug) tests

1: dynamically determine scratch memory range for tests 2: clone REP INSW test from REP INSB one Signed-off-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] x86/HVM: drop bogus #PF raising from linear->phys translation

to such locations are being split elsewhere and hence have been working fine already). Signed-off-by: Jan Beulich <jbeul...@suse.com> --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -566,15 +566,12 @@ static int hvmemul_linear_to_phys( if ( pfec & (PFEC_

Re: [Xen-devel] [PATCH] x86: introduce and use setup_force_cpu_cap()

>>> Sarah Newman <s...@prgmr.com> 09/07/17 3:55 AM >>> >On 09/05/2017 06:22 AM, Jan Beulich wrote: >> For XEN_SMEP and XEN_SMAP to not be cleared while bringing up APs we'd >> need to clone the respective hack used for CPUID_FAULTING. Introduce an >

[Xen-devel] Xen 4.8.2 released

All, I am pleased to announce the release of Xen 4.8.2. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.8 (tag RELEASE-4.8.2) or from the XenProject download page

Re: [Xen-devel] [BUG] x86/hvm/vioapic: 8-Bit IOREGSEL write does not work

>>> On 06.09.17 at 11:58, wrote: > On 05/09/17 19:26, Christian Prochaska wrote: >> I've seen this problem with Xen 4.6.5 from the Xubuntu 16.04 >> distribution and from a quick look over the current vioapic code it >> seems to be still present. >> >> From the IOAPIC

Re: [Xen-devel] [PATCH] x86/traps: Fix show_page_walk() to avoid printing trailing whitespace

> Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 5/6] xen: RCU: avoid busy waiting until the end of grace period.

>>> On 05.09.17 at 19:13, <dario.faggi...@citrix.com> wrote: > On Wed, 2017-08-30 at 01:18 -0600, Jan Beulich wrote: >> > > > On 29.08.17 at 18:06, <george.dun...@citrix.com> wrote: >> > Dario is on holiday, and I think it would be good to get thi

Re: [Xen-devel] [PATCH v9 1/2] x86emul: New return code for unimplemented instruction

>>> On 05.09.17 at 18:20, <ppircal...@bitdefender.com> wrote: > On Ma, 2017-09-05 at 09:46 -0600, Jan Beulich wrote: >> > >> > > >> > > > >> > > > On 05.09.17 at 17:23, <ppircal...@bitdefen

Re: [Xen-devel] [PATCH 4/4] DEPS handling: Remove absolute paths from references to cwd

>>> On 05.09.17 at 17:32, <ian.jack...@eu.citrix.com> wrote: > Jan Beulich writes ("Re: [PATCH 4/4] DEPS handling: Remove absolute paths > from references to cwd"): >> On 04.09.17 at 18:46, <ian.jack...@eu.citrix.com> wrote: >> > +%.d2: %.d >

Re: [Xen-devel] [PATCH v9 1/2] x86emul: New return code for unimplemented instruction

>>> On 05.09.17 at 17:23, <ppircal...@bitdefender.com> wrote: > On Lu, 2017-09-04 at 23:42 -0600, Jan Beulich wrote: >> > > >> > > > >> > > > @@ -5177,7 +5177,7 @@ x86_emulate( >> > > > goto done; >>

<    3   4   5   6   7   8   9   10   11   12   >