Re: [Xen-devel] [PATCH 2/2] swiotlb-xen: pass dev_addr to swiotlb_tbl_unmap_single

On 01/26/2015, 11:53 AM, Ian Campbell wrote: On Fri, 2014-11-21 at 17:00 +, Stefano Stabellini wrote: Need to pass the pointer within the swiotlb internal buffer to the swiotlb library, that in the case of xen_unmap_single is dev_addr, not paddr. Signed-off-by: Stefano Stabellini

[Xen-devel] [PATCH 3.12 48/82] x86/xen: Probe target addresses in set_aliased_prot() before the hypercall

...@linutronix.de Cc: secur...@kernel.org secur...@kernel.org Cc: xen-devel xen-devel@lists.xen.org Link: http://lkml.kernel.org/r/0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.l...@kernel.org Signed-off-by: Ingo Molnar mi...@kernel.org Signed-off-by: Jiri Slaby jsl...@suse.cz --- arch/x86

[Xen-devel] [patch added to the 3.12 stable tree] x86/xen: Probe target addresses in set_aliased_prot() before the hypercall

: Thomas Gleixner t...@linutronix.de Cc: secur...@kernel.org secur...@kernel.org Cc: xen-devel xen-devel@lists.xen.org Link: http://lkml.kernel.org/r/0b0e55b995cda11e7829f140b833ef932fcabe3a.1438291540.git.l...@kernel.org Signed-off-by: Ingo Molnar mi...@kernel.org Signed-off-by: Jiri Slaby jsl

[Xen-devel] [PATCH 3.12 28/91] x86/cpu: Fix SMAP check in PVOPS environments

com Signed-off-by: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Jiri Slaby <jsl...@suse.cz> --- arch/x86/kernel/cpu/common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 6db4828574ef..936

[Xen-devel] [patch added to the 3.12 stable tree] x86/cpu: Fix SMAP check in PVOPS environments

-email-andrew.coop...@citrix.com Signed-off-by: Thomas Gleixner <t...@linutronix.de> Signed-off-by: Jiri Slaby <jsl...@suse.cz> --- arch/x86/kernel/cpu/common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c

Re: [Xen-devel] XSA-155 and XSA-157 fixes missing from some stable Linux trees

On 03/16/2016, 10:25 AM, Jan Beulich wrote: > Hello, > > it's been puzzling me for a while that these fixes, despite having the > necessary Cc, did not make it into (at least) 4.1.y and 3.12.y yet. > Unless there's a specific reason, may I ask for inclusion of > > CVE-2015-8550 / XSA-155: > >

[Xen-devel] [PATCH 02/10] x86: assembly, use ENDPROC for functions

Somewhere END was used to end a function, elsewhere, nothing was used. So unify it and mark them all by ENDPROC. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zyto

[Xen-devel] [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

on 4 locations. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: <x...@kernel.org> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> C

[Xen-devel] [PATCH 08/10] x86: assembly, annotate aliases

_key_expansion_128 is an alias to _key_expansion_256a, __memcpy to memcpy, xen_syscall32_target to xen_sysenter_target, and so on. Annotate them all using the new ENTRY_ALIAS and ENTRY_LOCAL_ALIAS. This will make the tools generating the debuginfo happy. Signed-off-by: Jiri Slaby <jsl...@suse

Re: [Xen-devel] [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

On 03/01/2017, 10:38 AM, Ingo Molnar wrote: > Agreed? Sure. I wanted to keep it minimal to see if you agree with this direction at all. No problem to be more intrusive :). thanks, -- js suse labs ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [patch added to 3.12-stable] x86/mm/xen: Suppress hugetlbfs in PV guests

r Zijlstra <pet...@infradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Toshi Kani <toshi.k...@hp.com> Cc: xen-devel <xen-de...@lists.xenproject.org> Link: http://lkml.kernel.org/r/57188ed802000078000e4...@prv-mh.provo.novell.com Signed-off-by: Ingo Molnar <mi...@kern

Re: [Xen-devel] Patch "x86/mm/xen: Suppress hugetlbfs in PV guests" (CVE-2016-3961) is missing in 3.4, 3.10 and 3.12 stable tree

On 11/21/2016, 04:22 PM, Thomas Deutschmann wrote: > Hi, > > the following patch is present in the following LTS kernels > >> =linux-3.2.81 >> =linux-3.16.36 >> =linux-3.18.33 >> =linux-4.1.24 >> =linux-4.4.9 > > > however it is missing from LTS kernels > > - linux-3.4 > - linux-3.10 > -

[Xen-devel] [PATCH 3.12 050/127] x86/mm/xen: Suppress hugetlbfs in PV guests

fradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Toshi Kani <toshi.k...@hp.com> Cc: xen-devel <xen-de...@lists.xenproject.org> Link: http://lkml.kernel.org/r/57188ed802000078000e4...@prv-mh.provo.novell.com Signed-off-by: Ingo Molnar <mi...@kernel.org> Signed-o

Re: [Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

On 03/22/2017, 03:11 PM, Josh Poimboeuf wrote: > Or, here's a much easier way to do it, without involving objtool: > > --- a/include/linux/linkage.h > +++ b/include/linux/linkage.h > @@ -138,9 +138,17 @@ > name: > #endif > > +#ifndef CHECK_DUP_SYM_END > +#define CHECK_DUP_SYM_END(name)

Re: [Xen-devel] [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote: > On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote: >> Somewhere END was used to end a function, elsewhere, nothing was used. >> So unify it and mark them all by SYM_FUNC_END. >> >> Signed-off-by: Jiri Slaby &

Re: [Xen-devel] [RFC] linkage: new macros for functions and data

On 03/16/2017, 09:02 AM, Ingo Molnar wrote: > > * Jiri Slaby <jsl...@suse.cz> wrote: > >> SYM_LOCAL_ALIAS_START -- use where there are two local names for one code >> SYM_ALIAS_START -- use where there are two global names for one code >> SYM_LOCAL_FUNC

[Xen-devel] [PATCH v2 07/10] x86: assembly, annotate aliases

. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: "David S. Miller" <da...@davemloft.net> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com>

[Xen-devel] [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

Somewhere END was used to end a function, elsewhere, nothing was used. So unify it and mark them all by SYM_FUNC_END. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@

[Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

. Automatically at best. This particular patch makes proper use of SYM_DATA_START on data and SYM_FUNC_START on a function which was not the case on 4 locations. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com

[Xen-devel] [PATCH v2 01/10] linkage: new macros for assembler symbols

* use SYM_ prefix and sane names * add SYM_START and SYM_END and parametrize all the macros Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: h...@zytor.com Cc: Ingo Molnar <mi...@kernel.

Re: [Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

On 03/20/2017, 02:32 PM, Josh Poimboeuf wrote: > On Mon, Mar 20, 2017 at 01:32:14PM +0100, Jiri Slaby wrote: >> This is a start of series to cleanup macros used for starting functions, >> data, globals etc. across x86. When we have all this sorted out, this >> will help to i

Re: [Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

On 03/22/2017, 08:25 AM, Ingo Molnar wrote: > > * Pavel Machek wrote: > >> Hi! >> >>> -ENTRY(saved_rbp) .quad 0 >>> -ENTRY(saved_rsi) .quad 0 >>> -ENTRY(saved_rdi) .quad 0 >>> -ENTRY(saved_rbx) .quad 0 >>> +SYM_DATA_START(saved_rbp) .quad 0 >>>

Re: [Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

Hi, On 03/21/2017, 03:08 PM, Pavel Machek wrote: >> -ENTRY(saved_rbp).quad 0 >> -ENTRY(saved_rsi).quad 0 >> -ENTRY(saved_rdi).quad 0 >> -ENTRY(saved_rbx).quad 0 >> +SYM_DATA_START(saved_rbp) .quad 0 >> +SYM_DATA_START(saved_rsi) .quad 0 >>

Re: [Xen-devel] [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

On 04/10/2017, 09:35 PM, Josh Poimboeuf wrote: > The code should be in a mergeable state after each patch. If only > patches 1-3 were merged, the code would be in an inconsistent state, > with some functions having confusing ENTRY/SYM_FUNC_END pairs. That > complicates git history and also makes

Re: [Xen-devel] [PATCH v2 03/10] x86: assembly, use SYM_FUNC_END for functions

On 03/22/2017, 04:44 PM, Jiri Slaby wrote: > On 03/22/2017, 03:26 PM, Josh Poimboeuf wrote: >> On Mon, Mar 20, 2017 at 01:32:15PM +0100, Jiri Slaby wrote: >>> Somewhere END was used to end a function, elsewhere, nothing was used. >>> So unify it and mark them all by S

[Xen-devel] [PATCH v3 08/29] linkage: new macros for assembler symbols

arametrize all the macros [v3] * add SYM_DATA_SIMPLE, SYM_DATA_SIMPLE_LOCAL, and SYM_DATA_END_LABEL Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: h...@zytor.com Cc: Ingo Molnar

[Xen-devel] [PATCH v3 26/29] x86_64: assembly, change all ENTRY to SYM_FUNC_START

These are all functions which are invoked from elsewhere, so we annotate them as global using the new SYM_FUNC_START (and their ENDPROC's by SYM_FUNC_END.) And make sure ENTRY/ENDPROC is not defined on X86_64. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: "H. Peter Anvin" <

[Xen-devel] [PATCH v3 25/29] x86: assembly, make some functions local

There is couple of assembly functions, which are invoked only locally in a file they are defined. In C, we mark them "static". Annotate them here using SYM_FUNC_START_LOCAL (and switch their ENDPROC to SYM_FUNC_END too). Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: &qu

[Xen-devel] [PATCH v3 05/29] x86: assembly, add ENDPROC to functions

in the object file So fix this by adding ENDPROC to each such case. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: <x...@kernel.org> Cc: "Rafa

[Xen-devel] [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

Somewhere END was used to end a function. It is not intended to be used for functions, because it does not mark the actual symbols as functions. Use ENDPROC in such cases which does the right job. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de> Cc:

[Xen-devel] [PATCH v3 27/29] x86_32: assembly, change all ENTRY to SYM_FUNC_START

These are all functions which are invoked from elsewhere, so we annotate them as global using the new SYM_FUNC_START (and their ENDPROC's by SYM_FUNC_END.) Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: Thomas Gleixner <t...@linutroni

[Xen-devel] [PATCH v3 20/29] x86: xen-pvh, annotate data appropriatelly

early_stack Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Juergen Gross <jgr...@suse.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h..

[Xen-devel] [PATCH v3 15/29] x86: assembly, annotate aliases

. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: "David S. Miller" <da...@davemloft.net> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com>

Re: [Xen-devel] [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

On 03/03/2017, 07:20 PM, h...@zytor.com wrote: > On March 1, 2017 2:27:54 AM PST, Ingo Molnar <mi...@kernel.org> wrote: >> >> * Thomas Gleixner <t...@linutronix.de> wrote: >> >>> On Wed, 1 Mar 2017, Ingo Molnar wrote: >>>> >>>&g

[Xen-devel] [RFC] linkage: new macros for functions and data

SYM_ALIAS_END -- the end of LOCALALIASed or ALIASed code SYM_FUNCTION_END -- the end of SYM_LOCAL_FUNC_START, SYM_FUNCTION_START, SYM_WEAK_FUNC_START, ... SYM_DATA_START -- global data symbol SYM_DATA_END -- the end of SYM_DATA_START symbol Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Andrew

Re: [Xen-devel] [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

On 03/01/2017, 11:27 AM, Ingo Molnar wrote: > But no strong feelings either way, I just try to sneak in these small > namespace > structure tricks when nobody's looking! ;-) So I assume to introduce two underscores. thanks, -- js suse labs ___

Re: [Xen-devel] [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

On 04/26/2017, 03:42 AM, Josh Poimboeuf wrote: >> @@ -323,7 +323,7 @@ ENTRY(resume_userspace) >> movl%esp, %eax >> callprepare_exit_to_usermode >> jmp restore_all >> -END(ret_from_exception) >> +ENDPROC(ret_from_exception) > > What exactly is the motivation of this

Re: [Xen-devel] [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

On 05/13/2017, 12:15 AM, Josh Poimboeuf wrote: >> Similarly, I have OBJTOOL(START_FUNC) and OBJTOOL(END_FUNC) emitted with >> each FUNC_START/FUNC_END. So far, when manually expanded for simplicity, >> it looks like this: > > I like the idea of making objtool smart enough to read the entry code,

Re: [Xen-devel] [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

On 05/17/2017, 03:23 PM, Jiri Slaby wrote: >> So the initial CFI state is different between the two types of >> "functions". And there are a lot of other differences. C-type >> functions have to follow frame pointer conventions, for example. So >> your FUNC_ST

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

On 10/02/2017, 02:48 PM, Ard Biesheuvel wrote: > On 2 October 2017 at 10:12, Jiri Slaby <jsl...@suse.cz> wrote: >> There is a couple of assembly functions, which are invoked only locally >> in the file they are defined. In C, we mark them "static". In assembly, &

[Xen-devel] [PATCH v4 08/27] x86: assembly, annotate aliases

. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: "David S. Miller" <da...@davemloft.net> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h...@zytor.com>

[Xen-devel] [PATCH v4 23/27] x86_64: assembly, change all ENTRY+ENDPROC to SYM_FUNC_*

These are all functions which are invoked from elsewhere, so we annotate them as global using the new SYM_FUNC_START. And their ENDPROC's by SYM_FUNC_END. And make sure ENTRY/ENDPROC is not defined on X86_64, given these were the last users. Signed-off-by: Jiri Slaby <jsl...@suse.cz>

[Xen-devel] [PATCH v4 24/27] x86_32: assembly, add ENDs to some functions and relabel with SYM_CODE_*

All these are functions which are invoked from elsewhere, but they are not typical C functions. So we annotate them (as global) using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END, appropriatelly. Signed-off-by: Jiri Slaby <jsl...@suse.cz&

[Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

NDPROC/END for a particular function (C or non-C). Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: "H. Peter Anvin" <h...@zytor.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: x...@kernel.org Cc: Matt Fleming <m...@codeblueprint.co.uk

[Xen-devel] [PATCH v4 21/27] x86_64: assembly, add ENDs to some functions and relabel with SYM_CODE_*

All these are functions which are invoked from elsewhere, but they are not typical C functions. So we annotate them (as global) using the new SYM_CODE_START. All these were not balanced with any END, so mark their ends by SYM_CODE_END, appropriatelly. Signed-off-by: Jiri Slaby <jsl...@suse.cz&

[Xen-devel] [PATCH v4 22/27] x86_64: assembly, change all ENTRY+END to SYM_CODE_*

Here, we change all code which is not marked as functions. In other words, this code has been using END, not ENDPROC. So switch all of this to appropriate new markings SYM_CODE_START and SYM_CODE_END. Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Thomas Gleixner <t...@linutronix.de&

[Xen-devel] [PATCH v4 01/27] linkage: new macros for assembler symbols

nd SYM_END and parametrize all the macros [v3] * add SYM_DATA_SIMPLE, SYM_DATA_SIMPLE_LOCAL, and SYM_DATA_END_LABEL [v4] * add _NOALIGN versions of some macros * add _CODE_ derivates of _FUNC_ macros Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Andrew Morton <a...@linux-foundation.org&g

[Xen-devel] [PATCH v4 13/27] x86: xen-pvh, annotate data appropriatelly

early_stack Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Juergen Gross <jgr...@suse.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Ingo Molnar <mi...@redhat.com> Cc: "H. Peter Anvin" <h..

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

Hi, On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote: > On 4 October 2017 at 08:22, Jiri Slaby <jsl...@suse.cz> wrote: >> On 10/02/2017, 02:48 PM, Ard Biesheuvel wrote: >>> On 2 October 2017 at 10:12, Jiri Slaby <jsl...@suse.cz> wrote: >>>> There is a coupl

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

Hi, On 10/06/2017, 03:21 PM, Mark Rutland wrote: > If the aim of this series is to introduce something that architectures > use consistently, then can we please actually poke other architectures > about it? e.g. send this to linux-arch, with a cover letter explaining > the idea and asking

Re: [Xen-devel] [PATCH v4 01/27] linkage: new macros for assembler symbols

On 10/06/2017, 05:23 PM, Josh Poimboeuf wrote: > On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote: >>SYM_CODE_INNER_LABEL -- only for labels in the middle of code >>SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code > > Why are the

Re: [Xen-devel] [PATCH v4 19/27] x86: assembly, make some functions local

On 10/06/2017, 04:01 PM, Ard Biesheuvel wrote: > On 6 October 2017 at 13:53, Jiri Slaby <jsl...@suse.cz> wrote: >> On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote: >>> In arm64, we use ENTRY/ENDPROC for functions with external linkage, >>> and the bare symbol name