Re: [Xen-devel] [PATCH 0/2] limit xen vnic max queues number to online cpu number

2015-10-23 Thread Joe Jin
On 10/23/2015 04:47 PM, Paul Durrant wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev- >> ow...@vger.kernel.org] On Behalf Of Joe Jin >> Sent: 23 October 2015 08:54 >> To: Wei Liu; Ian Campbell; Boris Ostrovsky; Konrad Rzes

[Xen-devel] [PATCH V2 0/2] limit xen vnic max queues number to online cpus number

2015-10-23 Thread Joe Jin
. Joe Jin (2): xen-netback: limit xen vif max queues number to online cpus xen-netfront: limit vnic max_queues number to online cpus --- Changes in v2: - Replace param_get_int to param_get_uint. - Use '%u' for unsigned int when print. - Replace EINVAL to ERANGE when out of range [0-CPUs

[Xen-devel] [PATCH V2 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-23 Thread Joe Jin
Should not allocate xen vif queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Jan Beulich <jbeul...@suse.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com

[Xen-devel] [PATCH V3 0/2] limit xen vnic max queues number to online cpus number

2015-10-23 Thread Joe Jin
. Joe Jin (2): xen-netback: limit xen vif max queues number to online cpus xen-netfront: limit vnic max_queues number to online cpus --- Changes in v3: - Corrected the range info [1-CPUs]. Changes in v2: - Replace param_get_int to param_get_uint. - Use '%u' for unsigned int when print

[Xen-devel] [PATCH V3 2/2] xen-netfront: limit vnic max_queues number to online cpus

2015-10-23 Thread Joe Jin
Should not allocate vnic queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Jan Beulich <jbeul...@suse.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com

Re: [Xen-devel] [PATCH V2 2/2] xen-netfront: limit vnic max_queues number to online cpus

2015-10-23 Thread Joe Jin
pr_err("max_queues %u is out of range [0 - %u]!\n", > > I suppose you mean "...[1 - %u]!\n" here? Yes you are right, you catch my fault again :) Thanks so much, will resend new later. Regards, Joe > Jan > -- Oracle <http://www.oracle.com> Joe

[Xen-devel] [PATCH V3 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-23 Thread Joe Jin
Should not allocate xen vif queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Jan Beulich <jbeul...@suse.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com

[Xen-devel] [PATCH 1/1] xen-netfront: limit max queues number to online cpus

2015-10-22 Thread Joe Jin
Should not allocate queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Cc: David S. Miller <da...@davemloft.net> --- drivers/net/xen-netfr

Re: [Xen-devel] [PATCH 1/1] xen-netfront: limit max queues number to online cpus

2015-10-23 Thread Joe Jin
We need to take care sysfs too, please ignore this patch, I'll create new one later for review and comment. Thanks, Joe On 10/23/2015 08:50 AM, Joe Jin wrote: > Should not allocate queues number more than online cpus. > > Signed-off-by: Joe Jin <joe@oracle.com> > C

[Xen-devel] [PATCH 0/2] limit xen vnic max queues number to online cpu number

2015-10-23 Thread Joe Jin
Currently xen vnic allowed to create lots of queues by set module param max_queues(both netback and netfront), when queues number larger than cpu number, it does not help for performance but need more cpu time. This patchset limit netback and netfront max queues number to online cpus number. Joe

[Xen-devel] [PATCH 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-23 Thread Joe Jin
Should not allocate xen vif queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Konrad Rzeszutek Wilk

[Xen-devel] [PATCH 2/2] xen-front: limit vnic max_queues number to online cpus

2015-10-23 Thread Joe Jin
Should not allocate vnic queues number more than online cpus. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Konrad Rzeszutek Wilk <konrad.w.

Re: [Xen-devel] [PATCH 1/2] xen-netback: limit xen vif max queues number to online cpus

2015-10-23 Thread Joe Jin
> >> -/* Allow as many queues as there are CPUs if user has not >> - * specified a value. >> - */ >> -if (xenvif_max_queues == 0) >> - xenvif_max_queues = num_online_cpus(); >> +/* Allow at most as many queues as CPUs. */ >> +if (xenv

[Xen-devel] [PATCH v2 1/1] xen-netfront: update num_queues to real created

2015-10-18 Thread Joe Jin
Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer dereference. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Konrad Rzeszutek Wi

[Xen-devel] [PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-14 Thread Joe Jin
Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer dereference. Signed-off-by: Joe Jin <joe@oracle.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> C

Re: [Xen-devel] [PATCH] Remove redundant code in branch MAP_PIRQ_TYPE_MSI

2017-10-09 Thread Joe Jin
Looks good for me. Reviewed-by: Joe Jin <joe@oracle.com> On 10/09/2017 02:00 PM, Zhenzhong Duan wrote: > Same code is already in allocate_and_map_msi_pirq() > > Signed-off-by: Zhenzhong Duan <zhenzhong.d...@oracle.com> > --- > xen/arch/x86/physdev.c |