Re: [Xen-devel] [PATCH v2 17/32] arm: define __smp_xxx

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:36:58PM +0100, Peter Zijlstra wrote: > On Sun, Jan 03, 2016 at 11:12:44AM +0200, Michael S. Tsirkin wrote: > > On Sat, Jan 02, 2016 at 11:24:38AM +, Russell King - ARM Linux wrote: > > > > My only concern is that it gives people an add

Re: [Xen-devel] [PATCH v2 22/32] s390: define __smp_xxx

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:45:25PM +0100, Peter Zijlstra wrote: > On Thu, Dec 31, 2015 at 09:08:38PM +0200, Michael S. Tsirkin wrote: > > This defines __smp_xxx barriers for s390, > > for use by virtualization. > > > > Some smp_xxx barriers are removed as they are &

Re: [Xen-devel] [PATCH v2 06/32] s390: reuse asm-generic/barrier.h

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:20:42PM +0100, Peter Zijlstra wrote: > On Thu, Dec 31, 2015 at 09:06:30PM +0200, Michael S. Tsirkin wrote: > > On s390 read_barrier_depends, smp_read_barrier_depends > > smp_store_mb(), smp_mb__before_atomic and smp_mb__after_atomic match the > >

Re: [Xen-devel] [PATCH v2 17/32] arm: define __smp_xxx

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:54:20PM +0100, Peter Zijlstra wrote: > On Mon, Jan 04, 2016 at 02:36:58PM +0100, Peter Zijlstra wrote: > > On Sun, Jan 03, 2016 at 11:12:44AM +0200, Michael S. Tsirkin wrote: > > > On Sat, Jan 02, 2016 at 11:24:38AM +, Russell King - ARM Linux wrot

Re: [Xen-devel] [PATCH v2 06/32] s390: reuse asm-generic/barrier.h

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 04:03:39PM +0100, Martin Schwidefsky wrote: > On Mon, 4 Jan 2016 14:20:42 +0100 > Peter Zijlstra wrote: > > > On Thu, Dec 31, 2015 at 09:06:30PM +0200, Michael S. Tsirkin wrote: > > > On s390 read_barrier_depends, smp_read_barrier_de

Re: [Xen-devel] [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > SMP-only barriers were missing in checkpatch.pl > > > > Refactor code slightly to make adding more variants easier. > > > >

Re: [Xen-devel] [PATCH 3/3] checkpatch: add virt barriers

2016-01-04 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 08:47:53AM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 13:37 +0200, Michael S. Tsirkin wrote: > > Add virt_ barriers to list of barriers to check for > > presence of a comment. > > Are these virt_ barriers used anywhere? > > I see som

Re: [Xen-devel] [PATCH v2 15/32] powerpc: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 09:36:55AM +0800, Boqun Feng wrote: > Hi Michael, > > On Thu, Dec 31, 2015 at 09:07:42PM +0200, Michael S. Tsirkin wrote: > > This defines __smp_xxx barriers for powerpc > > for use by virtualization. > > > > smp_xxx barriers are removed

Re: [Xen-devel] [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 09:13:19AM +0100, Martin Schwidefsky wrote: > On Mon, 4 Jan 2016 22:18:58 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Jan 04, 2016 at 02:45:25PM +0100, Peter Zijlstra wrote: > > > On Thu, Dec 31, 2015 at 09:08:38PM +0200, Mich

Re: [Xen-devel] [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 01:08:52PM +0100, Martin Schwidefsky wrote: > On Tue, 5 Jan 2016 11:30:19 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 05, 2016 at 09:13:19AM +0100, Martin Schwidefsky wrote: > > > On Mon, 4 Jan 2016 22:18:58 +0200

Re: [Xen-devel] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 12:41:27PM +0100, Gerd Hoffmann wrote: > Hi, > > We have some code in our tree to support pci passthrough of intel > graphics devices (igd) on xen, which requires some chipset tweaks > for (a) the host bridge and (b) the lpc/isa-bridge to meat the > expectations of the gu

Re: [Xen-devel] [PATCH v2 17/32] arm: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 01:59:34PM +, Russell King - ARM Linux wrote: > On Mon, Jan 04, 2016 at 02:54:20PM +0100, Peter Zijlstra wrote: > > On Mon, Jan 04, 2016 at 02:36:58PM +0100, Peter Zijlstra wrote: > > > On Sun, Jan 03, 2016 at 11:12:44AM +0200, Michael S. Tsirkin wro

Re: [Xen-devel] [PATCH v2 22/32] s390: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 04:39:37PM +0100, Christian Borntraeger wrote: > On 01/05/2016 10:30 AM, Michael S. Tsirkin wrote: > > > > > arch/s390/kernel/vdso.c:smp_mb(); > > > > Looking at > > Author: Christian Borntraeger > >

Re: [Xen-devel] [PATCH v2 15/32] powerpc: define __smp_xxx

2016-01-05 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 05:53:41PM +0800, Boqun Feng wrote: > On Tue, Jan 05, 2016 at 10:51:17AM +0200, Michael S. Tsirkin wrote: > > On Tue, Jan 05, 2016 at 09:36:55AM +0800, Boqun Feng wrote: > > > Hi Michael, > > > > > > On Thu, Dec 31, 2015 at 09:07:

Re: [Xen-devel] [PATCH v2 15/32] powerpc: define __smp_xxx

2016-01-06 Thread Michael S. Tsirkin
On Wed, Jan 06, 2016 at 09:51:52AM +0800, Boqun Feng wrote: > On Tue, Jan 05, 2016 at 06:16:48PM +0200, Michael S. Tsirkin wrote: > [snip] > > > > > Another thing is that smp_lwsync() may have a third user(other than > > > > > smp_load_acquire() and smp_store_r

Re: [Xen-devel] [PATCH 3/3] checkpatch: add virt barriers

2016-01-08 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:11:37PM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 23:07 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2016 at 08:47:53AM -0800, Joe Perches wrote: > > > On Mon, 2016-01-04 at 13:37 +0200, Michael S. Tsirkin wrote: > > > >

Re: [Xen-devel] [PATCH 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
On Mon, Jan 04, 2016 at 02:15:50PM -0800, Joe Perches wrote: > On Mon, 2016-01-04 at 22:45 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 04, 2016 at 08:07:40AM -0800, Joe Perches wrote: > > > On Mon, 2016-01-04 at 13:36 +0200, Michael S. Tsirkin wrote: > > > > SMP

[Xen-devel] [PATCH v2 0/3] checkpatch: handling of memory barriers

2016-01-10 Thread Michael S. Tsirkin
optional\s* before () in barriers rewrite using qr{} instead of map Michael S. Tsirkin (3): checkpatch.pl: add missing memory barriers checkpatch: check for __smp outside barrier.h checkpatch: add virt barriers scripts/checkpatch.pl | 31 ++- 1 file

[Xen-devel] [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h

2016-01-10 Thread Michael S. Tsirkin
a checkpatch test so it will trigger a warning. Reported-by: Russell King Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 97b8b62..a96adcb 100755 --- a/scripts/checkpa

[Xen-devel] [PATCH v2 3/3] checkpatch: add virt barriers

2016-01-10 Thread Michael S. Tsirkin
Add virt_ barriers to list of barriers to check for presence of a comment. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a96adcb..5ca272b 100755 --- a/scripts

[Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
SMP-only barriers were missing in checkpatch.pl Refactor code slightly to make adding more variants easier. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[Xen-devel] [PATCH v3 06/41] s390: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/s390/include/asm/barrier.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/s390/include/asm/barrier.h b/arch/s390/include/asm/barrier.h index 7ffd0b1..c358c31 100644 --- a/arch/s390/include/asm/barrier.h

[Xen-devel] [PATCH v3 01/41] lcoking/barriers, arch: Use smp barriers in smp_store_release()

2016-01-10 Thread Michael S. Tsirkin
From: Davidlohr Bueso With commit b92b8b35a2e ("locking/arch: Rename set_mb() to smp_store_mb()") it was made clear that the context of this call (and thus set_mb) is strictly for CPU ordering, as opposed to IO. As such all archs should use the smp variant of mb(), respecting the semantics and sa

[Xen-devel] [PATCH v3 03/41] ia64: rename nop->iosapic_nop

2016-01-10 Thread Michael S. Tsirkin
asm-generic/barrier.h defines a nop() macro. To be able to use this header on ia64, we shouldn't call local functions/variables nop(). There's one instance where this breaks on ia64: rename the function to iosapic_nop to avoid the conflict. Signed-off-by: Michael S. Tsirkin Acked-by:

[Xen-devel] [PATCH v3 04/41] ia64: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
On ia64 smp_rmb, smp_wmb, read_barrier_depends, smp_read_barrier_depends and smp_store_mb() match the asm-generic variants exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin Acked

[Xen-devel] [PATCH v3 05/41] powerpc: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/powerpc/include/asm/barrier.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/include/asm/barrier.h b/arch/powerpc/include/asm/barrier.h index a7af5fb..980ad0c 100644 --- a/arch/powerpc/include/asm

[Xen-devel] [PATCH v3 02/41] asm-generic: guard smp_store_release/load_acquire

2016-01-10 Thread Michael S. Tsirkin
Allow architectures to override smp_store_release and smp_load_acquire by guarding the defines in asm-generic/barrier.h with ifndef directives. This is in preparation to reusing asm-generic/barrier.h on architectures which have their own definition of these macros. Signed-off-by: Michael S

[Xen-devel] [PATCH v3 00/41] arch: barrier cleanup + barriers for virt

2016-01-10 Thread Michael S. Tsirkin
n drivers to use the virt_xxx APIs compiled only (by intel 0-day infrastructure) -. Patch 40 makes some smp barriers on s390 more efficient included here to avoid merge conflicts, at maintainer's request tested on x86 Davidlohr Bueso (1): lcoking/barriers, arch: Use smp barrier

[Xen-devel] [PATCH v3 08/41] arm: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
refactoring this code area. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked-by: Russell King --- arch/arm/include/asm/barrier.h | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/arch/arm/include/asm/barrier.h b/arch/arm/include/asm/barrier.h

[Xen-devel] [PATCH v3 07/41] sparc: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
generic version, drop that as well. This is in preparation to refactoring this code area. Note: nop() was in processor.h and not in barrier.h as on other architectures. Nothing seems to depend on it being there though. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked-by: David S

[Xen-devel] [PATCH v3 09/41] arm64: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/arm64/include/asm/barrier.h | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h index 9622eb4..91a43f4 100644 --- a/arch/arm64/include/asm

[Xen-devel] [PATCH v3 12/41] x86/um: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
On x86/um CONFIG_SMP is never defined. As a result, several macros match the asm-generic variant exactly. Drop the local definitions and pull in asm-generic/barrier.h instead. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked

[Xen-devel] [PATCH v3 14/41] asm-generic: add __smp_xxx wrappers

2016-01-10 Thread Michael S. Tsirkin
ones or barrier() depending on SMP, identically for all architectures. We keep ifndef guards around them for now - once/if all architectures are converted to use the generic code, we'll be able to remove these. Suggested-by: Peter Zijlstra Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Ber

[Xen-devel] [PATCH v3 11/41] mips: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/mips/include/asm/barrier.h | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/arch/mips/include/asm/barrier.h b/arch/mips/include/asm/barrier.h index 752e0b8..3eac4b9 100644 --- a/arch/mips

[Xen-devel] [PATCH v3 15/41] powerpc: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for powerpc for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h This reduces the amount of arch-specific boiler-plate code. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked-by: Boqun

[Xen-devel] [PATCH v3 10/41] metag: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/metag/include/asm/barrier.h | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/arch/metag/include/asm/barrier.h b/arch/metag/include/asm/barrier.h index 172b7e5..b5b778b 100644 --- a/arch

[Xen-devel] [PATCH v3 13/41] x86: reuse asm-generic/barrier.h

2016-01-10 Thread Michael S. Tsirkin
As on most architectures, on x86 read_barrier_depends and smp_read_barrier_depends are empty. Drop the local definitions and pull the generic ones from asm-generic/barrier.h instead: they are identical. This is in preparation to refactoring this code area. Signed-off-by: Michael S. Tsirkin

[Xen-devel] [PATCH v3 17/41] arm: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for arm, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h This reduces the amount of arch-specific boiler-plate code. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked-by: Russell King

[Xen-devel] [PATCH v3 16/41] arm64: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for arm64, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Note: arm64 does not support !SMP config, so smp_xxx and __smp_xxx are always equivalent. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd

[Xen-devel] [PATCH v3 20/41] metag: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
between SMP and !SMP. For this reason, this patch introduces a wrapper metag_fence() that doesn't depend on CONFIG_SMP. fence() is then defined using that, depending on CONFIG_SMP. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/metag/include/asm/barrier.h

[Xen-devel] [PATCH v3 19/41] ia64: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for ia64, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h This reduces the amount of arch-specific boiler-plate code. Signed-off-by: Michael S. Tsirkin Acked-by: Tony Luck Acked-by: Arnd Bergmann

[Xen-devel] [PATCH v3 18/41] blackfin: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for blackfin, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/blackfin/include/asm/barrier.h | 4 ++-- 1 file changed, 2

[Xen-devel] [PATCH v3 21/41] mips: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
/barriers.h) and smp_mb__before_llsc (for use elsewhere on this architecture). Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/mips/include/asm/barrier.h | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/mips/include/asm/barrier.h

[Xen-devel] [PATCH v3 22/41] s390: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for s390, for use by virtualization. Some smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Note: smp_mb, smp_rmb and smp_wmb are defined as full barriers unconditionally on this architecture. Signed-off-by: Michael S. Tsirkin

[Xen-devel] [PATCH v3 26/41] xtensa: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for xtensa, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/xtensa/include/asm/barrier.h | 4 ++-- 1 file changed, 2 insertions

[Xen-devel] [PATCH v3 24/41] sparc: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for sparc, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann Acked-by: David S. Miller --- arch/sparc/include/asm/barrier_64.h | 8

[Xen-devel] [PATCH v3 27/41] x86: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for x86, for use by virtualization. smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Signed-off-by: Michael S. Tsirkin Acked-by: Arnd Bergmann --- arch/x86/include/asm/barrier.h | 31 --- 1 file

[Xen-devel] [PATCH v3 23/41] sh: define __smp_xxx, fix smp_store_mb for !SMP

2016-01-10 Thread Michael S. Tsirkin
sh variant of smp_store_mb() calls xchg() on !SMP which is stronger than implied by both the name and the documentation. define __smp_store_mb instead: code in asm-generic/barrier.h will then define smp_store_mb correctly depending on CONFIG_SMP. Signed-off-by: Michael S. Tsirkin Acked-by: Arnd

[Xen-devel] [PATCH v3 25/41] tile: define __smp_xxx

2016-01-10 Thread Michael S. Tsirkin
This defines __smp_xxx barriers for tile, for use by virtualization. Some smp_xxx barriers are removed as they are defined correctly by asm-generic/barriers.h Note: for 32 bit, keep smp_mb__after_atomic around since it's faster than the generic implementation. Signed-off-by: Michael S. Ts

[Xen-devel] [PATCH v3 29/41] Revert "virtio_ring: Update weak barriers to use dma_wmb/rmb"

2016-01-10 Thread Michael S. Tsirkin
!SMP. We switch to __smp_XXX barriers in the next patch. Cc: Peter Zijlstra Cc: Alexander Duyck Signed-off-by: Michael S. Tsirkin --- include/linux/virtio_ring.h | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/include/linux/virtio_ring.h b/include

[Xen-devel] [PATCH v3 34/41] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
SMP-only barriers were missing in checkpatch.pl Refactor code slightly to make adding more variants easier. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[Xen-devel] [PATCH v3 30/41] virtio_ring: update weak barriers to use virt_xxx

2016-01-10 Thread Michael S. Tsirkin
-by: Michael S. Tsirkin --- include/linux/virtio_ring.h | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index 67e06fe..f3fa55b 100644 --- a/include/linux/virtio_ring.h +++ b/include/linux

[Xen-devel] [PATCH v3 31/41] sh: support 1 and 2 byte xchg

2016-01-10 Thread Michael S. Tsirkin
. Suggested-by: Rich Felker Signed-off-by: Michael S. Tsirkin --- arch/sh/include/asm/cmpxchg-grb.h | 22 +++ arch/sh/include/asm/cmpxchg-irq.h | 11 arch/sh/include/asm/cmpxchg-llsc.h | 58 +++--- arch/sh/include/asm/cmpxchg.h | 3 ++ 4 files

[Xen-devel] [PATCH v3 32/41] sh: move xchg_cmpxchg to a header by itself

2016-01-10 Thread Michael S. Tsirkin
Looks like future sh variants will support a 4-byte cas which will be used to implement 1 and 2 byte xchg. This is exactly what we do for llsc now, move the portable part of the code into a separate header so it's easy to reuse. Suggested-by: Rich Felker Signed-off-by: Michael S. Ts

[Xen-devel] [PATCH v3 33/41] virtio_ring: use virt_store_mb

2016-01-10 Thread Michael S. Tsirkin
r pointers. Signed-off-by: Michael S. Tsirkin --- include/linux/virtio_ring.h | 11 +++ drivers/virtio/virtio_ring.c | 15 +-- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index f3fa55b..a156e2b 10

[Xen-devel] [PATCH v3 28/41] asm-generic: implement virt_xxx memory barriers

2016-01-10 Thread Michael S. Tsirkin
-by: David Miller Signed-off-by: Michael S. Tsirkin --- include/asm-generic/barrier.h | 11 +++ Documentation/memory-barriers.txt | 28 +++- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/include/asm-generic/barrier.h b/include/asm-generic

[Xen-devel] [PATCH v3 36/41] checkpatch: add virt barriers

2016-01-10 Thread Michael S. Tsirkin
Add virt_ barriers to list of barriers to check for presence of a comment. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a96adcb..5ca272b 100755 --- a/scripts

[Xen-devel] [PATCH v3 35/41] checkpatch: check for __smp outside barrier.h

2016-01-10 Thread Michael S. Tsirkin
a checkpatch test so it will trigger a warning. Reported-by: Russell King Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 97b8b62..a96adcb 100755 --- a/scripts/checkpa

[Xen-devel] [PATCH v3 40/41] s390: use generic memory barriers

2016-01-10 Thread Michael S. Tsirkin
The s390 kernel is SMP to 99.99%, we just didn't bother with a non-smp variant for the memory-barriers. If the generic header is used we'd get the non-smp version for free. It will save a small amount of text space for CONFIG_SMP=n. Suggested-by: Martin Schwidefsky Signed-off-by:

[Xen-devel] [PATCH v3 37/41] xenbus: use virt_xxx barriers

2016-01-10 Thread Michael S. Tsirkin
exact purpose. Signed-off-by: Michael S. Tsirkin Acked-by: David Vrabel --- drivers/xen/xenbus/xenbus_comms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/xen/xenbus/xenbus_comms.c b/drivers/xen/xenbus/xenbus_comms.c index fdb0f33..ecdecce 100644 --- a

[Xen-devel] [PATCH v3 39/41] xen/events: use virt_xxx barriers

2016-01-10 Thread Michael S. Tsirkin
/barrier.h here to make sure the file is self-contained. Suggested-by: David Vrabel Signed-off-by: Michael S. Tsirkin --- drivers/xen/events/events_fifo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/events/events_fifo.c b/drivers/xen/events/events_fifo.c index

[Xen-devel] [PATCH v3 41/41] s390: more efficient smp barriers

2016-01-10 Thread Michael S. Tsirkin
Schwidefsky Signed-off-by: Michael S. Tsirkin --- arch/s390/include/asm/barrier.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/s390/include/asm/barrier.h b/arch/s390/include/asm/barrier.h index 4d26fa4..5c8db3c 100644 --- a/arch/s390/include/asm/barrier.h +++ b/arch/s390/include/asm

[Xen-devel] [PATCH v3 38/41] xen/io: use virt_xxx barriers

2016-01-10 Thread Michael S. Tsirkin
exact purpose. Signed-off-by: Michael S. Tsirkin Acked-by: David Vrabel --- include/xen/interface/io/ring.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/xen/interface/io/ring.h b/include/xen/interface/io/ring.h index 7dc685b..21f4fbd 100644 --- a

Re: [Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
On Sun, Jan 10, 2016 at 07:07:05AM -0800, Joe Perches wrote: > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > > SMP-only barriers were missing in checkpatch.pl > > > > Refactor code slightly to make adding more variants easier. > [] > > diff --git a/s

Re: [Xen-devel] [PATCH v2 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote: > On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote: > > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote: > > > SMP-only barriers were missing in checkpatch.pl > > > > > > Refact

[Xen-devel] [PATCH v3 0/3] checkpatch: handling of memory barriers

2016-01-10 Thread Michael S. Tsirkin
{} instead of map Michael S. Tsirkin (3): checkpatch.pl: add missing memory barriers checkpatch: check for __smp outside barrier.h checkpatch: add virt barriers scripts/checkpatch.pl | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) -- MST

[Xen-devel] [PATCH v3 3/3] checkpatch: add virt barriers

2016-01-10 Thread Michael S. Tsirkin
Add virt_ barriers to list of barriers to check for presence of a comment. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 15cfca4..4466579 100755 --- a/scripts

[Xen-devel] [PATCH v3 1/3] checkpatch.pl: add missing memory barriers

2016-01-10 Thread Michael S. Tsirkin
SMP-only barriers were missing in checkpatch.pl Refactor code slightly to make adding more variants easier. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[Xen-devel] [PATCH v3 2/3] checkpatch: check for __smp outside barrier.h

2016-01-10 Thread Michael S. Tsirkin
a checkpatch test so it will trigger a warning. Reported-by: Russell King Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1c01b7d..15cfca4 100755 --- a/scripts/checkpa

Re: [Xen-devel] [PATCH v3 3/3] checkpatch: add virt barriers

2016-01-11 Thread Michael S. Tsirkin
On Sun, Jan 10, 2016 at 02:52:16PM -0800, Joe Perches wrote: > On Mon, 2016-01-11 at 09:13 +1100, Julian Calaby wrote: > > On Mon, Jan 11, 2016 at 6:31 AM, Michael S. Tsirkin wrote: > > > Add virt_ barriers to list of barriers to check for > > > presence of a comme

Re: [Xen-devel] [PATCH v3 3/3] checkpatch: add virt barriers

2016-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 09:40:18PM +1100, Julian Calaby wrote: > Hi Michael, > > On Mon, Jan 11, 2016 at 9:35 PM, Michael S. Tsirkin wrote: > > On Sun, Jan 10, 2016 at 02:52:16PM -0800, Joe Perches wrote: > >> On Mon, 2016-01-11 at 09:13 +1100, Julian Calaby wrote: > &

[Xen-devel] [PATCH v4 0/3] checkpatch: handling of memory barriers

2016-01-11 Thread Michael S. Tsirkin
unnecessary capture groups rename smp_barriers to smp_barrier_stems for clarity add barriers before/after atomic Changes from v1: catch optional\s* before () in barriers rewrite using qr{} instead of map Michael S. Tsirkin (3): checkpatch.pl: add missing memory

[Xen-devel] [PATCH v4 1/3] checkpatch.pl: add missing memory barriers

2016-01-11 Thread Michael S. Tsirkin
SMP-only barriers were missing in checkpatch.pl Refactor code slightly to make adding more variants easier. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts

[Xen-devel] [PATCH v4 2/3] checkpatch: check for __smp outside barrier.h

2016-01-11 Thread Michael S. Tsirkin
a checkpatch test so it will trigger a warning. Reported-by: Russell King Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 94b4e33..25476c2 100755 --- a/scripts/checkpa

[Xen-devel] [PATCH v4 3/3] checkpatch: add virt barriers

2016-01-11 Thread Michael S. Tsirkin
Add virt_ barriers to list of barriers to check for presence of a comment. Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 25476c2..c7bf1aa 100755 --- a/scripts

Re: [Xen-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-11 Thread Michael S. Tsirkin
d be useful > > > > > -Original Message- > > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > > Sent: Friday, January 8, 2016 7:57 PM > > > To: Hao, Xudong > > > Cc: Stefano Stabellini ; Lars Kurth > > > ; Lars Ku

Re: [Xen-devel] [PATCH v4 0/3] checkpatch: handling of memory barriers

2016-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 12:59:25PM +0200, Michael S. Tsirkin wrote: > As part of memory barrier cleanup, this patchset > extends checkpatch to make it easier to stop > incorrect memory barrier usage. > > This replaces the checkpatch patches in my series > arch: barrier

Re: [Xen-devel] [PATCH v2 20/32] metag: define __smp_xxx

2016-01-11 Thread Michael S. Tsirkin
On Tue, Jan 05, 2016 at 12:09:30AM +, James Hogan wrote: > Hi Michael, > > On Thu, Dec 31, 2015 at 09:08:22PM +0200, Michael S. Tsirkin wrote: > > This defines __smp_xxx barriers for metag, > > for use by virtualization. > > > > smp_xxx barriers are removed

Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-12 Thread Michael S. Tsirkin
On Mon, Jan 11, 2016 at 05:14:14PM -0800, Leonid Yegoshin wrote: > On 01/10/2016 06:18 AM, Michael S. Tsirkin wrote: > >On mips dma_rmb, dma_wmb, smp_store_mb, read_barrier_depends, > >smp_read_barrier_depends, smp_store_release and smp_load_acquire match > >the asm-generic v

Re: [Xen-devel] [Qemu-devel] [PATCH v4] igd-passthrough-i440FX: convert to realize()

2016-01-12 Thread Michael S. Tsirkin
g > > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: Monday, January 11, 2016 6:32 PM > > To: Hao, Xudong > > Cc: Stefano Stabellini ; Lars Kurth > > ; xen-de...@lists.xensource.com; Michael S. Tsirkin

Re: [Xen-devel] [PATCH v3 01/41] lcoking/barriers, arch: Use smp barriers in smp_store_release()

2016-01-12 Thread Michael S. Tsirkin
On Tue, Jan 12, 2016 at 08:28:44AM -0800, Paul E. McKenney wrote: > On Sun, Jan 10, 2016 at 04:16:32PM +0200, Michael S. Tsirkin wrote: > > From: Davidlohr Bueso > > > > With commit b92b8b35a2e ("locking/arch: Rename set_mb() to smp_store_mb()") > > it wa

Re: [Xen-devel] [v3,11/41] mips: reuse asm-generic/barrier.h

2016-01-14 Thread Michael S. Tsirkin
On Wed, Jan 13, 2016 at 02:26:16PM -0800, Leonid Yegoshin wrote: > And all that is out-of-topic here in my mind. I just want to be sure that > this patchset still provides a use of a specific lightweight SYNCs on MIPS > vs bold and heavy generalized "SYNC 0" in any case. > > - Leonid. Of course i

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 10:20:06AM +0100, Stefano Stabellini wrote: > CC'ing the author of the patch and xen-devel. > FYI I think that Jan is going to be on vacation for a couple of weeks. > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > > On Tue, Mar 31, 2015 at 03

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 10:41:12AM +0100, Andrew Cooper wrote: > On 01/04/15 10:20, Stefano Stabellini wrote: > > CC'ing the author of the patch and xen-devel. > > FYI I think that Jan is going to be on vacation for a couple of weeks. > > > > On Wed, 1 Apr 2015, M

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-01 Thread Michael S. Tsirkin
o be on vacation for a couple of weeks. > > > > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > > > On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: > > > > From: Jan Beulich > > > > > > > > Otherwise the guest can abu

[Xen-devel] [PULL 2/7] pc: Remove redundant arguments from xen_hvm_init()

2015-09-10 Thread Michael S. Tsirkin
From: Eduardo Habkost Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/xen/xen.h | 4 ++-- hw/i386/pc_piix.c| 4 +--- hw/i386/pc_q35.c | 4 +--- xen-hvm-stub.c

Re: [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > CC Michael > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > > was set by configure. That won't be

Re: [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > CC Michael > > > > > > On Thu, 10 Sep 2015, Stefano Stabellin

Re: [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Michael S. Tsirkin
On Thu, Sep 10, 2015 at 01:00:35PM +0100, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > > On Thu, Se

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Michael S. Tsirkin
On Tue, Jul 28, 2015 at 02:46:20PM +0200, Paolo Bonzini wrote: > > > On 28/07/2015 12:12, Benjamin Herrenschmidt wrote: > >> > That is an experimental feature (it's x-iommu), so it can change. > >> > > >> > The plan was: > >> > > >> > - for PPC, virtio never honors IOMMU > >> > > >> > - for no

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Michael S. Tsirkin
On Mon, Jul 27, 2015 at 06:08:59PM -0700, Andy Lutomirski wrote: > On Mon, Sep 1, 2014 at 10:39 AM, Andy Lutomirski wrote: > > This fixes virtio on Xen guests as well as on any other platform > > that uses virtio_pci on which physical addresses don't match bus > > addresses. > > > > This can be te

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-13 Thread Michael S. Tsirkin
nd xen-devel. > >> > FYI I think that Jan is going to be on vacation for a couple of weeks. > >> > > >> > On Wed, 1 Apr 2015, Michael S. Tsirkin wrote: > >> >> On Tue, Mar 31, 2015 at 03:18:03PM +0100, Stefano Stabellini wrote: > >>

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 12:34:34PM +0100, Jan Beulich wrote: > >>> On 13.04.15 at 13:19, wrote: > > Yes Linux can't fix firmware 1st mode, but > > PCI express spec says what firmware should do in this case: > > > > IMPLEMENTATION NOTE Software UR Reporting Compatibility with 1.0a Devices > > > >

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 01:40:59PM +0100, Jan Beulich wrote: > >>> On 13.04.15 at 13:47, wrote: > > On Mon, Apr 13, 2015 at 12:34:34PM +0100, Jan Beulich wrote: > >> >>> On 13.04.15 at 13:19, wrote: > >> > Yes Linux can't fix firmware 1st mode, but > >> > PCI express spec says what firmware shoul

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: > >>> On 13.04.15 at 14:47, wrote: > > On Mon, Apr 13, 2015 at 01:40:59PM +0100, Jan Beulich wrote: > >> Quite possible. Looking at the ITP log we were provided, the UR > >> severity bit is clear (non-fatal), yet the error got surfaced t

Re: [Xen-devel] [PATCH][XSA-126] xen: limit guest control of PCI command register

2015-04-20 Thread Michael S. Tsirkin
On Mon, Apr 20, 2015 at 03:08:09PM +0100, Jan Beulich wrote: > >>> On 20.04.15 at 15:43, wrote: > > On Mon, Apr 13, 2015 at 01:51:06PM +0100, Jan Beulich wrote: > >> >>> On 13.04.15 at 14:47, wrote: > >> > Can you check device capabilities register, offset 0x4 within > >> > pci express capability

Re: [Xen-devel] [PATCH v1 05/47] pci: add pci_iomap_wc() variants

2015-04-21 Thread Michael S. Tsirkin
On Tue, Apr 21, 2015 at 07:52:49PM +0200, Luis R. Rodriguez wrote: > On Thu, Mar 26, 2015 at 04:00:54AM +0100, Luis R. Rodriguez wrote: > > On Mon, Mar 23, 2015 at 12:20:47PM -0500, Bjorn Helgaas wrote: > > > Hi Luis, > > > > > > This seems OK to me, > > > > Great. > > > > > but I'm curious abo

Re: [Xen-devel] [PATCH v1 05/47] pci: add pci_iomap_wc() variants

2015-04-21 Thread Michael S. Tsirkin
On Mon, Mar 23, 2015 at 12:20:47PM -0500, Bjorn Helgaas wrote: > pci_iomap_range() already makes a cacheable mapping if > IORESOURCE_CACHEABLE; I'm guessing that you would like it to > automatically use WC if the BAR if IORESOURCE_PREFETCH, e.g., > > if (flags & IORESOURCE_CACHEABLE) > retur

Re: [Xen-devel] [RFC][PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-16 Thread Michael S. Tsirkin
On Mon, Nov 17, 2014 at 10:47:56AM +0800, Chen, Tiejun wrote: > On 2014/11/5 22:09, Michael S. Tsirkin wrote: > >On Wed, Nov 05, 2014 at 03:22:59PM +0800, Tiejun Chen wrote: > >>Currently IGD drivers always need to access PCH by 1f.0, and > >>PCH vendor/device id i

Re: [Xen-devel] [Qemu-devel] [RFC][PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-17 Thread Michael S. Tsirkin
On Mon, Nov 17, 2014 at 04:48:32PM +0800, Chen, Tiejun wrote: > On 2014/11/17 14:10, Michael S. Tsirkin wrote: > >On Mon, Nov 17, 2014 at 10:47:56AM +0800, Chen, Tiejun wrote: > >>On 2014/11/5 22:09, Michael S. Tsirkin wrote: > >>>On Wed, Nov 05, 2014 at 03:22

<    1   2   3   >