Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-15 Thread Olaf Hering
On Mon, Feb 15, Wei Liu wrote: > > I think yes, DEFINE_DEVICES_ADD has to be used somewhere. > I'm confused. You're joking, right? "Has to be used somewhere" is not > a justification for having it in this particular place. What would be the appropriate place? I think its there since I started wor

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-16 Thread Olaf Hering
On Mon, Feb 15, Ian Jackson wrote: > One reason you might define a virtual controller with no devices yet > is so that you have a stable and pre-expected device path for any > actual targets you choose to hotplug later. Would it be acceptable to reuse the devid as the "group index"? The various v

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-16 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > #xl usbctrl-attach test_vm version=1 ports=8 > #xl usbdev-attach test_vm hostbus=1 hostaddr=2 I think this does not handle the -N knob of xl. Other commands check the global dryrun_only variable. Olaf ___ Xen-de

Re: [Xen-devel] [PATCH v8 3/5] libxl: add support for vscsi

2016-02-17 Thread Olaf Hering
On Tue, Feb 16, Ian Jackson wrote: > Olaf Hering writes ("Re: [PATCH v8 3/5] libxl: add support for vscsi"): > > On Mon, Feb 15, Ian Jackson wrote: > > > One reason you might define a virtual controller with no devices yet > > > is so that you have a stable

[Xen-devel] libxl_device handling for nic and vtmp

2016-02-18 Thread Olaf Hering
What is the point of libxl__update_config_nic and libxl__update_config_vtmp? In libxl__device_type_add (called from DEFINE_DEVICE_ADD) the input type is copied with libxl_device_type_copy to type_saved, which is a 1:1 copy. If needed, a new devid is assigned to the input. Later the copy is updated

Re: [Xen-devel] libxl_device handling for nic and vtmp

2016-02-18 Thread Olaf Hering
On Thu, Feb 18, Wei Liu wrote: > For example, user might not have specified mac address so the library > generates one for (s)he. You don't want mac address to regenerate after > save / restore or migration. But you don't want to preserve all > autogenerated state, so you use the original copy as

Re: [Xen-devel] libxl_device handling for nic and vtmp

2016-02-18 Thread Olaf Hering
On Thu, Feb 18, Wei Liu wrote: > Sorry I don't follow. What do you mean by 1:1 copy? Why does it make the > update unnecessary? The current code does: libxl_device_nic_init(&nic_saved); libxl_device_nic_copy(CTX, &nic_saved, nic); nic->devid = libxl__device_nextid(gc, domid, "vif"); libx

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Olaf Hering
On Fri, Feb 19, Chun Yan Liu wrote: > > > >>> On 2/17/2016 at 12:56 AM, in message <20160216165608.ga21...@gmail.com>, > >>> Olaf > Hering wrote: > > On Tue, Jan 19, Chunyan Liu wrote: > > > > > #xl usbctrl-attach test_vm versi

Re: [Xen-devel] [PATCH V13 5/5] xl: add pvusb commands

2016-02-19 Thread Olaf Hering
On Fri, Feb 19, Olaf Hering wrote: > Not sure how to handle it, perhaps exit when xl -N is called? Also the interface is 'xl -N' is not clearly defined. What is it supposed to do with the newly introduced ctrl types? Should it display the json just for the dev, just for the ct

[Xen-devel] [PATCH v9 4/6] vscsiif.h: add some notes about xenstore layout

2016-02-23 Thread Olaf Hering
Signed-off-by: Olaf Hering Acked-by: Ian Campbell Acked-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/vscsiif.h | 69 + 1 file changed, 69 insertions(+) diff --git a/xen

[Xen-devel] [PATCH v9 2/6] vscsiif.h: fix WWN notation for p-dev property

2016-02-23 Thread Olaf Hering
The pvops kernel expects either "naa.WWN:LUN" or "h:c:t:l" in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering Acked-by: Ian Campbell Acked-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deeg

[Xen-devel] [PATCH v9 1/6] libxl: Export libxl__device_nextid for internal use

2016-02-23 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/libxl/libxl.c | 2 +- tools/libxl/libxl_internal.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 2bde0f5

[Xen-devel] [PATCH v9 0/6] libxl: add support for pvscsi, iteration 9

2016-02-23 Thread Olaf Hering
S as backend and frontend. This version has been tested with pvops as backend and SLES as frontend. Olaf Hering (6): libxl: Export libxl__device_nextid for internal use vscsiif.h: fix WWN notation for p-dev property docs: add vscsi to xenstore-paths.markdown vscsiif.h: add some notes abou

[Xen-devel] [PATCH v9 6/6] Scripts to create and delete xen-scsiback nodes in Linux target framework

2016-02-23 Thread Olaf Hering
Signed-off-by: Olaf Hering --- tools/misc/Makefile | 4 + tools/misc/target-create-xen-scsiback.sh | 135 +++ tools/misc/target-delete-xen-scsiback.sh | 41 ++ 3 files changed, 180 insertions(+) diff --git a/tools/misc/Makefile b/tools/misc

[Xen-devel] [PATCH v9 5/6] libxl: add support for vscsi

2016-02-23 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- docs/man/xl.cfg.pod.5| 56 ++ docs/ma

[Xen-devel] [PATCH v9 3/6] docs: add vscsi to xenstore-paths.markdown

2016-02-23 Thread Olaf Hering
Signed-off-by: Olaf Hering Acked-by: Ian Campbell Acked-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/misc/xenstore-paths.markdown b

Re: [Xen-devel] Build problems with xen 4.7

2015-12-01 Thread Olaf Hering
On Tue, Dec 01, M A Young wrote: > It happens if CFLAGS is set to anything as a environment variable, eg. > export CFLAGS=" " > make dist-xen This never worked. I have this in xen.spec to workaround the way %configure is implemented in rpm: %configure unset CFLAGS unset CXXFLAGS unset FFLAGS un

Re: [Xen-devel] [PATCH v2] libxl: Introduce a template for devices with a controller

2015-12-02 Thread Olaf Hering
On Tue, Dec 01, George Dunlap wrote: > We have several outstanding patch series which add devices that have > two levels: a controller and individual devices attached to that > controller. Will likely work for pvscsi. Thanks. Acked-by: Olaf Heri

Re: [Xen-devel] Missing libvirt+libxl functionality (Was: Re: [Xen-users] Programmatic administration of Xen machines)

2016-01-07 Thread Olaf Hering
On Thu, Jan 07, Jim Fehlig wrote: > The 'iscsi:iqn.2006-09.de.suse@0ac47ee2-216e-452a-a341-a12624cd0225' blob was > passed wholesale to xend, which would eat it and "do the right thing". AFAIK, > libxl is not that forgiving. I've cc'd Olaf on this thread since we recently > discussed how libvirt+l

Re: [Xen-devel] [PATCH XEN v8 11/29] tools: Refactor foreign memory mapping into libxenforeignmemory

2016-01-25 Thread Olaf Hering
On Fri, Jan 15, Ian Campbell wrote: > libxenforeignmemory will provide a stable API and ABI for mapping > foreign domain memory (subject to appropriate privileges). I think this will break my Xen pkg build: [ 333s] kdd-xen.c: In function 'kdd_access_physical_page': [ 333s] kdd-xen.c:508:15: wa

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. s/know/no/ ? Acked-by: Olaf Hering Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.or

Re: [Xen-devel] [PATCH] kdd: Opt in to libxc compat xc_map_foreign_* intefaces.

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > Reported by: Olaf Hering Tested-by: Olaf Hering Thanks, Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] kdd: build using Werror

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > We build most of tools using Werror and there seems to be know > deliberate reason for this to be an exception. > > Signed-off-by: Ian Campbell This would have caught the kdd error. Tested-by: Olaf H

Re: [Xen-devel] [PATCH] tools: avoid redefinition of typedefs

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > When splitting out various functionality from libxc into tools/libs/* > I attempted to make it possible to avoid callers being unnecessarily > exposed to the xentoollog interface by providing a typedef of the > xentoollog_logger handle in each of the headers.

Re: [Xen-devel] [PATCH 1/2] tools: rename libxc's evtchn_port_or_error_t with an xc_ prefix

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > This is used only for xc_evtchn_alloc_unbound and the legacy/compat > versions of the old interfaces and avoids redefining the typedef. The > evtchn_port_or_error_t name is now used only be libxenevtchn. Tested-by: Olaf Heri

Re: [Xen-devel] [PATCH 2/2] tools: avoid redefinining xenevtchn_handle typedef for xc_suspend_*

2016-01-25 Thread Olaf Hering
On Mon, Jan 25, Ian Campbell wrote: > Similar to the previous xentoollog case this is not allowed. Switch to > a forward decl of the struct and use of it in the APIs. Tested-by: Olaf Hering Olaf ___ Xen-devel mailing list Xen-devel@lists.x

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > +++ b/tools/libxl/libxl.c > @@ -3204,7 +3204,7 @@ void > libxl__device_disk_local_initiate_detach(libxl__egc *egc, > aodev->dev = device; > aodev->callback = local_device_detach_cb; > aodev->force = 0; > -libxl__initiate_devi

Re: [Xen-devel] [PATCH 3/5] libxl: add support for vscsi

2016-01-27 Thread Olaf Hering
On Fri, Nov 13, Olaf Hering wrote: > Port pvscsi support from xend to libxl: How should code which converts devices from xenstore to json handle devices which got marked as "to be removed"? In my pvscsi code I set XenbusStateClosing in the vscsidev, then XenbusStateReconfiguring

[Xen-devel] qemu-upstream compile failure in intel_iommu.c:vtd_context_device_invalidate

2016-01-27 Thread Olaf Hering
Compiling qemu-xen at 2ce1d30 ("xenfb.c: avoid expensive loops when prod <= out_cons") leads to this error with -O1: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c:911:46: error: ‘mask’ may be used u

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst, > > + libxl_vscsi_dev *dev); > > +int libxl_device_vscsi_ge

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst, > > + libxl_vscsi_dev *dev); > > +int libxl_device_vscsi_ge

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-12 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: > dist/install/var/xen/dump > which all seems proper and correct to me. Except the last one, which should be /var/lib/xen/dump or whatever dumpdir the OS/FHS provides. Olaf ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst, > > + libxl_vscsi_dev *dev); > > +int libxl_device_vscsi_ge

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-12 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned int > > *hst, > > +unsigned int *c

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Daniel Kiper wrote: > IIRC, 4.3 release (and probably earlier ones) was a mess. Olaf did the > work for 4.5. However, as he pointed out in another email last one is > incorrect. Olaf, are you going to fix it for 4.6? I suppose it is > quite simple. There are still many hardcoded

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Daniel Kiper wrote: > On Thu, Mar 12, 2015 at 10:21:56AM +, wei.l...@citrix.com wrote: > > * Rearrange and cleanup installation destination directories (/var -> > > var/lib/xen) (fair) > > - Daniel Kiper > If Olaf did all work then we can remove this one. What does this m

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-13 Thread Olaf Hering
n_types.h as filename? Olaf > Signed-off-by: Olaf Hering > Signed-off-by: Quan Xu > .. > > (1) > -- /dev/null > +++ b/stubdom/vtpmmgr/common_types.h > @@ -0,0 +1,11 @@ > +#ifndef VTPM_ODD_TYPES > +#define VTPM_ODD_TYPES 1 > +typedef unsigned char BYTE; >

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: > On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote: > > On Wed, Mar 11, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, ch

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote: > > On Wed, Mar 11, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > +void libxl_device_vscsi_append_dev(libxl_ctx *c

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I > > assume its required to validate input in libxl_device_vscsi_get_host. > Not sure what you mea

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-16 Thread Olaf Hering
On Fri, Mar 13, Wei Liu wrote: > On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote: > > On Thu, Mar 12, Ian Campbell wrote: > > > > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: > > > > Related: I see libxl_device_vscsi_dispose does now

Re: [Xen-devel] [PATCH] Build: Fix stubdom vtpm build failure

2015-03-16 Thread Olaf Hering
On Fri, Mar 13, Quan Xu wrote: > Typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers > do not cope with current staging branch. What remains after applying this patch is this error: [ 665s] tpm2_types.h:229:19: error: redefinition of typedef 'TPM_ALGORITHM_ID' [ 665s] tcg.

Re: [Xen-devel] [PATCH v2] Build: Fix stubdom vtpm build failure

2015-03-17 Thread Olaf Hering
On Mon, Mar 16, Quan Xu wrote: > Typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers > do not cope with current staging branch. This version finally compiles. Thanks! Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://

[Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
Some change commited to staging earlier this week breaks ocaml bindings, as shown below. I think it was introduced between a68d1b65bb1bbb9b8db2d82695d32ac09c52a2d7..d4ea77c9d7b314001ff4e2eb7618b45f11551371: NotImplementedError: Cannot handle KeyedUnion fields which are not Structs But now that I

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: > The name at (*) must be the enum member, which I've duplicated at (**) > but you might like to thing about whether (**) would have a better name > in the context of e.g. vscsi_dev->u.dev.dev or vscsi_dev->u.wwn.wwn. Thanks Ian. For some reason I have ocaml di

[Xen-devel] [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable VGABIOS_REL_DATE="dd Mon " to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbel

[Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper Cc: Ian Jackson Cc

[Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-20 Thread Olaf Hering
Mention two variables introduced by commit ac977f5 ("use more fixed strings to build the hypervisor"). Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- INSTALL | 6 ++ 1 file changed, 6 insertions(+) diff --git a

[Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-20 Thread Olaf Hering
e change uses a representation of date+time. Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu Cc: George Dunlap --- tools/misc/mkrpm | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/tools/misc/mkrpm b/tools/mis

[Xen-devel] [PATCH 0/5] tools: various changes

2015-03-20 Thread Olaf Hering
builds are really just interesting for distro packages. Passing all the variables via a rpm spec file for example can be automated in such build environment. The current behaviour is preserved. Please review once more and apply. Thanks, Olaf Olaf Hering (5): tools/mkrpm: improve

[Xen-devel] [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-03-20 Thread Olaf Hering
It is already used in the runlevel script and the service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 1 file changed, 8 insertions(+) diff --git a/tools/hotplug

Re: [Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, Jan Beulich wrote: > >>> On 20.03.15 at 18:24, wrote: > > To allow reproducible builds of hvmloader introduce a make variable > > SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this > > change the hvmloader binary changes with every rebuild. > > I don't really

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: > I'm not really happy with having the massive number show up > automatically when anyone makes an rpm. What would you think about > adding a variable where you could set this as part of the build process? > e.g., > XEN_RPM_RELEASE="$(date +%Y%m%d%H%M%S)" m

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: > xen-4.6_unstable-20150323160547.x86_64.rpm Do you want to continue to get "unstable" as release? My patch uses everything passed as "$2" as Version string. I think thats ok. Release will be either 0 or $PKG_DATE. Olaf _

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-23 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: > On Mon, Mar 23, 2015 at 5:52 PM, Olaf Hering wrote: > > On Mon, Mar 23, George Dunlap wrote: > >> xen-4.6_unstable-20150323160547.x86_64.rpm > > Do you want to continue to get "unstable" as release? > > My patch u

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: > On 03/23/2015 06:49 PM, Olaf Hering wrote: > > release will be anything after a dash, or 0. And an optional ".$PKG_RELEASE" > > will be appended. > Just trying to decode this: So if I were using PKG_RELEASE=$(date ...), > then

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-24 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: > On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: > > + ("dev", Struct(None, [("m", libxl_vscsi_hctl)])), > > + ("wwn", Struct(None, [("m", string)])), > > + ("hct

[Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
ot; is used, which has the bad side effect that xen.gz always gets a different filename every time. Update mkrpm to recognize PKG_RELEASE=. Its value will be appended to the Release string. It can be filled with a time stamp, like: make rpmball PKG_RELEASE="`date +%Y%m%d%H%M%S`" Signed-o

Re: [Xen-devel] [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string

2015-03-25 Thread Olaf Hering
On Tue, Mar 24, Ian Campbell wrote: > Is it expected that they should all be settable independently? Or would > one global setting be sufficient? A single timestamp would be nice, sure. > If so then a single variable which can be set to something accepted by > date -d which could be formatted in

Re: [Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-25 Thread Olaf Hering
On Tue, Mar 24, Ian Campbell wrote: > On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote: > > +Some components of xen and tools will include an unpredictable timestamp > > +into the binaries. To allow reproducible builds the following variables > > +can be used to provid

Re: [Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-26 Thread Olaf Hering
On Wed, Mar 25, George Dunlap wrote: > Reviewed-by: George Dunlap > Tested-by: George Dunlap Thanks. Whoever is in charge, please backport to staging-4.5 as well. Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-26 Thread Olaf Hering
On Fri, Mar 13, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > > > +("feature_host", bool), > > > > > What is this feature thing? What does !host imply? > > > > This enable

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-27 Thread Olaf Hering
On Thu, Mar 26, Ian Campbell wrote: > On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote: > > On Fri, Mar 13, Ian Campbell wrote: > > > Also, should this be a defbool or not? > > This is a good idea. I remmeber xend had code to make sure that all > > devices wit

[Xen-devel] [PATCH] hotplug/Linux: add missing backslash in dom0_ip

2015-03-27 Thread Olaf Hering
Without it the actual error message is not written to xenstore. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/vif-common.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hotplug/Linux/vif

[Xen-devel] sudden hang on boot on AMD Notebook

2015-03-30 Thread Olaf Hering
Just last week I was running staging to test pvscsi on this HP ProBook 6555b, since around Wednesday I think. But todays staging fails to boot. So I started a bisect in xen/, but every attempt to boot xen.gz results in a hang at the same place. Even going back to the state of 4.5.0. Any idea what

[Xen-devel] [PATCH 0/4 v2] tools: various changes

2015-04-01 Thread Olaf Hering
via a rpm spec file for example can be automated in such build environment. The current behaviour is preserved. Please review once more and apply. Thanks, Olaf Olaf Hering (4): tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file. INSTALL: mention variables for reproducible builds

[Xen-devel] [PATCH 2/4 v2] INSTALL: mention variables for reproducible builds

2015-04-01 Thread Olaf Hering
Mention two variables introduced by commit ac977f5 ("use more fixed strings to build the hypervisor"). Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- v2: adjust format for XEN_BUILD_DATE INSTALL | 6 ++ 1 file

[Xen-devel] [PATCH 3/4] hvmloader: add knob for fixed SMBIOS date string

2015-04-01 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Acked-by: Jan Beulich Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew

[Xen-devel] [PATCH 4/4] hvmloader: add knob for fixed VGABIOS date string

2015-04-01 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable VGABIOS_REL_DATE="dd Mon " to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbel

[Xen-devel] [PATCH 1/4] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-04-01 Thread Olaf Hering
It is already used in the runlevel script and the service file. Signed-off-by: Olaf Hering Acked-by: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 1 file changed, 8 insertions(+) diff

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Mon, Mar 30, Andrew Cooper wrote: > On 30/03/15 13:14, Olaf Hering wrote: > > Just last week I was running staging to test pvscsi on this HP ProBook > > 6555b, since around Wednesday I think. But todays staging fails to boot. > > So I started a bisect in xen/, but every a

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Wed, Apr 01, Ian Campbell wrote: > Key handlers are only available via serial, I think, and not VGA which > it sounds like what Olaf is looking at. This laptop has a serial port, and thats what I used to grab the output. No reaction there. Just today I noticed the blinking cursor. Will continu

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Wed, Apr 01, Olaf Hering wrote: > On Wed, Apr 01, Ian Campbell wrote: > > > Key handlers are only available via serial, I think, and not VGA which > > it sounds like what Olaf is looking at. > > This laptop has a serial port, and thats what I used to grab the out

Re: [Xen-devel] sudden hang on boot on AMD Notebook

2015-04-01 Thread Olaf Hering
On Wed, Apr 01, Konrad Rzeszutek Wilk wrote: > You can also use the USB EHCI debug port. It works great on laptops. Is there an howto for that? Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] ENC:[Xen-users] Failed to insert 'xen_evtchn': No such device

2015-04-01 Thread Olaf Hering
On Wed, Apr 01, Carlos Gustavo Ramirez Rodriguez wrote: > Hello DEVs, can anyone help me? > > Ian Campbell pointed me that maybe you could help me, here is the link to the > last e-mail line that started this problem fixing: > http://lists.xenproject.org/archives/html/xen-users/2015-04/msg9.h

Re: [Xen-devel] ENC:[Xen-users] Failed to insert 'xen_evtchn': No such device

2015-04-02 Thread Olaf Hering
On Thu, Apr 02, Carlos Gustavo Ramirez Rodriguez wrote: > >systemctl enable xen-qemu-dom0-disk-backend.service > >systemctl enable xen-init-dom0.service > >systemctl enable xenconsoled.service > These MAGIC lines did the trick! Thanks for the help, this solved the First > Problem, BUT, if you know

Re: [Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-10 Thread Olaf Hering
Ping? On Tue, Feb 03, Olaf Hering wrote: > It is already used in the runlevel script and the service file. It is > supposed to replace XENSTORED_TRACE= boolean, which cant be easily > supported in the xenstored.service file. > > Signed-off-by: Olaf Hering > Cc: Ian Jack

[Xen-devel] [PATCH] tools: require at least pixman 0.21.8 for qemu-xen

2015-02-11 Thread Olaf Hering
11s] (2) Fetch the pixman submodule, using: [ 211s] git submodule update --init pixman Please run autogen.sh after applying this patch. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/configure|

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-02-11 Thread Olaf Hering
On Wed, Jan 28, Xu, Quan wrote: > Thanks, I will check and fix it tomorrow. It is 23:12 PM Pacific time now. Any progress? These typedefs are duplicated in stubdom/vtpmmgr/tcg.h and supported compilers do not cope with current staging: # for i in `grep -w typedef stubdom/vtpmmgr/tcg.h | sed -n '

Re: [Xen-devel] [PATCH 3/3] mini-os: sort objects in binary archives

2015-02-16 Thread Olaf Hering
On Thu, Feb 05, Ian Campbell wrote: > On Tue, 2015-02-03 at 12:45 +0100, Olaf Hering wrote: > > When building stubdom the mini-os objects are also linked into the > > binary. Unfortunately the linker will place them in the order found in > > the archive. Since this order is

Re: [Xen-devel] [PATCH] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-02-16 Thread Olaf Hering
On Fri, Feb 13, Ian Jackson wrote: > Olaf Hering writes ("[PATCH] tools/hotplug: introduce XENSTORED_ARGS= in > sysconfig file."): > > It is already used in the runlevel script and the service file. It is > > supposed to replace XENSTORED_TRACE= boolean, which can

[Xen-devel] how to assign resources exclusive to a single domU

2015-02-26 Thread Olaf Hering
While working on pvscsi support for libxl I noticed that assigning a resource exclusivly to just a single domU via libxl will be a major effort. Up to now libxl could rely on the fact that a resource can be either shared or the backend deals with the attempt to share. There are two cases in pvscsi

Re: [Xen-devel] how to assign resources exclusive to a single domU

2015-02-27 Thread Olaf Hering
On Fri, Feb 27, Jürgen Groß wrote: > On 02/26/2015 09:57 AM, Olaf Hering wrote: > >I wonder what should be done in my changes for libxl. > If you are doing something, please add a flag to be able to disable > the additional security checks regarding multiple assignment. I think li

[Xen-devel] [PATCH 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-02 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- NOTE: the URLS are still broken because the "unstable" directory does not exist. docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) di

[Xen-devel] [PATCH 0/4] libbxl: add support for pvscsi, iteration 2

2015-03-02 Thread Olaf Hering
success to configure a pvops backend, which has to be configured independent from libxl. Will continue to poke at that. Please review. The first two changes could be applied independent from the libxl changes. Olaf Olaf Hering (4): vscsiif.h: remove reference to WWN docs: add vscsi to

[Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. Remove incorrect reference to WWN because it was never supported. And its not clear how it could be supported. p-devname can be used to store a config string. Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc

[Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/pvscsi.txt | 147 +++ 1 file changed, 147 insertions(+) diff --git a/docs/misc/pvscsi.txt b/docs/misc/pvscsi.txt new file

[Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
Port pvscsi support from xend to libxl. See pvscsi.txt for details. Outstanding work is listed in the TODO section. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/libxl/Makefile | 1 + tools/libxl/libxl.c

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: > On Mon, Mar 02, Juergen Gross wrote: > > > On 03/02/2015 11:15 AM, Olaf Hering wrote: > > >The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. > > >Remove incorrect reference to WWN because it was never sup

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: > +libxl_device_vscsi *libxl_device_vscsi_list(libxl_ctx *ctx, uint32_t domid, > int *num) > +fe_path = libxl__sprintf(gc, "%s/device/vscsi", > libxl__xs_get_dompath(gc, domid)); IanC, last year you made a comment that this path

Re: [Xen-devel] [PATCH 1/4] vscsiif.h: remove reference to WWN

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: > On 03/02/2015 11:15 AM, Olaf Hering wrote: > >The code in xend, xenlinux and pvops 3.18 expects the h:c:t:l notation. > >Remove incorrect reference to WWN because it was never supported. And > >its not clear how it could be supported.

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Olaf Hering wrote: > +++ b/tools/libxl/libxl_types.idl > +libxl_vscsi_hctl = Struct("vscsi_hctl", [ > +("hst", uint32), > +("chn", uint32), > +("tgt", uint32), > +("lun", uint32), > +

Re: [Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: > On 03/02/2015 11:16 AM, Olaf Hering wrote: > >+How to do live migration? > >+ - pdev will likely be evaluated again on the target host if it came from > >+ domU.cfg. But what about pdev from 'xl scsi-attach pdev vdev'? It

Re: [Xen-devel] [PATCH 4/4] libxl: add support for vscsi

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Ian Campbell wrote: > On Mon, 2015-03-02 at 15:20 +0100, Olaf Hering wrote: > > Its used as //vscsi-devs/dev-/. What name > > should be used to reference the devices? Also just "devid" even if it > > refers to devices "private" to th

Re: [Xen-devel] [PATCH 3/4] docs: add pvscsi.txt

2015-03-02 Thread Olaf Hering
On Mon, Mar 02, Juergen Gross wrote: > On 03/02/2015 04:14 PM, Olaf Hering wrote: > >In this case the code which checks pdev usage in > >libxl_device_vscsi_get_host can just be removed. > Hmm, maybe issuing a warning would be a sensible thing to do? This gets us back to

[Xen-devel] [PATCH v3 0/4] libbxl: add support for pvscsi, iteration 3

2015-03-06 Thread Olaf Hering
is version has been tested with pvops as backend and SLES as frontend. Please review. The first two changes could be applied independent from the libxl changes. Olaf Olaf Hering (4): vscsiif.h: fix WWN notation for p-dev property docs: add vscsi to xenstore-paths.markdown docs: add pvscsi.t

[Xen-devel] [PATCH v3 2/4] docs: add vscsi to xenstore-paths.markdown

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/xenstore-paths.markdown | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/misc/xenstore-paths.markdown b/docs/misc/xenstore-paths.markdown index

[Xen-devel] [PATCH v3 1/4] vscsiif.h: fix WWN notation for p-dev property

2015-03-06 Thread Olaf Hering
The pvops kernel expects either "naa.WWN:LUN" or "h:c:t:l" in the p-dev property. Add the missing :LUN part to the comment. Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- xen/include/public/io/vscsiif.h |

[Xen-devel] [PATCH v3 3/4] docs: add pvscsi.txt

2015-03-06 Thread Olaf Hering
Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- docs/misc/pvscsi.txt | 188 +++ 1 file changed, 188 insertions(+) diff --git a/docs/misc/pvscsi.txt b/docs/misc/pvscsi.txt new file

[Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-06 Thread Olaf Hering
Port pvscsi support from xend to libxl. See pvscsi.txt for details. Outstanding work is listed in the TODO section. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/libxl/Makefile | 1 + tools/libxl/libxl.c

<    1   2   3   4   5   6   7   8   9   >