Re: [Xen-devel] STAO spec in xen.git

2017-02-14 Thread Olaf Hering
On Tue, Jan 17, Stefano Stabellini wrote: > On Tue, 17 Jan 2017, Olaf Hering wrote: > > On Fri, Jan 13, Julien Grall wrote: > > > > > Regarding the format. Does ODT will allow git to do proper diff? > > > > There is flat ODT, "Safe as ..." and pick

Re: [Xen-devel] [PATCH biosdevname]: handle dom0 on AMD systems

2017-02-14 Thread Olaf Hering
Hello, and ping. Olaf On Wed, Aug 17, Olaf Hering wrote: > Starting with xen-4.7 cpuid() will return with the hypervisor bit set > in a dom0 when running on an AMD system. As a result biosdevname > thinks it runs in a guest and does nothing. Detect a dom0 by looking > into xenfs

Re: [Xen-devel] STAO spec in xen.git

2017-02-14 Thread Olaf Hering
On Tue, Feb 14, Stefano Stabellini wrote: > Interestingly, my "git am" is unable to apply those patches. Does it > work for you? I cannot see anything wrong with them, but they don't > work. If the problem is that they are too large, please send the files > as attachments. Its the '\ No newline

Re: [Xen-devel] STAO spec in xen.git

2017-02-15 Thread Olaf Hering
Am Tue, 14 Feb 2017 20:27:15 + schrieb Wei Liu : > Better to just push to a branch for us to fetch. That would be git://github.com/olafhering/xen.git#libreoffice https://github.com/olafhering/xen/commits/libreoffice Thanks, Olaf pgpgIrWZLs_Dh.pgp Description:

[Xen-devel] [PATCH 0/2] libxl: add support for pvscsi, iteration 13

2017-02-17 Thread Olaf Hering
pt was sent a year ago: http://lists.xenproject.org/archives/html/xen-devel/2014-04/msg03958.html Most comments are addressed. This version has been tested with SLES as backend and frontend. This version has been tested with pvops as backend and SLES as frontend. Olaf Hering (2): libxl: add

[Xen-devel] [PATCH 1/2] libxl: add support for vscsi

2017-02-17 Thread Olaf Hering
Port pvscsi support from xend to libxl: vscsi=['pdev,vdev{,options}'] xl scsi-attach xl scsi-detach xl scsi-list Signed-off-by: Olaf Hering <o...@aepfle.de> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Wei Liu &l

[Xen-devel] [PATCH 2/2] Scripts to create and delete xen-scsiback nodes in Linux target framework

2017-02-17 Thread Olaf Hering
These scripts are not use by libxl. These scripts are meant for testing vscsi= in libxl Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/misc/Makefile | 4 + tools/misc/target-create-xen-scsiback.sh | 135 +++ tools/misc/target-dele

Re: [Xen-devel] STAO spec in xen.git

2017-01-17 Thread Olaf Hering
On Fri, Jan 13, Julien Grall wrote: > Regarding the format. Does ODT will allow git to do proper diff? There is flat ODT, "Safe as ..." and pick the better format from the pulldown menu. Olaf signature.asc Description: PGP signature ___ Xen-devel

Re: [Xen-devel] [PATCH 1/6] libxl: add "merge" function to generic device type support

2017-01-19 Thread Olaf Hering
On Tue, Jul 12, Juergen Gross wrote: > Instead of using a macro generating the code to merge xenstore and > json configuration data, use the generic device type support for > this purpose. > This requires to add some accessor functions to the framework and > a structure for disks (as disks are

Re: [Xen-devel] live migration to qemu.git fails

2016-08-03 Thread Olaf Hering
On Wed, Aug 03, Anthony PERARD wrote: > Does the patch "xen: handle inbound migration of VMs without ioreq > server pages" from Paul fix the issue? > <1470042985-680-1-git-send-email-paul.durr...@citrix.com> > https://lists.xen.org/archives/html/xen-devel/2016-08/msg00020.html Would that help

Re: [Xen-devel] live migration to qemu.git fails

2016-08-03 Thread Olaf Hering
On Wed, Aug 03, Anthony PERARD wrote: > Haven't you try to create a guest with Xen 4.5 and qemu-xen-4.5, and > then migrate to Xen 4.7 with QEMU-2.6/master? In the end I tried xen-4.5/6/7/8 as source and their qemu-xen, and migrated to qemu#master. All failed. Olaf signature.asc Description:

[Xen-devel] [PATCH] tools/libxendevicemodel: define O_CLOEXEC

2017-03-01 Thread Olaf Hering
Similar defines are already used elsewhere. Fixes e7745d8ef5 ("tools/libxendevicemodel: introduce a Linux-specific implementation") Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/libs/devicemodel/linux.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/

[Xen-devel] missing unplug of SCSI devices in HVM guest

2016-08-24 Thread Olaf Hering
Does anyone remember why the the vbd frontend drivers also claim the SCSI disks, but the vbd backend in qemu has no unplug support for SCSI? The current situation for qemu-xen and qemu-xen-traditional is that both will create an emulated LSI controller with disk=[vdev=sda]. The xenlinux and pvops

[Xen-devel] [PATCH 1/2] xen_platform: unplug also SCSI disks

2016-09-01 Thread Olaf Hering
-off-by: Olaf Hering <o...@aepfle.de> --- hw/i386/xen/xen_platform.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index aa78393..d94b53c 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -115,6 +

[Xen-devel] [PATCH 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-09-01 Thread Olaf Hering
Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUSE 12.3. Signed-off-by: Olaf Hering &l

[Xen-devel] [PATCH 0/2] Xen HVM unplug changes

2016-09-01 Thread Olaf Hering
Update unplug in Xen HVM guests to cover more cases. Please review. Olaf Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux unplug for emulated PCI hw/i386/xen/xen_platform.c | 36 +++- 1 file changed, 35 insertions(+), 1

[Xen-devel] [PATCH] docs: document old SUSE/Novell unplug for HVM

2016-09-02 Thread Olaf Hering
Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/misc/hvm-emulated-unplug.markdown | 24 1 file changed, 24 insertions(+) diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index c6d1f9b..70fb024 100644 --- a/docs/mi

[Xen-devel] [PATCH v2 0/2] Xen HVM unplug changes

2016-09-02 Thread Olaf Hering
Update unplug in Xen HVM guests to cover more cases. Please review. Olaf changes in v2: - fix issues reported by checkpatch Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux unplug for emulated PCI hw/i386/xen/xen_platform.c | 35

[Xen-devel] [PATCH v2 1/2] xen_platform: unplug also SCSI disks

2016-09-02 Thread Olaf Hering
-off-by: Olaf Hering <o...@aepfle.de> --- hw/i386/xen/xen_platform.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index aa78393..53be3c7 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -114,6 +

[Xen-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-09-02 Thread Olaf Hering
Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUSE 12.3. Signed-off-by: Olaf Hering &l

Re: [Xen-devel] missing unplug of SCSI devices in HVM guest

2016-09-07 Thread Olaf Hering
Am 7. September 2016 12:38:09 MESZ, schrieb Paul Durrant : >I would have thought option #1 is the most logical and desirable in the >long run, but #2 could perhaps be used (by means of a configuration >option to qemu) in the meantime. In practice I doubt there is

Re: [Xen-devel] qemu-2.7 regression, IPXE boot in HVM fails

2016-09-02 Thread Olaf Hering
On Wed, Aug 31, Olaf Hering wrote: > The following HVM domU.cfg crashes during boot from emulated network > with qemu 2.7, but it works fine with qemu stable-2.6 branch: > > name='hvm' > memory=1024 > vcpus=2 > boot="n" > disk=[ 'file:/disk0.raw,hda,w', ] >

[Xen-devel] qemu-2.7 regression, IPXE boot in HVM fails

2016-08-31 Thread Olaf Hering
The following HVM domU.cfg crashes during boot from emulated network with qemu 2.7, but it works fine with qemu stable-2.6 branch: name='hvm' memory=1024 vcpus=2 boot="n" disk=[ 'file:/disk0.raw,hda,w', ] vif=[ 'mac=00:08:15:41:10:80,bridge=br0', ] keymap="de" serial="pty" builder="hvm" vnc=1

Re: [Xen-devel] OVMF compile error

2016-09-13 Thread Olaf Hering
> > > On Mon, Sep 12, 2016 at 07:31:42AM +, Chen, Farrah wrote: > > > > When I compile xen with the latest commit in RHEL 6.7, it failed when > > > > make tools. Errors showed when running edk2 build for OvmfPkgX64. > > > > erAsm.iii:315: error: invalid combination of opcode and operands

Re: [Xen-devel] [PATCH v2 1/2] xen_platform: unplug also SCSI disks

2016-09-16 Thread Olaf Hering
On Wed, Sep 14, Stefano Stabellini wrote: > Written like this, the code will unplug any Xen SCSI disks together with > Xen IDE disks when the guest writes "1" to ioport `0x10`. I am sorry to > be pedantic, but the recent changes introduced to > docs/misc/hvm-emulated-unplug.markdown do not cover

Re: [Xen-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-09-16 Thread Olaf Hering
On Wed, Sep 14, Stefano Stabellini wrote: > The doc says: > > "If VMDP was configured to control just NIC devices it would write the > value 0x1 to offset 0x8. If VMDP was configured to control just storage > devices it would write the value 0x2 to offset 0x8." > > So 0x1 to 0x8 to unplug NICs,

[Xen-devel] [PATCH] docs: correct values for old VMDP unplug

2016-09-19 Thread Olaf Hering
(val == 2) { pci_unplug_netifs(); net_tap_shutdown_all(); } break; Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/misc/hvm-emulated-unplug.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/misc/hvm-emulated-unplug.markdown

Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing

2016-11-10 Thread Olaf Hering
On Tue, Nov 10, Boris Ostrovsky wrote: > Doing so will cause the grant to be unmapped and then, during > fault handling, the fault to be mistakenly treated as NUMA hint > fault. > > In addition, even if those maps could partcipate in NUMA > balancing, it wouldn't provide any benefit since we are

Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing

2016-11-10 Thread Olaf Hering
On Thu, Nov 10, Boris Ostrovsky wrote: > Is this something new? Because this patch has been there for a year. It was just tested now, cycling through all the combinations for a disk=[]. Removing "direct-is-save" will use different code paths and the error is not seen. Olaf signature.asc

Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing

2016-11-10 Thread Olaf Hering
On Thu, Nov 10, Boris Ostrovsky wrote: > Are you sure it's this patch that causes the failure? > > I commented out '| VM_IO' and still unable to boot with this option. Yes, this works for me, sles12sp2 dom0+domU, which is linux-4.4 based: +++ b/drivers/xen/gntdev.c @@ -804,7 +804,7 @@ static

Re: [Xen-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-10-20 Thread Olaf Hering
On Thu, Oct 13, Stefano Stabellini wrote: > On Fri, 2 Sep 2016, Olaf Hering wrote: > > Implement SUSE specific unplug protocol for emulated PCI devices > > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > > This protocol was implemented and used since Xen 3.0.4.

[Xen-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

2016-10-21 Thread Olaf Hering
-off-by: Olaf Hering <o...@aepfle.de> --- hw/i386/xen/xen_platform.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index f85635c..91d8a7a 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -114,6 +

[Xen-devel] [PATCH v3 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-10-21 Thread Olaf Hering
versions are handled as well. Signed-off-by: Olaf Hering <o...@aepfle.de> --- hw/i386/xen/xen_platform.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 91d8a7a..2e1e543 100644 --- a/hw/i3

[Xen-devel] [PATCH v3 0/2] Xen HVM unplug changes

2016-10-21 Thread Olaf Hering
Update unplug in Xen HVM guests to cover more cases. Please review. changes in v3: - adapt to API changes from 49137bf ("block-backend: remove blk_flush_all") changes in v2: - fix issues reported by checkpatch Olaf Hering (2): xen_platform: unplug also SCSI disks xen_plat

Re: [Xen-devel] [Qemu-devel] [PATCH for-2.8 v3] xen_disk: split discard input to match internal representation

2016-11-23 Thread Olaf Hering
Am 23. November 2016 21:44:50 MEZ, schrieb Olaf Hering <o...@aepfle.de>: >Is this a can for 2.x? candidate Olaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2] xen_disk: split discard input to match internal representation

2016-11-23 Thread Olaf Hering
: mkfs.ext4 -F /dev/xvda Discarding device blocks: failed - Input/output error Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. Add input range checking to avoid overflow. Fixes f313520 ("xen_disk: add discard support") Signed-off-by: Olaf Hering <o...@aepf

Re: [Xen-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-23 Thread Olaf Hering
Ping. On Fri, Nov 18, Olaf Hering wrote: > On Fri, Nov 18, Olaf Hering wrote: > > > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > > +if (!blk_split_discard(ioreq, req->sector_number, > > req->nr_sectors)) { > > +

[Xen-devel] [PATCH v3] xen_disk: split discard input to match internal representation

2016-11-23 Thread Olaf Hering
: mkfs.ext4 -F /dev/xvda Discarding device blocks: failed - Input/output error Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. Add input range checking to avoid overflow. Fixes f313520 ("xen_disk: add discard support") Signed-off-by: Olaf Hering <o...@aepf

Re: [Xen-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-23 Thread Olaf Hering
On Wed, Nov 23, Olaf Hering wrote: > > > +if (!blk_split_discard(ioreq, req->sector_number, > > > req->nr_sectors)) { > > > +goto err; > > How is error handling supposed to work here? In the guest the cmd is stuck, instead of getting

Re: [Xen-devel] [PATCH v4] xen/gntdev: Use VM_MIXEDMAP instead of VM_IO to avoid NUMA balancing

2016-11-23 Thread Olaf Hering
On Mon, Nov 21, Boris Ostrovsky wrote: > Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to > NUMA balancing") set VM_IO flag to prevent grant maps from being > subjected to NUMA balancing. Tested-by: Olaf Hering <o...@aepfle.de> This should go

Re: [Xen-devel] [Qemu-devel] [PATCH for-2.8 v3] xen_disk: split discard input to match internal representation

2016-11-23 Thread Olaf Hering
Am 23. November 2016 13:27:13 MEZ, schrieb Kevin Wolf : >Am 23.11.2016 um 12:40 hat Eric Blake geschrieben: >> Qualifies as a bug fix, so requesting 2.8 inclusion. >> Reviewed-by: Eric Blake Is this a can for 2.x? Olaf

Re: [Xen-devel] [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-22 Thread Olaf Hering
On Fri, Nov 18, Eric Blake wrote: > if (sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count) I have looked at this for a while now and cant spot how this would cover all cases. Are you saying there should be just a single overflow check, yours? My change has two: one to check for wrap around

Re: [Xen-devel] [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-22 Thread Olaf Hering
On Tue, Nov 22, Eric Blake wrote: > if (sec_start + sec_count < sec_count || > sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count) { > return false; > } My point was: how does this handle sec_start=0,sec_count=UINT64_MAX or sec_start=INT64_MAX,sec_count=INT64_MAX? For me this gets

[Xen-devel] [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks

2016-11-24 Thread Olaf Hering
From: Olaf Hering <oher...@suse.de> Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can be used by the emulated BIOS to boot from disk. If the HVM domU has also PV driver the disk may appear twice in the guest. To avoid this an unplug of the emulated hardware is needed, s

[Xen-devel] [PATCH qemu-xen-traditional 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

2016-11-24 Thread Olaf Hering
From: Olaf Hering <oher...@suse.de> Implement SUSE specific unplug protocol for emulated PCI devices in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. This protocol was implemented and used since Xen 3.0.4. It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and openSUS

[Xen-devel] [PATCH qemu-xen-traditional 0/2] Xen HVM unplug changes

2016-11-24 Thread Olaf Hering
Backport from qemu-2.8: Update unplug in Xen HVM guests to cover more cases. The patches are used since years in the SUSE xen-tools package. Olaf Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux unplug for emulated PCI hw/pci.c | 41

Re: [Xen-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

2016-11-24 Thread Olaf Hering
On Fri, Oct 21, Olaf Hering wrote: > Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can > be used by the emulated BIOS to boot from disk. If the HVM domU has also > PV driver the disk may appear twice in the guest. To avoid this an > unplug of the emulated hardwa

Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Olaf Hering
On Wed, Nov 16, Boris Ostrovsky wrote: > Unfortunately I haven't been able to trigger NUMA balancing > so while I tested this in general I am not sure I actually > exercised the code path. Thanks for the patch! Would be nice to actually test the code path which caused the initial addition of

Re: [Xen-devel] [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
Am 18. November 2016 14:43:18 MEZ, schrieb Eric Blake <ebl...@redhat.com>: >On 11/18/2016 04:24 AM, Olaf Hering wrote: >> The guest sends discard requests as u64 sector/count pairs, but the >> block layer operates internally with s64/s32 pairs. The conversion >> lead

Re: [Xen-devel] [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
On Fri, Nov 18, Eric Blake wrote: > On 11/18/2016 04:24 AM, Olaf Hering wrote: > > +/* Overflowing byte limit? */ > > +if ((sec_start + sec_count) > ((INT64_MAX + INT_MAX) >> > > BDRV_SECTOR_BITS)) { > This is undefined. INT64_MAX + anything non-negati

Re: [Xen-devel] [PATCH v2] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-17 Thread Olaf Hering
On Thu, Nov 17, Boris Ostrovsky wrote: > On 11/17/2016 06:28 AM, Olaf Hering wrote: > > ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined! > > ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined! > I just built 4.4.11 with this patc

Re: [Xen-devel] [PATCH v3 (re-send)] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-18 Thread Olaf Hering
On Thu, Nov 17, Boris Ostrovsky wrote: > Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to > NUMA balancing") set VM_IO flag to prevent grant maps from being > subjected to NUMA balancing. Thanks, this works for me in 4.4: Tested-by: Olaf Hering <

[Xen-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
: mkfs.ext4 -F /dev/xvda Discarding device blocks: failed - Input/output error Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. Add input range checking to avoid overflow. Signed-off-by: Olaf Hering <o...@aepfle.de> --- hw/block/xen_disk.

Re: [Xen-devel] [PATCH] xen_disk: convert discard input to byte ranges

2016-11-18 Thread Olaf Hering
On Fri, Nov 18, Olaf Hering wrote: > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > +if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) { > +goto err; How is error handling supposed to work here? Initially I forgot

Re: [Xen-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

2016-11-02 Thread Olaf Hering
On Wed, Nov 02, Thomas Huth wrote: > Olaf Hering reported a build failure due to an undefined reference > to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to > fix the issue. > > Signed-off-by: Thomas Huth <th...@redhat.com> Tested-by: Olaf Hering &l

Re: [Xen-devel] [PATCH 0/2] Open Xen 4.9-unstable, reenable debug

2016-12-02 Thread Olaf Hering
On Fri, Dec 02, Ian Jackson wrote: > I have pushed the first of these two patches to new-staging. It is > very like all previous such commits. The second, to reenable > hypervisor debug, I decided to get some review on. Please also bump the SONAMEs as it was done in commit

Re: [Xen-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

2016-11-29 Thread Olaf Hering
On Tue, Nov 29, Wei Liu wrote: > On Mon, Nov 28, 2016 at 10:28:21AM -0800, Stefano Stabellini wrote: > > Anthony, are you going to take care of this? > > However, given the state of the release, they'll need a release-ack to > > be applied. > I think these patches will need to wait to be

Re: [Xen-devel] [PATCH qemu-xen-traditional 1/2] xen_platform: unplug also SCSI disks [and 1 more messages]

2017-01-09 Thread Olaf Hering
On Mon, Jan 09, Ian Jackson wrote: > Olaf Hering writes ("[PATCH qemu-xen-traditional 2/2] xen_platform: SUSE > xenlinux unplug for emulated PCI"): > > From: Olaf Hering <oher...@suse.de> > > > > Implement SUSE specific unplug protocol for emulate

Re: [Xen-devel] [PATCH qemu-xen-traditional 0/2] Xen HVM unplug changes

2017-01-09 Thread Olaf Hering
On Thu, Nov 24, Olaf Hering wrote: > Backport from qemu-2.8: > Update unplug in Xen HVM guests to cover more cases. > The patches are used since years in the SUSE xen-tools package. Are these patches in the review queue, or did they get dropped? Olaf signature.asc Description: PGP

Re: [Xen-devel] [PATCH v3] x86/time: Don't use virtual TSC if host and guest frequencies are equal

2017-03-28 Thread Olaf Hering
Am Fri, 17 Mar 2017 14:15:26 -0400 schrieb Boris Ostrovsky : > Commit 82713ec8d2 ("x86: use native RDTSC(P) execution when guest and > host frequencies are the same") left out optimization for PV guests > when host and guest run at the same frequency. > > For such a

Re: [Xen-devel] inaccurate dirty_count from XEN_DOMCTL_SHADOW_OP

2017-03-30 Thread Olaf Hering
Am Thu, 30 Mar 2017 12:40:34 +0100 schrieb Andrew Cooper <andrew.coop...@citrix.com>: > On 22/03/17 10:59, Olaf Hering wrote: > > On Wed, Mar 22, Olaf Hering wrote: > > > >> Did the xc_shadow_control API change at some point? > > ... staging-4.5 works, wh

[Xen-devel] inaccurate dirty_count from XEN_DOMCTL_SHADOW_OP

2017-03-21 Thread Olaf Hering
To measure how many dirty pages a domU creates within a timeframe the attached tool was created, based on code from xc_domain_save. Once the domU touches many pages the reported dirty rate is high, but after a few seconds the rate drops down from thousands to just a few dozen. I wonder if the

[Xen-devel] PV performance degraded after live migration

2017-03-15 Thread Olaf Hering
After reports about degraded performance after a PV domU was migrated from one dom0 to another it turned out that this issue happens with every version of Xen and every version of domU kernel. The used benchmark is 'sysbench memory'. I hacked it up to show how long the actual work takes, and that

Re: [Xen-devel] PV performance degraded after live migration

2017-03-15 Thread Olaf Hering
On Wed, Mar 15, Andrew Cooper wrote: > As a crazy idea, doest this help? > tsc->incarnation = 0 Had to move to another testhost and this seems to help. Will do more testing once the original testsystems are accessible again. Thanks! Olaf signature.asc Description: PGP signature

Re: [Xen-devel] PV performance degraded after live migration

2017-03-15 Thread Olaf Hering
On Wed, Mar 15, Olaf Hering wrote: > On Wed, Mar 15, Andrew Cooper wrote: > > As a crazy idea, doest this help? > > tsc->incarnation = 0 This does indeed help. One system shows now the results below, which means the performance goes down during migration (to localhost) and g

Re: [Xen-devel] PV performance degraded after live migration

2017-03-16 Thread Olaf Hering
On Wed, Mar 15, Jan Beulich wrote: > ..., and iirc PV migration didn't have any issue with TSC freq > changing during migration prior to the introduction of vTSC. When was this introduced? There is a claim that this slowdown is a regression. Olaf signature.asc Description: PGP signature

Re: [Xen-devel] inaccurate dirty_count from XEN_DOMCTL_SHADOW_OP

2017-03-22 Thread Olaf Hering
On Tue, Mar 21, Olaf Hering wrote: > I wonder if the usage of xc_shadow_control is correct. The testing was > done with a xen-4.4 based dom0, I will verify with staging once I find > the time. It does work with xen-4.4, but fails with staging. Did the xc_shadow_control API change at s

Re: [Xen-devel] inaccurate dirty_count from XEN_DOMCTL_SHADOW_OP

2017-03-22 Thread Olaf Hering
On Wed, Mar 22, Olaf Hering wrote: > Did the xc_shadow_control API change at some point? ... staging-4.5 works, while staging-4.6 does not. Olaf signature.asc Description: PGP signature ___ Xen-devel mailing list Xen-devel@lists.xen.org ht

Re: [Xen-devel] [PATCH] tools: Include due to glibc 2.25

2017-03-15 Thread Olaf Hering
On Tue, Mar 14, Anthony PERARD wrote: > +++ b/tools/libxl/libxl_internal.h > +#include There is a __linux__ section in that file. I sent a similar patch yesterday, but with a wrong change for blktap2. Olaf signature.asc Description: PGP signature

[Xen-devel] [PATCH v2] tools: include sys/sysmacros.h on Linux

2017-03-15 Thread Olaf Hering
/sysmacros.h to define these three macros. blktap2 is already Linux specific. The kernel header which was used to get makedev() does not provided it anymore, and it was wrong to use a kernel header anyway. Signed-off-by: Olaf Hering <o...@aepfle.de> --- v2: keep include linux/major.h for MISC_MAJOR

[Xen-devel] [PATCH RFC] handle tsc_tolerance during migration between identical hosts

2017-04-11 Thread Olaf Hering
Testing has shown that domUs with 'tsc_mode=default' can be migrated safely between identical hardware, even if the measured clock frequency differs by a few kHz. A change like shown below would allow to migrate between "2.nnGHz" hosts without enforcing emulation. If the domU is migrated to a host

[Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Olaf Hering
Andrew, with eab806a097b ("tools/libxc: x86 PV restore code") the only call of xc_domain_populate_physmap_exact was added to the new restore code. This call always sets order=0. The old migration code did consider superpages, the new one does not. What is the reason for not using superpages when

Re: [Xen-devel] superpages lost after migration of HVM domU

2017-04-20 Thread Olaf Hering
On Thu, Apr 20, Andrew Cooper wrote: > As it currently stands, the sending side iterates from 0 to p2m_size, > and sends every frame on the first pass. This means we get PAGE_DATA > records linearly, in batches of 1024, or two aligned 2M superpages. Is there a way to preserve 1G pages? This

Re: [Xen-devel] [PATCH] tools: include sys/sysmacros.h on Linux

2017-03-14 Thread Olaf Hering
Am Tue, 14 Mar 2017 11:54:46 + schrieb Wei Liu : > tap-ctl-allocate.c:143:9: error: ‘MISC_MAJOR’ undeclared (first use in That happened because the variant of the change I sent was untested... I will revisit this part. sys/types.h is needed according to mknod(2). Olaf

[Xen-devel] [PATCH] tools: include sys/sysmacros.h on Linux

2017-03-14 Thread Olaf Hering
/sysmacros.h to define these three macros. blktap2 is already Linux specific. The kernel header which was used to get makedev() does not provided it anymore, and it was wrong to use a kernel header anyway. Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/blktap2/control/tap-ctl-allocate

[Xen-devel] [PATCH] tools/xenstore: define off_t

2017-03-03 Thread Olaf Hering
talloc.h uses off_t, but did not include Fixes 7012548e0d ("xenstore: enhance control command support") Signed-off-by: Olaf Hering <o...@aepfle.de> --- tools/xenstore/talloc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xenstore/talloc.h b/tools/xenstor

Re: [Xen-devel] [PATCH RFC] handle tsc_tolerance during migration between identical hosts

2017-04-18 Thread Olaf Hering
On Tue, Apr 11, Jan Beulich wrote: > I'm afraid successful testing is not a sufficient criteria here. At > the very least the (so far missing) documentation needs to very > clearly point out the possible risks associated with using this > option. But with there not being any functional change

Re: [Xen-devel] [PATCH RFC] handle tsc_tolerance during migration between identical hosts

2017-04-19 Thread Olaf Hering
On Tue, Apr 18, Jan Beulich wrote: > >>> On 18.04.17 at 11:50, wrote: > > On Tue, Apr 11, Jan Beulich wrote: > > > >> I'm afraid successful testing is not a sufficient criteria here. At > >> the very least the (so far missing) documentation needs to very > >> clearly point out

[Xen-devel] [PATCH] xen-disk: use g_malloc0 to fix build

2017-07-28 Thread Olaf Hering
g_malloc0_n is available since glib-2.24. To allow build with older glib versions use the generic g_malloc0, which is already used in many other places in the code. Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings") Signed-off-by: Olaf Hering <o...@aepfl

Re: [Xen-devel] [Qemu-devel] [PATCH] xen-disk: use g_malloc0 to fix build

2017-07-28 Thread Olaf Hering
On Fri, Jul 28, Eric Blake wrote: > This version is prone to multiplication overflow (well, maybe not, but > you have to audit for that). Wouldn't it be better to use: What could go wrong? qemu will die either way, I think. Olaf signature.asc Description: PGP signature

[Xen-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Olaf Hering
g_malloc0_n is available since glib-2.24. To allow build with older glib versions use the generic g_new0, which is already used in many other places in the code. Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings") Signed-off-by: Olaf Hering <o...@aepfl

Re: [Xen-devel] backport docs changes for Xen 4.9.1

2017-08-03 Thread Olaf Hering
On Thu, Aug 03, Jan Beulich wrote: > >>> On 01.08.17 at 11:43, wrote: > > Please backport the following changes for docs/ for the Xen 4.9.1 > > release: > > > > aa4eb460bc docs: add pod variant of xl-numa-placement > > 458df9f374 docs: add pod variant of

Re: [Xen-devel] [PATCH v1] tools/libxc: use superpages during restore of HVM guest

2017-08-03 Thread Olaf Hering
On Wed, Aug 02, Olaf Hering wrote: > +++ b/tools/libxc/xc_sr_restore_x86_hvm.c > +#define SUPERPAGE_2MB_SHIFT 9 > +#define SUPERPAGE_2MB_NR_PFNS (1UL << SUPERPAGE_2MB_SHIFT) > +#define SUPERPAGE_1GB_SHIFT 18 > +#define SUPERPAGE_1GB_NR_PFNS (1UL << SUPERPAGE_1G

[Xen-devel] API to query NUMA node of mfn

2017-07-10 Thread Olaf Hering
I would like to verify on which NUMA node the PFNs used by a HVM guest are located. Is there an API for that? Something like: foreach (pfn, domid) mfns_per_node[pfn_to_node(pfn)]++ foreach (node) printk("%x %x\n", node, mfns_per_node[node]) Olaf signature.asc Description: PGP

Re: [Xen-devel] API to query NUMA node of mfn

2017-07-10 Thread Olaf Hering
On Mon, Jul 10, Konrad Rzeszutek Wilk wrote: > Soo I wrote some code for exactly this for Xen 4.4.4 , along with > creation of a PGM map to see the NUMA nodes locality. Are you planning to prepare that for staging at some point? I have not checked this series is already merged. Olaf

[Xen-devel] [PATCH 4/6] docs: remove markdown variant of xen-pv-channel.7

2017-07-24 Thread Olaf Hering
A variant in pod format exists now. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xen-pv-channel.markdown.7 | 106 - 1 file changed, 106 deletions(-) delete mode 100644 docs/man/xen-pv-channel.markdown.7 diff --git a/docs/man/

[Xen-devel] [PATCH 5/6] docs: remove markdown variant of xl-network-configuration.5

2017-07-24 Thread Olaf Hering
A variant in pod format exists now. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xl-network-configuration.markdown.5 | 173 --- 1 file changed, 173 deletions(-) delete mode 100644 docs/man/xl-network-configuration.markdown.5 diff --git a/docs/man/xl-n

[Xen-devel] [PATCH 3/6] docs: add pod variant of xl-numa-placement

2017-07-24 Thread Olaf Hering
Add source in pod format for xl-numa-placement.7 This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xl-numa-placement.pod.7

[Xen-devel] [PATCH 6/6] docs: remove markdown variant of xl-numa-placement.7

2017-07-24 Thread Olaf Hering
A variant in pod format exists now. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xl-numa-placement.markdown.7 | 239 -- 1 file changed, 239 deletions(-) delete mode 100644 docs/man/xl-numa-placement.markdown.7 diff --git a/docs/man/x

[Xen-devel] [PATCH 1/6] docs: add pod variant of xen-pv-channel.7

2017-07-24 Thread Olaf Hering
Add source in pod format for xen-pv-channel.7 This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xen-pv-channel.pod.7

[Xen-devel] [PATCH 2/6] docs: add pod variant of xl-network-configuration.5

2017-07-24 Thread Olaf Hering
Add source in pod format for xl-network-configuration.5 This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xl-network-configuration.pod.5

[Xen-devel] [PATCH 0/6] docs: convert manpages to pod

2017-07-24 Thread Olaf Hering
forward. Olaf Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Wei Liu <wei.l...@citrix.com> To: xen-devel@lists.xen.org Olaf Hering (6): docs: add pod variant of xen-pv-channel.7 docs: add pod variant of xl-network-configuration.5 docs: add pod variant of xl-numa-placement

Re: [Xen-devel] [PATCH 0/6] docs: convert manpages to pod

2017-07-24 Thread Olaf Hering
On Mon, Jul 24, Ian Jackson wrote: > Olaf Hering writes ("[PATCH 0/6] docs: convert manpages to pod"): > > To remove the buildtime dependency to pandoc/ghc some manpages are > > converted from markdown to pod format. This will provide more manpages > > which are r

Re: [Xen-devel] [PATCH 0/6] docs: convert manpages to pod

2017-07-24 Thread Olaf Hering
On Mon, Jul 24, Ian Jackson wrote: > * There are a lot of other documents in docs/misc/ which are in > markdown format. Some of them are internal. I'm pretty sure we don't > want them _all_ converted. So even if you convert the manpages, these > documents will remain. I did not intent to

Re: [Xen-devel] [PULL 3/3] xen-disk: add support for multi-page shared rings

2017-07-27 Thread Olaf Hering
On Tue, Jun 27, Stefano Stabellini wrote: > From: Paul Durrant > The blkif protocol has had provision for negotiation of multi-page shared > rings for some time now and many guest OS have support in their frontend > drivers. > +++ b/hw/block/xen_disk.c > +domids =

[Xen-devel] [PATCH v3 1/3] docs: add pod variant of xen-pv-channel.7

2017-07-26 Thread Olaf Hering
Convert source for xen-pv-channel.7 from markdown to pod. This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- docs/man/xen-pv-channel.markdown.7

[Xen-devel] [PATCH v3 2/3] docs: add pod variant of xl-network-configuration.5

2017-07-26 Thread Olaf Hering
Convert source for xl-network-configuration.5 from markdown to pod. This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- ...n.markdown.5 => xl-network-configurat

[Xen-devel] [PATCH v3 3/3] docs: add pod variant of xl-numa-placement

2017-07-26 Thread Olaf Hering
Convert source for xl-numa-placement.7 from markdown to pod. This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- ...lacement.markdown.7 => xl-numa-placement.pod

[Xen-devel] [PATCH v3 0/3] docs: convert manpages to pod

2017-07-26 Thread Olaf Hering
forward. Olaf v3: - add NAME/DESCRIPION, minor formating tweaks, whitespace v2: fold each add/remove into a single commit Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Wei Liu <wei.l...@citrix.com> To: xen-devel@lists.xen.org Olaf Hering (3): docs: add pod variant of xen-

[Xen-devel] [PATCH v2 3/3] docs: add pod variant of xl-numa-placement

2017-07-25 Thread Olaf Hering
Convert source for xl-numa-placement.7 from markdown to pod. This removes the buildtime requirement for pandoc, and subsequently the need for ghc, in the chain for BuildRequires of xen.rpm. Signed-off-by: Olaf Hering <o...@aepfle.de> --- ...lacement.markdown.7 => xl-numa-placement.pod

<    2   3   4   5   6   7   8   9   >