Re: [Xen-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 14:35, Li, Liang Z wrote: > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..f2893b2 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -736,7 +736,7 @@ static int xen_pt_initfn(PCIDevice *d) > } > > out: > -memory_listener_register(&s->memory_li

Re: [Xen-devel] [v3 5/5] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

2015-01-12 Thread Paolo Bonzini
On 31/12/2014 00:03, Quan Xu wrote: > make sure QEMU machine class is initialized and QEMU has registered > Xen stubdom vTPM driver when call tpm_init() > > Signed-off-by: Quan Xu > --- > vl.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/vl.c b/vl

Re: [Xen-devel] [PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-12 Thread Paolo Bonzini
On 12/10/2015 13:09, Stefano Stabellini wrote: > On Sun, 11 Oct 2015, Lan Tianyu wrote: >> From: > >> >> msix->mmio is added to XenPCIPassthroughState's object as property. >> object_finalize_child_property is called for XenPCIPassthroughState's >> object, which calls object_property_del_all, whi

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 03:08, Andy Lutomirski wrote: > On Mon, Sep 1, 2014 at 10:39 AM, Andy Lutomirski wrote: >> This fixes virtio on Xen guests as well as on any other platform >> that uses virtio_pci on which physical addresses don't match bus >> addresses. >> >> This can be tested with: >> >> vir

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 12:12, Benjamin Herrenschmidt wrote: >> > That is an experimental feature (it's x-iommu), so it can change. >> > >> > The plan was: >> > >> > - for PPC, virtio never honors IOMMU >> > >> > - for non-PPC, either have virtio always honor IOMMU, or enforce that >> > virtio is not un

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 15:11, Jan Kiszka wrote: >>> >> >>> >> This doesn't matter much, since the only guests that implement an IOMMU >>> >> in QEMU are (afaik) PPC and x86, and x86 does not yet promise any kind >>> >> of stability. >> > >> > Hmm I think Jan (cc) said it was already used out there. > Yes

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 18:42, Jan Kiszka wrote: > > On the other hand interrupt remapping is absolutely necessary for > > production use, hence my point that x86 does not promise API stability. > > Well, we currently implement the features that the Q35 used to expose. > Adding interrupt remapping will re

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-28 Thread Paolo Bonzini
On 28/07/2015 19:19, Jan Kiszka wrote: > On 2015-07-28 19:15, Paolo Bonzini wrote: >> >> >> On 28/07/2015 18:42, Jan Kiszka wrote: >>>> On the other hand interrupt remapping is absolutely necessary for >>>> production use, hence my point that x86 doe

Re: [Xen-devel] [PATCH v4 0/4] virtio: Clean up scatterlists and use the DMA API

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 02:47, Andy Lutomirski wrote: > > > If new kernels ignore the IOMMU for devices that don't set the flag > > > and there are physical devices that already exist and don't set the > > > flag, then those devices won't work reliably on most modern > > > non-virtual platforms, PPC includ

Re: [Xen-devel] [v3 1/5] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

2015-01-19 Thread Paolo Bonzini
On 31/12/2014 00:02, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > configure| 14 ++ > hmp.c| 7 +++ > qapi-schema.json | 19 --- > qemu-options.hx | 13 +++-- > tpm.c| 7 ++- > 5 files changed, 54 insertions(+), 6

Re: [Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 16:12, Liang Li wrote: > 2. Do the attach and detach operation with a time interval. eg. 10s. > > The error message will not disappear if retry, in this case, it's > a bug. > > In the 'xen_pt_region_add' and 'xen_pt_region_del', we should only care > about the 'xen-pc

Re: [Xen-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed

2015-04-15 Thread Paolo Bonzini
On 15/04/2015 16:14, Li, Liang Z wrote: > Yes, it's the right place. Put aside the bug fix, I think the > memory_region_ref/unref pair > should be move to xen_pt_region_update after the conditional as you point > out. > Do you think so? It would make sense, but I was just guessing... I'm s

<    1   2