Re: [Xen-devel] RFC: Cleaning up the Mini-OS namespace

Antti Kantee, le Thu 04 Dec 2014 22:52:05 +, a écrit : Currently, the software stack in rumprun-xen is confusing because MiniOS partially uses libc Which part of libc? MiniOS itself is very independent of libc, it only ships a couple of things. We can probably happily #ifdef them if needed.

Re: [Xen-devel] RFC: Cleaning up the Mini-OS namespace

Antti Kantee, le Sun 07 Dec 2014 18:13:38 +, a écrit : On 07/12/14 18:09, Samuel Thibault wrote: I said it unclearly. I meant the use of #include lotofthings.h (e.g. string.h, stdio.h, etc) ? minios itself doesn't do this when it's not compiled with HAVE_LIBC. Building

Re: [Xen-devel] [PATCH] Mini-OS: netfront: Fix rx ring starvation in network_rx

and no packets will be delivered. Further, we make the HAVE_LIBC codepath clearer to follow by removing the some variable from the for loop initialisation and conditions. Signed-off-by: Martin Lucina mar...@lucina.net Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- extras/mini-os

Re: [Xen-devel] [PATCH 3/3] mini-os: sort objects in binary archives

from identical sources but on different build hosts. To help with creating a reproducible binary the elements in an archive must simply be sorted before passing them to $(AR). Signed-off-by: Olaf Hering o...@aepfle.de Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com Cc: Samuel Thibault

Re: [Xen-devel] [PATCH] x86/minios: Remove more vestigial remnants of SUPERVISOR_MODE_KERNEL

...@suse.com CC: Tim Deegan t...@xen.org CC: Stefano Stabellini stefano.stabell...@eu.citrix.com CC: Samuel Thibault samuel.thiba...@ens-lyon.org Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- extras/mini-os/arch/x86/x86_64.S |5 + 1 file changed, 1 insertion(+), 4 deletions

Re: [Xen-devel] [PATCH RFC 0/5] Split off mini-os to a separate tree

Hello, Wei Liu, le Sun 25 Jan 2015 18:13:41 +, a écrit : There has been increasing use of mini-os in unikernel world and basically everybody has their own fork of mini-os. That way going foward is going to cause fragmentation of the community. We would like to split off mini-os tree so

Re: [Xen-devel] [PATCH RFC 0/5] Split off mini-os to a separate tree

Wei Liu, le Thu 29 Jan 2015 11:09:04 +, a écrit : In fact, stubdom should be treated as a downstream of mini-os as with any other unikernel. This can help us discover any dishonesty in API design and code. Right :) Samuel ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v2 1/5] vTPM: event channel bind interdomain with para/hvm virtual machine

Xu, Quan, le Tue 06 Jan 2015 16:46:58 +, a écrit : QEMU is running in Dom0 as usual, so the domid is 0. One can also run the HVM QEMU inside a stubdomain. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] Upstream QEMU based stubdom and rump kernel

Hello, Wei Liu, le Tue 17 Mar 2015 14:29:07 +, a écrit : One of my lessons learned from the existing stubdom stuffs is that I should work with upstream and produce maintainable code. Not only maintainable, but really make sure to have the time to stick with upstream on the long run, first

Re: [Xen-devel] [PATCH] stubdom: export XEN_ROOT in makefile

Wei Liu, le Tue 10 Mar 2015 13:14:39 +, a écrit : ... because XEN_ROOT is used in mini-os's Config.mk. Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- stubdom/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/stubdom

Re: [Xen-devel] [PATCH] mini-os: replace XEN_TARGET_ARCH with MINIOS_TARGET_ARCH

Wei Liu, le Tue 10 Mar 2015 13:14:38 +, a écrit : One place was missed when I did the replacement in 55f7cd7427 (Mini-OS: standalone build). Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- Makefile | 2 +- 1 file changed, 1

Re: [Xen-devel] [PATCH v2 5/5] libxc: rumpxen: provide xc_osdep_info

ian.jack...@eu.citrix.com Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org +static xc_osdep_handle minios_privcmd_open(xc_interface *xch) +{ +return 1; +} +static xc_osdep_handle minios_gnttab_open(xc_gnttab *xcg) +{ +return 1

Re: [Xen-devel] [PATCH v2 5/5] libxc: rumpxen: provide xc_osdep_info

Wei Liu, le Tue 03 Mar 2015 16:41:23 +, a écrit : On Tue, Mar 03, 2015 at 05:05:29PM +0100, Samuel Thibault wrote: Wei Liu, le Tue 03 Mar 2015 15:57:21 +, a écrit : This allows programs which use the bulk of libxc to link. We use /dev/xenevt for event channels, the raw minios

Re: [Xen-devel] [PATCH v2 5/5] libxc: rumpxen: provide xc_osdep_info

Wei Liu, le Tue 03 Mar 2015 16:58:07 +, a écrit : Rump kernel doesn't use mini-os's fd management facility so there is no alloc_fd etc. On the other hand this makes me think number 1 is as good as any other number we can use. Does Rump have not fd at all? It'd probably still be good to

Re: [Xen-devel] [PATCH v2 5/7] Mini-OS: standalone build

Acked-by: Ian Campbell ian.campb...@citrix.com I'd be happier if it also had Samuel's ack on it. Ack-by: Samuel Thibault samuel.thiba...@ens-lyon.org ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/5] libxc: Split off xc_minios_privcmd.c

...@eu.citrix.com [ wei: wrap long lines, use __RUMPRUN__ and define macro for map_frames_ex ] Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- tools/libxc/Makefile| 2 +- tools/libxc/xc_minios.c | 243

Re: [Xen-devel] [PATCH 4/5] libxc: minios: Introduce abstraction for files[]

away the use of files[] inside the actual functions. Do this with a #define whose definition we are going to make conditional in just a moment. No functional change in this patch. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org

Re: [Xen-devel] [PATCH v2 5/7] Mini-OS: standalone build

Ian Campbell, le Wed 25 Feb 2015 09:53:52 +, a écrit : On Tue, 2015-02-24 at 20:39 +0100, Samuel Thibault wrote: Ack-by: Samuel Thibault samuel.thiba...@ens-lyon.org Can I take it you are OK in principal with the plans to move things out? Yes. TBH I think it'll make very little

Re: [Xen-devel] [PATCH] pvgrub: initialise p2m_size

ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- stubdom/grub/kexec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/stubdom/grub/kexec.c b/stubdom/grub/kexec.c index dc8db81..4c33b25 100644

Re: [Xen-devel] [PATCH mini-os] Correct printf formatting for tpm_tis message.

Ian Campbell, le Fri 26 Jun 2015 11:58:40 +0100, a écrit : This is under #ifdef HAVE_LIBC so went unnoticed before. Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- tpm_tis.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [Xen-devel] [PATCH xen] stubdom: vtpmmgr: Correctly format size_t with %z when printing.

...@eu.citrix.com Acked-By: Samuel Thibault samuel.thiba...@ens-lyon.org (after the 'z' modifier support is commited, of course) --- I intend to fold in an update to MINIOS_UPSTREAM_REVISION upon commit to pull in the updated mini-os plus the Correct printf formatting for tpm_tis message. patch

Re: [Xen-devel] [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries

lude libxengnttab with libxc > mini-os: Include libxencall with libxc > mini-os: Include libxenforeignmemory with libxc All Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> in case it was really necessary :) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Wei Liu, le Tue 27 Oct 2015 10:32:18 +, a écrit : > I haven't checked if cxenstored behaves the same, though. It doesn't: it checks for room in rings before sleeping. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

igned-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> diff --git a/tools/ocaml/libs/xb/xs_ring_stubs.c b/tools/ocaml/libs/xb/xs_ring_stubs.c index fd561a2..5c771d6 100644 --- a/tools/ocaml/libs/xb/xs_ring_stubs.c +++ b/tools/ocaml/libs/xb/xs_ring_stubs.c @@ -99,12 +99,12 @@

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Samuel Thibault, le Mon 26 Oct 2015 18:11:04 +0100, a écrit : > diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml > index 50944b5..33298d2 100644 > --- a/tools/ocaml/libs/xb/xb.ml > +++ b/tools/ocaml/libs/xb/xb.ml > @@ -91,10 +91,12 @@ let write_fd

Re: [Xen-devel] [PATCH MINI-OS v3 1/2] xenbus: notify the other end when necessary

n using stubdom > because the device model was stalled. > > Fix this by sending notification to the other end when it consumes a > message. A bunch of memory barriers are also added to ensure > correctness. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Sam

Re: [Xen-devel] [PATCH MINI-OS v3 2/2] xenbus: workaround oxenstored short-write

om> As discussed in the previous thread, this is rather a workaround. Better be safe than sorry. Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> And could too be backported to stable branches. > --- > xenbus/xenbus.c | 10 -- > 1 file changed, 8 insertions(+),

Re: [Xen-devel] Oxenstored short-write issue

Wei Liu, le Tue 27 Oct 2015 15:59:46 +, a écrit : > > Interesting! I always thought it was a bit odd that oxenstored could write > > a partial packet but I thought it would retry higher up and complete the > > transmit before sleeping. It’s certainly clearer to complete the write at > > the

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

Andrew Cooper, le Tue 27 Oct 2015 17:21:39 +, a écrit : > The correct behaviour would be for Xs_ring.write to return the actual > number of bytes it put into the ring, even if this is shorter than len. That is already what it does. Samuel ___

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

Another way would be to make ml_interface_write write both pieces instead of just a contiguous one. The caml code would then look less suspicious :) Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

Andrew Cooper, le Tue 27 Oct 2015 17:21:39 +, a écrit : > as the second attempted write could return short as well. That is fine. The second attempt will only return a short write if there was really not enough room for it, which is what we want. Samuel

Re: [Xen-devel] [PATCH] oxenstored: fix short-write issue

That being said, Wei Liu, le Tue 27 Oct 2015 17:10:09 +, a écrit : > @@ -91,10 +91,12 @@ let write_fd back con s len = > Unix.write back.fd s 0 len > > let write_mmap back con s len = > - let ws = Xs_ring.write back.mmap s len in > - if ws > 0 then > + let ws = ref

Re: [Xen-devel] [PATCH RFC] tools/ocaml/xb: Correct calculations of data/space the ring

Andrew Cooper, le Wed 28 Oct 2015 16:05:36 +, a écrit : > @@ -62,22 +62,32 @@ CAMLprim value ml_interface_read(value ml_interface, > > xen_mb(); > > - if ((prod - cons) > XENSTORE_RING_SIZE) > + if (((prod - cons) > XENSTORE_RING_SIZE) || > +((cons - prod) <

Re: [Xen-devel] [PATCH RFC] tools/ocaml/xb: Correct calculations of data/space the ring

Andrew Cooper, le Wed 28 Oct 2015 16:43:54 +, a écrit : > > IIRC the test is not bogus even when prod wraps around, (prod - cons) > > will still correctly be the difference between both, modulo 2^32. > > (prod - cons) >= XENSTORE_RING_SIZE checks for the prod getting more > than a ring's

Re: [Xen-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Wei Liu, le Mon 26 Oct 2015 12:47:56 +, a écrit : > -if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > sizeof(msg)) > +if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < > sizeof(msg)) { > +notify_remote_via_evtchn(start_info.store_evtchn); >

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

Wei Liu, le Mon 26 Oct 2015 12:30:28 +, a écrit : > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +, a écrit : > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > which I

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

Hello, Indeed, notification seems to have been missing since basically 2006... Wei Liu, le Mon 26 Oct 2015 09:47:48 +, a écrit : > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..7451161 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,10 @@ static void

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

Wei Liu, le Mon 26 Oct 2015 12:14:43 +, a écrit : > In my patch, mini-os notifies remote whenever it consumes a message, > which I think it's slightly better because backend can start putting > things in the ring as mini-os processes them. That makes more notifications, but that can lead to

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Wei Liu, le Mon 26 Oct 2015 16:41:15 +, a écrit : > The oxenstored in staging. Ok. For a first, one fishy thing at quick sight is that the only occurence of rsp_cons (except at closure) is when writing, and not when going to sleep. One issue there is that ml_interface_write only writes a

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Wei Liu, le Mon 26 Oct 2015 13:55:31 +, a écrit : > On Mon, Oct 26, 2015 at 01:52:47PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:47:56 +, a écrit : > > > -if (xenstore_buf->rsp_prod - xenstore_buf->rsp_

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Ian Jackson, le Mon 26 Oct 2015 16:32:10 +, a écrit : > Samuel Thibault writes ("Re: [Minios-devel] [PATCH MINI-OS v2] xenbus: notify > the other end when necessary"): > > Ok... This is still very worrying. The more I'm thinking about it, > > the more I belie

Re: [Xen-devel] [Minios-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

Also, just to make sure: you tested with the third and fourth hooks of your v2 patch applied, only first and second hooks were removed? Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

Wei Liu, on Tue 10 Nov 2015 15:09:33 +, wrote: > On Tue, Nov 10, 2015 at 04:06:13PM +0100, Samuel Thibault wrote: > > Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > > > I think I will port this patch to cxenstored at some point. As far as I > > > can tel

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

Wei Liu, on Tue 10 Nov 2015 14:59:17 +, wrote: > I think I will port this patch to cxenstored at some point. As far as I > can tell cxenstored's data / space calculation is bogus in the same way. The low-level function return short reads and writes, yes, but that is handled at a higher level:

Re: [Xen-devel] [PATCH v2] tools/ocaml/xb: Correct calculations of data/space the ring

an a ring size ahead of the consumer, or if > the consumer ever overtakes the producer. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > CC: Ian Campbell <ian.campb...@citrix.com&g

Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

Eric Shelton, le Fri 10 Jul 2015 11:36:02 -0400, a écrit : Allocate additional memory to the stub domain for qemu-traditional if more than 4 MB is assigned to the video adapter to avoid out of memory condition for QEMU. Signed-off-by: Eric Shelton eshel...@pobox.com Acked-by: Samuel

Re: [Xen-devel] [PATCH 0/1] libxl: set stub domain size based on VRAM size

Eric Shelton, le Fri 10 Jul 2015 11:36:01 -0400, a écrit : Assuming the the original value of 32 MB was based on having a 4 MB video adapter, In my memory that was the case, yes. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH V2 1/1] libxl: set stub domain size based on VRAM size

Eric Shelton, le Fri 10 Jul 2015 18:14:32 -0400, a écrit : -dm_config-b_info.max_memkb = 32 * 1024; +dm_config-b_info.max_memkb = 28 * 1024 + +max(guest_config-b_info.video_memkb, 4096); I'm actually wondering whether just using +dm_config-b_info.max_memkb = 28 * 1024 +

Re: [Xen-devel] On distro packaging of stub domains (Re: Notes from Xen BoF at Debconf15)

Ian Campbell, le Tue 08 Sep 2015 17:15:40 +0100, a écrit : > Is it at all possible (even theoretically) to take a shared library (which > is relocatable as required) and to do a compile time static linking pass on > it? i.e. use libfoo.so but still do static linking? € gcc test.c -o libtest.so

Re: [Xen-devel] On distro packaging of stub domains (Re: Notes from Xen BoF at Debconf15)

Ian Campbell, le Tue 08 Sep 2015 17:37:21 +0100, a écrit : > On Tue, 2015-09-08 at 18:26 +0200, Samuel Thibault wrote: > > Ian Campbell, le Tue 08 Sep 2015 17:15:40 +0100, a écrit : > > > Is it at all possible (even theoretically) to take a shared library > > >

Re: [Xen-devel] [BUG] XEN domU crash when PV grub chainloads 32-bit domU grub

Andreas Sundstrom, le Mon 21 Sep 2015 22:03:22 +0200, a écrit : > Note that my original thought was that this bug probably is within GRUB. It's probably in the GRUB implementation of loading the domU GRUB, since you say that pvgrub1 loads it fine. > (XEN) domain_crash_sync called from entry.S:

Re: [Xen-devel] Double gnttab_end_access in mini-os netfront

Ian Campbell, on Tue 08 Dec 2015 11:33:49 +, wrote: > > http://xenbits.xen.org/gitweb/?p=mini-os.git;a=commit;h=7c8f348390652a67e > > 9356eec9cd2b0f76a9c7c72 > > > > With that commit reverted, issue vanishes. > > > > I guess it's because before this commit, there was "if (rx->status == > >

Re: [Xen-devel] Double gnttab_end_access in mini-os netfront

Marek Marczykowski-Górecki, on Tue 08 Dec 2015 12:46:31 +0100, wrote: > > > http://xenbits.xen.org/gitweb/?p=mini-os.git;a=commit;h=7c8f348390652a67e > > > 9356eec9cd2b0f76a9c7c72 > > > > > > With that commit reverted, issue vanishes. > > > > > > I guess it's because before this commit, there

Re: [Xen-devel] [PATCH XEN v7 01/29] stubdom: recurse into tools/include in mk-headers-$(XEN_TARGET_ARCH) rule

gh > their eventual dependency on newlib which in turn depends on > mk-headers-$(XEN_TARGET_ARCH). > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: samuel.thiba...@ens-lyon.org Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > v7: New pa

Re: [Xen-devel] [PATCH 9/9] xenstore: when running in mini-os use printk for diagnostic messages

Ian Campbell, on Tue 15 Dec 2015 12:31:05 +, wrote: > On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote: > > Xenstore messages for diagnostic purposes are lost today in case > > xenstore is running under mini-os instead in a dom0 daemon. > > Where does vfprintf end up under mini-os?  In

Re: [Xen-devel] Xen Security Advisory 155 (CVE-2015-8550) - paravirtualized drivers incautious about shared memory

Stefano Stabellini, on Tue 22 Dec 2015 12:24:35 +, wrote: > MiniOS for QEMU stubdom has frontends, such as mini-os/blkfront.c and > mini-os/netfront.c, not backends. There is one backend, tpmback. It however doesn't use a ring. Samuel ___

Re: [Xen-devel] dom builder logging from pvgrub.

Ian Campbell, on Tue 01 Dec 2015 11:12:36 +, wrote: > I found the following hack quite handy here. Posting it for the > archives/posterity, I don't really plan to clean it up and submit it > properly (since I'm not really sure what a non-hack version would be). I would say a non-hack version

Re: [Xen-devel] [PATCH v2] minios: don't rely on specific page table allocation scheme

Hello, Juergen Gross, on Fri 20 Nov 2015 14:52:57 +0100, wrote: > Today mini-os is making assumptions how the page tables it is started > with are being allocated. Especially it is using the number of page > table frames to calculate which is the first unmapped pfn. > > Instead of relying on

Re: [Xen-devel] [PATCH] MAINTAINERS: mini-os patches should be copied to minios-devel

Ian Campbell, on Fri 20 Nov 2015 14:22:11 +, wrote: > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: samuel.thiba...@ens-lyon.org > Cc: stefano.stabell...@eu.citrix.com > Cc: minios-de...@lists.xenproject.org Acked-by: Samuel Thibault <samuel.

Re: [Xen-devel] [PATCH v3] minios: don't rely on specific page table allocation scheme

g on page table number assumptions just look into the > page tables to find the first pfn not already mapped. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Changes in V3: > - check for every pfn

Re: [Xen-devel] [PATCH MINI-OS] Add a .gitignore

Ian Campbell, on Mon 23 Nov 2015 16:34:31 +, wrote: > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > .gitignore | 6 ++ > 1 file changed, 6 insertions(+) > create mode 100644 .gitignore &

Re: [Xen-devel] HVMlite ABI specification DRAFT A

Roger Pau Monné, on Thu 04 Feb 2016 20:21:24 +0100, wrote: > > +1 > > We need that to pass parameters to gnumach modules. > > Hm, parameters as in a string that's paired with a module, That, yes. Just like the kernel command line. One per module. > I see that multiboot provides a string

Re: [Xen-devel] [PATCH] x86/HVM: rewrite the start info structure definition in binary form

Jan Beulich, on Tue 09 Feb 2016 01:14:13 -0700, wrote: > >>> On 05.02.16 at 16:45, wrote: > > El 5/2/16 a les 14:13, Jan Beulich ha escrit: > >> But > >> even then - wouldn't what I've read on the other thread mean > >> at least the filename should be put there (as kind of

Re: [Xen-devel] [PATCH] x86/HVM: rewrite the start info structure definition in binary form

Roger Pau Monné, on Tue 09 Feb 2016 11:45:01 +0100, wrote: > El 9/2/16 a les 11:41, Samuel Thibault ha escrit: > > Roger Pau Monné, on Tue 09 Feb 2016 11:38:43 +0100, wrote: > >> Other OSes that use the pv loader don't pass any module at all AFAIK. > > > > GNU

Re: [Xen-devel] [PATCH] x86/HVM: rewrite the start info structure definition in binary form

Roger Pau Monné, on Tue 09 Feb 2016 11:38:43 +0100, wrote: > Other OSes that use the pv loader don't pass any module at all AFAIK. GNU Mach does need several modules. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] HVMlite ABI specification DRAFT A

Boris Ostrovsky, on Thu 04 Feb 2016 13:38:02 -0500, wrote: > On 02/04/2016 12:48 PM, Roger Pau Monné wrote: > >The format of the boot start info structure is the following (pointed to > >be %ebx): > > > > struct hvm_start_info { > > #define HVM_START_MAGIC_VALUE 0x336ec578 > >

Re: [Xen-devel] [PATCH] stubdom: fix link farm runes

gt; Indeed, 31d2d1e0 (Move xenstore and libxc public headers to include subdir) should have done that. Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> &

Re: [Xen-devel] [PATCH v4 1/4] x86/HVM: update the start info structure layout

ut is described in binary terms in order to avoid issues > with alignments when using C structs. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org> &g

Re: [Xen-devel] [RFC PATCH v1] Splitting off stubdom to a different tree

Hello, Wei Liu, on Thu 10 Mar 2016 16:46:39 +, wrote: > 1. There are some open questions -- see individual commits. Not sure I have seen them all, but here are some bits of answers: - Not sure what the version number of stubdom.git should be. Indeed. I don't really have an opinion on this,

Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

Hello, > > > > +if (prod - out_cons >= XENFB_OUT_RING_LEN) { > > > > +return; > > > > +} This test seems overzealous to me: AIUI, the producer can produce XENFB_OUT_RING_LEN events, and thus prod - out_cons is exactly XENFB_OUT_RING_LEN, i.e. there is no room left at all. The

Re: [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

Sarah Newman, on Fri 25 Mar 2016 12:19:23 -0700, wrote: > I have no objections to backing out additional changes made in 7c8f3483, ? My patch doesn't really back out more than what you proposed actually. > The patch tests OK with GNT_DEBUG enabled. Good :) Samuel

Re: [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

ssed multiple times with the break in place. Remove the break and re-add "some !=0" in the loop for HAVE_LIBC, rename it into dobreak to mitigate confusion. Signed-off-by: Sarah Newman <s...@prgmr.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> diff --git a/ne

[Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

ids ifdefs for the non-libc case. It also renames it to dobreak to make its usage clearer. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Tested-by: Sarah Newman <s...@prgmr.com> --- netfront.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) dif

[Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

ids ifdefs for the non-libc case. It also renames it to dobreak to make its usage clearer. Suggested-by: Sarah Newman <s...@prgmr.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Tested-by: Sarah Newman <s...@prgmr.com> --- netfront.c | 20 ++--

Re: [Xen-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483

Samuel Thibault, on Fri 01 Apr 2016 20:17:01 +0200, wrote: > 7c8f3483 introduced a break within a loop in netfront.c such that > cons and nr_consumed were no longer always being incremented. The > offset at cons will be processed multiple times with the break in > place. > > T

Re: [Xen-devel] [PATCH for-4.6] Config.mk: update mini-os commit

Wei Liu, on Mon 02 May 2016 10:48:11 +0100, wrote: > On Mon, Apr 25, 2016 at 12:21:51PM +0100, Wei Liu wrote: > > On Mon, Apr 25, 2016 at 05:15:57AM -0600, Jan Beulich wrote: > > > >>> On 25.04.16 at 13:12, wrote: > > > > Backport several fixes to mini-os in order to fix

[Xen-devel] [PATCH] xenfb: Fix overzealous ring test

a normal condition and should not be excluded. From: Wei Liu <wei.l...@citrix.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Tested-by: Hao Xudong <xudong@intel.com> --- hw/display/xenfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/d

Re: [Xen-devel] [PATCH] xenfb: Fix overzealous ring test

Wei Liu, on Mon 18 Apr 2016 15:40:15 +0100, wrote: > This patch is already queued by Stefano. Ah, sorry, I missed it. Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] mini-os: replace lib/printf.c with a version not under GPL

> Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > V2: remove include/lib-gpl.h as requested by Samuel Thibault > --- > blkfront.c|4 - > include/lib-gpl.h | 59 -- >

Re: [Xen-devel] [PATCH v3 16/19] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

Juergen Gross, on Thu 11 Aug 2016 12:19:20 +0200, wrote: > On 11/08/16 11:40, Samuel Thibault wrote: > > Juergen Gross, on Thu 11 Aug 2016 11:18:19 +0200, wrote: > >> +extern unsigned long *mm_bitmap; > >> +extern unsigned long mm_bitmap_size; > > > &

Re: [Xen-devel] [PATCH v4 16/19] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

use.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > V4: - mm_bitmap* -> mm_alloc_bitmap* as requested by Samuel Thibault > > V3: - add assertion as requested by Samuel Thibault > - rename functions to have mm_ prefix as requested by Sa

Re: [Xen-devel] [PATCH v3 19/19] mini-os: repair build system

the used ones > into Config.mk and delete the rest. > > The CONFIG_* defines should be set for assembler sources, too. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Config.mk | 93 > +

Re: [Xen-devel] [PATCH v2 06/18] mini-os: let memory allocation fail if no free page available

Juergen Gross, on Fri 05 Aug 2016 19:35:50 +0200, wrote: > Instead of panicing when no page can be allocated try to fail the > memory allocation by returning NULL instead. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH v2 10/18] mini-os: remove unused mem_test() function

Juergen Gross, on Fri 05 Aug 2016 19:35:54 +0200, wrote: > mem_test() isn't used anywhere and its value is rather questionable > with mini-os being in a mature state. Remove the function. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault &l

Re: [Xen-devel] [PATCH v2 02/18] mini-os: remove unused alloc_contig_pages() function

Juergen Gross, on Fri 05 Aug 2016 19:35:46 +0200, wrote: > alloc_contig_pages() is never used anywhere in mini-os. Remove it. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@e

Re: [Xen-devel] [PATCH v2 03/18] mini-os: remove MM_DEBUG code

t with a 0 byte). > > Remove this code. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > mm.c | 60 ---

Re: [Xen-devel] [PATCH v2 04/18] mini-os: add description of x86 memory usage

Juergen Gross, on Fri 05 Aug 2016 19:35:48 +0200, wrote: > Add a brief description how the physical and virtual address usage > looks like on x86 to include/x86/arch_mm.h > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH v2 08/18] mini-os: get maximum memory size from hypervisor

Juergen Gross, on Fri 05 Aug 2016 19:35:52 +0200, wrote: > Add support for obtaining the maximum memory size from the hypervisor. > This will make it possible to support ballooning. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.

Re: [Xen-devel] [PATCH v2 11/18] mini-os: add checks for out of memory

ions to succeed. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/mm.c | 8 > arch/x86/mm.c | 26 +++--- > include/mm.h | 2 +- > 3 files changed, 28 insertions(+)

Re: [Xen-devel] [PATCH v2 13/18] mini-os: add function to map one frame

Juergen Gross, on Fri 05 Aug 2016 19:35:57 +0200, wrote: > Add a function to map one physical frame to a specified virtual > address as read/write. This will be used later multiple times. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault &l

Re: [Xen-devel] [PATCH v2 14/18] mini-os: move p2m related macros to header file

, as all levels share the > same entry format (a plain mfn). So reduce the number of macros > accordingly. > > Add some macros to get the indices into p2m pages from a pfn and make > use of them in current p2m code. > > Signed-off-by: Juergen Gross <jgr...@suse.com>

Re: [Xen-devel] [PATCH v2 05/18] mini-os: add nr_free_pages counter

Juergen Gross, on Fri 05 Aug 2016 19:35:49 +0200, wrote: > Add a variable holding the number of available memory pages. This will > aid auto-ballooning later. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Sa

Re: [Xen-devel] [PATCH v2 07/18] mini-os: add ballooning config item

Juergen Gross, on Fri 05 Aug 2016 19:35:51 +0200, wrote: > Add CONFIG_BALLOON defaulting to 'n' as a config item to Mini-OS. > > Add balloon.c, balloon.h and arch/*/balloon.c for future use. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Not much to be against here

Re: [Xen-devel] [PATCH v2 16/18] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

It looks a bit odd to be remapping something that was just allocated, but I guess it makes portability easier. Juergen Gross, on Fri 05 Aug 2016 19:36:00 +0200, wrote: > diff --git a/balloon.c b/balloon.c > index 4c18c5c..75b87c8 100644 > --- a/balloon.c > +++ b/balloon.c > @@ -44,3 +44,20 @@

Re: [Xen-devel] [PATCH v2 15/18] mini-os: remap p2m list in case of ballooning

e at the end. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/balloon.c| 2 ++ > arch/x86/balloon.c| 24 > arch/x86/mm.c | 3 +++ >

Re: [Xen-devel] [PATCH v2 01/18] mini-os: correct first free pfn

Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/mm.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c > index 51aa966..ae1036e 100644 > --- a/arch/x86/

Re: [Xen-devel] [PATCH v2 09/18] mini-os: modify virtual memory layout for support of ballooning

in order to keep the heap at about 1GB. > > The kernel virtual mappings are a new area needed for being able to > grow the p2m list without having to relocate it in physical memory. > > Modify the placement of the demand mappings and heap and adjust the > memory layout description.

Re: [Xen-devel] [PATCH v2 12/18] mini-os: don't allocate new pages for level 1 p2m tree

that purpose. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/mm.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c >

Re: [Xen-devel] [PATCH v2 15/18] mini-os: remap p2m list in case of ballooning

Juergen Gross, on Fri 05 Aug 2016 19:35:59 +0200, wrote: > +void arch_remap_p2m(unsigned long max_pfn) > +{ ... > + > +virt_kernel_area_end += PAGE_SIZE * p2m_pages(nr_max_pages); I'd however rather see an assertion against hitting VIRT_DEMAND_AREA here, even if the figures happen to make it

Re: [Xen-devel] [PATCH v2 00/18] mini-os: support of auto-ballooning

Hello, Juergen Gross, on Fri 05 Aug 2016 19:35:44 +0200, wrote: > Support ballooning Mini-OS automatically up in case of memory shortage. Thanks! Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

  1   2   >