Re: [Xen-devel] [PATCH 00/11] Convert a few docs/misc pages into man pages

2017-01-09 Thread Cedric Bosdonnat
On Thu, 2017-01-05 at 15:19 +, Wei Liu wrote: > On Thu, Jan 05, 2017 at 04:12:46PM +0100, Cedric Bosdonnat wrote: > > On Thu, 2017-01-05 at 15:01 +, Wei Liu wrote: > > > On Wed, Jan 04, 2017 at 04:49:25PM +0100, Cedric Bosdonnat wrote: > > > > On Wed, 2017

Re: [Xen-devel] [PATCH 00/11] Convert a few docs/misc pages into man pages

2017-01-05 Thread Cedric Bosdonnat
On Thu, 2017-01-05 at 15:01 +, Wei Liu wrote: > On Wed, Jan 04, 2017 at 04:49:25PM +0100, Cedric Bosdonnat wrote: > > On Wed, 2017-01-04 at 15:07 +, Wei Liu wrote: > > > On Fri, Dec 09, 2016 at 05:17:03PM +0100, Cédric Bosdonnat wrote: > > > > As pointed out

Re: [Xen-devel] [PATCH 00/11] Convert a few docs/misc pages into man pages

2017-01-04 Thread Cedric Bosdonnat
On Wed, 2017-01-04 at 15:07 +, Wei Liu wrote: > On Fri, Dec 09, 2016 at 05:17:03PM +0100, Cédric Bosdonnat wrote: > > As pointed out in Ian and Andrew's emails on my recent docs improvement > > attempt, getting the documents from docs/misc referenced in man pages > > as man pages would would ma

Re: [Xen-devel] [PATCH 07/11] docs: move vtpm from misc to man

2016-12-19 Thread Cedric Bosdonnat
On Wed, 2016-12-14 at 16:08 -0500, Daniel De Graaf wrote: > On 12/09/2016 11:17 AM, Cédric Bosdonnat wrote: > > vtpm.txt is referenced in xl.cfg man page. Convert it to pod, > > move it to the man folder and update the reference. > > > > Signed-off-by: Cédric Bosdonnat > > Since this manpage onl

Re: [Xen-devel] [xen-unstable-smoke test] 103306: regressions - FAIL

2016-12-14 Thread Cedric Bosdonnat
Hello Wei, On Wed, 2016-12-14 at 07:52 +, Wei Liu wrote: > On Wed, Dec 14, 2016 at 06:24:15AM +, osstest service owner wrote: > > flight 103306 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/103306/ > > > > Regressions :-( > > > > Tests which did not

Re: [Xen-devel] [PATCH v3] libxl: QED disks support

2016-12-13 Thread Cedric Bosdonnat
Hi Ian, On Mon, 2016-12-12 at 17:36 +, Ian Jackson wrote: > Cédric Bosdonnat writes ("[PATCH v3] libxl: QED disks support"): > > Qdisk supports qcow and qcow2, extend it to also support qed disk > > format. > > The patch is good. > > I have a qualm, though.  I think this would increase our s

Re: [Xen-devel] [PATCH] Fix errornous negation for isstubdom, which breaks HVM pci-passthrough.

2016-12-12 Thread Cedric Bosdonnat
Nice catch! ACK from me, thought I don't know if it really counts ;) -- Cedric On Sat, 2016-12-10 at 18:59 +0100, Sander Eikelenboom wrote: > Commit 20b75251d9721d9c050a973c02baac396c794ade introduced an errornous > negation which gave the isstubdom bool the opposite semantics, > causing the subs

Re: [Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-09 Thread Cedric Bosdonnat
On Fri, 2016-12-09 at 11:25 +, Ian Jackson wrote: > Hi, Cedric et al.  I like the idea of tidying this up.  Thanks for the > patch, which (with some small changes) will be a good idea. > > Cedric Bosdonnat writes ("Re: [Xen-devel] [PATCH] docs: turn links to docs/* >

Re: [Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-09 Thread Cedric Bosdonnat
On Thu, 2016-12-08 at 17:59 +, Andrew Cooper wrote: > On 08/12/16 16:56, Cédric Bosdonnat wrote: > > From a user point of view, when reading things like "See > > docs/misc/txt" in a man page, it is not obvious to find the > > location of that file. Use $docdir to turn these into absolute >

Re: [Xen-devel] [PATCH] docs: turn links to docs/* into absolute path

2016-12-09 Thread Cedric Bosdonnat
On Thu, 2016-12-08 at 17:59 +, Wei Liu wrote: > On Thu, Dec 08, 2016 at 05:56:12PM +0100, Cédric Bosdonnat wrote: > > From a user point of view, when reading things like "See > > docs/misc/txt" in a man page, it is not obvious to find the > > location of that file. Use $docdir to turn these

Re: [Xen-devel] [PATCH] libxl: QED disks support

2016-12-07 Thread Cedric Bosdonnat
On Wed, 2016-12-07 at 11:25 +, Wei Liu wrote: > On Mon, Nov 14, 2016 at 03:57:00PM +0100, Cédric Bosdonnat wrote: > > Qdisk supports qcow and qcow2, extend it to also support qed disk > > format. > > > > Signed-off-by: Cédric Bosdonnat > > --- > >  tools/libxl/libxl_device.c  |1 + > >  to

Re: [Xen-devel] [PATCH] libxl: QED disks support

2016-12-06 Thread Cedric Bosdonnat
Has this one been buried in the mail stack? -- Cedric On Mon, 2016-11-14 at 15:57 +0100, Cédric Bosdonnat wrote: > Qdisk supports qcow and qcow2, extend it to also support qed disk > format. > > Signed-off-by: Cédric Bosdonnat > --- >  tools/libxl/libxl_device.c  |1 + >  tools/libxl/libxl_d

Re: [Xen-devel] [PATCH 04/35] libxl.c: switch to LOG*D use

2016-11-17 Thread Cedric Bosdonnat
On Thu, 2016-11-17 at 14:50 +, Wei Liu wrote: > On Tue, Nov 15, 2016 at 11:18:42AM +0100, Cédric Bosdonnat wrote: > > Use LOG*D functions to output the domain ID in logs as much as > > possible. This will help consumer code sorting the logs by > > domain. > > > > This commit includes all LOG*

Re: [Xen-devel] [PATCH 01/35] libxl: add LIBXL_LOGD_* and LOG*D function families.

2016-11-17 Thread Cedric Bosdonnat
On Thu, 2016-11-17 at 14:41 +, Wei Liu wrote: > On Tue, Nov 15, 2016 at 11:18:39AM +0100, Cédric Bosdonnat wrote: > > From: Cédric Bosdonnat > > > > These functions should be used to log messages when the domain > > id is known. libxl__log will now prepend the log message by > > "Domain %PRIu

Re: [Xen-devel] Xen like VirtualBox

2016-11-15 Thread Cedric Bosdonnat
Hi Jason, On Tue, 2016-11-15 at 14:05 +, Jason Long wrote: > Thank you but I guess it is serious for Xen. > Are you Sure Red Hat company help Xen? I guess you wrong. Red Hat employee > not mean Red Hat company and they can help > other Open Source projects as hobbyist. I guess some Citrix guy

Re: [Xen-devel] [PATCH v2] libxl: fix gentypes call in Makefile

2016-11-14 Thread Cedric Bosdonnat
On Fri, 2016-11-11 at 02:22 +, Wei Liu wrote: > On Thu, Nov 10, 2016 at 05:46:00PM +0100, Cédric Bosdonnat wrote: > > From the make documentation: > > > > "$* [...] If the target is `dir/a.foo.b' and the target pattern is > > `a.%.b' then the stem is `dir/foo'. In a static pattern rule, the >

Re: [Xen-devel] [PATCH] libxl: fix gentypes call in Makefile

2016-11-10 Thread Cedric Bosdonnat
On Thu, 2016-11-10 at 15:49 +0100, Juergen Gross wrote: > On 10/11/16 14:11, Cédric Bosdonnat wrote: > > From the make documentation: > > > > "$* [...] If the target is `dir/a.foo.b' and the target pattern is > > `a.%.b' then the stem is `dir/foo'. In a static pattern rule, the > > stem is part of

Re: [Xen-devel] [PATCH] Fix misleading indentation warnings

2016-11-10 Thread Cedric Bosdonnat
Hi Juergen, Just resent the patch with the missing Signed-off-By and --cc-cmd './scripts/get_maintainers.pl' -- Cedric On Thu, 2016-11-10 at 09:42 +0100, Juergen Gross wrote: > On 10/11/16 09:37, Cédric Bosdonnat wrote: > > Gcc6 build reports misleading indentation as warnings. Fix a few > > wa

Re: [Xen-devel] per-domain logging

2016-11-09 Thread Cedric Bosdonnat
that? -- Cedric On Thu, 2016-10-13 at 10:41 +0100, Wei Liu wrote: > On Thu, Oct 13, 2016 at 11:28:21AM +0200, Cedric Bosdonnat wrote: > > Hi Wei, Ian, > > > > In quite a number of places, the domid we have in the function calling LOG* > > may be the one of a stubdom.

Re: [Xen-devel] per-domain logging

2016-10-13 Thread Cedric Bosdonnat
, suggesting that domid may not be the real domain id. An I wonder if there are other places where domid may be the one of a stubdom and I don't know it. -- Cedric On Mon, 2016-10-10 at 11:06 +0100, Wei Liu wrote: > On Mon, Oct 10, 2016 at 09:03:49AM +0200, Cedric Bosdonnat wrote: > > On F

Re: [Xen-devel] per-domain logging

2016-10-10 Thread Cedric Bosdonnat
On Fri, 2016-10-07 at 16:37 +0100, Ian Jackson wrote: > > But let's step back a bit: have we agreed on the approach forward? This > > thread doesn't seem to have a clear conclusion yet.  Obviously I don't > > want you to waste your writing code that's going to be threw away. > >  > > If you're happ

Re: [Xen-devel] per-domain logging

2016-10-10 Thread Cedric Bosdonnat
On Fri, 2016-10-07 at 15:09 +0100, Wei Liu wrote: > Instead of trying to change all the format strings I think it would be > better to have a new set of LOG macros that takes domid. > > Something like: >   LOGEVD(ERROR, errno, domid, ""); Sounds good to me, even if LOGEVD will just concatenat

Re: [Xen-devel] per-domain logging

2016-10-04 Thread Cedric Bosdonnat
Hi Ian and Wei, On Mon, 2016-09-19 at 16:23 +0100, Ian Jackson wrote: > Cedric Bosdonnat writes ("Re: [Xen-devel] per-domain logging"): > > On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote: > > > IIRC there is already logfile abstraction inside libvirt -- can you

Re: [Xen-devel] per-domain logging

2016-09-15 Thread Cedric Bosdonnat
On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote: > On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote: > > > > CC Ian who might have some ideas on this. > > > > On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote: > > > > > > H

[Xen-devel] per-domain logging

2016-09-14 Thread Cedric Bosdonnat
Hi all, I wanted to get libvirt's libxl driver have per-domain logs like all other drivers. After looking at the libxl and XenToolLogger it seems I'll need to add the feature in either libxl XenToolLogger. Would anyone already have an idea how best to add API to allow this? Thanks for your hel