Re: [Xen-devel] [PATCH] MAINTAINERS: Make Christian Lindig maintainer for ocaml tools

2017-10-19 Thread Christian Lindig
ot been a great deal of new development. > > Christian's contributions have been sensible and I think it would be a > good idea now to formally make him a maintainer. > > CC: Christian Lindig > CC: David Scott > Signed-off-by: Ian Jackson > --- > MAINTAINERS | 1 + >

Re: [Xen-devel] [PATCH RFC] tools: Drop xc_cpuid_check() and bindings

2017-07-17 Thread Christian Lindig
> On 17. Jul 2017, at 13:38, Andrew Cooper wrote: > > It turns out that Xapi has a library function using it, but that > function is dead so can be removed. I am fine with the removal of the OCaml bindings and the patch for the OCaml code. If the code is fundamentally broken it should be remov

[Xen-devel] OCaml xenstore: max value size is configure to be 2048 bytes - consistent with C xenstore?

2017-04-27 Thread Christian Lindig
We recently had a case where XenServer installation showed errors because the data stored in OCaml xenstore exceeded 2048 bytes: [root@dt87 tmp]# xenstore-write /local/domain/1/foo $(cat /dev/zero | tr '\0' X | dd bs=1 count=2048) 2048+0 records in 2048+0 records out 2048 bytes (2.0 kB) copied,

Re: [Xen-devel] [PATCH for-4.9 v2 0/3] oxenstored: make it work on FreeBSD

2017-04-19 Thread Christian Lindig
> On 18. Apr 2017, at 16:31, Wei Liu wrote: > > Wei Liu (3): > paths.m4: provide XENSTORED_{KVA,PORT} > oxenstored: provide options to define xenstored devices > hotplug/FreeBSD: configure xenstored > > m4/paths.m4 | 12 > tools/hotplug/FreeBSD/rc.d/x

Re: [Xen-devel] [PATCH for-4.9 2/2] oxenstored: make it work on FreeBSD

2017-04-18 Thread Christian Lindig
> On 18. Apr 2017, at 11:16, Ian Jackson wrote: > > Wei Liu writes ("[PATCH for-4.9 2/2] oxenstored: make it work on FreeBSD"): >> Call the uname syscall to determine sysname and return device names >> accordingly. > ... >> -let xenstored_proc_kva = "/proc/xen/xsd_kva" >> -let xenstored_proc_por

Re: [Xen-devel] [PATCH for-4.9 0/2] oxenstored: make it work on FreeBSD

2017-04-18 Thread Christian Lindig
> On 18. Apr 2017, at 10:59, Wei Liu wrote: > > Forgive my ignorance for the Ocaml ecosystem, but I can't seem to find a > way to conditionally compile ocaml source code easily. > > Presumably you mean "Determine the path at *configure* time"? Even if > we make those configurable, there should

Re: [Xen-devel] [PATCH for-4.9 0/2] oxenstored: make it work on FreeBSD

2017-04-18 Thread Christian Lindig
> On 18. Apr 2017, at 10:59, Wei Liu wrote: > > Forgive my ignorance for the Ocaml ecosystem, but I can't seem to find a > way to conditionally compile ocaml source code easily. > > Presumably you mean "Determine the path at *configure* time"? Even if > we make those configurable, there should

Re: [Xen-devel] [PATCH for-4.9 0/2] oxenstored: make it work on FreeBSD

2017-04-18 Thread Christian Lindig
> On 14. Apr 2017, at 11:20, Wei Liu wrote: > > Unfortunately there is an easy way to determine system name in the standard > library so I wrote a wrapper for uname syscall. I think there are two solutions to using the correct path: (1) Determine the path at compile time and use the mechanism

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 10. Apr 2017, at 09:33, Wei Liu wrote: > > On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote: >> >>> On 7. Apr 2017, at 14:27, Jonathan Davies >>> wrote: >>> >>> tools/ocaml/xenstored/domain.ml| 4 ++-- >>>

Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

2017-04-10 Thread Christian Lindig
> On 7. Apr 2017, at 14:27, Jonathan Davies wrote: > > tools/ocaml/xenstored/domain.ml| 4 ++-- > tools/ocaml/xenstored/store.ml | 8 +++- > tools/ocaml/xenstored/xenstored.ml | 10 ++ The OCaml code is looking good and I’d be happy to take it as it is. I noticed that the (

Re: [Xen-devel] ARM64 hardware in osstest (WAS: [PATCH 0/2] ocaml: Start on fixing brokenness when no ocamlopt)

2017-03-30 Thread Christian Lindig
> On 30. Mar 2017, at 15:40, Ian Jackson wrote: > > Christian, can you advise what the correct test should be to check > whether the native code compiler is available ? I can then try to > make a patch to our autoconfery, and maybe you would be able to review > it. Or if you prefer to make tha