Re: [Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2016-01-10 Thread Don Slutz
e was when the name could be easily changed. I know of no simple way to do so now. Any change like this needs to start in QEMU and be accepted up-stream and in Xen's version of up-stream QEMU. After that Xen is changed. The thread http://lists.xenproject.org/archives/html/xen-devel/2015-06/msg00476.html looks at this being more general and just VMware. > Also throughout the series I didn't find any code addition to > guarantee (perhaps at build time) that BDOOR_PORT doesn't > collide with any other use ports (statically assigned ones as well > as the range used for dynamic assignment to PCI devices). Since this is optional code, I am having an issue understanding this statement. Xen will not do anything with BDOOR_PORT when vmware_port=0. I do not know how at build time to check for run time optional items. What ports are in use include what QEMU has. My understanding was that configuration issues like overlapping or multiple uses of I/O port is the users issue not Xen. I do not see any code in xen that checks for this for other ports. So it is not clear what the set of port in xen needs to be checked. The default range used for dynamic assignment to PCI devices is 0xc000 - 0x, which does not mean that the guest is prevented from adjusting pci bridges so that BDOOR_PORT is an overlap. But that is true of a lot of the rest of the ports in Xen. register_portio_handler() could be changed to check at run time for Xen. At this time I have no plans to add code related to this. -Don Slutz > > Jan > ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v13 5/8] xen: Add vmware_port support

2015-12-20 Thread Don Slutz
is appeared to be ok because the added emulation_flags was a unit32_t. I have no reason not to use another XEN_X86_EMU_ flag. It was not clear when I was re-baseing that it would be ok to do so. Will drop arch_flags and use XEN_X86_EMU_VMWARE_PORT which will not be added to "all". -Don Slutz

Re: [Xen-devel] [PATCH v13 2/8] xen: Add support for VMware cpuid leaves

2015-12-20 Thread Don Slutz
t; me again why this needs to be a 64-bit quantity? Looking at it, it only needs to be a 32-bit quantity. My memory says that it was 64-bits because that was the size of a HVM_PARAM_... which was were it was passed before this code existed. I see no

Re: [Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-12-14 Thread Don Slutz
no no >> 2.4.xyesno no >> 2.5.xyesno yes >> >> Xen vmport is_default atomic >> QEMU support >> >> 4.5.xno yesn/a >> 4.6.x yesno

Re: [Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-12-04 Thread Don Slutz
On 12/04/15 03:59, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:don.sl...@gmail.com] >> Sent: 04 December 2015 00:23 >> To: Paul Durrant; xen-devel@lists.xen.org >> Cc: Jun Nakajima; Wei Liu; Kevin Tian; Keir (Xen.org); Ian Campbell; G

Re: [Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-12-03 Thread Don Slutz
On 12/01/15 06:28, Paul Durrant wrote: >> -Original Message- >> From: xen-devel-boun...@lists.xen.org [mailto:xen-devel- >> boun...@lists.xen.org] On Behalf Of Don Slutz >> Sent: 28 November 2015 21:45 >> To: xen-devel@lists.xen.org >> Cc: Jun Nakajima

[Xen-devel] [PATCH v13 6/8] tools: Add vmware_port support

2015-11-28 Thread Don Slutz
From: Don Slutz <don.sl...@gmail.com> This new libxl_domain_create_info field is used to set XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK in the xc_domain_configuration_t for x86. In xen it is is_vmware_port_enabled. If is_vmware_port_enabled then enable a limited support of VMware's hype

[Xen-devel] [PATCH v13 8/8] Add xentrace to vmware_port

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> Also added missing TRAP_DEBUG & VLAPIC. Signed-off-by: Don Slutz <dsl...@verizon.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> CC: Don Slutz <don.sl...@gmail.com> --- v13: Please do this by extending the existing in

[Xen-devel] [PATCH v13 2/8] xen: Add support for VMware cpuid leaves

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> This is done by adding xen_arch_domainconfig vmware_hw. It is set to the VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values. However the code only checks for == 0 or != 0 or >= 7. If non-zero then Return VMware's cpu

[Xen-devel] [PATCH v13 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> This adds synchronization of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and vmm

[Xen-devel] [PATCH v13 4/8] vmware: Add VMware provided include file.

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> This file: backdoor_def.h comes from: http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html open-vm-tools-kmod-7.4.8-396269.423167.src.rpm open-vm-tools-kmod-7.4.8.tar.gz vmhgfs/backdoor_def.h and is unchanged. Added the badly

[Xen-devel] [PATCH v13 0/8] Xen VMware tools support

2015-11-28 Thread Don Slutz
Bus? I would say no. XenBus (and XenStore) is about domain to domain communication. This is about VMware's hyper-call and providing access to VMware's guest info very low speed access. Olaf Hering: Dropped changing of bios-strings. Still needs some documentation about this may

[Xen-devel] [PATCH v13 5/8] xen: Add vmware_port support

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> This includes adding is_vmware_port_enabled This is a new xen_arch_domainconfig flag, XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK. This enables limited support of VMware's hyper-call. This is both a more complete support then in currently provided by QEMU and/

[Xen-devel] [PATCH v13 3/8] tools: Add vmware_hwver support

2015-11-28 Thread Don Slutz
From: Don Slutz <dsl...@verizon.com> This is used to set xen_arch_domainconfig vmware_hw. It is set to the emulated VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values. However the code only checks for == 0, != 0, or < 7. Signed-off-by: Don Slutz <dsl...@ver

Re: [Xen-devel] [PATCH v12 2/8] xen: Add support for VMware cpuid leaves

2015-07-27 Thread Don Slutz
. Which do you want? It is up to you. Usually one posts with the latest copyright date. Since I will need to re-post series do to merge issues, I will change to 2012-2015. -Don Slutz P.S. Sorry about the slow response, was on vacation. ___ Xen

Re: [Xen-devel] [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-07-27 Thread Don Slutz
Port PFN' ? Will switch to this. -Don Slutz -Don Slutz +#define HVM_PARAM_VMPORT_REGS_PFN 35 #define HVM_PARAM_BUFIOREQ_PFN 6 #define HVM_PARAM_BUFIOREQ_EVTCHN 26 @@ -187,6 +189,6 @@ /* Location of the VM Generation ID in guest physical address space. */ #define

Re: [Xen-devel] [PATCH v12 3/8] tools: Add vmware_hwver support

2015-07-27 Thread Don Slutz
On 07/07/15 11:59, Ian Campbell wrote: On Wed, 2015-07-01 at 16:14 -0400, Konrad Rzeszutek Wilk wrote: On Sat, Jun 27, 2015 at 07:27:40PM -0400, Don Slutz wrote: From: Don Slutz dsl...@verizon.com +In a .ovf it is part of the value of vssd:VirtualSystemType. +For vssd:VirtualSystemType

Re: [Xen-devel] [PATCH v12 0/8] Xen VMware tools support

2015-07-27 Thread Don Slutz
as possible, preferably within next week. I see that this did not happen. Do you want me to re-post just 1 to 6 that I have now rebased? (the improvement to the doc, Ian said could be a follow on patch) -Don Slutz Wei. Jan ___ Xen-devel

Re: [Xen-devel] [PATCH v12 2/8] xen: Add support for VMware cpuid leaves

2015-07-03 Thread Don Slutz
index 000..8390173 --- /dev/null +++ b/xen/include/asm-x86/hvm/vmware.h @@ -0,0 +1,33 @@ +/* + * asm-x86/hvm/vmware.h + * + * Copyright (C) 2012 Verizon Corporation s/2012/2015 See above. -Don Slutz + * + * This file is free software; you can redistribute it and/or modify

Re: [Xen-devel] [PATCH v5 01/16] x86/hvm: make sure emulation is retried if domain is shutting down

2015-06-30 Thread Don Slutz
to be shutting down. Reported-by: Don Slutz don.sl...@gmail.com Signed-off-by: Paul Durrant paul.durr...@citrix.com Keir Fraser k...@xen.org Jan Beulich jbeul...@suse.com Andrew Cooper andrew.coop...@citrix.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- xen/arch/x86/hvm/emulate.c

Re: [Xen-devel] Migration bug added by commit 2df1aa01bef7366798248ac6d03cfb42048b003d

2015-06-29 Thread Don Slutz
On 06/29/15 10:03, Paul Durrant wrote: -Original Message- From: Paul Durrant Sent: 29 June 2015 13:54 To: Paul Durrant; Don Slutz; xen-devel@lists.xen.org; Jan Beulich Subject: RE: [Xen-devel] Migration bug added by commit 2df1aa01bef7366798248ac6d03cfb42048b003d -Original Message

Re: [Xen-devel] [PATCH v12 8/8] Add xentrace to vmware_port

2015-06-29 Thread Don Slutz
On 06/29/15 10:54, Andrew Cooper wrote: On 28/06/15 00:27, Don Slutz wrote: From: Don Slutz dsl...@verizon.com Also added missing TRAP_DEBUG VLAPIC. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Don Slutz don.sl...@gmail.com --- v12: Switch

[Xen-devel] [PATCH v12 3/8] tools: Add vmware_hwver support

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com This is used to set xen_arch_domainconfig vmware_hw. It is set to the emulated VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values. However the code only checks for == 0, != 0, or 7. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don

[Xen-devel] [PATCH v12 1/8] tools: Add vga=vmware

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com This allows use of QEMU's VMware emulated video card NOTE: vga=vmware is not supported by device_model_version=qemu-xen-traditional Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- v12: Dropped

[Xen-devel] [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com This adds synchronization of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu registers used by the code in vmport.c and vmmouse.c

[Xen-devel] [PATCH v12 8/8] Add xentrace to vmware_port

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com Also added missing TRAP_DEBUG VLAPIC. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Ian Campbell ian.campb...@citrix.com CC: Don Slutz don.sl...@gmail.com --- v12: Switch VMPORT_IGNORED to port, regs-_eax. v11: No change v10: Added Acked

[Xen-devel] [PATCH v12 4/8] vmware: Add VMware provided include file.

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com This file: backdoor_def.h comes from: http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html open-vm-tools-kmod-7.4.8-396269.423167.src.rpm open-vm-tools-kmod-7.4.8.tar.gz vmhgfs/backdoor_def.h and is unchanged. Added the badly named

[Xen-devel] [PATCH v12 2/8] xen: Add support for VMware cpuid leaves

2015-06-27 Thread Don Slutz
From: Don Slutz dsl...@verizon.com This is done by adding xen_arch_domainconfig vmware_hw. It is set to the VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values. However the code only checks for == 0 or != 0 or = 7. If non-zero then Return VMware's cpuid leaves. If = 7

[Xen-devel] [PATCH v12 6/8] tools: Add vmware_port support

2015-06-27 Thread Don Slutz
(vmware_hwver = 7). Note: vmware_port and nestedhvm cannot be specified at the same time. Signed-off-by: Don Slutz dsl...@verizon.com --- v12: s/come/comes/ In v11 this seems to have morphed into only LIBXL_HAVE_LIBXL_VGA_INTERFACE_TYPE_VMWARE being provided, which is clearly

[Xen-devel] [PATCH v12 0/8] Xen VMware tools support

2015-06-27 Thread Don Slutz
build number Don Slutz (8): tools: Add vga=vmware xen: Add support for VMware cpuid leaves tools: Add vmware_hwver support vmware: Add VMware provided include file. xen: Add vmware_port support tools: Add vmware_port support Add IOREQ_TYPE_VMWARE_PORT Add xentrace to vmware_port

[Xen-devel] Migration bug added by commit 2df1aa01bef7366798248ac6d03cfb42048b003d

2015-06-27 Thread Don Slutz
) rc = X86EMUL_RETRY; } -Don Slutz ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-26 Thread Don Slutz
Signed-off-by: Don Slutz dsl...@verizon.com As there don't seem to be enough convincing arguments for this to be worthwhile, I'm going to drop this and subsequent patches from my list of things to look at. Would you mind following George's (at least I think it was him) advice to post a shortened

[Xen-devel] [PATCH 2/2] Add xen-hyp-rw

2015-06-18 Thread Don Slutz
opt_hvm_debug_level @ 0x82d080285610 is 0x0(0) opt_hvm_debug_level @ 0x82d080285610 set to 0x(4294967295) Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- .gitignore | 1 + tools/debugger/gdbsx/Makefile | 7 +- tools

[Xen-devel] [PATCH 1/2] gdbsx_guestmemio: Allow it to check domain.

2015-06-18 Thread Don Slutz
gdbsx_guest_mem_io() does not get d passed, it expects to handle the domain lookup itself. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- xen/common/domctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/domctl.c b/xen/common/domctl.c index

Re: [Xen-devel] [PATCH 2/2] Add xen-hyp-rw

2015-06-18 Thread Don Slutz
On 06/18/15 13:05, Andrew Cooper wrote: On 18/06/15 16:55, Don Slutz wrote: This allows reading and writing of variables in the hypervisor. for example (read case -- default 4 bytes): xen-hyp-rw /boot/System.map-xen* opt_hvm_debug_level opt_hvm_debug_level @ 0x82d080285610 is 0x0(0

Re: [Xen-devel] [PATCH 1/2] gdbsx_guestmemio: Allow it to check domain.

2015-06-18 Thread Don Slutz
On 06/18/15 12:59, Andrew Cooper wrote: On 18/06/15 16:55, Don Slutz wrote: gdbsx_guest_mem_io() does not get d passed, it expects to handle the domain lookup itself. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com As for the change itself, Reviewed

Re: [Xen-devel] [PATCH 3/4] Allow vif= to specify PCI address for each nic

2015-06-16 Thread Don Slutz
On 06/16/15 06:32, Wei Liu wrote: On Mon, Jun 15, 2015 at 01:45:26PM -0400, Don Slutz wrote: On 06/15/15 11:54, Wei Liu wrote: On Mon, Jun 15, 2015 at 10:15:51AM -0400, Don Slutz wrote: This allows more then 32 nics. How does this patch help? What prevents you from having more than 32 nics

Re: [Xen-devel] [PATCH 3/4] Allow vif= to specify PCI address for each nic

2015-06-16 Thread Don Slutz
On 06/16/15 12:14, Wei Liu wrote: On Tue, Jun 16, 2015 at 11:23:46AM -0400, Don Slutz wrote: [...] which enables usage of xen-netback. In any case, exposing HVM-only options to top-level vif configuration space doesn't look right. There are already HVM-only options in vifs: ### type

[Xen-devel] [PATCH 1/4] hvmloader: Fixup pci_write* macros

2015-06-15 Thread Don Slutz
Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz dsl...@verizon.com --- tools/firmware/hvmloader/util.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/firmware/hvmloader/util.h b/tools/firmware/hvmloader/util.h index a70e4aa..8431f2d 100644 --- a/tools

[Xen-devel] [PATCH 4/4] Allow disk= to specify their emulated bus address

2015-06-15 Thread Don Slutz
. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz dsl...@verizon.com --- docs/misc/xl-disk-configuration.txt | 25 ++ tools/libxl/libxl_dm.c | 171 tools/libxl/libxl_types.idl | 4 + tools/libxl/libxlu_disk_l.l | 4 + 4

[Xen-devel] [PATCH 3/4] Allow vif= to specify PCI address for each nic

2015-06-15 Thread Don Slutz
=pciBridge5.0,multifunction=on,addr=0x15.0, ] vif = [ model=vmxnet3,bridge=xenbr0,mac=00:0c:29:86:44:a0,bus=pciBridge5.0,addr=0x4.0x0, ] which enables usage of xen-netback. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz dsl...@verizon.com --- docs/misc/xl-network

Re: [Xen-devel] [PATCH 2/4] hvmloader: Add support for PCI to PCI bridge

2015-06-15 Thread Don Slutz
On 06/15/15 10:26, Andrew Cooper wrote: On 15/06/15 15:15, Don Slutz wrote: Most of this code is ported from SeaBIOS. SeaBIOS is LGPLv3, while Hvmloader is GPLv2 IANAL, but the FSF indicates that this is not a compatible combination. Sigh, Well I did code some of it from scratch

Re: [Xen-devel] [PATCH 1/4] hvmloader: Fixup pci_write* macros

2015-06-15 Thread Don Slutz
On 06/15/15 10:19, Andrew Cooper wrote: On 15/06/15 15:15, Don Slutz wrote: Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz dsl...@verizon.com Fix how? It looks like you are bracketing val. If val is an expression, the macro most likely does the wrong thing. For example

[Xen-devel] [PATCH 0/4] Add PCI to PCI bridge support to Xen

2015-06-15 Thread Don Slutz
bridges. I.E. make imported Windows disk images more usable under Xen. Don Slutz (4): hvmloader: Fixup pci_write* macros hvmloader: Add support for PCI to PCI bridge Allow vif= to specify PCI address for each nic Allow disk= to specify their emulated bus address docs/misc/xl-disk

[Xen-devel] [PATCH 2/4] hvmloader: Add support for PCI to PCI bridge

2015-06-15 Thread Don Slutz
Most of this code is ported from SeaBIOS. This allows many more PCI devices to be added. It can also allow Windows to find it boot disks. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz dsl...@verizon.com --- tools/firmware/hvmloader/pci.c | 805

Re: [Xen-devel] [PATCH 3/4] Allow vif= to specify PCI address for each nic

2015-06-15 Thread Don Slutz
On 06/15/15 11:54, Wei Liu wrote: On Mon, Jun 15, 2015 at 10:15:51AM -0400, Don Slutz wrote: This allows more then 32 nics. How does this patch help? What prevents you from having more than 32 nics? Without a way to put the emulated nics onto a PCI to PCI Bridge, you are limited to 1 PCI

Re: [Xen-devel] [PATCH 2/4] hvmloader: Add support for PCI to PCI bridge

2015-06-15 Thread Don Slutz
On 06/15/15 10:58, George Dunlap wrote: On Mon, Jun 15, 2015 at 3:26 PM, Andrew Cooper andrew.coop...@citrix.com wrote: On 15/06/15 15:15, Don Slutz wrote: Most of this code is ported from SeaBIOS. SeaBIOS is LGPLv3, while Hvmloader is GPLv2 IANAL, but the FSF indicates

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-12 Thread Don Slutz
to monitor the health of a guest. The reason to install them after is to get the VMware mouse driver on Windows. This mouse driver works much better on Window when there is higher network latency. -Don Slutz Jan ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH v11 8/9] Add IOREQ_TYPE_VMWARE_PORT

2015-06-11 Thread Don Slutz
On 06/08/15 06:05, George Dunlap wrote: On 06/04/2015 12:28 PM, Don Slutz wrote: On 06/03/15 13:09, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: This adds synchronization of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-11 Thread Don Slutz
desktops. 6) Access to VMware guest info variables (code to access QEMU's from Xen to do this is missing). This can be used to customize guest operating systems immediately after powering on virtual machines. It can also be used to monitor the health of a guest. -Don Slutz Ian

Re: [Xen-devel] [xen-unstable test] 57852: regressions - FAIL

2015-06-10 Thread Don Slutz
/microcode.bin 3) Make sure ucode=-1 is in GRUB_CMDLINE_XEN 4) /sbin/grub2-mkconfig -o /boot/grub2/grub.cfg And you see microcode loaded on the serial console. -Don Slutz Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http

Re: [Xen-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 10:03, Paul Durrant wrote: -Original Message- From: Don Slutz [mailto:dsl...@verizon.com] Sent: 09 June 2015 14:51 To: Paul Durrant; Slutz, Donald Christopher; qemu-de...@nongnu.org; xen- de...@lists.xen.org Cc: Michael S. Tsirkin; Stefano Stabellini; Don Slutz Subject

Re: [Xen-devel] [PATCH v2 0/4] Fix device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 10:27, Michael S. Tsirkin wrote: On Tue, Jun 09, 2015 at 02:14:29PM +, Paul Durrant wrote: -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: 09 June 2015 13:30 To: Paul Durrant Cc: Don Slutz; qemu-de...@nongnu.org; xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 11:11, Paul Durrant wrote: -Original Message- From: Don Slutz [mailto:dsl...@verizon.com] Sent: 09 June 2015 15:28 To: Paul Durrant; Slutz, Donald Christopher; qemu-de...@nongnu.org; xen- de...@lists.xen.org Cc: Michael S. Tsirkin; Stefano Stabellini; Don Slutz Subject

Re: [Xen-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 05:05, Paul Durrant wrote: -Original Message- From: Don Slutz [mailto:dsl...@verizon.com] Sent: 08 June 2015 22:19 To: qemu-de...@nongnu.org; xen-devel@lists.xen.org Cc: Michael S. Tsirkin; Paul Durrant; Stefano Stabellini; Don Slutz; Don Slutz Subject: [PATCH v2 4/4

Re: [Xen-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 05:08, Paul Durrant wrote: -Original Message- From: Don Slutz [mailto:dsl...@verizon.com] Sent: 08 June 2015 22:19 To: qemu-de...@nongnu.org; xen-devel@lists.xen.org Cc: Michael S. Tsirkin; Paul Durrant; Stefano Stabellini; Don Slutz; Don Slutz Subject: [PATCH v2 2/4

Re: [Xen-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 09:55, Paul Durrant wrote: -Original Message- From: Don Slutz [mailto:dsl...@verizon.com] Sent: 09 June 2015 14:53 To: Paul Durrant; Slutz, Donald Christopher; qemu-de...@nongnu.org; xen- de...@lists.xen.org Cc: Michael S. Tsirkin; Stefano Stabellini; Don Slutz Subject

[Xen-devel] [BUGFIX][PATCH v2 1/4] exec: Do not use MemoryRegion after free

2015-06-08 Thread Don Slutz
-subpage) { (gdb) p mr $10 = (MemoryRegion *) 0x7fdf32a168b0 (gdb) p *mr Cannot access memory at address 0x7fdf32a168b0 Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- exec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/exec.c b

[Xen-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-08 Thread Don Slutz
bdf: 00:04.0 xen_map_pcidev id: 1 bdf: 03:04.0 Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- include/hw/xen/xen_common.h | 53 +++-- trace-events| 6 +++-- xen-hvm.c | 15

[Xen-devel] [PATCH v2 3/4] xen: Add usage of device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- include/hw/xen/xen_common.h | 10 ++ xen-hvm.c | 13 - 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h

[Xen-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
listener interface to be called when ever the secondary bus number is set to a new value. This new interface is called for all PCI devices that are on the secondary bridge. Signed-off-by: Don Slutz dsl...@verizon.com CC: Don Slutz don.sl...@gmail.com --- hw/core/qdev.c | 7 +++ hw/pci

[Xen-devel] [PATCH v2 0/4] Fix device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
it happens to be the reset value). Dropped all checking of 0 and 255. Open question by Michael S. Tsirkin: On Thu, May 28, 2015 at 07:25:50AM -0400, Don Slutz wrote: ... It is not clear to me that the complexity of tracking bus visibility make sense. Clearly you do. Well what

Re: [Xen-devel] QEMU bumping memory bug analysis

2015-06-08 Thread Don Slutz
and qemu, as we can between Xen and the toolstack. But I think setting anything like this in stone is a really bad idea; which unfortulately excludes the idea of putting it in qemu. -Don Slutz -George ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] QEMU bumping memory bug analysis

2015-06-08 Thread Don Slutz
On 06/08/15 11:37, George Dunlap wrote: On 06/08/2015 04:01 PM, Don Slutz wrote: On 06/08/15 10:20, George Dunlap wrote: And at the moment, pages in the p2m are allocated by a number of entities: * In the libxc domain builder. * In the guest balloon driver * And now, in qemu, to allocate

Re: [Xen-devel] [PATCH v11 5/9] xen: Add vmware_port support

2015-06-05 Thread Don Slutz
-arch.hvm_domain.is_vmware_port_enabled ) +{ +rc = -EOPNOTSUPP; +break; +} Surrounding code avoiding the use of break makes the result look rather inconsistent. Please move this up immediately after the XSM check, or drop the break. Will do. -Don Slutz Jan

Re: [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
for my bad english. The patch: From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001 From: Don Slutz dsl...@verizon.com Date: Thu, 4 Jun 2015 17:04:42 -0400 Subject: [PATCH 01/14] monitor: Allow Xen's (broken) usage of asynchronous command interface. commit

Re: [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
On 06/04/15 17:59, Don Slutz wrote: On 06/04/15 11:04, Fabio Fantoni wrote: Today after trying xen-unstable build (tested many hours) of some days ago I tried update qemu to latest development version (from git master commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems

Re: [Xen-devel] [Qemu-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/15 18:10, Eric Blake wrote: [adding Markus, as author of the regression] On 06/04/2015 03:59 PM, Don Slutz wrote: On 06/04/15 11:04, Fabio Fantoni wrote: Today after trying xen-unstable build (tested many hours) of some days ago I

Re: [Xen-devel] [PATCH v11 3/9] tools: Add vmware_hwver support

2015-06-04 Thread Don Slutz
On 06/04/15 11:17, Ian Campbell wrote: On Fri, 2015-05-22 at 11:50 -0400, Don Slutz wrote: [...] +=item Bvmware_hwver=NUMBER + +Turns on or off the exposure of VMware cpuid. The number is +VMware's hardware version number, where 0 is off. A number = 7 +is needed to enable exposure

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-04 Thread Don Slutz
On 06/04/15 10:14, George Dunlap wrote: On 06/04/2015 01:37 PM, Don Slutz wrote: On 06/03/15 12:58, George Dunlap wrote: On 06/03/2015 05:41 PM, Don Slutz wrote: On 06/03/15 12:23, George Dunlap wrote: On 06/03/2015 04:58 PM, Andrew Cooper wrote: On 03/06/15 16:26, George Dunlap wrote

Re: [Xen-devel] [PATCH v11 7/9] tools: Add vmware_port support

2015-06-04 Thread Don Slutz
On 06/04/15 11:49, Ian Campbell wrote: On Wed, 2015-06-03 at 18:06 +0100, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: This new libxl_domain_create_info field is used to set XEN_DOMCTL_CONFIG_VMWARE_PORT_MASK in the xc_domain_configuration_t for x86. In xen

Re: [Xen-devel] [PATCH v11 3/9] tools: Add vmware_hwver support

2015-06-04 Thread Don Slutz
On 06/04/15 11:15, Ian Campbell wrote: On Wed, 2015-06-03 at 15:53 +0100, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: This is used to set xen_arch_domainconfig vmware_hw. It is set to the emulated VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-04 Thread Don Slutz
On 06/03/15 12:23, George Dunlap wrote: On 06/03/2015 04:58 PM, Andrew Cooper wrote: On 03/06/15 16:26, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: Summary is that VMware treats in (%dx),%eax (or out %eax,(%dx)) to port 0x5658 specially. Note: since many operations return

Re: [Xen-devel] [PATCH v11 9/9] Add xentrace to vmware_port

2015-06-04 Thread Don Slutz
On 06/04/15 07:20, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: Also added missing TRAP_DEBUG VLAPIC. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Ian Campbell ian.campb...@citrix.com --- v11: No change v10: Added Acked-by: Ian Campbell Added back

Re: [Xen-devel] [PATCH v11 8/9] Add IOREQ_TYPE_VMWARE_PORT

2015-06-04 Thread Don Slutz
On 06/03/15 13:09, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: This adds synchronization of the 6 vcpu registers (only 32bits of them) that vmport.c needs between Xen and QEMU. This is to avoid a 2nd and 3rd exchange between QEMU and Xen to fetch and put these 6 vcpu

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-04 Thread Don Slutz
On 06/03/15 12:58, George Dunlap wrote: On 06/03/2015 05:41 PM, Don Slutz wrote: On 06/03/15 12:23, George Dunlap wrote: On 06/03/2015 04:58 PM, Andrew Cooper wrote: On 03/06/15 16:26, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: Summary is that VMware treats in (%dx),%eax

Re: [Xen-devel] RFC: QEMU bumping memory limit and domain restore

2015-06-03 Thread Don Slutz
this with the security deprivileging thing would make some sense? I.e., have qemu do no hypercalls at all, but have them done instead by a babysitter process from libxl, which could then update the domain config state as well. Not sure. -Don Slutz -George

Re: [Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-06-03 Thread Don Slutz
On 06/03/15 11:58, Andrew Cooper wrote: On 03/06/15 16:26, George Dunlap wrote: On 05/22/2015 04:50 PM, Don Slutz wrote: Summary is that VMware treats in (%dx),%eax (or out %eax,(%dx)) to port 0x5658 specially. Note: since many operations return data in EAX, in (%dx),%eax is the one to use

Re: [Xen-devel] [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-29 Thread Don Slutz
On 05/28/15 17:05, Michael S. Tsirkin wrote: On Thu, May 28, 2015 at 11:03:07PM +0200, Michael S. Tsirkin wrote: On Thu, May 28, 2015 at 03:09:48PM -0400, Don Slutz wrote: On 05/28/15 08:28, Michael S. Tsirkin wrote: On Thu, May 28, 2015 at 07:25:50AM -0400, Don Slutz wrote: On 05/28/15 05:30

Re: [Xen-devel] ACPI shutdown unreliable with win7?

2015-05-29 Thread Don Slutz
/Tweak_Your_Windows_PCs_Sleep_Mode.html That says there are BIOS settings that Win7 will also look at. Could be the colo needs some changes also. -Don Slutz Also, when the test fails the guest is also not hibernating either. Would we have ways to tell it at least tried to enter e.g. S3? I'm not sure, but it's

Re: [Xen-devel] Earlier embargoed pre-disclosure without patches

2015-05-27 Thread Don Slutz
if patches have not yet been written or tested. An updated draft will be sent to the pre-disclosure list once patches become available. No objections here. +1 Also looks good to me. +1 -Don Slutz ___ Xen-devel mailing list Xen-devel

[Xen-devel] [PATCH v11 8/9] Add IOREQ_TYPE_VMWARE_PORT

2015-05-22 Thread Don Slutz
vmport code. The currently most useful VMware port support that QEMU has is the VMware mouse support. Xorg included a VMware mouse support that uses absolute mode. This make using a mouse in X11 much nicer. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Ian Campbell ian.campb...@citrix.com

[Xen-devel] [PATCH v11 0/9] Xen VMware tools support

2015-05-22 Thread Don Slutz
(viridian support) breaks this check.) Add the magic VMware port Allow VMware tools poweroff and reboot Enable access to VMware's guest info Provide the VMware tools build number Don Slutz (9): tools: Add vga=vmware xen: Add support for VMware cpuid

[Xen-devel] [PATCH v11 1/9] tools: Add vga=vmware

2015-05-22 Thread Don Slutz
This allows use of QEMU's VMware emulated video card NOTE: vga=vmware is not supported by device_model_version=qemu-xen-traditional Signed-off-by: Don Slutz dsl...@verizon.com --- v11: Dropped support for Qemu-trad. Also changed later patchs to not need this one. v10: New at v10

[Xen-devel] [PATCH v11 7/9] tools: Add vmware_port support

2015-05-22 Thread Don Slutz
(vmware_hwver = 7). Note: vmware_port and nestedhvm cannot be specified at the same time. Signed-off-by: Don Slutz dsl...@verizon.com --- v11: Dropped If non-zero then default VGA to VMware's VGA v10: If... at the start of the sentence ... Also, why is 7 special? docs/man/xl.cfg.pod.5

[Xen-devel] [PATCH v11 9/9] Add xentrace to vmware_port

2015-05-22 Thread Don Slutz
Also added missing TRAP_DEBUG VLAPIC. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Ian Campbell ian.campb...@citrix.com --- v11: No change v10: Added Acked-by: Ian Campbell Added back in the trace point calls. Why is cmd in this patch? Because the trace points use

[Xen-devel] [PATCH v11 3/9] tools: Add vmware_hwver support

2015-05-22 Thread Don Slutz
This is used to set xen_arch_domainconfig vmware_hw. It is set to the emulated VMware virtual hardware version. Currently 0, 3-4, 6-11 are good values. However the code only checks for == 0, != 0, or 7. Signed-off-by: Don Slutz dsl...@verizon.com --- v11: Dropped If non-zero then default VGA

[Xen-devel] [PATCH v11 5/9] xen: Add vmware_port support

2015-05-22 Thread Don Slutz
-tools.sourceforge.net/ Which only uses inl (%dx). Also http://kb.vmware.com/selfservice/microsites/search.do?language=en_UScmd=displayKCexternalId=1009458 Some of the best info is at: https://sites.google.com/site/chitchatvmback/backdoor Signed-off-by: Don Slutz dsl...@verizon.com Reviewed

[Xen-devel] [PATCH v11 2/9] xen: Add support for VMware cpuid leaves

2015-05-22 Thread Don Slutz
. Signed-off-by: Don Slutz dsl...@verizon.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- v11: Adjust /* Disallow if vmware_hwver */ Newline after break; Added Reviewed-by: Andrew Cooper. It would be worth to add an explicit vmware_hwver = 0

[Xen-devel] [PATCH v11 6/9] xen: Add ring 3 vmware_port support

2015-05-22 Thread Don Slutz
registers after doing a VMware backdoor operation. Add new routine hvm_emulate_one_gp() to be used by the #GP fault handler. Some of the best info is at: https://sites.google.com/site/chitchatvmback/backdoor Signed-off-by: Don Slutz dsl...@verizon.com --- v11: No change v10: Re-worked

[Xen-devel] [PATCH v11 4/9] vmware: Add VMware provided include file.

2015-05-22 Thread Don Slutz
. It only has a comment and is provided so that backdoor_def.h can be used without change. Signed-off-by: Don Slutz dsl...@verizon.com Acked-by: Andrew Cooper andrew.coop...@citrix.com --- v11: No change v10: Add Acked-by: Andrew Cooper v9: Either the description is wrong, or the patch is stale

Re: [Xen-devel] [PATCH] xen/public: Clarify xen_arch_domainconfig ABI statement

2015-05-20 Thread Don Slutz
On 05/20/15 09:10, Andrew Cooper wrote: This structure is used by XEN_DOMCTL_createdomain, and is liable to be modified going forwards. Explicitly state that it falls under the XEN_DOMCTL_INTERFACE_VERSION. Looks good to me. Reviewed-by: Don Slutz dsl...@verizon.com -Don Slutz Signed

Re: [Xen-devel] [PATCH] xen/x86: Don't unconditionally touch the hvm_domain union during domain construction

2015-05-20 Thread Don Slutz
good to me. Reviewed-by: Don Slutz dsl...@verizon.com -Don Slutz ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v10 02/10] xen: Add support for VMware cpuid leaves

2015-05-20 Thread Don Slutz
in the libxl__arch_domain_prepare_config. Ok, I will do so (the next patch does change this code). This does add a requirement of a tools ack to this patch. -Don Slutz Regards, ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org

Re: [Xen-devel] [PATCH v10 01/10] tools: Add vga=vmware

2015-05-20 Thread Don Slutz
On 05/15/15 04:49, Ian Campbell wrote: On Fri, 2015-05-15 at 00:42 +0100, Andrew Cooper wrote: On 15/05/2015 00:34, Don Slutz wrote: This allows use of QEMU's VMware emulated video card Signed-off-by: Don Slutz dsl...@verizon.com Nack. Qemu-trad is currently has remote code execution

Re: [Xen-devel] [PATCH v10 05/10] xen: Add vmware_port support

2015-05-20 Thread Don Slutz
On 05/19/15 16:23, Andrew Cooper wrote: On 15/05/15 00:34, Don Slutz wrote: This includes adding is_vmware_port_enabled diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index bc3d3a5..153048a 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -519,7 +519,11

Re: [Xen-devel] [PATCH v10 02/10] xen: Add support for VMware cpuid leaves

2015-05-20 Thread Don Slutz
On 05/19/15 16:02, Andrew Cooper wrote: On 15/05/15 00:34, Don Slutz wrote: This is done by adding xen_arch_domainconfig vmware_hw. It is set to the VMware virtual hardware version. ... Signed-off-by: Don Slutz dsl...@verizon.com Reviewed-by: Andrew Cooper andrew.coop...@citrix.com --- v10

Re: [Xen-devel] [PATCH v9 07/13] tools: Add vmware_port support

2015-05-14 Thread Don Slutz
On 03/03/15 09:23, Ian Campbell wrote: On Mon, 2015-02-16 at 18:05 -0500, Don Slutz wrote: I do not see that I ever replied to this :( +=item Bvmware_port=BOOLEAN + +Turns on or off the exposure of VMware port. This is known as +vmport in QEMU. Also called VMware Backdoor I/O Port

Re: [Xen-devel] [PATCH v10 01/10] tools: Add vga=vmware

2015-05-14 Thread Don Slutz
On 05/14/15 19:42, Andrew Cooper wrote: On 15/05/2015 00:34, Don Slutz wrote: This allows use of QEMU's VMware emulated video card Signed-off-by: Don Slutz dsl...@verizon.com Nack. Qemu-trad is currently has remote code execution vulnerabilities in its vmware vga model. CVE-2014-3689

[Xen-devel] [PATCH v10 00/10] Xen VMware tools support

2015-05-14 Thread Don Slutz
info Provide the VMware tools build number Don Slutz (10): tools: Add vga=vmware xen: Add support for VMware cpuid leaves tools: Add vmware_hwver support vmware: Add VMware provided include file. xen: Add vmware_port support xen: Add ring 3 vmware_port support tools: Add

  1   2   3   >