Hi Fengguang,
There are two different warning.
At 10/30/2017 03:35 PM, Fengguang Wu wrote:
On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote:
Hi Linus,
Up to now we see the below boot error/warnings when testing v4.14-rc6.
The original warning:
), and set
the value in xen_init_lock_cpu() to make the setup later and avoid the
WARN().
Reported-by: Juergen Gross <jgr...@suse.com>
Suggested-by: Juergen Gross <jgr...@suse.com>
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
Reviewed-by: Juergen Gross <jgr...@sus
us(). Make the
setup later to avoid the WARN().
Reported-by: Juergen Gross <jgr...@suse.com>
Suggested-by: Juergen Gross <jgr...@suse.com>
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/smpboot.c | 3 ++-
arch/x86/xen/smp_pv.c | 2 ++
arch/x86/xen/spin
with a noop().
[Rewritten by Thomas Gleixner <t...@linutronix.de>]
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
Acked-by: Juergen Gross <jgr...@suse.com>
Cc: xen-de...@lists.xenproject.org
Cc: boris.ostrov...@oracle.com
Cc: Juergen Gross <jgr...@suse.com>
---
V10 -->
Hi Juergen,
At 09/13/2017 05:45 PM, Juergen Gross wrote:
On 13/09/17 11:12, Dou Liyang wrote:
XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
initializes interrupts in the XEN PV specific way and does not invoke
native_smp_prepare_cpus(). As a consequence
- Fix some typos
- Rewrite the changelog
Cc: xen-de...@lists.xenproject.org
Cc: boris.ostrov...@oracle.com
Cc: Juergen Gross <jgr...@suse.com>
Cc: linux-a...@vger.kernel.org
Cc: Rafael J. Wysocki <r...@rjwysocki.net>
Cc: Zheng, Lv <lv.zh...@intel.com>
Dou Liyang (12):
x86/apic: Constru
native_smp_prepare_cpus() in a follow up patch to solve .
That move would cause the invocation of x86_init.intr_mode_init() for XEN
PV platforms. To prevent that, override the default x86_init.intr_mode_init()
callback with a noop().
[Rewrited by Thomas Gleixner <t...@linutronix.de>]
Signed-off-b
Hi,
Follow Juergen's advice, +CC xen-devel and linux-acpi
In case a single patch of a series isn't stand alone it would be nice
to receive at least the cover letter of the series in order to know
what its all about.
Thanks,
dou.
At 08/28/2017 11:20 AM, Dou Liyang wrote:
Changes V7
Hi Juergen,
At 08/28/2017 12:32 PM, Juergen Gross wrote:
On 28/08/17 06:25, Juergen Gross wrote:
On 28/08/17 05:20, Dou Liyang wrote:
XEN PV overrides smp_prepare_cpus(). xen_pv_smp_prepare_cpus()
initializes interrupts in the XEN PV specific way and does not invoke
native_smp_prepare_cpus
native_smp_prepare_cpus() in a follow up patch to solve .
That move would cause the invocation of x86_init.intr_mode_init() for XEN
PV platforms. To prevent that, override the default x86_init.
intr_mode_init() callback with a noop().
[Rewrited by Thomas Gleixner <t...@linutronix.de>]
Signed-off-b
native_smp_prepare_cpus() in a follow up patch to solve .
That move would cause the invocation of x86_init.intr_mode_init() for XEN
PV platforms. To prevent that, override the default x86_init.intr_mode_init()
callback with a noop().
[Rewrited by Thomas Gleixner <t...@linutronix.de>]
Signed-off-b
Hi, Lu
At 07/13/2017 11:00 AM, Lu Baolu wrote:
Hi,
On 07/13/2017 09:39 AM, Dou Liyang wrote:
Hi, Lu
At 07/13/2017 09:17 AM, Lu Baolu wrote:
Hi,
On 07/12/2017 04:02 PM, Dou Liyang wrote:
Hi, Lu
At 05/05/2017 08:50 PM, Boris Ostrovsky wrote:
On 05/05/2017 01:41 AM, Lu Baolu wrote:
Hi
Hi, Lu
At 07/13/2017 09:17 AM, Lu Baolu wrote:
Hi,
On 07/12/2017 04:02 PM, Dou Liyang wrote:
Hi, Lu
At 05/05/2017 08:50 PM, Boris Ostrovsky wrote:
On 05/05/2017 01:41 AM, Lu Baolu wrote:
Hi,
On 05/03/2017 06:38 AM, Boris Ostrovsky wrote:
On 03/21/2017 04:01 AM, Lu Baolu wrote:
Add
Hi, Lu
At 05/05/2017 08:50 PM, Boris Ostrovsky wrote:
On 05/05/2017 01:41 AM, Lu Baolu wrote:
Hi,
On 05/03/2017 06:38 AM, Boris Ostrovsky wrote:
On 03/21/2017 04:01 AM, Lu Baolu wrote:
Add a simple udelay calibration in x86 architecture-specific
boot-time initializations. This will get a
("x86/time: Initialize interrupt
mode behind timer init")
url:
https://github.com/0day-ci/linux/commits/Dou-Liyang/Unify-the-interrupt-delivery-mode-and-do-its-setup-in-advance/20170705-124610
in testcase: will-it-scale
with following parameters:
nr_task: 50%
mod
Hi Thomas,
At 07/07/2017 11:04 AM, Ye Xiaolong wrote:
On 07/07, Dou Liyang wrote:
Hi xiaolong,
Really thanks for your testing.
At 07/07/2017 09:54 AM, Ye Xiaolong wrote:
On 07/06, Thomas Gleixner wrote:
On Thu, 6 Jul 2017, kernel test robot wrote:
commit
Hi xiaolong,
Really thanks for your testing.
At 07/07/2017 09:54 AM, Ye Xiaolong wrote:
On 07/06, Thomas Gleixner wrote:
On Thu, 6 Jul 2017, kernel test robot wrote:
commit: 03fa63cc96ab35592e0a7d522b8edbc1e6b02d22 ("x86/time: Initialize interrupt
mode behind timer init")
the APIC setup, keep it in the
original position for SMP and UP kernel for preparation.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 4 ++--
arch/x86/kernel/smpboot.c | 5 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ar
In UniProcessor kernel with UP_LATE_INIT=y, it enables and setups
interrupt delivery mode in up_late_init().
Unify it to apic_intr_mode_init(), remove APIC_init_uniprocessor().
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kerne
the mode should be earlier than calibrating TSC as soon as
possible and needs testing whether the timer interrupt works at the same
time.
call it behind timers init, which meets the above conditions.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 2 --
ar
init_bsp_APIC()
is redundant.
Remove the init_bsp_APIC() function.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kernel/apic/apic.c | 49 -
arch/x86/kernel/irqinit.c | 3 ---
3 files chang
native_smp_prepare_cpus() in a follow up patch to solve .
That move would cause the invocation of x86_init.intr_mode_init() for XEN
PV platforms. To prevent that, override the default x86_init.intr_mode_init()
callback with a noop().
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x
X86 and XEN initialize interrupt delivery mode in different way.
Ordinary conditional function calls will make the code mess.
Add an unconditional x86_init_ops function which defaults to the
standard function and can be overridden by the early platform code.
Signed-off-by: Dou Liyang <doul
this selector to get an interrupt delivery mode directly.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 59 +
1 file changed, 59 insertions(+)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
st to rewrite some changelog again
Changes since V1:
- Move the initialization from init_IRQ() to x86_late_time_init()
- Use a threshold to refactor the check logic in timer_irq_works()
- Rename the framework to a selector
- Split two patches
- Consistently start sentences with upper case letter
.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 41 ++---
arch/x86/kernel/smpboot.c | 14 ++
2 files changed, 40 insertions(+), 15 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kerne
.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/io_apic.c | 45 --
1 file changed, 43 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f..3087f0a
helper function for cleanup and
mark apic_bsp_setup() void.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 2 +-
arch/x86/kernel/apic/apic.c | 10 +-
arch/x86/kernel/smpboot.c | 12 +++-
3 files changed, 13 insertions(+), 11 del
the switch and remove
the redundant sanity check.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 9 +++
arch/x86/kernel/apic/apic.c | 12 --
arch/x86/kernel/smpboot.c | 57 +++--
3 files chang
.
Provide a new function to unify that three positions. Preparatory
patch to initialize an interrupt mode directly.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 2 ++
arch/x86/kernel/apic/apic.c | 16
2 files changed, 18 insertions(+)
Hi Thomas,
At 07/03/2017 02:56 PM, Thomas Gleixner wrote:
On Mon, 3 Jul 2017, Dou Liyang wrote:
At 07/03/2017 03:18 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
xen_smp_ops overwrites smp_prepare_cpus to xen_pv_smp_prepare_cpus
which initializes interrupt itself
Hi Thomas,
At 07/03/2017 02:41 PM, Thomas Gleixner wrote:
On Mon, 3 Jul 2017, Dou Liyang wrote:
At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
+/* Init the interrupt delivery mode for the BSP */
+void __init apic_intr_mode_init(void)
+{
+ switch
Hi Thomas,
At 07/03/2017 03:18 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
xen_smp_ops overwrites smp_prepare_cpus to xen_pv_smp_prepare_cpus
which initializes interrupt itself.
Touching the intr_mode_init causes unexpected results on the system.
Bypass
Hi Thomas,
At 07/03/2017 03:16 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
Add an unconditional x86_init_ops function which defaults to the
standard function and can be overridden by the early platform code.
That changelog describes WHAT the patch does, but not WHY
Hi Thomas,
At 07/03/2017 03:15 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
+static void __init delay_with_tsc(void)
+{
+ unsigned long long start, now;
+ unsigned long ticks = jiffies;
Please make that
unsigned long end = jiffies + 4;
ticks really
Hi Thomas,
At 07/03/2017 02:19 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
static inline int apic_force_enable(unsigned long addr)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 0601054..9bf7e95 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b
Hi Thomas,
At 07/03/2017 02:07 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
-static int __init apic_intr_mode_select(void)
+static int __init apic_intr_mode_select(int *upmode)
{
/* Check kernel option */
if (disable_apic) {
@@ -1206,12 +1208,30 @@ static
Hi, Thomas
At 07/03/2017 01:54 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
/*
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 93f0cda..d6721f0 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1347,8 +1347,11 @@ void
Hi Thomas,
At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
+/* Init the interrupt delivery mode for the BSP */
+void __init apic_intr_mode_init(void)
+{
+ switch (apic_intr_mode_select()) {
+ case APIC_PIC:
+ apic_printk
Hi Thomas,
At 07/03/2017 01:37 AM, Thomas Gleixner wrote:
On Fri, 30 Jun 2017, Dou Liyang wrote:
+static int __init apic_intr_mode_select(void)
+{
+ /* Check kernel option */
+ if (disable_apic) {
+ pr_info("APIC disabled via kernel command l
Add an unconditional x86_init_ops function which defaults to the
standard function and can be overridden by the early platform code.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/x86_init.h | 2 ++
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/kernel/smp
.
Provide a new function to unify that three positions. Preparatory
patch to initialize an interrupt mode directly.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 2 ++
arch/x86/kernel/apic/apic.c | 19 +++
2 files changed, 21 inse
the APIC setup, keep it in the
original position for SMP and UP kernel for preparation.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 4 ++--
arch/x86/kernel/smpboot.c | 5 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ar
init_bsp_APIC()
is redundant.
Remove the init_bsp_APIC() function.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kernel/apic/apic.c | 49 -
arch/x86/kernel/irqinit.c | 3 ---
3 files chang
this selector to get an interrupt delivery mode directly.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 60 +
1 file changed, 60 insertions(+)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
In UniProcessor kernel with UP_LATE_INIT=y, it enables and setups
interrupt delivery mode in up_late_init().
Unify it to apic_intr_mode_init(), remove APIC_init_uniprocessor().
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kerne
xen_smp_ops overwrites smp_prepare_cpus to xen_pv_smp_prepare_cpus
which initializes interrupt itself.
Touching the intr_mode_init causes unexpected results on the system.
Bypass it in enlighten_pv system.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/xen/enlighte
.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 41 -
arch/x86/kernel/smpboot.c | 13 ++---
2 files changed, 38 insertions(+), 16 deletions(-)
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kerne
the switch and remove
the redundant sanity check.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 9
arch/x86/kernel/apic/apic.c | 11 +++---
arch/x86/kernel/smpboot.c | 50 -
3 files chang
to native_smp_prepare_cpus() for cleanup and mark
apic_bsp_setup() void.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/include/asm/apic.h | 2 +-
arch/x86/kernel/apic/apic.c | 10 +-
arch/x86/kernel/smpboot.c | 7 +--
3 files changed, 7 insertions(+), 12 deletions(-)
diff
.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/io_apic.c | 45 --
1 file changed, 43 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 347bb9f..f710077
- Rename the framework to a selector
- Split two patches
- Consistently start sentences with upper case letters
- Fix some typos
- Rewrite the changelog
Dou Liyang (12):
x86/apic: Construct a selector for the interrupt delivery mode
x86/apic: Prepare for unifying the interrupt deli
the mode should be earlier than calibrating TSC as soon as
possible and needs testing whether the timer interrupt works at the same
time.
call it behind timers init, which meets the above conditions.
Signed-off-by: Dou Liyang <douly.f...@cn.fujitsu.com>
---
arch/x86/kernel/apic/apic.c | 2 --
ar
53 matches
Mail list logo
