Re: [Xen-devel] [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote: > On 2017年08月19日 00:38, Eduardo Habkost wrote: > > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > >> On 2017年08月16日 19:21, Paolo Bonzini wrote: > >>> On 16/08/2017 02:22, Lan Tianyu wrote:

[Xen-devel] [PATCH] xen/pt: Mark TYPE_XEN_PT_DEVICE as hybrid

xen-pt doesn't set the is_express field, but is supposed to be able to handle PCI Express devices too. Mark it as hybrid. Suggested-by: Jan Beulich <jbeul...@suse.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- hw/xen/xen_pt.c | 1 + 1 file changed, 1 insertion(+) dif

Re: [Xen-devel] xen-pci-passthrough PCI Express support? (Re: [Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices)

On Wed, Oct 04, 2017 at 03:08:15AM -0600, Jan Beulich wrote: > >>> On 03.10.17 at 02:12, <ehabk...@redhat.com> wrote: > > On Thu, Sep 28, 2017 at 10:12:34AM -0300, Eduardo Habkost wrote: > >> On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > &

[Xen-devel] xen-pci-passthrough PCI Express support? (Re: [Qemu-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices)

On Thu, Sep 28, 2017 at 10:12:34AM -0300, Eduardo Habkost wrote: > On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > > >>> On 27.09.17 at 21:56, <ehabk...@redhat.com> wrote: > > > --- a/hw/xen/xen_pt.c > > > +++ b/hw/xen/xen_pt.c > &

Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > >>> On 27.09.17 at 21:56, wrote: > > --- a/hw/xen/xen_pt.c > > +++ b/hw/xen/xen_pt.c > > @@ -964,6 +964,10 @@ static const TypeInfo xen_pci_passthrough_info = { > > .instance_size =

[Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices

-by: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Changes v1 -> v2: * s/legacy/conventional/ * Suggested-by: Alex Williamson <alex.william...@redhat.com> * Note about pcie-pci-bridge on commit message. * New devices: sungem, sunhme

Re: [Xen-devel] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

On Mon, Aug 28, 2017 at 06:58:37PM -0400, John Snow wrote: > > > On 08/25/2017 03:39 PM, Eduardo Habkost wrote: > > CCing maintainers of affected devices (sorry for not CCing you > > before). > > > > On Wed, Aug 23, 2017 at 07:14:44PM -0300

Re: [Xen-devel] [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

CCing maintainers of affected devices (sorry for not CCing you before). On Wed, Aug 23, 2017 at 07:14:44PM -0300, Eduardo Habkost wrote: > Add INTERFACE_LEGACY_PCI_DEVICE to all direct subtypes of > TYPE_PCI_DEVICE, except: > > 1) The ones that already have INTERFACE_PCIE_DEVICE set:

Re: [Xen-devel] [PATCH] x86: Skip check apic_id_limit for Xen

On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote: > On 2017年08月16日 19:21, Paolo Bonzini wrote: > > On 16/08/2017 02:22, Lan Tianyu wrote: > >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU > >> check for Xen here when vcpu number is more than 255. > > > > I think you

Re: [Xen-devel] [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

On Mon, Apr 24, 2017 at 12:40:07PM +0200, Thomas Huth wrote: > On 20.12.2016 18:43, Eduardo Habkost wrote: > > This moves the KVM and Xen files to the an accel/ subdir. > > > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > > move most of the

Re: [Xen-devel] [Qemu-devel] [PATCH v3 2/4] qdev: add function qdev_set_id()

On Tue, Nov 22, 2016 at 07:10:57AM +0100, Juergen Gross wrote: > In order to have an easy way to add a new qdev with a specific id > carve out the needed functionality from qdev_device_add() into a new > function qdev_set_id(). > > Signed-off-by: Juergen Gross > Reviewed-by:

Re: [Xen-devel] [Qemu-devel] [PATCH v3 3/4] xen: create qdev for each backend device

Hi, I am reviewing the existing code that sets has_dynamic_sysbus, and this patch confused me. I have a question below: On Tue, Nov 22, 2016 at 07:10:58AM +0100, Juergen Gross wrote: > Create a qdev plugged to the xen-sysbus for each new backend device. > This device can be used as a parent for

Re: [Xen-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

On Wed, Dec 21, 2016 at 02:47:54PM +0100, Paolo Bonzini wrote: > > > On 21/12/2016 14:14, Eduardo Habkost wrote: > > On Wed, Dec 21, 2016 at 12:21:44PM +0100, Paolo Bonzini wrote: > >> > >> > >> On 20/12/2016 18:43, Eduardo Habkost wrote: > >>

Re: [Xen-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

On Wed, Dec 21, 2016 at 12:21:44PM +0100, Paolo Bonzini wrote: > > > On 20/12/2016 18:43, Eduardo Habkost wrote: > > This moves the KVM and Xen files to the an accel/ subdir. > > > > Instead of moving the *-stubs.c file to accel/ as-is, I tried to > > move most

[Xen-devel] [RFC 1/7] xen: Move xen-*-stub.c to stubs/

Move xen stubs to stubs/ so they are handled automatically by libqemustub.a. Cc: Stefano Stabellini <sstabell...@kernel.org> Cc: Anthony Perard <anthony.per...@citrix.com> Cc: xen-de...@lists.xensource.com Cc: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Eduardo Habkost &l

[Xen-devel] [RFC 2/7] xen: Move xen files to accel/

Cc: Stefano Stabellini <sstabell...@kernel.org> Cc: Anthony Perard <anthony.per...@citrix.com> Cc: xen-de...@lists.xensource.com Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Makefile.target| 4 +--- xen-common.c => accel/xen-common.c |

[Xen-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

o.org> Cc: Anthony Perard <anthony.per...@citrix.com> Cc: Stefano Stabellini <sstabell...@kernel.org> Cc: xen-de...@lists.xensource.com Eduardo Habkost (7): xen: Move xen-*-stub.c to stubs/ xen: Move xen files to accel/ kvm: Move some kvm-stub.c code to stubs/kvm.c kvm:

Re: [Xen-devel] [PATCH v2] xen: Fix xenpv machine initialisation

Moving the code > to xen_hvm_init() fix the issue. > > This fix 021746c131cdfeab9d82ff918795a9f18d20d7ae. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > --- > CC: Wei Liu <wei.l...@cit

Re: [Xen-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 03:30:59PM -0700, Stefano Stabellini wrote: > On Tue, 1 Nov 2016, Eduardo Habkost wrote: > > On Tue, Nov 01, 2016 at 05:44:16PM +, Wei Liu wrote: > > > Introduce this field to control whether ACPI build is enabled by a > > > partic

Re: [Xen-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

en is in charge of building ACPI > tables for the guest. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 05:12:37PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 03:02:31PM -0200, Eduardo Habkost wrote: > > On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: > > [...] > > > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *op

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 04:43:11PM +, Wei Liu wrote: [...] > @@ -114,6 +115,11 @@ static void xen_change_state_handler(void *opaque, int > running, > > static int xen_init(MachineState *ms) > { > +PCMachineState *pcms = PC_MACHINE(ms); > + > +/* Disable ACPI build because Xen

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

On Tue, Nov 01, 2016 at 04:53:17PM +, Wei Liu wrote: > On Tue, Nov 01, 2016 at 02:48:27PM -0200, Eduardo Habkost wrote: > [...] > > > static void pc_machine_set_nvdimm(Object *obj, bool value, Error **errp) > > > { > > > PCMachineState *pcms = PC_MACHI

Re: [Xen-devel] [PATCH RFC] PCMachineState: introduce acpi_build_enabled field

en is in charge of building ACPI > tables for the guest. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > --- > Cc: Igor Mammedov <imamm...@redhat.com> > Cc: Eduardo Habkost <ehabk...@redhat.com> > Cc: Anthony PERARD <anthony.per...@citrix.com> &g

Re: [Xen-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

On Wed, Oct 26, 2016 at 11:32:56AM +0100, Wei Liu wrote: > On Tue, Oct 25, 2016 at 04:33:03PM -0700, Stefano Stabellini wrote: > > CC'ing maintainers > > > > On Tue, 25 Oct 2016, Wei Liu wrote: > > > Xen's toolstack is in charge of building ACPI tables. Skip acpi table > > > building if running

Re: [Xen-devel] [Qemu-devel] [PATCH v3 04/11] igd: switch TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE to realize

On Tue, Jan 05, 2016 at 12:41:31PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/igd.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/hw/pci-host/igd.c b/hw/pci-host/igd.c > index ef0273b..d1eeafb 100644 >

Re: [Xen-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

; > > Many device classes have a parent_realize field so they can keep > > a pointer to the original realize function. It's better than a > > static variable. > > How does the attached patch (incremental fix, not tested yet) look like? Looks good. Reviewed-by: Eduardo Habkos

Re: [Xen-devel] [PATCH v3 02/11] pc: remove has_igd_gfx_passthru global

On Tue, Jan 05, 2016 at 12:41:29PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo ___ Xen-devel mailing list Xen-devel@lists.xen.org http:

Re: [Xen-devel] [PATCH v3 05/11] igd: TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE: call parent realize

On Wed, Jan 06, 2016 at 04:45:01PM +0100, Gerd Hoffmann wrote: > > > > > > +static void (*i440fx_realize)(PCIDevice *pci_dev, Error **errp); > > > static void igd_pt_i440fx_realize(PCIDevice *pci_dev, Error **errp) > > > { > > > +Error *err = NULL; > > > uint32_t val = 0; > > >

Re: [Xen-devel] [PATCH v2 02/10] pc: remove has_igd_gfx_passthru global

On Mon, Dec 14, 2015 at 12:39:34PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/xen/xen_pt.h | 3 +-- > vl.c| 10 -- > 2 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h > index