[Xen-devel] [PATCH v3 01/13] xen: Fix coding style errors

Fixes the following errors: * ERROR: line over 90 characters * ERROR: code indent should never use tabs * ERROR: space prohibited after that open square bracket '[' * ERROR: do not initialise statics to 0 or NULL * ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Em

[Xen-devel] [PATCH v3 07/13] xen: Move xenstore cleanup and mkdir functions

The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/xen/xen_ba

[Xen-devel] [PATCH v3 06/13] xen: Prepare xendev qtail to be shared with frontends

* move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 51 +-- hw/xen/xen_pvdev.c

[Xen-devel] [PATCH v3 08/13] xen: Rename xen_be_printf to xen_pv_printf

Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/block/xen_disk.c| 58 +++-

[Xen-devel] [PATCH v3 11/13] xen: Rename xen_be_evtchn_event

Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/xen/xen_backend.c

[Xen-devel] [PATCH v3 13/13] xen: Rename xen_be_del_xendev

Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/xen/xen_backend.c

[Xen-devel] [PATCH v3 05/13] xen: Move evtchn functions to xen_pvdev.c

The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 35 --- hw/xen/xen_pvdev.c

[Xen-devel] [PATCH v3 00/13] Refactor common part of xen backend and frontend

to xen_pvdev file. --- Changes in v3: * align second line with first parameter Changes in v2: * fixed parameter alignment when spliting long lines * removed patches for creating xen_frontend Emil Condrea (13): xen: Fix coding style errors xen: Fix coding style warnings xen: Create a new file

[Xen-devel] [PATCH v3 10/13] xen: Rename xen_be_send_notify

Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/block/xen_disk.c

[Xen-devel] [PATCH v3 09/13] xen: Rename xen_be_unbind_evtchn

Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/block/xen_dis

[Xen-devel] [PATCH v3 04/13] xen: Move xenstore_update to xen_pvdev.c

* xenstore_update -> xen_pvdev.c Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 30 +++--- hw/xen/xen_pvdev.c | 23 +++ include/hw/xen/xen_backend.h | 3 +++ include/hw/xen/xen_pvdev.h

[Xen-devel] [PATCH v3 12/13] xen: Rename xen_be_find_xendev

Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/display/xenfb.c

[Xen-devel] [PATCH v3 02/13] xen: Fix coding style warnings

Fixes: * WARNING: line over 80 characters Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c | 3 ++- hw/char/xen_console.c| 3 ++- hw/display/xenfb.c | 6 -- hw/net/xen_nic.c | 12 hw/xen/xen_bac

[Xen-devel] [PATCH v3 03/13] xen: Create a new file xen_pvdev.c

The purpose of the new file is to store generic functions shared by frontend and backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/Makefile.objs | 2 +- hw/xen/x

Re: [Xen-devel] [PATCH 02/15] xen: Fix coding style warnings

, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Thu, Oct 13, 2016 at 07:04:56AM +0300, Emil Condrea wrote: >> On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD >> <anthony.per...@citrix.com> wrote: >> > On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote:

Re: [Xen-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed

As you suggested, I've dropped the all patches for xen_frontend. Emil On Wed, Oct 12, 2016 at 2:00 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 09/10/2016 21:50, Emil Condrea wrote: >> On Tue, Oct 4, 2016 at 11:06 AM, Paolo Bonzini <pbonz...@redhat.com>

Re: [Xen-devel] [PATCH v2 00/13] Refactor common part of xen backend and frontend

+ cc Paolo Bonzini On Thu, Oct 13, 2016 at 9:01 AM, Emil Condrea <emilcond...@gmail.com> wrote: > This patch series was splitted from QEMU:Xen stubdom vTPM for HVM virtual > machine > http://markmail.org/message/fkix7g3a5zdj7lvr > > It contains a reorganization of xen

[Xen-devel] [PATCH v2 02/13] xen: Fix coding style warnings

Fixes: * WARNING: line over 80 characters Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c | 3 ++- hw/char/xen_console.c| 6 -- hw/display/xenfb.c | 30 -- hw/net/xen_nic.c | 12 --

[Xen-devel] [PATCH v2 06/13] xen: Prepare xendev qtail to be shared with frontends

* move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 51 +-- hw/xen/xen_pvdev.c

[Xen-devel] [PATCH v2 01/13] xen: Fix coding style errors

Fixes the following errors: * ERROR: line over 90 characters * ERROR: code indent should never use tabs * ERROR: space prohibited after that open square bracket '[' * ERROR: do not initialise statics to 0 or NULL * ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Em

[Xen-devel] [PATCH v2 08/13] xen: Rename xen_be_printf to xen_pv_printf

Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/block/xen_disk.c| 58 +++-

[Xen-devel] [PATCH v2 11/13] xen: Rename xen_be_evtchn_event

Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/xen/xen_backend.c

[Xen-devel] [PATCH v2 07/13] xen: Move xenstore cleanup and mkdir functions

The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/xen/xen_ba

[Xen-devel] [PATCH v2 04/13] xen: Move xenstore_update to xen_pvdev.c

* xenstore_update -> xen_pvdev.c Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 30 +++--- hw/xen/xen_pvdev.c | 23 +++ include/hw/xen/xen_backend.h | 3 +++ include/hw/xen/xen_pvdev.h

[Xen-devel] [PATCH v2 10/13] xen: Rename xen_be_send_notify

Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/block/xen_disk.c

[Xen-devel] [PATCH v2 09/13] xen: Rename xen_be_unbind_evtchn

Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/block/xen_dis

[Xen-devel] [PATCH v2 12/13] xen: Rename xen_be_find_xendev

Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/display/xenfb.c

[Xen-devel] [PATCH v2 13/13] xen: Rename xen_be_del_xendev

Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Quan Xu <xuqu...@huawei.com> --- hw/xen/xen_backend.c

[Xen-devel] [PATCH v2 00/13] Refactor common part of xen backend and frontend

to xen_pvdev file. --- Changes in v2: * fixed parameter alignment when spliting long lines * removed patches for creating xen_frontend Emil Condrea (13): xen: Fix coding style errors xen: Fix coding style warnings xen: Create a new file xen_pvdev.c xen: Move xenstore_update to xen_pvdev.c xen

[Xen-devel] [PATCH v2 03/13] xen: Create a new file xen_pvdev.c

The purpose of the new file is to store generic functions shared by frontend and backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/Makefile.objs | 2 +- hw/xen/x

[Xen-devel] [PATCH v2 05/13] xen: Move evtchn functions to xen_pvdev.c

The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 35 --- hw/xen/xen_pvdev.c

Re: [Xen-devel] [PATCH 02/15] xen: Fix coding style warnings

On Tue, Oct 11, 2016 at 5:20 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote: >> Fixes: >> * WARNING: line over 80 characters >> >> Signed-off-by: Emil Condrea <emilcond...@gmail.com> >&

Re: [Xen-devel] [PATCH 01/15] xen: Fix coding style errors

warnings" patch. On Tue, Oct 11, 2016 at 4:56 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Tue, Oct 04, 2016 at 09:43:30AM +0300, Emil Condrea wrote: >> Fixes the following errors: >> * ERROR: line over 90 characters > > It's 80 ;), and there are a f

Re: [Xen-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed

On Tue, Oct 4, 2016 at 11:06 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 04/10/2016 08:43, Emil Condrea wrote: >> xen_be_frontend_changed -> xen_fe_frontend_changed > > This is not correct. The front-end is implemented in the guest domain, >

Re: [Xen-devel] [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)

1PM +0300, Emil Condrea wrote: >> Emil Condrea (19): >> xen: Create a new file xen_pvdev.c >> xen: Create a new file xen_frontend.c >> xen: Move xenstore_update to xen_pvdev.c >> xen: Move evtchn functions to xen_pvdev.c >> xen: Prepare xendev qtail

[Xen-devel] [PATCH 05/15] xen: Move xenstore_update to xen_pvdev.c

* xenstore_update -> xen_pvdev.c * xenstore_update_fe -> xen_frontend.c Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 43 +-- hw/xen/xen_frontend.c | 18 ++ hw/xen

[Xen-devel] [PATCH 12/15] xen: Rename xen_be_evtchn_event

Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files changed, 3 i

[Xen-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed

xen_be_frontend_changed -> xen_fe_frontend_changed Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_frontend.c | 4 ++-- include/hw/xen/xen_frontend.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Xen-devel] [PATCH 14/15] xen: Rename xen_be_del_xendev

Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files changed, 3 inserti

[Xen-devel] [PATCH 10/15] xen: Rename xen_be_unbind_evtchn

Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 2 +- hw/char/xen_console.c | 2 +- hw/display/xenfb.c | 2 +- hw/net/

[Xen-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions

The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 49 - hw/xen/xen_pvdev.c

[Xen-devel] [PATCH 11/15] xen: Rename xen_be_send_notify

Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 4 ++-- hw/char/xen_console.c | 4 ++-- hw/display/xenfb.c | 8 hw/net/

[Xen-devel] [PATCH 03/15] xen: Create a new file xen_pvdev.c

The purpose of the new file is to store generic functions shared by frontend and backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/Makefile.objs | 2 +- hw/xen/x

[Xen-devel] [PATCH 13/15] xen: Rename xen_be_find_xendev

Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/display/xenfb.c | 4 ++-- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pv

[Xen-devel] [PATCH 09/15] xen: Rename xen_be_printf to xen_pv_printf

Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 58 +++--- hw/char/xen_console.c | 10 hw/displa

[Xen-devel] [PATCH 01/15] xen: Fix coding style errors

Fixes the following errors: * ERROR: line over 90 characters * ERROR: code indent should never use tabs * ERROR: space prohibited after that open square bracket '[' * ERROR: do not initialise statics to 0 or NULL * ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Em

[Xen-devel] [PATCH 00/15] Refactor common part of xen backend and frontend

to xen_pvdev file. Emil Condrea (15): xen: Fix coding style errors xen: Fix coding style warnings xen: Create a new file xen_pvdev.c xen: Create a new file xen_frontend.c xen: Move xenstore_update to xen_pvdev.c xen: Move evtchn functions to xen_pvdev.c xen: Prepare xendev qtail to be shared

[Xen-devel] [PATCH 02/15] xen: Fix coding style warnings

Fixes: * WARNING: line over 80 characters Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c | 3 ++- hw/char/xen_console.c| 6 -- hw/display/xenfb.c | 30 -- hw/net/xen_nic.c | 12 --

[Xen-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c

Its purpose is to store frontend related functions. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c | 1 + hw/display/xenfb.c| 1 + hw/net/xen_nic.c | 1 + hw/u

[Xen-devel] [PATCH 07/15] xen: Prepare xendev qtail to be shared with frontends

* move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 51 +- hw/xen/xen_pvdev.c

[Xen-devel] [PATCH 06/15] xen: Move evtchn functions to xen_pvdev.c

The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 35 --- hw/xen/xen_pvdev.c

Re: [Xen-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure

On Mon, Jul 25, 2016 at 7:01 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > > On Sun, Jul 10, 2016 at 02:47:46PM +0300, Emil Condrea wrote: > > This patch adds infrastructure for xen front drivers living in qemu, > > so drivers don't need to implement common s

Re: [Xen-devel] [Qemu-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)

Thanks Anthony for the feedback. I will send v10 containing fixes for patches 1 to 12 + additional patches for fixing code style issues for moved code. On Mon, Jul 25, 2016 at 5:09 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Sun, Jul 10, 2016 at 02:47:31PM +0300, Emi

Re: [Xen-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c

On Mon, Jul 25, 2016 at 4:53 PM, Anthony PERARD <anthony.per...@citrix.com> wrote: > On Sun, Jul 10, 2016 at 02:47:35PM +0300, Emil Condrea wrote: > > The name of the functions moved: > > * xen_be_evtchn_event > > * xen_be_unbind_evtchn > > * xen_be_send_n

Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

Sure, I will continue to send revisions until it is approved upstream. On Jul 22, 2016 5:24 PM, "Quan Xu" wrote: > Anthony, thanks for your explaination. > IMO, patch 1 and patch 2 need your detailed review.. IMO the reset > patches are good in general.. > Emil, if patch 1

Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

s to store generic functions shared by > frontendand backends such as xenstore operations, xendevs. > > > > s/frontendand/front end and/ > > Please wrap your commit message lines. Since 'git log' displays logs > with indentation, wrapping around 72 characters is ideal. > > > Sig

Re: [Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

xen_backend with refactoring in the same patch. Eventually this can be done in another patch later. > > > The purpose of the new file is to store generic functions shared by frontend > and backends such as xenstore operations, xendevs. > > Signed-off-by: Quan Xu <quan.xu@

[Xen-devel] [PATCH 06/19] xen: Rename xen_be_printf to xen_pv_printf

Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 52 +++--- hw/char/xen_console.c | 10 - hw/displa

[Xen-devel] [PATCH 05/19] xen: Prepare xendev qtail to be shared with frontends

* move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 70 +--- hw/xen/xen_pvdev.c

[Xen-devel] [PATCH 03/19] xen: Move xenstore_update to xen_pvdev.c

* xenstore_update -> xen_pvdev.c * xenstore_update_fe -> xen_frontend.c Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 43 +-- hw/xen/xen_frontend.c | 18 ++ hw/xen

[Xen-devel] [PATCH 16/19] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

[...] -->xen_fe_register("vtpm", ...) -->xenstore_fe_scan() -->xen_fe_try_init(ops) --> XenDevOps.init() -->xen_fe_get_xendev() --> XenDevOps.alloc() -->xen_fe_check() -->xen_fe_try_initialise() --> XenDevOp

[Xen-devel] [PATCH 17/19] Qemu-Xen-vTPM: Move tpm_passthrough_is_selftest() into tpm_util.c

Also rename it to tpm_util_is_selftest(). Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com> --- hw/tpm/Makefile.objs | 2 +- hw/tpm/tpm_passthrough.c | 13 +

[Xen-devel] [PATCH 14/19] Qemu-Xen-vTPM: Support for Xen stubdom vTPM command line options

Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- Changes in v9: * Replace `type` with `struct` as required by 895a2a80e * Change `qpm_query_tpm_inst` as required by ce21131a0 --- con

[Xen-devel] [v9 00/19] QEMU:Xen stubdom vTPM for HVM virtual machine(QEMU Part)

) Emil Condrea (19): xen: Create a new file xen_pvdev.c xen: Create a new file xen_frontend.c xen: Move xenstore_update to xen_pvdev.c xen: Move evtchn functions to xen_pvdev.c xen: Prepare xendev qtail to be shared with frontends xen: Rename xen_be_printf to xen_pv_printf xen: Rename

[Xen-devel] [PATCH 01/19] xen: Create a new file xen_pvdev.c

The purpose of the new file is to store generic functions shared by frontend and backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/Makefile.objs | 2 +- hw/xen/x

[Xen-devel] [PATCH 08/19] xen: Rename xen_be_send_notify

Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 4 ++-- hw/char/xen_console.c | 4 ++-- hw/display/xenfb.c | 8 hw/net/

[Xen-devel] [PATCH 12/19] xen: Rename xen_be_frontend_changed

xen_be_frontend_changed -> xen_fe_frontend_changed Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_frontend.c | 4 ++-- include/hw/xen/xen_frontend.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Xen-devel] [PATCH 10/19] xen: Rename xen_be_find_xendev

Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/display/xenfb.c | 4 ++-- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pv

[Xen-devel] [PATCH 11/19] xen: Rename xen_be_del_xendev

Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files changed, 3 inserti

[Xen-devel] [PATCH 04/19] xen: Move evtchn functions to xen_pvdev.c

The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 37 + hw/xen/xen_pvdev.c

[Xen-devel] [PATCH 09/19] xen: Rename xen_be_evtchn_event

Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files changed, 3 i

[Xen-devel] [PATCH 18/19] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backend

, "-tpmdev xenstubdoms,id=xenvtpm0 -device tpm-tis,tpmdev=xenvtpm0" Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com> --- Changes in v9: * added reset_tpm_establis

[Xen-devel] [PATCH 13/19] xen: Distinguish between frontend and backend devops

xen_be_check_state should not be called for frontends Use DEVOPS_FLAG_FE flag to distinguish a frontend. Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Quan Xu <quan...@intel.com> --- Changes in v9: * Removed not needed strstr from xenstore_update_be It was le

[Xen-devel] [PATCH 02/19] xen: Create a new file xen_frontend.c

Its purpose is to store frontend related functions. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c | 1 + hw/display/xenfb.c| 1 + hw/net/xen_nic.c | 1 + hw/xen/M

[Xen-devel] [PATCH 19/19] Qemu-Xen-vTPM: QEMU machine class is initialized before tpm_init()

make sure QEMU machine class is initialized and QEMU has registered Xen stubdom vTPM driver when call tpm_init() Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> Reviewed-by: Stefan Berger <stef...@linux.vnet.ibm.com&

[Xen-devel] [PATCH 15/19] Qemu-Xen-vTPM: Xen frontend driver infrastructure

channel between the virtual machines. Call xen_fe_register() function to register XenDevOps, and make sure, XenDevOps's flags is DEVOPS_FLAG_FE, which is flag bit to point out the XenDevOps is Xen frontend. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <

[Xen-devel] [PATCH 07/19] xen: Rename xen_be_unbind_evtchn

Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea <emilcond...@gmail.com> --- hw/block/xen_disk.c| 2 +- hw/char/xen_console.c | 2 +- hw/display/xenfb.c | 2 +- hw/net/

Re: [Xen-devel] vTPM issues

if that might solve the problem. Thanks a lot for your reply again. -- *De:* Emil Condrea emilcond...@gmail.com *Enviado:* jueves, 25 de junio de 2015 11:22 *Para:* Marcos Simó Picó *Cc:* xen-devel@lists.xen.org *Asunto:* Re: [Xen-devel] vTPM issues Sorry

Re: [Xen-devel] vTPM issues

I guess you are using pv guests, I don't know exactly if Quan finished development for hvm. I suggest to take a look at tcsd log: pkill tcsd tcsd -f tpm_takeownership -z -y -l debug Also can you see if /sys/devices/vtpm-0 and /dev/tpm0 are present? On Wed, Jun 24, 2015 at 6:16 PM, Marcos Simó

Re: [Xen-devel] vTPM issues

, /sys/devices/vtpm-0 is present, but /etc/tpm0 is not. Thanks for your reply. -- *De:* Emil Condrea emilcond...@gmail.com *Enviado:* jueves, 25 de junio de 2015 10:21 *Para:* Marcos Simó Picó *Cc:* xen-devel@lists.xen.org; Xu, Quan *Asunto:* Re: [Xen-devel

Re: [Xen-devel] [PATCH v3 0/2] vtpm deep quote in locality 0

Thank you! On Thu, Apr 16, 2015 at 5:10 PM, Ian Campbell ian.campb...@citrix.com wrote: On Wed, 2015-04-15 at 21:00 +0300, Emil Condrea wrote: Changes from v2: - removed useless whitespace - fixed compiling issues for tpm emulator Applied, thanks

Re: [Xen-devel] [PATCH v2 1/2] vtpm: deep quote flags

Thanks! Should it remove it and resend the patches ? On Wed, Apr 15, 2015 at 6:07 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 04/14/2015 05:08 AM, Emil Condrea wrote: Currently, the flags are not interpreted by vTPM. They are just packed and sent to vtpmmgr. Signed-off-by: Emil

[Xen-devel] [PATCH v3 0/2] vtpm deep quote in locality 0

the flexibility of the request. It is simple to define additional flags and add data to the hash if needed. Emil Condrea (2): vtpm: deep quote flags vtpmmgr: execute deep quote in locality 0 stubdom/Makefile| 1 + stubdom/vtpm-deepquote-anyloc.patch | 127

Re: [Xen-devel] [PATCH v2 1/2] vtpm: deep quote flags

: On Wed, 2015-04-15 at 16:34 +0100, Ian Campbell wrote: On Wed, 2015-04-15 at 18:09 +0300, Emil Condrea wrote: Thanks! Should it remove it and resend the patches ? I'll do it on commit (which I'm about to do). Except: stubdom/tpm_emulator-x86_64/tpm/tpm_cmd_handler.c: In function

[Xen-devel] [PATCH v3 2/2] vtpmmgr: execute deep quote in locality 0

values are appended. Signed-off-by: Emil Condrea emilcond...@gmail.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- stubdom/vtpmmgr/marshal.h | 1 + stubdom/vtpmmgr/mgmt_authority.c | 91 ++ stubdom/vtpmmgr/mgmt_authority.h | 2 +- stubdom

[Xen-devel] [PATCH v3 1/2] vtpm: deep quote flags

Currently, the flags are not interpreted by vTPM. They are just packed and sent to vtpmmgr. Signed-off-by: Emil Condrea emilcond...@gmail.com Acked-by: Daniel De Graaf dgde...@tycho.nsa.gov --- stubdom/Makefile| 1 + stubdom/vtpm-deepquote-anyloc.patch | 127

[Xen-devel] [PATCH v2 0/2] vtpm deep quote in locality 0

if needed. Emil Condrea (2): vtpm: deep quote flags vtpmmgr: execute deep quote in locality 0 stubdom/Makefile| 1 + stubdom/vtpm-deepquote-anyloc.patch | 127 stubdom/vtpm/vtpm_cmd.c | 13 ++-- stubdom/vtpmmgr/marshal.h

[Xen-devel] [PATCH v2 1/2] vtpm: deep quote flags

Currently, the flags are not interpreted by vTPM. They are just packed and sent to vtpmmgr. Signed-off-by: Emil Condrea emilcond...@gmail.com --- stubdom/Makefile| 1 + stubdom/vtpm-deepquote-anyloc.patch | 127 stubdom/vtpm/vtpm_cmd.c

[Xen-devel] [PATCH 0/2] vtpm deep quote in locality 0

it into PCRs. This change also has the benefit of increasing the flexibility of the request. It is simple to define additional flags and add data to the hash if needed. Emil Condrea (2): vtpm: deep quote flags vtpmmgr: execute deep quote in locality 0 stubdom/Makefile| 1

[Xen-devel] [PATCH 2/2] vtpmmgr: execute deep quote in locality 0

if requested] ) Signed-off-by: Emil Condrea emilcond...@gmail.com --- stubdom/vtpmmgr/marshal.h | 1 + stubdom/vtpmmgr/mgmt_authority.c | 89 ++ stubdom/vtpmmgr/mgmt_authority.h | 2 +- stubdom/vtpmmgr/vtpm_cmd_handler.c | 7 ++- stubdom/vtpmmgr

[Xen-devel] [PATCH 1/2] vtpm: deep quote flags

Currently, the flags are not interpreted by vTPM. They are just packed and sent to vtpmmgr. The new implementation is backward compatible, if it receives a request without flags, it continues the request to vtpmmgr with extraInfoFlags=0. Signed-off-by: Emil Condrea emilcond...@gmail.com

Re: [Xen-devel] vTPM Deep Quote validation

, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 03/09/2015 11:58 AM, Emil Condrea wrote: On Mon, Mar 9, 2015 at 4:40 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 03/08/2015 07:41 AM, Emil Condrea wrote: I am trying to validate a Deep Quote request made by domU but I feel

Re: [Xen-devel] vTPM Deep Quote validation

On Mon, Mar 9, 2015 at 4:40 PM, Daniel De Graaf dgde...@tycho.nsa.gov wrote: On 03/08/2015 07:41 AM, Emil Condrea wrote: I am trying to validate a Deep Quote request made by domU but I feel that something is missing. Right now when a domU requests TPM_ORD_DeepQuote: 1. vTPM: - unpacks

Re: [Xen-devel] vTPM Deep Quote validation

] *On Behalf Of *Emil Condrea *Sent:* Sunday, March 08, 2015 7:41 PM *To:* xen-devel@lists.xen.org *Cc:* Daniel De Graaf *Subject:* [Xen-devel] vTPM Deep Quote validation I am trying to validate a Deep Quote request made by domU but I feel that something is missing. Right now when a domU requests