Re: [Xen-devel] [PATCH 10/12] xen-blkback: Fix indentation

2017-08-18 Thread Hannes Reinecke
count; > } > > static void xen_blkbk_unmap_and_respond_callback(int result, struct > gntab_unmap_queue_data *data) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [Xen-devel] [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1

2017-08-18 Thread Hannes Reinecke
> - /* fall through if not online */ > + /* fall through */ > + /* if not online */ > case XenbusStateUnknown: > /* implies xen_blkif_disconnect() via xen_blkbk_remove() */ > device_unregister(>dev); >

Re: [Xen-devel] [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data

2017-05-24 Thread Hannes Reinecke
/scsi/xen-scsifront.c > @@ -534,7 +534,6 @@ static int scsifront_queuecommand(struct Scsi_Host *shost, > int err; > > sc->result = 0; > - memset(shadow, 0, sizeof(*shadow)); > > shadow->sc = sc; > shadow->act = VSCSIIF_ACT_SCSI_CDB; &