Re: [Xen-devel] [PATCH] mini-os: add config item for printing via hypervisor

> - of standard dom0 handled console */ Please keep this comment somewhere, probably here: > CONFIG_BALLOON ?= n > +CONFIG_USE_XEN_CONSOLE ?= n apart from that, Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Samuel ___

Re: [Xen-devel] [MINIOS PATCH v2] Include string.h before console.h

Wei Liu, on mer. 04 oct. 2017 14:51:26 +0100, wrote: > Starting from Xen commit af8d93564, it is required to include string.h > before console.h. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > ---

Re: [Xen-devel] [MINIOS PATCH] Include string.h before console.h

Wei Liu, on mer. 04 oct. 2017 14:33:36 +0100, wrote: > Starting from Xen commit af8d93564, it is required to include string.h > before console.h. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > ---

Re: [Xen-devel] [Minios-devel] [MirageOS-devel] [Xen-API] [RFC] Unicore Subproject Proposal

Hello, Anil Madhavapeddy, on jeu. 14 sept. 2017 15:38:54 +0100, wrote: > On 13 Sep 2017, at 17:13, Samuel Thibault <samuel.thiba...@ens-lyon.org> > wrote: > > Anil Madhavapeddy, on mer. 13 sept. 2017 11:11:03 +0100, wrote: > >> Maintaining a forked MiniOS h

Re: [Xen-devel] [Minios-devel] [Xen-API] [RFC] Unicore Subproject Proposal

Hello, Anil Madhavapeddy, on mer. 13 sept. 2017 11:11:03 +0100, wrote: > Maintaining a forked MiniOS has been a multi-year source of a maintenance > burden for MirageOS, I'm just wondering why this happened? The mini-os repository is open for development, it's just a matter of agreeing on how

Re: [Xen-devel] [Minios-devel] [RFC] Unicore Subproject Proposal

Hello, I'm all for it :) I won't have time to spend for contributions, but I can probably answer questions about the existing source code, challenges with stubdomains etc. The only thing I'd worry about is to be clear on the scope of Unicore: we don't want to just create another Linux kernel.

Re: [Xen-devel] [MINIOS PATCH] lib/math.c: implement __udivmoddi4

Wei Liu, on mer. 09 août 2017 13:15:48 +0100, wrote: > Some code compiled by gcc 7 requires this. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > lib/math.c | 10 ++ > 1 file changed, 10

Re: [Xen-devel] [PATCH for-4.9 v2] build: stubdom and tools should depend on public header target

d-by: Steven Haigh <net...@crc.id.au> > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Cc: Steven Haigh <net...@crc.id.au> > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Samuel Thib

Re: [Xen-devel] [PATCH for-4.9 2/2] build: fix tools/include and stubdom build

g absolute paths in tools/include Makefile. Provide > mechanism to override the prefix in paths. Use that mechanism in > stubdom build to reduce code duplication. > > Reported-by: Steven Haigh <net...@crc.id.au> > Signed-off-by: Wei Liu <wei.l...@citrix.com&

Re: [Xen-devel] [GSoc] Adding Floating Point support to Mini-OS

Hello, Felix Schmoll, on mer. 29 mars 2017 20:53:14 +0200, wrote: > -While implementing our own kernel last semester me and my team-mate > came to believe that pusha/popa were faster that pushing/popping the > individual registers, since it is just a single command. The Mini-OS > kernel however

Re: [Xen-devel] [PATCH] Include libxendevicemodel with libxc

y: Paul Durrant <paul.durr...@citrix.com> > Cc: Samuel Thibault <samuel.thiba...@ens-lyon.org> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 74f

Re: [Xen-devel] [PATCH 1/4] tools/libxendevicemodel: introduce the new library

mit;h=41c9f2ae > > > > > > > > > > > Need an ack from Samuel Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3] stubdom: modify ioemu linkfarm only if necessary

fied by each "make tools" call. > > This can be avoided by writing stubdom/ioemu/linkfarm.stamp only if > a source file beneath tools/qemu-xen-traditional-dir has been added > or removed. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Acked-by: Wei Liu &l

Re: [Xen-devel] [MINIOS PATCH] build: prepend OBJ_DIR to linker script

t; Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [Xen-users] pvgrub: Error 9: Unknown boot failure

Hello, Jan Beulich, on Wed 07 Dec 2016 09:28:52 -0700, wrote: > > Right. Jan, could you please include the patch for 4.7.2? Upstream > > commit was 9714f6b87e19b32d3a6663a20df6610265c4bfe5. > > Samuel, could you confirm that this is okay to backport. For 4.7, yes. > In which case the question

Re: [Xen-devel] [PATCH] stubdom: remove EXTRA_CFLAGS meant for building tools

S=MiniOS > > > > +# Remove flags which are meant for tools, e.g. "-m64" > > +export EXTRA_CFLAGS_XEN_TOOLS= > > +export EXTRA_CFLAGS_QEMU_TRADITIONAL= > > + > > I can't think of a better way to deal with this. This is in line with > how it is done in firmware build, so

Re: [Xen-devel] [PATCH] stubdom: simplify and fix Makefile

too. > > At the same time don't repeat the same link pattern 7 times but use a > make macro to do the linking. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > stubdom/Makefile | 77 > +++

Re: [Xen-devel] [PATCH] stubdom: fix "make distclean" regarding gmp

Juergen Gross, on Fri 28 Oct 2016 16:53:20 +0200, wrote: > make distclean tries to remove stubdom/gmp-4.3.2.tar.gz, while the > downloaded file is stubdom/gmp-4.3.2.tar.bz2 > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.

Re: [Xen-devel] [PATCH for-4.8] stubdom: make GMP aware that it's being cross-compiled

led for another architecture. > > > > This should fix the issue that GMP doesn't compile with gcc 6, because > > configure script won't try to test the host environment anymore. > > Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-l

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

Jan Beulich, on Mon 24 Oct 2016 07:12:27 -0600, wrote: > And btw - is it really qemu that does this? It's pciaccess which does it. > I didn't think it would be a user space app doing any such sizing; I > thought this would get done elsewhere in stubdom/mini-os. mini-os just lets libpciaccess

Re: [Xen-devel] PCI passthrough to QEMU traditional stubdom not working when option ROM present

Hello, Eric Shelton, on Fri 21 Oct 2016 09:01:43 -0400, wrote: > ERROR: PCI region size must be pow2 type=0x8, size=0xdf08 > u32 u = pci_read_long(d, reg); > if (u != 0x) > - d->rom_base_addr = u; > +{ > + d->rom_base_addr = u; >

Re: [Xen-devel] [PATCH 0/3] Fix PCI passthrough for HVM with stubdomain

Hello, Marek Marczykowski-Górecki, on Tue 18 Oct 2016 03:53:30 +0200, wrote: > This series is follow up to previous attempts to fix this. Related threads: > - http://markmail.org/thread/dwjcdfk3y7s5c5kl "PCI passthrough with > stubdomain" > - http://xen.markmail.org/thread/l7tvqcxbiyc2grvr

Re: [Xen-devel] [PATCH] minios: fix build issue with xen_*mb defines

xc_private.h. > > Fix this by defining the macros only if compiling a minios source. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > include/x86/os.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [Xen-devel] [PATCH] pvgrub: use printk() instead of grub_printf()

rgen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > stubdom/grub/kexec.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/stubdom/grub/kexec.c b/stubdom/grub/kexec.c > index 8fd9ff9

Re: [Xen-devel] [PATCH] minios: make mini-os_app.o depend on included xen libraries

for linking mini-os_app.o to avoid > a linker warning. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Makefile | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > dif

Re: [Xen-devel] PCI passthrough with stubdomain

Marek Marczykowski-Górecki, on Fri 23 Sep 2016 20:56:43 +0200, wrote: > 1. How to do this? ;) I.e. what synchronization primitives are available > in mini-os? Just pthread_mutex_lock/unlock? pthread_mutex_lock are nops :o) because we don't have pthread_create. But for mini-os itself there are

Re: [Xen-devel] PCI passthrough with stubdomain

Marek Marczykowski-Górecki, on Fri 23 Sep 2016 16:25:41 +0200, wrote: > On Fri, Sep 23, 2016 at 03:27:07PM +0200, Samuel Thibault wrote: > > Marek Marczykowski-Górecki, on Fri 23 Sep 2016 10:48:14 +0200, wrote: > > > I'm still trying to get PCI passthrough working with stubdomain

Re: [Xen-devel] PCI passthrough with stubdomain

Marek Marczykowski-Górecki, on Fri 23 Sep 2016 10:48:14 +0200, wrote: > I'm still trying to get PCI passthrough working with stubdomain and > without qemu in dom0 (even for just vfb/vkbd backends). How is this > supposed to work? Just as I recall from my memory: > 1. Should xen-pcifront in the

Re: [Xen-devel] [MINIOS PATCH] Add travis.yml and travis-build script

Wei Liu, on Mon 05 Sep 2016 15:43:21 +0100, wrote: > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > See: > https://travis-ci.org/liuw/mini-os/builds/157653746 > > Cc: Samuel Thibault <samuel.thi

Re: [Xen-devel] [PATCH] mini-os: add comments in Config.mk regarding new config options

Juergen Gross, on Mon 05 Sep 2016 13:43:30 +0200, wrote: > Add some comment in Config.mk what to do in case of adding new config > options. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- >

Re: [Xen-devel] [PATCH 2/3] mini-os: add testbuild target to Makefile

ons found there are built in > a local directory. Please also document just above the CONFIG_* lines in Config.mk that new CONFIG options should be set in all-* testbuilds. > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault &

Re: [Xen-devel] [PATCH 1/3] mini-os: fix builds with uncommon config settings

Juergen Gross, on Fri 02 Sep 2016 10:56:45 +0200, wrote: > Some config settings won't build standalone. Fix the following cases: > > - all CONFIG_* set to "n" > - standard config with latest Xen interface version > > Signed-off-by: Juergen Gross <jgr...@suse.com

Re: [Xen-devel] [PATCH 3/3] mini-os: support "make config" for out-of-tree users

Juergen Gross, on Fri 02 Sep 2016 07:42:36 +0200, wrote: > I think I'll add a new make target "test" which will test different > build configurations (PARAVIRT y/n, BALLOON y/n, 32/64 bit, Xen > interface versions, all/no frontends). This can be easily added to > OSStest. Good, thanks. Samuel

Re: [Xen-devel] [Minios-devel] [PATCH 3/3] mini-os: support "make config" for out-of-tree users

y: Juergen Gross <jgr...@suse.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/3] mini-os: support "make config" for out-of-tree users

Hello, Juergen Gross, on Thu 01 Sep 2016 08:21:33 +0200, wrote: > I stumbled over the problem with xenstore-stubdom: xenstore is using > __XEN_LATEST_INTERFACE_VERSION__ when being compiled. This produced a > build error with Mini-OS (console_evtchn in include/console.h was > #define'd to

Re: [Xen-devel] [PATCH 3/3] mini-os: support "make config" for out-of-tree users

Hello, Juergen Gross, on Tue 30 Aug 2016 13:51:23 +0200, wrote: > @@ -51,7 +51,7 @@ endif > > libc = $(stubdom) > > -XEN_INTERFACE_VERSION := 0x00030205 > +XEN_INTERFACE_VERSION ?= 0x00030205 Why making it overridable? AIUI changing the version would change the xen headers API, and thus

Re: [Xen-devel] [Minios-devel] [PATCH 2/3] mini-os: provide irq on/off/save/restore functions for Mini-OS apps

, and applications may want to implement some such... > >> Signed-off-by: Juergen Gross <jgr...@suse.com> > > > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/3] mini-os: support newer xen interface

Gross <jgr...@suse.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

the start_info structure, but make it dependent on > CONFIG_PARAVIRT. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/setup.c | 12 > include/hypervisor.h | 13 +++

Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

Samuel Thibault, on Mon 29 Aug 2016 22:49:07 +0200, wrote: > Juergen Gross, on Mon 29 Aug 2016 16:18:26 +0200, wrote: > > +union start_info_union > > +{ > > +start_info_t start_info; > > +char padding[512]; > > +}; > > Why defining a union? 512 is ac

Re: [Xen-devel] [PATCH v2 1/2] mini-os: partially revert "remove using start_info ..."

Hello, Juergen Gross, on Mon 29 Aug 2016 16:18:26 +0200, wrote: > +union start_info_union > +{ > +start_info_t start_info; > +char padding[512]; > +}; Why defining a union? 512 is actually not enough for start_info_t. Samuel ___ Xen-devel

Re: [Xen-devel] [PATCH 2/2] mini-os: don't get xenbus parameters if xenbus is disabled

Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [MINIOS PATCH 1/3] Makefile: simplify all_sources macro

Juergen Gross, on Mon 29 Aug 2016 15:07:20 +0200, wrote: > On 29/08/16 15:01, Wei Liu wrote: > > There is no SCCS file. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel

Re: [Xen-devel] [MINIOS PATCH 3/3] gitignore: ignore files generated by various indexing software

Juergen Gross, on Mon 29 Aug 2016 15:07:55 +0200, wrote: > On 29/08/16 15:01, Wei Liu wrote: > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault &l

Re: [Xen-devel] [MINIOS PATCH 2/3] Makefile: add gtags target

Juergen Gross, on Mon 29 Aug 2016 15:07:39 +0200, wrote: > On 29/08/16 15:01, Wei Liu wrote: > > Use GNU Global to generate source code index. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross <jgr...@suse.com> Acked-b

Re: [Xen-devel] [PATCH v2 2/3] mini-os: cleanup x86_64.S

of CONFIG_PARAVIRT defined. > > > > Remove the parameter from HYPERVISOR_IRET macro as it is used with > > 0 only. > > > > Signed-off-by: Juergen Gross <jgr...@suse.com> > > Reviewed-by: Wei Liu <wei.l

Re: [Xen-devel] [PATCH 3/3] mini-os: remove unused functions from sched.c

Juergen Gross, on Fri 26 Aug 2016 16:35:36 +0200, wrote: > sched.c contains some functions nobody is using. Remove them. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>

Re: [Xen-devel] [PATCH 1/3] mini-os: cleanup x86_32.S

Juergen Gross, on Fri 26 Aug 2016 16:35:34 +0200, wrote: > arch/x86/x86_32.S has some superfluous instructions. Remove them. > > Signed-off-by: Juergen Gross <jgr...@suse.com> These are indeed remnants from the past. Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org&g

Re: [Xen-devel] [MINIOS PATCH 0/5] x86 assmebly code clean up

ies For the whole series, Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [Minios-devel] [PATCH 17/22] mini-os: add get_cmdline() function

rgen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/setup.c | 20 ++-- > include/kernel.h | 3 +++ > kernel.c | 1 + > main.c | 5 +++-- > 4 files changed, 25 insertions(+), 4 dele

Re: [Xen-devel] [PATCH 22/22] mini-os: support idle for HVMlite

imer in the timer handler as there is no > guarantee the original timer event we are waiting for won't fire > between enabling interrupts and calling "hlt". > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>

Re: [Xen-devel] [PATCH 21/22] mini-os: get physical memory map

with a maximum > memory size. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/mm.c | 8 ++ > arch/x86/mm.c | 72 ++ >

Re: [Xen-devel] [PATCH 20/22] mini-os: print start of day messages depending on domain type

", (unsigned long)si->modlist_paddr); It would be useful to also print nr_modules. > +printk(" flags: 0x%x\n", (unsigned int)si->flags); > +printk("cmd_line: %s\n", cmdline); > +printk(" stack: %p-%p\n", stack, stac

Re: [Xen-devel] [PATCH 19/22] mini-os: remove using start_info in architecture independent code

; > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/setup.c | 8 > arch/x86/setup.c | 8 > daytime.c| 2 +- > include/hypervisor.h | 11 ---

Re: [Xen-devel] [PATCH 18/22] mini-os: map shared info page for HVMlite

Juergen Gross, on Tue 23 Aug 2016 17:16:04 +0200, wrote: > Add a service function to map the shared info page on a > non-paravirtualized system. The code is already existing on ARM side, > just move it to hypervisor.c. > > Signed-off-by: Juergen Gross <jgr...@suse.com>

Re: [Xen-devel] [PATCH 16/22] mini-os: setup xenbus interface parameters

de a similar paravirtualized function. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/setup.c | 16 +--- > arch/x86/setup.c | 1 + > events.c | 3 +-- > inclu

Re: [Xen-devel] [PATCH 15/22] mini-os: setup console interface parameters

de a similar paravirtualized function. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/setup.c | 16 +--- > arch/x86/setup.c

Re: [Xen-devel] [PATCH 14/22] mini-os: add map_frame_virt() function

make this area > available even in case of undefined CONFIG_BALLOON. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/balloon.c| 2 -- > arch/arm/mm.c | 5 + > arch/x86/

Re: [Xen-devel] [PATCH 12/22] mini-os: add x86 native page table handling

Juergen Gross, on Tue 23 Aug 2016 17:15:58 +0200, wrote: > For support of HVMlite don't use mmu_update hypercalls, but write the > page table entries directly. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>

Re: [Xen-devel] [PATCH 11/22] mini-os: add static page tables for virtual kernel area for HVMlite

e tables needed for doing the mapping. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/mm.c | 11 +++ > arch/x86/x86_64.S | 7 +++ > 2 files changed, 18 insertions(+) > >

Re: [Xen-devel] [PATCH 10/22] mini-os: make p2m related code depend on CONFIG_PARAVIRT

avirtualized environments. Instead of using > references to start_info use dedicated variables initialized from > start_info on boot. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/balloon.

Re: [Xen-devel] [PATCH 09/22] mini-os: support HVMlite traps

Juergen Gross, on Tue 23 Aug 2016 17:15:55 +0200, wrote: > Trap handling in HVMlite domain is different from pv one. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/traps.c | 2 -

Re: [Xen-devel] [PATCH 08/22] mini-os: initialize trap handling for HVMlite

Juergen Gross, on Tue 23 Aug 2016 17:15:54 +0200, wrote: > Trap handling for HVMlite domains requires an initialized IDT. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/setup.c | 15 ---

Re: [Xen-devel] [PATCH 07/22] mini-os: support hvm_op hypercall

Juergen Gross, on Tue 23 Aug 2016 17:15:53 +0200, wrote: > Support the HYPERVISOR_hvm_op() hypercall which is needed for HVMlite. > Add convenience functions hvm_get_parameter() and hvm_set_parameter(). > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thib

Re: [Xen-devel] [PATCH 06/22] mini-os: setup hypercall page for HVMlite

t; -#else /* ifdef __x86_64__ */ > -#error "Unsupported architecture" > -#endif > #endif /* ifdef __INSIDE_MINIOS */ Then please move it after > /* common i386 and x86_64 / This line :) Apart from that, Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 05/22] mini-os: add boot code for HVMlite support

Hello, It looks good, there is just: Juergen Gross, on Tue 23 Aug 2016 17:15:51 +0200, wrote: > +.macro PTES prot, addr, incr, idx, end Please document what prot, addr, incr, idx, end represent precisely. > +.ifgt \end-\idx-32 > +PTES \prot, \addr, \incr, \idx,

Re: [Xen-devel] [PATCH 03/22] mini-os: add CONFIG_PARAVIRT

osen as the arm port can then drop some dummy routines needed for > para-virtualization only. > > Add include/paravirt.h for furute support of paravirt specific > handling. future* > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thi

Re: [Xen-devel] [PATCH 13/22] mini-os: correct wrong calculation of alloc bitmap size

nevertheless. Oops, indeed! > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > balloon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/balloon.c b/balloon.c > in

Re: [Xen-devel] [PATCH 04/22] mini-os: make some memory management related macros usable from assembler

e. > > Hide some C prototypes when in assembler environment. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > include/x86/arch_mm.h | 56 > +++---

Re: [Xen-devel] [PATCH 02/22] mini-os: make dump_regs() work in early boot

Juergen Gross, on Tue 23 Aug 2016 17:15:48 +0200, wrote: > dump_regs() will result in page fault in early boot as there is no > current thread pointer. Handle this case. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyo

Re: [Xen-devel] [PATCH 01/22] mini-os: resync xen headers

Juergen Gross, on Tue 23 Aug 2016 17:15:47 +0200, wrote: > Use the latest Xen headers. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > include/xen/arc

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

Juergen Gross, on Wed 17 Aug 2016 15:39:59 +0200, wrote: > Fix two issues discovered by coverity. Thanks for processing mini-os through coverity :) Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

rity: > > 1. properl mark one switch case as fall-through > 2. unroll a loop that only executes once > > CID: 1369623 > CID: 1019001 > > > > > > Signed-off-by: Juergen Gross <jgr...@suse.com> > > Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [MINIOS PATCH 3/3] x86: use unified linker script

top-level directory to cope with the change. > > Ideally the build system should also be made more elegant, but > > overhauling the build system is out of scope of this patch. > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross &l

Re: [Xen-devel] [MINIOS PATCH 2/3] x86: switch to use elfnote

Reviewed-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [MINIOS PATCH 1/3] Introduce asm_macros.h

Juergen Gross, on Thu 18 Aug 2016 12:34:48 +0200, wrote: > On 18/08/16 12:15, Wei Liu wrote: > > Ported from Xen Test Framework project (BSD license). > > > > Signed-off-by: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Juergen Gross <jgr...@suse.com>

Re: [Xen-devel] [MINIOS PATCH 2/4] Introduce asm_macros.h

Hello, Wei Liu, on Wed 17 Aug 2016 13:35:12 +0100, wrote: > Ported from xtf.git. What is xtf.git? Does it use the same BSD licencing? To my knowledge this is coming from the linux kernel source. > Signed-off-by: Wei Liu > --- > include/asm_macros.h | 36

Re: [Xen-devel] [MINIOS PATCH 1/4] gitignore: ignore vim swap file

Wei Liu, on Wed 17 Aug 2016 13:35:11 +0100, wrote: > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore &

Re: [Xen-devel] [MINIOS PATCH] lib.h: remove BUILD_BUG_ON

ttab library. > > Ideally BUILD_BUG_ON should be moved to a private header, but there is > actually no user of it in mini-os tree, just remove it. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > inc

Re: [Xen-devel] [Minios-devel] [PATCH v3 00/19] mini-os: support of auto-ballooning

to x86/mm.c > > Making that function inlined won't buy us much and is causing error in > vtpm manager stubdom build. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/mm.c | 9 + >

Re: [Xen-devel] [PATCH v3 19/19] mini-os: repair build system

the used ones > into Config.mk and delete the rest. > > The CONFIG_* defines should be set for assembler sources, too. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > Config.mk | 93 > +

Re: [Xen-devel] [PATCH v4 16/19] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

use.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > V4: - mm_bitmap* -> mm_alloc_bitmap* as requested by Samuel Thibault > > V3: - add assertion as requested by Samuel Thibault > - rename functions to have mm_ prefix as requested by Sa

Re: [Xen-devel] [PATCH v3 16/19] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

Juergen Gross, on Thu 11 Aug 2016 12:19:20 +0200, wrote: > On 11/08/16 11:40, Samuel Thibault wrote: > > Juergen Gross, on Thu 11 Aug 2016 11:18:19 +0200, wrote: > >> +extern unsigned long *mm_bitmap; > >> +extern unsigned long mm_bitmap_size; > > > &

Re: [Xen-devel] [PATCH v3 16/19] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

Juergen Gross, on Thu 11 Aug 2016 11:18:19 +0200, wrote: > +extern unsigned long *mm_bitmap; > +extern unsigned long mm_bitmap_size; Ah I was thinking to have these use mm_malloc_ too. "mm_bitmap" seems short for namespace pollution. Samuel ___

Re: [Xen-devel] [PATCH v2 00/18] mini-os: support of auto-ballooning

Hello, Juergen Gross, on Fri 05 Aug 2016 19:35:44 +0200, wrote: > Support ballooning Mini-OS automatically up in case of memory shortage. Thanks! Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 18/18] mini-os: balloon up in case of oom

mory; I would have written it > +if ( !chk_free_pages(1UL << order) ) > +goto no_memory; "If there are not enough free pages for this amount, go out". Otherwise it looks good, Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Samuel ___

Re: [Xen-devel] [PATCH v2 16/18] mini-os: map page allocator's bitmap to virtual kernel area for ballooning

It looks a bit odd to be remapping something that was just allocated, but I guess it makes portability easier. Juergen Gross, on Fri 05 Aug 2016 19:36:00 +0200, wrote: > diff --git a/balloon.c b/balloon.c > index 4c18c5c..75b87c8 100644 > --- a/balloon.c > +++ b/balloon.c > @@ -44,3 +44,20 @@

Re: [Xen-devel] [PATCH v2 15/18] mini-os: remap p2m list in case of ballooning

Juergen Gross, on Fri 05 Aug 2016 19:35:59 +0200, wrote: > +void arch_remap_p2m(unsigned long max_pfn) > +{ ... > + > +virt_kernel_area_end += PAGE_SIZE * p2m_pages(nr_max_pages); I'd however rather see an assertion against hitting VIRT_DEMAND_AREA here, even if the figures happen to make it

Re: [Xen-devel] [PATCH v2 15/18] mini-os: remap p2m list in case of ballooning

e at the end. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/balloon.c| 2 ++ > arch/x86/balloon.c| 24 > arch/x86/mm.c | 3 +++ >

Re: [Xen-devel] [PATCH v2 14/18] mini-os: move p2m related macros to header file

, as all levels share the > same entry format (a plain mfn). So reduce the number of macros > accordingly. > > Add some macros to get the indices into p2m pages from a pfn and make > use of them in current p2m code. > > Signed-off-by: Juergen Gross <jgr...@suse.com>

Re: [Xen-devel] [PATCH v2 13/18] mini-os: add function to map one frame

Juergen Gross, on Fri 05 Aug 2016 19:35:57 +0200, wrote: > Add a function to map one physical frame to a specified virtual > address as read/write. This will be used later multiple times. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault &l

Re: [Xen-devel] [PATCH v2 12/18] mini-os: don't allocate new pages for level 1 p2m tree

that purpose. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/x86/mm.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/mm.c b/arch/x86/mm.c >

Re: [Xen-devel] [PATCH v2 11/18] mini-os: add checks for out of memory

ions to succeed. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > arch/arm/mm.c | 8 > arch/x86/mm.c | 26 +++--- > include/mm.h | 2 +- > 3 files changed, 28 insertions(+)

Re: [Xen-devel] [PATCH v2 10/18] mini-os: remove unused mem_test() function

Juergen Gross, on Fri 05 Aug 2016 19:35:54 +0200, wrote: > mem_test() isn't used anywhere and its value is rather questionable > with mini-os being in a mature state. Remove the function. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Samuel Thibault &l

Re: [Xen-devel] [PATCH v2 09/18] mini-os: modify virtual memory layout for support of ballooning

in order to keep the heap at about 1GB. > > The kernel virtual mappings are a new area needed for being able to > grow the p2m list without having to relocate it in physical memory. > > Modify the placement of the demand mappings and heap and adjust the > memory layout description.

Re: [Xen-devel] [PATCH v2 08/18] mini-os: get maximum memory size from hypervisor

Juergen Gross, on Fri 05 Aug 2016 19:35:52 +0200, wrote: > Add support for obtaining the maximum memory size from the hypervisor. > This will make it possible to support ballooning. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Samuel Thibault <samuel.

Re: [Xen-devel] [PATCH v2 07/18] mini-os: add ballooning config item

Juergen Gross, on Fri 05 Aug 2016 19:35:51 +0200, wrote: > Add CONFIG_BALLOON defaulting to 'n' as a config item to Mini-OS. > > Add balloon.c, balloon.h and arch/*/balloon.c for future use. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Not much to be against here

Re: [Xen-devel] [PATCH v2 06/18] mini-os: let memory allocation fail if no free page available

Juergen Gross, on Fri 05 Aug 2016 19:35:50 +0200, wrote: > Instead of panicing when no page can be allocated try to fail the > memory allocation by returning NULL instead. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH v2 05/18] mini-os: add nr_free_pages counter

Juergen Gross, on Fri 05 Aug 2016 19:35:49 +0200, wrote: > Add a variable holding the number of available memory pages. This will > aid auto-ballooning later. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com> Acked-by: Sa

Re: [Xen-devel] [PATCH v2 04/18] mini-os: add description of x86 memory usage

Juergen Gross, on Fri 05 Aug 2016 19:35:48 +0200, wrote: > Add a brief description how the physical and virtual address usage > looks like on x86 to include/x86/arch_mm.h > > Signed-off-by: Juergen Gross <jgr...@suse.com> > Reviewed-by: Wei Liu <wei.l...@citrix.com>

  1   2   >