Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-22 Thread Wei Liu
On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > Fix two issues discovered by coverity. > Pushed with fixed up commit message. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-20 Thread Samuel Thibault
Juergen Gross, on Wed 17 Aug 2016 15:39:59 +0200, wrote: > Fix two issues discovered by coverity. Thanks for processing mini-os through coverity :) Samuel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-20 Thread Samuel Thibault
Wei Liu, on Wed 17 Aug 2016 15:13:27 +0100, wrote: > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > > Fix two issues discovered by coverity. > > I would update the commit message to make it contain more information. > > Fix two issues discovered by Coverity: > > 1. properl

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 04:25:44PM +0200, Juergen Gross wrote: > On 17/08/16 16:13, Wei Liu wrote: > > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > >> Fix two issues discovered by coverity. > > > > I would update the commit message to make it contain more information. > > > >

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Juergen Gross
On 17/08/16 16:13, Wei Liu wrote: > On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: >> Fix two issues discovered by coverity. > > I would update the commit message to make it contain more information. > > Fix two issues discovered by Coverity: > > 1. properl mark one switch case

Re: [Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Wei Liu
On Wed, Aug 17, 2016 at 03:39:59PM +0200, Juergen Gross wrote: > Fix two issues discovered by coverity. I would update the commit message to make it contain more information. Fix two issues discovered by Coverity: 1. properl mark one switch case as fall-through 2. unroll a loop that only

[Xen-devel] [PATCH] mini-os: fix coverity issues in printf.c

2016-08-17 Thread Juergen Gross
Fix two issues discovered by coverity. Signed-off-by: Juergen Gross --- lib/printf.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/lib/printf.c b/lib/printf.c index ad6a304..f9e9d68 100644 --- a/lib/printf.c +++ b/lib/printf.c