Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Andrew Cooper
On 24/10/16 10:54, Wei Liu wrote: > On Mon, Oct 24, 2016 at 03:23:01AM -0600, Jan Beulich wrote: > On 19.10.16 at 18:30, wrote: >>> c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected >>> all push %sreg instructions into the general push path.

Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Wei Liu
On Mon, Oct 24, 2016 at 03:23:01AM -0600, Jan Beulich wrote: > >>> On 19.10.16 at 18:30, wrote: > > c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected > > all push %sreg instructions into the general push path. However, this > > ends up hitting the

Re: [Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-24 Thread Jan Beulich
>>> On 19.10.16 at 18:30, wrote: > c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected > all push %sreg instructions into the general push path. However, this > ends up hitting the assertion at the head of the push path. > > Annotate All push and

[Xen-devel] [PATCH] x86/emul: Correctly annotate all push/pop %sreg instructions

2016-10-19 Thread Andrew Cooper
c/s 373923ed9c2 "x86emul: fix pushing of selector registers" redirected all push %sreg instructions into the general push path. However, this ends up hitting the assertion at the head of the push path. Annotate All push and pop %sreg instructions as Mov, indicating that they do not read the