Re: [Xen-devel] [PATCH] xen/x86/shadow: adjust barriers around gtable_dirty_version.

2017-08-18 Thread Andrew Cooper
On 18/08/17 15:23, Tim Deegan wrote: > Use the smp_ variants, as we're only synchronizing against other CPUs. > > Add a write barrier before incrementing the version. > > x86's memory ordering rules and the presence of various out-of-unit > function calls mean that this code worked OK before, and

[Xen-devel] [PATCH] xen/x86/shadow: adjust barriers around gtable_dirty_version.

2017-08-18 Thread Tim Deegan
Use the smp_ variants, as we're only synchronizing against other CPUs. Add a write barrier before incrementing the version. x86's memory ordering rules and the presence of various out-of-unit function calls mean that this code worked OK before, and the barriers are mostly decorative.