Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-04-19 Thread Stefano Stabellini
On Fri, 14 Apr 2017, Bhupinder Thakur wrote: > Hi Stefano, > > On 12 April 2017 at 03:37, Stefano Stabellini wrote: > > On Tue, 11 Apr 2017, Bhupinder Thakur wrote: > >> Hi, > >> > >> Kindly let me know if my understanding is correct. > >> > >> Using a domctl API will

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-04-14 Thread Bhupinder Thakur
Hi Stefano, On 12 April 2017 at 03:37, Stefano Stabellini wrote: > On Tue, 11 Apr 2017, Bhupinder Thakur wrote: >> Hi, >> >> Kindly let me know if my understanding is correct. >> >> Using a domctl API will allow us to keep the vUART configuration >> flexible. Currently,

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-04-11 Thread Stefano Stabellini
On Tue, 11 Apr 2017, Bhupinder Thakur wrote: > Hi, > > Kindly let me know if my understanding is correct. > > Using a domctl API will allow us to keep the vUART configuration > flexible. Currently, we can operate on one ring-buf PFN and an event > channel port only for a single vUART but if we

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-04-11 Thread Bhupinder Thakur
Hi, Kindly let me know if my understanding is correct. Using a domctl API will allow us to keep the vUART configuration flexible. Currently, we can operate on one ring-buf PFN and an event channel port only for a single vUART but if we use DOMCTL interface, then we can effectively get/set

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-24 Thread Bhupinder Thakur
Hi Julien, >> Three new HVM param handlers added for: >> - allocating a new VIRQ and return to the toolstack > > > This is not necessary. We could hardcode it. I will modify the code to use a fixed SPI for vpl011. > >> - allocating a new event channel for sending/receiving events from

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-24 Thread Bhupinder Thakur
Hi Konrad, On 4 March 2017 at 01:32, Konrad Rzeszutek Wilk wrote: > On Tue, Feb 21, 2017 at 04:55:59PM +0530, Bhupinder Thakur wrote: >> Three new HVM param handlers added for: >> - allocating a new VIRQ and return to the toolstack >> - allocating a new event

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-08 Thread Stefano Stabellini
On Wed, 8 Mar 2017, Jan Beulich wrote: > >>> On 08.03.17 at 15:45, wrote: > > I was looking at the backend code and see it is using DOMCTL command. I > > guess it is considered that the console backend will be tied to a > > specific Xen version. Am I correct? > > I don't

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-08 Thread Jan Beulich
>>> On 08.03.17 at 15:45, wrote: > I was looking at the backend code and see it is using DOMCTL command. I > guess it is considered that the console backend will be tied to a > specific Xen version. Am I correct? I don't think I'm qualified to talk about the console

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-08 Thread Julien Grall
Hi Jan, On 06/03/17 13:48, Jan Beulich wrote: On 06.03.17 at 14:21, wrote: On 06/03/17 12:41, Jan Beulich wrote: Furthermore - how does this scale? I.e. what if other devices pop up wanting to be emulated? Or multiple UARTs? I think you can appreciate that using QEMU

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-08 Thread Julien Grall
Hi George, On 06/03/17 14:48, George Dunlap wrote: On 06/03/17 13:21, Julien Grall wrote: Hi Jan, On 06/03/17 12:41, Jan Beulich wrote: On 06.03.17 at 12:42, wrote: I thought a bit more about those params. I think the name should be generic and not tie to pl011

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread George Dunlap
On 06/03/17 13:21, Julien Grall wrote: > Hi Jan, > > On 06/03/17 12:41, Jan Beulich wrote: > On 06.03.17 at 12:42, wrote: >>> I thought a bit more about those params. I think the name should be >>> generic and not tie to pl011 because we may want to emulate different

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread Jan Beulich
>>> On 06.03.17 at 14:21, wrote: > On 06/03/17 12:41, Jan Beulich wrote: >> Furthermore - how does this scale? I.e. what if other devices pop >> up wanting to be emulated? Or multiple UARTs? > > I think you can appreciate that using QEMU for emulating an UART is > quite

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread Julien Grall
Hi Jan, On 06/03/17 12:41, Jan Beulich wrote: On 06.03.17 at 12:42, wrote: I thought a bit more about those params. I think the name should be generic and not tie to pl011 because we may want to emulate different UART for the guest in the future. That's reasonable, but

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread Jan Beulich
>>> On 06.03.17 at 12:42, wrote: > I thought a bit more about those params. I think the name should be > generic and not tie to pl011 because we may want to emulate different > UART for the guest in the future. That's reasonable, but I continue to have reservations

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread Julien Grall
Hi Jan, On 06/03/17 08:06, Jan Beulich wrote: On 05.03.17 at 13:35, wrote: On 02/21/2017 11:25 AM, Bhupinder Thakur wrote: --- a/xen/include/public/hvm/params.h +++ b/xen/include/public/hvm/params.h @@ -203,10 +203,17 @@ */ #define HVM_PARAM_ACPI_IOPORTS_LOCATION 19

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-06 Thread Jan Beulich
>>> On 05.03.17 at 13:35, wrote: > On 02/21/2017 11:25 AM, Bhupinder Thakur wrote: >> --- a/xen/include/public/hvm/params.h >> +++ b/xen/include/public/hvm/params.h >> @@ -203,10 +203,17 @@ >> */ >> #define HVM_PARAM_ACPI_IOPORTS_LOCATION 19 >> >> -/* Deprecated */ >>

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-05 Thread Julien Grall
(CC "The REST" maintainers) Hi Bhupinder, On 02/21/2017 11:25 AM, Bhupinder Thakur wrote: Three new HVM param handlers added for: - allocating a new VIRQ and return to the toolstack This is not necessary. We could hardcode it. - allocating a new event channel for sending/receiving

Re: [Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-03-03 Thread Konrad Rzeszutek Wilk
On Tue, Feb 21, 2017 at 04:55:59PM +0530, Bhupinder Thakur wrote: > Three new HVM param handlers added for: > - allocating a new VIRQ and return to the toolstack > - allocating a new event channel for sending/receiving events from Xen > and return > to the toolstack > - mapping

[Xen-devel] [PATCH 02/11] xen/arm: vpl011: Add new hvm params in Xen for ring buffer/event setup

2017-02-21 Thread Bhupinder Thakur
Three new HVM param handlers added for: - allocating a new VIRQ and return to the toolstack - allocating a new event channel for sending/receiving events from Xen and return to the toolstack - mapping the PFN allocted by the toolstack to be used as IN/OUT ring buffers