Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-09-29 Thread Dario Faggioli
On Tue, 2016-09-13 at 12:28 +0100, George Dunlap wrote: > On 17/08/16 18:18, Dario Faggioli wrote: > >  > diff --git a/xen/common/sched_credit2.c > > @@ -2233,7 +2241,8 @@ void __dump_execstate(void *unused); > >  static struct csched2_vcpu * > >  runq_candidate(struct csched2_runqueue_data *rqd,

Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-09-13 Thread George Dunlap
On 17/08/16 18:18, Dario Faggioli wrote: > Right now, the following scenario can occurr: > - upon vcpu v wakeup, v itself is put in the runqueue, >and pcpu X is tickled; > - pcpu Y schedules (for whatever reason), sees v in >the runqueue and picks it up. > > This may seem ok (or even a

Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-09-13 Thread George Dunlap
On 05/09/16 14:47, Dario Faggioli wrote: > On Wed, 2016-08-31 at 18:10 +0100, anshul makkar wrote: >> On 17/08/16 18:18, Dario Faggioli wrote: >>> >>> Right now, the following scenario can occurr: >>> - upon vcpu v wakeup, v itself is put in the runqueue, >>> and pcpu X is tickled; >>> -

Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-09-07 Thread anshul makkar
On 05/09/16 14:47, Dario Faggioli wrote: On Wed, 2016-08-31 at 18:10 +0100, anshul makkar wrote: On 17/08/16 18:18, Dario Faggioli wrote: @@ -1266,6 +1272,7 @@ csched2_alloc_vdata(const struct scheduler *ops, struct vcpu *vc, void *dd) ASSERT(svc->sdom != NULL);

Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-09-05 Thread Dario Faggioli
On Wed, 2016-08-31 at 18:10 +0100, anshul makkar wrote: > On 17/08/16 18:18, Dario Faggioli wrote: > > > > Right now, the following scenario can occurr: > >   - upon vcpu v wakeup, v itself is put in the runqueue, > > and pcpu X is tickled; > >   - pcpu Y schedules (for whatever reason), sees

Re: [Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-08-31 Thread anshul makkar
On 17/08/16 18:18, Dario Faggioli wrote: Right now, the following scenario can occurr: - upon vcpu v wakeup, v itself is put in the runqueue, and pcpu X is tickled; - pcpu Y schedules (for whatever reason), sees v in the runqueue and picks it up. This may seem ok (or even a good

[Xen-devel] [PATCH 05/24] xen: credit2: make tickling more deterministic

2016-08-17 Thread Dario Faggioli
Right now, the following scenario can occurr: - upon vcpu v wakeup, v itself is put in the runqueue, and pcpu X is tickled; - pcpu Y schedules (for whatever reason), sees v in the runqueue and picks it up. This may seem ok (or even a good thing), but it's not. In fact, if runq_tickle()