Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-21 Thread Jan Beulich
>>> On 21.08.17 at 12:28, wrote: > Hi Jan, > > On 7 August 2017 at 14:44, Jan Beulich wrote: > Bhupinder Thakur 08/07/17 10:55 AM >>> >>>@@ -1148,6 +1149,24 @@ struct xen_domctl_psr_cat_op { >>>uint32_t target;/* IN */ >>>uint64_t data; /* IN/OUT */ >>>}; >>>+ >>>+struct xen_domctl

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-21 Thread Bhupinder Thakur
Hi Jan, On 7 August 2017 at 14:44, Jan Beulich wrote: Bhupinder Thakur 08/07/17 10:55 AM >>> >>@@ -1148,6 +1149,24 @@ struct xen_domctl_psr_cat_op { >>uint32_t target;/* IN */ >>uint64_t data; /* IN/OUT */ >>}; >>+ >>+struct xen_domctl_vuart_op { >>+#define XEN_DOMCTL_VUART_OP_INIT

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-08 Thread Julien Grall
Hi Bhupinder, On 07/08/17 09:52, Bhupinder Thakur wrote: diff --git a/tools/libxl/libxl_arch.h b/tools/libxl/libxl_arch.h index 5e1fc60..784ec7f 100644 --- a/tools/libxl/libxl_arch.h +++ b/tools/libxl/libxl_arch.h @@ -44,6 +44,13 @@ int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-08 Thread Julien Grall
Hi, On 08/08/17 14:30, Wei Liu wrote: On Tue, Aug 08, 2017 at 02:11:08PM +0100, Wei Liu wrote: +else +rc = -EINVAL; Indentation. Ignore this please. You were right, the indentation is wrong :). It is 8 spaces rather than 4. Cheers, -- Julien Grall

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-08 Thread Wei Liu
On Tue, Aug 08, 2017 at 02:11:08PM +0100, Wei Liu wrote: > > +else > > +rc = -EINVAL; > > Indentation. Ignore this please. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-08 Thread Wei Liu
On Mon, Aug 07, 2017 at 02:22:58PM +0530, Bhupinder Thakur wrote: > Add a new domctl API to initialize vpl011. It takes the GFN and console > backend domid as input and returns an event channel to be used for > sending and receiving events from Xen. > > Xen will communicate with xenconsole using G

Re: [Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-07 Thread Jan Beulich
>>> Bhupinder Thakur 08/07/17 10:55 AM >>> >@@ -1148,6 +1149,24 @@ struct xen_domctl_psr_cat_op { >uint32_t target;/* IN */ >uint64_t data; /* IN/OUT */ >}; >+ >+struct xen_domctl_vuart_op { >+#define XEN_DOMCTL_VUART_OP_INIT 0 >+uint32_t cmd; /* XEN_DOMCTL_VUART_OP_* *

[Xen-devel] [PATCH 06/25 v7] xen/arm: vpl011: Add a new domctl API to initialize vpl011

2017-08-07 Thread Bhupinder Thakur
Add a new domctl API to initialize vpl011. It takes the GFN and console backend domid as input and returns an event channel to be used for sending and receiving events from Xen. Xen will communicate with xenconsole using GFN as the ring buffer and the event channel to transmit and receive pl011 da