Re: [Xen-devel] [PATCH 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

2016-06-14 Thread Konrad Rzeszutek Wilk
On Tue, Jun 14, 2016 at 09:22:45PM +0200, Olaf Hering wrote: > On Fri, Jun 10, Dongli Zhang wrote: > > > Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)" > > is true. Thus, it is not necessary to update "j" when "i == > > ARRAY_SIZE(main_options)" is false. > > This

Re: [Xen-devel] [PATCH 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

2016-06-14 Thread Olaf Hering
On Fri, Jun 10, Dongli Zhang wrote: > Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)" > is true. Thus, it is not necessary to update "j" when "i == > ARRAY_SIZE(main_options)" is false. This breaks the build with gcc45: [ 153s] cc1: warnings being treated as errors [

Re: [Xen-devel] [PATCH 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

2016-06-09 Thread Wei Liu
On Fri, Jun 10, 2016 at 12:02:52AM +0800, Dongli Zhang wrote: > Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)" > is true. Thus, it is not necessary to update "j" when "i == > ARRAY_SIZE(main_options)" is false. > > Signed-off-by: Dongli Zhang

[Xen-devel] [PATCH 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

2016-06-09 Thread Dongli Zhang
Local variable "j" would be used only when "i == ARRAY_SIZE(main_options)" is true. Thus, it is not necessary to update "j" when "i == ARRAY_SIZE(main_options)" is false. Signed-off-by: Dongli Zhang Reviewed-by: Konrad Rzeszutek Wilk ---