Re: [Xen-devel] [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy

[Wei Liu]

On Thu, Jun 16, 2016 at 02:47:51PM -0700, Dongli Zhang wrote:
> 
> > I suggest pasting in Olaf's exact error message here.
> > 
> > To avoid extra round trip, I propose updating the commit message as
> > followed:
> > 
> > Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3)
> > happy to
> > avoid compilation error by commit
> > beba3693f7243e68bbe31fe3794da91068eeea5b.
> > 
> > Failure manifests with gcc 4.5 as:
> > 
> > [  153s] cc1: warnings being treated as errors
> > [  153s] xen-livepatch.c: In function 'main':
> > [  153s] xen-livepatch.c:415:12: error: 'j' may be used
> > uninitialized in this function
> > [  153s] make[3]: *** [xen-livepatch.o] Error 1
> > 
> > If you agree with this I will handle the updating while doing my next
> > sweep.
> 
> 
> Sure. Feel free to update the commit message.

Thanks for confirming. This patch is now acked and queued.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy

[Dongli Zhang]

> I suggest pasting in Olaf's exact error message here.
> 
> To avoid extra round trip, I propose updating the commit message as
> followed:
> 
> Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3)
> happy to
> avoid compilation error by commit
> beba3693f7243e68bbe31fe3794da91068eeea5b.
> 
> Failure manifests with gcc 4.5 as:
> 
> [  153s] cc1: warnings being treated as errors
> [  153s] xen-livepatch.c: In function 'main':
> [  153s] xen-livepatch.c:415:12: error: 'j' may be used
> uninitialized in this function
> [  153s] make[3]: *** [xen-livepatch.o] Error 1
> 
> If you agree with this I will handle the updating while doing my next
> sweep.


Sure. Feel free to update the commit message.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy

[Wei Liu]

On Wed, Jun 15, 2016 at 09:07:53PM +0800, Dongli Zhang wrote:
> Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
> avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.
> 

I suggest pasting in Olaf's exact error message here.

To avoid extra round trip, I propose updating the commit message as
followed:

Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.

Failure manifests with gcc 4.5 as:

[  153s] cc1: warnings being treated as errors
[  153s] xen-livepatch.c: In function 'main':
[  153s] xen-livepatch.c:415:12: error: 'j' may be used uninitialized in 
this function
[  153s] make[3]: *** [xen-livepatch.o] Error 1

If you agree with this I will handle the updating while doing my next
sweep.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/1] tools/livepatch: initialise j to 0 to make some versions of gcc happy

[Dongli Zhang]

Initialise j to 0 to make some versions of gcc (e.g., gcc4.5/4.3) happy to
avoid compilation error by commit beba3693f7243e68bbe31fe3794da91068eeea5b.

Signed-off-by: Dongli Zhang 
---
 tools/misc/xen-livepatch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/misc/xen-livepatch.c b/tools/misc/xen-livepatch.c
index 3162489..62c072e 100644
--- a/tools/misc/xen-livepatch.c
+++ b/tools/misc/xen-livepatch.c
@@ -412,7 +412,7 @@ struct {
 
 int main(int argc, char *argv[])
 {
-int i, j, ret;
+int i, j = 0, ret;
 
 if ( argc  <= 1 )
 {
-- 
1.9.1


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel