Re: [Xen-devel] [PATCH 1/1] xen-netfront: uninitialized fields in xenvif_rx_action

[David Vrabel]

On 02/02/16 06:20, Dongli Zhang wrote:
> While npo.copy and npo.meta are initialized in xenvif_rx_action, fields
> such as npo.meta_prod are directly used later in xenvif_gop_skb without
> being initialized first. Although the output of xenvif_rx_action is based
> on the difference between new npo->meta_prod and old npo->meta_prod, it is
> better to initialize them to 0 at the beginning.

Fields that are omitted from an initializer are initialized to zero.  So
this patch is not needed.

David

> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -560,6 +560,10 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
>   bool need_to_notify = false;
>  
>   struct netrx_pending_operations npo = {
> + .copy_prod = 0,
> + .copy_cons = 0,
> + .meta_prod = 0,
> + .meta_cons = 0,
>   .copy  = queue->grant_copy_op,
>   .meta  = queue->meta,
>   };
> 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/1] xen-netfront: uninitialized fields in xenvif_rx_action

[Dongli Zhang]

While npo.copy and npo.meta are initialized in xenvif_rx_action, fields
such as npo.meta_prod are directly used later in xenvif_gop_skb without
being initialized first. Although the output of xenvif_rx_action is based
on the difference between new npo->meta_prod and old npo->meta_prod, it is
better to initialize them to 0 at the beginning.

Signed-off-by: Dongli Zhang 
---
 drivers/net/xen-netback/netback.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/xen-netback/netback.c 
b/drivers/net/xen-netback/netback.c
index 61b97c3..32f0fbd 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -560,6 +560,10 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
bool need_to_notify = false;
 
struct netrx_pending_operations npo = {
+   .copy_prod = 0,
+   .copy_cons = 0,
+   .meta_prod = 0,
+   .meta_cons = 0,
.copy  = queue->grant_copy_op,
.meta  = queue->meta,
};
-- 
1.9.1






___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel