Re: [Xen-devel] [PATCH 1/2] x86/p2m: simplify p2m_next_level()

2017-06-22 Thread George Dunlap
On 22/06/17 08:25, Jan Beulich wrote: On 21.06.17 at 17:20, wrote: >> On 21/06/17 11:25, Jan Beulich wrote: >>> Calculate entry PFN and flags just once, making the respective >>> variables (and also pg) function wide. Take the opportunity and also >>> make the

Re: [Xen-devel] [PATCH 1/2] x86/p2m: simplify p2m_next_level()

2017-06-22 Thread Jan Beulich
>>> On 21.06.17 at 17:20, wrote: > On 21/06/17 11:25, Jan Beulich wrote: >> Calculate entry PFN and flags just once, making the respective >> variables (and also pg) function wide. Take the opportunity and also >> make the induction variable unsigned. > > Hmm -- I'm a

Re: [Xen-devel] [PATCH 1/2] x86/p2m: simplify p2m_next_level()

2017-06-21 Thread George Dunlap
On 21/06/17 11:25, Jan Beulich wrote: > Calculate entry PFN and flags just once, making the respective > variables (and also pg) function wide. Take the opportunity and also > make the induction variable unsigned. Hmm -- I'm a fan of keeping the scope of variables limited to where they're

[Xen-devel] [PATCH 1/2] x86/p2m: simplify p2m_next_level()

2017-06-21 Thread Jan Beulich
Calculate entry PFN and flags just once, making the respective variables (and also pg) function wide. Take the opportunity and also make the induction variable unsigned. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -195,7 +195,9