Re: [Xen-devel] [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART

2016-09-14 Thread Jan Beulich
>>> On 13.09.16 at 19:35, wrote: > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -45,7 +45,8 @@ config HAS_SCIF > say Y. > > config HAS_EHCI > - bool > + bool "EHCI UART" if EXPERT = "y" Please make the prompt say e.g "EHCI debug port"

Re: [Xen-devel] [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART

2016-09-14 Thread Julien Grall
Hello Derek, On 13/09/16 18:35, Derek Straka wrote: diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index c87e018..08a60e0 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -45,7 +45,8 @@ config HAS_SCIF say Y. config HAS_EHCI - bool +

Re: [Xen-devel] [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART

2016-09-13 Thread Andrew Cooper
On 13/09/16 18:35, Derek Straka wrote: > Allows for the conditional inclusion of EHCI UART driver on the x86 platform > rather than having it always enabled. > > The default configuration for the HAS_EHCI option remains 'y' on x86, so the > behavior out of the box remains unchanged. The addition

[Xen-devel] [PATCH 2/2] x86: add a user configurable Kconfig option for the EHCI UART

2016-09-13 Thread Derek Straka
Allows for the conditional inclusion of EHCI UART driver on the x86 platform rather than having it always enabled. The default configuration for the HAS_EHCI option remains 'y' on x86, so the behavior out of the box remains unchanged. The addition of the option allows advanced users to