Re: [Xen-devel] [PATCH 2/2] xen/arm32: Use alternative to skip the check of pending serrors

2017-03-16 Thread Wei Chen 
Hi Julien,

On 2017/3/17 1:36, Julien Grall wrote:
> Hi Wei,
>
> On 03/16/2017 09:53 AM, Wei Chen wrote:
>> We have provided an option to administrator to determine how to
>> handle the SErrors. In order to skip the check of pending SError,
>> in conventional way, we have to read the option every time before
>> we try to check the pending SError. This will add overhead to check
>> the option at every trap.
>>
>> The ARM32 supports the alternative patching feature. We can use an
>> ALTERNATIVE to avoid checking option at every trap. We added a new
>> cpufeature named "SKIP_CHECK_PENDING_VSERROR". This feature will be
>> enabled when the option is not diverse.
>
> Can you please squash this patch in #10 of the SError series?
>

I will squash it to new version of SError series.

> Cheers,
>


-- 
Regards,
Wei Chen

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] xen/arm32: Use alternative to skip the check of pending serrors

2017-03-16 Thread Julien Grall 

Hi Wei,

On 03/16/2017 09:53 AM, Wei Chen wrote:

We have provided an option to administrator to determine how to
handle the SErrors. In order to skip the check of pending SError,
in conventional way, we have to read the option every time before
we try to check the pending SError. This will add overhead to check
the option at every trap.

The ARM32 supports the alternative patching feature. We can use an
ALTERNATIVE to avoid checking option at every trap. We added a new
cpufeature named "SKIP_CHECK_PENDING_VSERROR". This feature will be
enabled when the option is not diverse.


Can you please squash this patch in #10 of the SError series?

Cheers,

--
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 2/2] xen/arm32: Use alternative to skip the check of pending serrors

2017-03-16 Thread Wei Chen 
We have provided an option to administrator to determine how to
handle the SErrors. In order to skip the check of pending SError,
in conventional way, we have to read the option every time before
we try to check the pending SError. This will add overhead to check
the option at every trap.

The ARM32 supports the alternative patching feature. We can use an
ALTERNATIVE to avoid checking option at every trap. We added a new
cpufeature named "SKIP_CHECK_PENDING_VSERROR". This feature will be
enabled when the option is not diverse.

Signed-off-by: Wei Chen 
---
 xen/arch/arm/arm32/entry.S | 27 +--
 1 file changed, 9 insertions(+), 18 deletions(-)

diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S
index 79929ca..105cae8 100644
--- a/xen/arch/arm/arm32/entry.S
+++ b/xen/arch/arm/arm32/entry.S
@@ -1,6 +1,6 @@
 #include 
 #include 
-#include 
+#include 
 #include 
 
 #define SAVE_ONE_BANKED(reg)mrs r11, reg; str r11, [sp, #UREGS_##reg]
@@ -12,21 +12,6 @@
 #define RESTORE_BANKED(mode) \
 RESTORE_ONE_BANKED(SP_##mode) ; RESTORE_ONE_BANKED(LR_##mode) ; 
RESTORE_ONE_BANKED(SPSR_##mode)
 
-/*
- * If the SKIP_CHECK_PENDING_VSERROR has been set in the cpu feature,
- * the checking of pending SErrors will be skipped.
- *
- * As it is a temporary solution, we are assuming that
- * SKIP_CHECK_PENDING_VSERROR will always be in the first word for
- * cpu_hwcaps. This would have to be dropped as soon as ARM32 gain
- * support of alternative.
- */
-#define SKIP_VSERROR_CHECK  \
-ldr r1, =cpu_hwcaps;\
-ldr r1, [r1];   \
-tst r1, #SKIP_CHECK_PENDING_VSERROR;\
-moveq pc, lr
-
 #define SAVE_ALL\
 sub sp, #(UREGS_SP_usr - UREGS_sp); /* SP, LR, SPSR, PC */  \
 push {r0-r12}; /* Save R0-R12 */\
@@ -61,8 +46,13 @@ save_guest_regs:
 SAVE_ONE_BANKED(R8_fiq); SAVE_ONE_BANKED(R9_fiq); 
SAVE_ONE_BANKED(R10_fiq)
 SAVE_ONE_BANKED(R11_fiq); SAVE_ONE_BANKED(R12_fiq);
 
-SKIP_VSERROR_CHECK
-
+/*
+ * If the SKIP_CHECK_PENDING_VSERROR has been set in the cpu feature,
+ * the checking of pending SErrors will be skipped.
+ */
+ALTERNATIVE("nop",
+"b skip_check",
+SKIP_CHECK_PENDING_VSERROR)
 /*
  * Start to check pending virtual abort in the gap of Guest -> HYP
  * world switch.
@@ -118,6 +108,7 @@ abort_guest_exit_end:
  */
 bne return_from_trap
 
+skip_check:
 mov pc, lr
 
 #define DEFINE_TRAP_ENTRY(trap) \
-- 
2.7.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel