Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

2015-03-02 Thread Ian Campbell
On Sat, 2015-02-28 at 22:20 +, Julien Grall wrote: Hi Ian, On 19/02/2015 15:24, Ian Campbell wrote: +static void check_timer_irq_cfg(unsigned int irq, const char *which) +{ +struct irq_desc *desc = irq_to_desc(irq); + +/* + * The interrupt contoller driver will

Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

2015-02-28 Thread Julien Grall
Hi Ian, On 19/02/2015 15:24, Ian Campbell wrote: +static void check_timer_irq_cfg(unsigned int irq, const char *which) +{ +struct irq_desc *desc = irq_to_desc(irq); + +/* + * The interrupt contoller driver will update desc-arch.type with + * the actual type which ended up

Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

2015-02-25 Thread Ian Campbell
On Thu, 2015-02-19 at 16:20 +, Julien Grall wrote: Regardless the question,this patch look good to me. With the 2 nits I spotted on my previous email: Reviewed-by: Julien Grall julien.gr...@linaro.org Thanks, applied both patches (with nits fixed) Regards,

Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

2015-02-19 Thread Julien Grall
Hi Ian, On 19/02/15 15:24, Ian Campbell wrote: Edge trigger arch timer interrupts really don't make much sense, so if we discover we are booting on such a system issue a warning. So far this has only been seen on the fast model emulators which have both an incorrect DT description of the

Re: [Xen-devel] [PATCH 2/2] xen: arm: Warn if timer interrupts are not level triggered

2015-02-19 Thread Ian Campbell
On Thu, 2015-02-19 at 15:41 +, Julien Grall wrote: I did consider overriding the incorrect DT on such systems but since so far it has only been observed on emulators and we have code in place to deal with edge triggering here I think warning is sufficient for now. [...] + * + *