Wei Liu writes ("Re: [PATCH 3/4] libxl/remus: Change the assert for info to an
return"):
> On Tue, Jan 26, 2016 at 04:30:59PM -0500, Konrad Rzeszutek Wilk wrote:
> > The assert(info) is after quite a lot of manipulations
> > on 'info' - which makes the assert pointless because if
> > info was NULL it would have crashed earlier.
>
> This sounds sensible.
I don't think I agree.
As I wrote in response to a previous version:
Ian Jackson writes ("Re: [PATCH 2/3] libxl/remus: Move the assert
before the info is used."):
> I think the assert should simply be removed. We don't assert() other
> pointer parameters for non-NULL-ness.
>
> Certainly turning null pointer bugs into ERROR_INVALID is very
> unfriendly.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
