Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-03-05 Thread Julien Grall
Hi Ian, On 05/03/2015 14:43, Ian Campbell wrote: On Wed, 2015-02-18 at 15:16 +, Julien Grall wrote: ranges; means there is not translation necessary. But nothing prevent to have a the property ranges set. I don't suppose you know of a system where this translation is needed do you? So

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Julien Grall
Hi Ian, On 18/02/2015 13:50, Ian Campbell wrote: On Tue, 2015-02-17 at 17:33 +, Julien Grall wrote: Hi Ian, On 24/10/14 10:58, Ian Campbell wrote: These properties are defined in ePAPR and the OpenFirmware PCI Bus Binding Specification (IEEE Std 1275-1994). This replaces the xgene

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-18 at 14:19 +, Julien Grall wrote: Hi Ian, On 18/02/2015 13:50, Ian Campbell wrote: On Tue, 2015-02-17 at 17:33 +, Julien Grall wrote: Hi Ian, On 24/10/14 10:58, Ian Campbell wrote: These properties are defined in ePAPR and the OpenFirmware PCI Bus Binding

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Julien Grall
On 18/02/2015 15:18, Ian Campbell wrote: On Wed, 2015-02-18 at 15:05 +, Julien Grall wrote: On 18/02/2015 14:37, Ian Campbell wrote: On Wed, 2015-02-18 at 14:19 +, Julien Grall wrote: I think so, and we probably should consider the two cases separately since the right answer could

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-18 at 15:31 +, Julien Grall wrote: Either soc has a device_type property which we understand, in which case we would handle it and stop recursing or (more likely for an soc) it does not, in which case we would handle the pcie ranges property, but it needs to be

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Ian Campbell
On Tue, 2015-02-17 at 17:33 +, Julien Grall wrote: Hi Ian, On 24/10/14 10:58, Ian Campbell wrote: These properties are defined in ePAPR and the OpenFirmware PCI Bus Binding Specification (IEEE Std 1275-1994). This replaces the xgene specific mapping. Tested on Mustang and on a

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Julien Grall
On 18/02/2015 14:37, Ian Campbell wrote: On Wed, 2015-02-18 at 14:19 +, Julien Grall wrote: I think so, and we probably should consider the two cases separately since the right answer could reasonably differ for different resource types. I am reasonably convinced that for MMIO (+IO+CFG

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-18 at 15:05 +, Julien Grall wrote: On 18/02/2015 14:37, Ian Campbell wrote: On Wed, 2015-02-18 at 14:19 +, Julien Grall wrote: I think so, and we probably should consider the two cases separately since the right answer could reasonably differ for different resource

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-18 at 15:13 +, Julien Grall wrote: On 18/02/2015 14:37, Ian Campbell wrote: I am reasonably convinced that for MMIO (+IO+CFG space) we should map everything as described by the ranges property of the top most node, it can be considered an analogue to / extension of the

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Julien Grall
On 18/02/2015 14:37, Ian Campbell wrote: I am reasonably convinced that for MMIO (+IO+CFG space) we should map everything as described by the ranges property of the top most node, it can be considered an analogue to / extension of the reg property of that node. BTW, the CFG space is part of

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-18 Thread Julien Grall
On 18/02/2015 15:05, Julien Grall wrote: On 18/02/2015 14:37, Ian Campbell wrote: On Wed, 2015-02-18 at 14:19 +, Julien Grall wrote: I think so, and we probably should consider the two cases separately since the right answer could reasonably differ for different resource types. I am

Re: [Xen-devel] [PATCH 5/5] xen: arm: handle PCI DT node ranges and interrupt-map properties

2015-02-17 Thread Julien Grall
Hi Ian, On 24/10/14 10:58, Ian Campbell wrote: These properties are defined in ePAPR and the OpenFirmware PCI Bus Binding Specification (IEEE Std 1275-1994). This replaces the xgene specific mapping. Tested on Mustang and on a model with a PCI virtio controller. I'm wondering why you