Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-11-02 Thread Wei Liu
On Mon, Nov 02, 2015 at 03:08:26PM +, Ian Campbell wrote: > On Mon, 2015-11-02 at 15:00 +, Wei Liu wrote: > > On Mon, Nov 02, 2015 at 12:14:50PM +, Ian Campbell wrote: > > > On Mon, 2015-10-26 at 09:47 +, Wei Liu wrote: > > > > The xenbus thread didn't send notification to other

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-11-02 Thread Ian Campbell
On Mon, 2015-11-02 at 15:53 +, Wei Liu wrote: > On Mon, Nov 02, 2015 at 03:08:26PM +, Ian Campbell wrote: > > On Mon, 2015-11-02 at 15:00 +, Wei Liu wrote: > > > On Mon, Nov 02, 2015 at 12:14:50PM +, Ian Campbell wrote: > > > > On Mon, 2015-10-26 at 09:47 +, Wei Liu wrote: > >

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-11-02 Thread Wei Liu
On Mon, Nov 02, 2015 at 12:14:50PM +, Ian Campbell wrote: > On Mon, 2015-10-26 at 09:47 +, Wei Liu wrote: > > The xenbus thread didn't send notification to other end when it expected > > more data or consumed responses, which led to stalling the ring from > > time to time. > > > > This is

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-11-02 Thread Ian Campbell
On Mon, 2015-11-02 at 15:00 +, Wei Liu wrote: > On Mon, Nov 02, 2015 at 12:14:50PM +, Ian Campbell wrote: > > On Mon, 2015-10-26 at 09:47 +, Wei Liu wrote: > > > The xenbus thread didn't send notification to other end when it > > > expected > > > more data or consumed responses, which

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-11-02 Thread Ian Campbell
On Mon, 2015-10-26 at 09:47 +, Wei Liu wrote: > The xenbus thread didn't send notification to other end when it expected > more data or consumed responses, which led to stalling the ring from > time to time. > > This is the culprit that guest was less responsive when using stubdom > because

[Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Wei Liu
The xenbus thread didn't send notification to other end when it expected more data or consumed responses, which led to stalling the ring from time to time. This is the culprit that guest was less responsive when using stubdom because the device model was stalled. Fix this by sending notification

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Wei Liu
On Mon, Oct 26, 2015 at 01:02:45PM +0100, Samuel Thibault wrote: > Hello, > > Indeed, notification seems to have been missing since basically 2006... > > Wei Liu, le Mon 26 Oct 2015 09:47:48 +, a écrit : > > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > > index 4613ed6..7451161 100644 > >

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Samuel Thibault
Wei Liu, le Mon 26 Oct 2015 12:30:28 +, a écrit : > On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > > Wei Liu, le Mon 26 Oct 2015 12:14:43 +, a écrit : > > > In my patch, mini-os notifies remote whenever it consumes a message, > > > which I think it's slightly better

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Samuel Thibault
Hello, Indeed, notification seems to have been missing since basically 2006... Wei Liu, le Mon 26 Oct 2015 09:47:48 +, a écrit : > diff --git a/xenbus/xenbus.c b/xenbus/xenbus.c > index 4613ed6..7451161 100644 > --- a/xenbus/xenbus.c > +++ b/xenbus/xenbus.c > @@ -205,8 +205,10 @@ static void

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Samuel Thibault
Wei Liu, le Mon 26 Oct 2015 12:14:43 +, a écrit : > In my patch, mini-os notifies remote whenever it consumes a message, > which I think it's slightly better because backend can start putting > things in the ring as mini-os processes them. That makes more notifications, but that can lead to

Re: [Xen-devel] [PATCH MINI-OS] xenbus: notify the other end when necessary

2015-10-26 Thread Wei Liu
On Mon, Oct 26, 2015 at 01:21:51PM +0100, Samuel Thibault wrote: > Wei Liu, le Mon 26 Oct 2015 12:14:43 +, a écrit : > > In my patch, mini-os notifies remote whenever it consumes a message, > > which I think it's slightly better because backend can start putting > > things in the ring as